This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jun 19, 2023
-
-
Natalie authored
-
Nick Fitzpatrick authored
* Custom Homepage Dashboard Polish * adding missed mock
-
Oisin Coveney authored
-
Ngoc Khuat authored
-
Cal Herries authored
-
Cal Herries authored
-
Ngoc Khuat authored
-
Ngoc Khuat authored
* Adding new db trigger full scan by default * Add DatabaseForm unit test --------- Co-authored-by:
Mahatthana Nomsawadi <mahatthana.n@gmail.com>
-
Mahatthana (Kelvin) Nomsawadi authored
* Encourage admin users to connect to a database (#31210) * Encourage admin users to connect to a database * Only render either payment banner or database prompt banner Discussed here: https://metaboat.slack.com/archives/C057T1QTB3L/p1685549180307149?thread_ts=1685547913.580079&cid=C057T1QTB3L * Improve mobile view layout * Address review: Remove `withRouter` HoC * Address review: Remove optional chaining * Address review: Refactor a component's deprecated `shouldRender` property * Add an e2e test to cover happy path * Remove new translation in `aria-label` * Fix sticky parameter widgets when showing database prompt banner * Fix E2E tests * Address review: Add missing unit tests * Fix a failed E2E test from rebasing off `master` branch * Add analytics (#31470) * 2/x Add analytics * Fix a failed E2E test from merging code from master * Prevent rendering the database prompt banner when white labeling (#31471) * 3/x Convert enterpise settings selectors to TypeScript * Add missing enterprise settings selectors tests * Don't render db prompt banner when white labeling * Reorganize the test to make an EE test more standing out * Address review: Remove unused function * 4/x Follow up reviews and tests (#31545) * 4/x Address review: Simplify code structure * Address review: Fix variable name collision * Move logic to display database banner to a hook * Remove unnecessary await * Restructure AppBanner tests * Swap test position to match the defined test matrix * Address review: removed outdated comment * Address review: Make `useShouldShowDatabasePromptBanner` hook tests clearer * Address review: Make conditions easier to follow Co-authored-by:
Uladzimir Havenchyk <uladzimir.dev@gmail.com> Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by:
Uladzimir Havenchyk <uladzimir.dev@gmail.com> Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * 5/x Add embedding tests (#31557) * 5/x Add embedding tests * Clean up: Fix a selector signature * Address review: Using existing utility * Ensures that embedding pages are loaded before asserting UI not existing * Ready to write PublicQuestion tests * Move public and signed embeds tests to unit tests * Removed outdated eslint comment --------- Co-authored-by:
Uladzimir Havenchyk <uladzimir.dev@gmail.com> Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
- Jun 17, 2023
-
-
Cam Saul authored
* Squash * Replace connection-with-timezone usages * Add deprecation warning. * Fix docstring
-
Ngoc Khuat authored
* Collection to toucan2
-
Ngoc Khuat authored
* Permissions to toucan2 * PermissionsGroup to toucan2 * PermissionsGroupMembership to toucan2 * PermissionsRevision to toucan2 * GroupTableAccessPolicy to toucan2 * ApplicationPermissionsRevision to toucan2 * CollectionPermissionGraphRevision to toucan2 too
-
Ryan Laurie authored
* load snapshot instance data * stop hardcoding question/1 * parameterize default question IDs * cleanup * fix imports * more slashes * misc fixes --------- Co-authored-by:
Bryan Maass <bryan.maass@gmail.com>
-
- Jun 16, 2023
-
-
Cam Saul authored
* Implement `suggested-join-condition` * Update docstring
-
metamben authored
* Calculate and set join alias when joining
-
Jerry Huang authored
-
Jeff Bruemmer authored
-
Nemanja Glumac authored
* Use BuildJet runner for `be-cloverage` We're seeing OOM failures in `be-linter-cloverage` job in CI. * revert back to using ubuntu-22.04 and increase heap size to 2GB * 2gb to 4gb * add comment --------- Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
Oisin Coveney authored
-
metamben authored
-
Jeff Bruemmer authored
* update data reference * update screenshot
-
Jeff Bruemmer authored
-
john-metabase authored
Resolves #28792 * Always create a transient dataset for BigQuery tests * Simplifies BigQuery test data code * More BigQuery test data code cleanup * More BigQuery test data code cleanup, test fix * Extracts test-db-name in bigquery tests, restores normalize-name * Fixes BigQuery QP tests for new test DB name scheme * Removes extraneous clojure.core * Updates bigquery QP test helper code style * Cleans up comments and code in bigquery test data * Update modules/drivers/bigquery-cloud-sdk/test/metabase/driver/bigquery_cloud_sdk/query_processor_test.clj Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
Nemanja Glumac authored
[ci skip]
-
Nemanja Glumac authored
I forgot to do this in #31432. As the result, some PRs have been stuck in CI due to the required check. This PR will run the fallback job for `actions` E2E group when changed files don't require E2E tests to run. [ci skip]
-
Nick Fitzpatrick authored
* WIP showing Toast * add dismissed_toasts stub on GET api/user/current * backend to save dismissed toast names as user-local-settings - adds dismissed_toasts key to GET user/current - introduces POST /user/:user-id/dismissed/:toast-name - For now, only custom_homepage_changed is a valid `toast-name`, but it can be extended to others. - I nearly put in a DELETE to unset it, which could be useful for tests, but took it out. * add untested DELETE route to ease devtime pains * setup dismissed-custom-dashboard-toast to be "yet another setting" - remove specific endpoints - keep the result on GET api/user/current * dismissed_toasts + improve setting api to take Snake Case - with tests * Adding dismiss action * dismissed toast map * Ensure that toast is dismissed for admin who set the custom homepage property * Fixing 2 toasts on login * Moving dismissed toast to settings * updateSettings, undo.canDismiss * adding loading state to settings, removing unneeded CLJ tests --------- Co-authored-by:
Bryan Maass <bryan.maass@gmail.com>
-
Ngoc Khuat authored
-
Ngoc Khuat authored
* User to toucan2 * Pulse to toucan2 * PulseCard to toucan 2 * PulseChannel and PulseChannelRecipient to toucan2 * Query, QueryCache, QueryExecution to toucan2 * Metric, Segment, MetricImportantField to toucan2 * ParameterCard to toucan2 * DataMigrations and FakeCard to toucan2 * NativeQuerySnippet to toucan2
-
metamben authored
* Disable slow test to prevent flakiness Fixes #29266.
-
- Jun 15, 2023
-
-
john-metabase authored
-
metamben authored
This should not really happen, but parts of the code handle this situation while others don't.
-
Dennis Schridde authored
Due to AOT (Ahead Of Time) compilation (specifically direct linking), the `MB_COLORIZE_LOGS` and `MB_EMOJI_IN_LOGS` env vars where not respected. Marking `metabase.util.format/colorize` and `metabase.util/emoji` with `^:redef` metadata prevents the compiler from using direct linking for calls to these functions (and thus evaluating the env vars at compile time) and thus delays resolution of what function to call until runtime when the actual user-provided value of the env var is known. cf. https://clojure.org/reference/compilation#directlinking Closes: https://github.com/metabase/metabase/issues/30518
-
metamben authored
Also make sure that the attached columns have the right temporal bucket information.
-
john-metabase authored
* Filter import on YAML extension * sorts namespaces --------- Co-authored-by:
Luiz Arakaki <luiz.arakaki@metabase.com>
-
Cal Herries authored
-
Tim Macdonald authored
* Avoid expensive call to fetch DB metadata Double-checking the schema name is unnecessarily defensive since we already call include-schema? * Check that schema is set
-
Lena authored
Previously: one “feature or project” template with the `.Epic` label automatically attached. Now: two templates, one for epics, one for smaller things that don't require milestones (or `.Epic` label; they get `.Task` instead). Squashed commit messages follow: * Remove unused optional field * Update title to current convention * Fix typo * Remove unused section * Change capitalization for consistency * Remove redundant description * Rename the issue template to mention epic * Shorten the description of the issue template * Lighten up the milestones section Unfortunately, it doesn't seem possible to prepopulate the issue with an empty tasklist (https://github.com/orgs/community/discussions/50502). * Add an issue template for tasks [ci skip] We had one for epics, with milestones and `.Epic` label. Pretty often that label was accidentally left on smaller issues that were created using the same template. Now the smaller issues have their own template and their own label. Yay. https://metaboat.slack.com/archives/C04CGFHCJDD/p1686548875239219 * Remove redundant angle brackets * Use a string to get a valid yaml file Without the quotes, github says `Error in user YAML: (<unknown>): did not find expected key while parsing a block mapping at line 1 column 1` * Remove rarely if ever used placeholders * Call out optional-ness of some links * Contextualize a header Context can be some text, a slack thread, a notion page, another issue, whatever.
-
- Jun 14, 2023
-
-
bryan authored
* update audit log view migration * separate mysql and fix h2 * typo * fix views --------- Co-authored-by:
Luiz Arakaki <luiz.arakaki@metabase.com>
-
Denis Berezin authored
* Fix dashboard description markdown overflow * Review fixes, Improved e2e test
-
shaun authored
* Fetch field icon from dimension instead of semantic_type (#28622) * simplify field.dimension().icon() → field.icon() * resync tooltip to reflect non-semantic icon * add ts-ignore to iconName with justification * Updating eslint rules to allow importing types to metabase-lib * Revert "Updating eslint rules to allow importing types to metabase-lib" This reverts commit 1b6aca4362a7ca530046466bc9c1bfc02d5b116c. --------- Co-authored-by:
Abdul Aziz Ali <abdulazizali@acm.org> Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com>
-