Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 14, 2023
  2. Aug 10, 2023
  3. Aug 06, 2023
    • Cam Saul's avatar
      QP: use Malli (#32657) · 18c1b198
      Cam Saul authored
      * QP: use Malli
      
      * Fix schema names
      
      * Fix missing namespaces
      
      * Fix busted stuff
      
      * Simplify the new schema
      
      * Test fix :wrench:
      
      * Test fixes :wrench:
      
      * MongoDB fixes :wrench:
      
      * FAST mu/defn
      
      * Malli registry
      
      * Misc fixes
      
      * Some cleanup
      
      * Misc cleanup and test fixes :wrench:
      
      * mu/disable-enforcement
      
      * Test fix
      
      * Fix Cljs version of `disable-enforcement`
      
      * Misc improvements
      
      * Update tests
      
      * Fix Kondo warnings
      
      * Fix Kondo warnings
      
      * Fix busted Malli schema
      
      * PR feedback
      
      * Fix busted schema
      
      * Kondo fixx
      
      * Test fixes :wrench:
      
      * Use Malli version of `describe` now that PR was merged
      
      * Work around https://github.com/metosin/malli/issues/924
      
      * Test fixes :wrench:
      
      * Improvements
      
      * Test fix
      18c1b198
  4. Aug 04, 2023
  5. Aug 03, 2023
  6. Aug 02, 2023
    • Jesse Devaney's avatar
      Enable parameter mapping for heading dash-cards (#32462) · 84537554
      Jesse Devaney authored
      
      * add parameter mapping to heading cards
      
      * update unit tests for new props
      
      * memoize parameter mapped content
      
      * add heading card tests to text parameters spec
      
      * update test descriptions
      
      * add BE for params/substitute_tags
      
      * fix tests
      
      * fix test
      
      * update FE parameter substitution to use optional flag
      
      * heading cards should not escape characters
      
      * add test for dashboard sub
      
      * remove invalid specs -> desired behavior changed
      
      - enabled parameter mapping for heading cards
        - in parameter editing mode, we should display the option to map a parameter to a heading text variable, so we should not display the original text
      
      * fix react hook dependencies
      
      * improve parameterValues type
      
      * refactor E2E test to a unit test
      
      * address nits
      
      * fix spacing
      
      * update types and add unit tests
      
      * fix type errors
      
      ---------
      
      Co-authored-by: default avatarJerry Huang <jhuang37050@gmail.com>
      84537554
  7. Jul 20, 2023
  8. Jul 10, 2023
  9. Jul 07, 2023
  10. Jul 04, 2023
  11. Jun 20, 2023
  12. Jun 12, 2023
  13. Jun 02, 2023
  14. May 24, 2023
  15. May 23, 2023
  16. May 19, 2023
  17. May 15, 2023
  18. May 11, 2023
  19. May 01, 2023
  20. Apr 19, 2023
    • Braden Shepherdson's avatar
      [MLv2] Change how `TemplateTag.widget-type` works for field filters (#30191) · 86688e10
      Braden Shepherdson authored
      The current state is a collection of hacks to preserve some legacy
      behavior (eg. normalization sets a blank `widget-type` to `"category"`)
      and it doesn't work properly right now.
      
      An example of a currently-broken case:
      - `SELECT * FROM Orders WHERE {{tag}}`
      - Set it to a Field Filter and select People > LONGITUDE
        - Or some other field for which type we don't have a widget.
      - It shows "None" as the widget type, and the widget isn't shown at the
        top.
      - Save the question and reopen it.
      - Now the widget is visible (and a bit broken) as a `"category"` type.
      
      This is because on reading from the appdb it gets normalized.
      
      This PR uses `"none"` properly for cases where there are no widget
      options for the field type (eg. longitude), and updates all the usage
      sites to properly handle `"none"` rather than missing/undefined.
      
      Existing saved questions with a blank `widget-type` will continue to
      "work" as they currently do.
      86688e10
    • Cam Saul's avatar
      Tree shake the backend code (#30214) · ae0d9c62
      Cam Saul authored
      ae0d9c62
  21. Apr 18, 2023
  22. Apr 11, 2023
    • Braden Shepherdson's avatar
      [MLv2] Drop non-standard normalization in QB selectors (#29830) · e0d5922e
      Braden Shepherdson authored
      Use the canonical `metabase.mbql.js/normalize` instead, with a bit of
      customization for the query builder's needs. In the long run this should
      be fully unified; for now at least the logic is inside MLv2 now.
      
      All the test cases from the existing code are still exercised between
      `selectors.unit.spec` and `metabase.mbql.js_test`.
      e0d5922e
  23. Mar 31, 2023
  24. Mar 30, 2023
  25. Mar 29, 2023
  26. Mar 28, 2023
  27. Mar 20, 2023
  28. Mar 13, 2023
  29. Mar 09, 2023
    • Cam Saul's avatar
      MLv2 metadata calculation (#28921) · be66142d
      Cam Saul authored
      * MLv2 metadata overhaul, second try
      
      * Stricter linting for MLv2
      
      * Address PR feedback
      
      * Revert fancy fn schema for now
      
      * Remove unused import
      
      * Test fixes :wrench:
      
      * Oops fix bad :require form
      
      * MLv2 mega metadata overhaul 2 of infinity
      
      * Test fixes
      
      * Cljc humanization
      
      * Misc MLv2 improvements from #28921
      
      * Fix indentation
      
      * expression.non-integer-real
      
      * Remove debugging stuff
      
      * More cleanup
      
      * Add method for `:advanced`
      
      * non-integer-real
      
      * Test fixes :wrench:
      
      * Test fixes: ::ref/field shouldn't fail if checked against a non-sequential object
      
      * MLv2 `define-mbql-clause` and `type-of` calculation
      
      * Continued [ci skip]
      
      * MLv2 overhaul :flex:
      
      * Address PR feedback
      
      * Merge type-of overhaul
      
      * Address PR feedback
      be66142d
    • Cam Saul's avatar
      MLv2 clause and type determination overhaul (#29070) · 473758e3
      Cam Saul authored
      * MLv2 `define-mbql-clause` and `type-of` calculation
      
      * Continued [ci skip]
      
      * MLv2 overhaul :flex:
      473758e3
  30. Feb 24, 2023
  31. Feb 21, 2023
    • john-metabase's avatar
      Improves consistency of substring in MBQL (#28067) · a39b710e
      john-metabase authored
      
      * Improves consistency of substring in MBQL
      
      Standard SQL SUBSTRING() uses a 1-based start index, with various drivers
      handling a 0 start index in different ways. To make the behavior of substring
      consistent across drivers, we will always convert a 0 start index in MBQL
      to a 1 in SQL. The ->honeysql implementation of substring has been generalized
      and drivers can now override just the name of the substring function, or the
      entire expression if necessary. SQL Server now calls the parent implementation.
      
      Resolves #12445
      
      * Fixes substring from 0 in Mongo
      
      * Adds arg to substring parent call
      
      * Fix docs and helper text for substring()
      
      * Adds schema to require positive integer index for substring
      
      * WIP, adds frontend validation for substring index arg
      
      * Adds frontend test for substring arg validation
      
      * Updates substring test to expect exception on index 0
      
      * Update src/metabase/driver/sql/query_processor.clj
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      
      * Use s/if instead of s/conditional
      
      * Fix substring call in mysql substring spec
      
      * Reverts driver and sql.qp changes for substring index
      
      * Reverts changes to dispatch-by-clause-name-or-class
      
      * Fixes typeinferencer test substring index
      
      * Adds test for canonicalizing substring
      
      * Fixes substring canonicalization with extra args
      
      * Updates string extracts test to account for substring canonicalization
      
      * Rewrites resolver validation application
      
      * Adds test case for frontend expression validation errors
      
      * Fixes frontend compiler spec for new substring validation
      
      ---------
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      a39b710e
  32. Feb 11, 2023
  33. Feb 10, 2023
  34. Feb 07, 2023
Loading