Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Nov 10, 2024
  2. Nov 07, 2024
  3. Oct 23, 2024
    • Aleksandr Lesnenko's avatar
      Add allowed iframe host setting (#48805) · 7d61485b
      Aleksandr Lesnenko authored
      * add allowed iframe host setting wip
      
      * use allowed-iframe-hosts setting in the CSP header
      
      * add a test for the frame-src csp directive
      
      * Update allowed-iframe-hosts setting definition
      
      * Add error state for forbidden iframe url domains
      
      * Move out iframe e2e test suite
      
      * Add e2e test
      
      * Update error message in view mode
      
      * Fix unit tests
      
      * Update setting on the admin page
      
      * Update error state
      
      * Add links to error states
      
      * Update docs links
      
      * Update link anchors
      
      * Add default allowed hosts to public setting
      
      * Update allowed domain check logic
      
      * Fix default value display in admin page
      
      * Don't update setting without changes
      
      * Update error message spacing
      
      * correct the parsing of allowed-hosts string for CSP header entries
      
      * fix test
      
      * fix not handling wildcard ports
      
      * Fix failing e2e test
      
      * Fix subdomain test
      
      * address review
      
       - the parse-allowed-iframe-hosts fn is now memoized
       - a * entry is handled and doesn't produce a weird *:* entry
       - no more try/catch, errors in parsing will be logged but the list returns all valid entries
       - when www. is encountered, an entry including www. is added
       - trailing / is 'cleaned' and the entry is used as if there was no trailing /
      
      * Fixup test for expecting a few more frame sources
      
      * indentation fix for linter :smiling_face_with_tear:
      
      
      
      * Fix type error
      
      ---------
      
      Co-authored-by: default avatarAdam James <adam.vermeer2@gmail.com>
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      Co-authored-by: default avatardan sutton <dan@dpsutton.com>
      Unverified
      7d61485b
    • Chris Truter's avatar
    • Ngoc Khuat's avatar
  4. Oct 14, 2024
  5. Oct 10, 2024
    • Ngoc Khuat's avatar
      [Notification] System event notification (#47857) · fc43d3cd
      Ngoc Khuat authored
      * [Notification] Notification and subscription (#47707)
      
      * [Notification] Notification and subscription (#47707)
      
      * [Notification] Handlers + recipients (#47759)
      
      * [Notification] Channel template table and model (#47782)
      
      * [Notification] Render system event emails (#47859)
      
      * [Notification] Strict type for channel template and notification recipient (#47910)
      
      * [Notification] Event hydration (#47953)
      
      * [Notification] Send asynchronously (#48200)
      Unverified
      fc43d3cd
  6. Oct 04, 2024
    • Ryan Laurie's avatar
      Add Release Channel selection in-product (#48126) · 4e343c1d
      Ryan Laurie authored
      * add update channels in product
      
      * support for changing release notes to show beta and nightly info
      
      * dont export setting
      
      * obey the linter and add tests
      
      * export setting
      
      * update e2e tests
      
      * clojure magic
      
      * clojure-foo
      
      * better localization
      
      * sorry mr linter
      
      * add more tests :muscle:
      Unverified
      4e343c1d
  7. Sep 10, 2024
  8. Aug 30, 2024
  9. Apr 30, 2024
  10. Apr 04, 2024
    • lbrdnk's avatar
      Enable not emptyable arguments for is-empty and not-empty clauses (#40957) · ee6f4ac1
      lbrdnk authored
      * Enable not emptyable arguments for is-empty and not-empty clauses
      
      * Add review remarks
      
      * Shorten dataset name so it is usable with some drivers
      
      * Disable test for Athena
      
      * Handle possibly missing base type
      
      * Update comment
      
      * Missing base type field is treated as not emptyable
      
      * Update desugar middleware
      
      Now middleware adds base type to fields with integer id that are missing that first. This ensures correct function of is-empty expansion.
      
      * Update desugar middleware
      
      Cleanup base types necessary for desugaring is-empty
      
      * Update desugar middleware cleanup
      
      * Update test
      
      * Adjust tests
      
      * Remove now redundant e2e test
      
      * Update comment
      Unverified
      ee6f4ac1
  11. Mar 21, 2024
    • Cam Saul's avatar
      Rename `metabase.mbql` to `metabase.legacy-mbql` (#40158) · 0a15637f
      Cam Saul authored
      * Wow
      
      * Test fix :wrench:
      
      * Fixes
      
      * Actions should use strings for column names (fix :update-row and :create-row normalization)
      
      * MLv2 schema should check against keys for the other query type
      
      * Ok, have I fixed things?
      
      * More fixes :wrench:
      
      * Fix indentation
      
      * Another round of test fixes. :wrench:
      
      * Hopefully the last few test fixes :wrench:
      
      * We need to test normalization for queries that have keyword keys as well.
      
      * Fix Cljs i18n namespaces
      
      * Sort namespaces
      
      * Only test against H2
      
      * Rename `metabase.mbql` to `metabase.legacy-mbql`
      
      * Fix Kondo warnings
      
      * Test fixes :wrench:
      
      * Register MBQL clause schemas and test fixes :wrench:
      
      * Test fixes and PR feedback
      
      * Test fix
      
      * Remove the normalization tests
      
      * Test fixes :wrench:
      
      * Fix kondo
      
      * Fix import
      
      * Another fix :wrench:
      
      * Merge
      
      * FIXES
      
      * Add another missing REQUIRE
      Unverified
      0a15637f
  12. Mar 20, 2024
    • bryan's avatar
      Feature branch for airgap-token: Milestone 1 (#39733) · bcda8468
      bryan authored
      
      * decrypt and read values from airgap token
      
      - Adds notion of "AirgapToken"
      - Adds max-users and company optional fields to `TokenStatus`
      - Adds branch to `fetch-token-status*` for handling airgapped tokens
      
      * Add support for handling airgap tokens
      
      - validate airgap token valid-thru date
      
      * enforce user creation limits using airgap token
      
      * fix airgap token reads + fill in the token data
      
      * in oss mode don't try to read the airgap_ token
      
      * use airgap-token? helper
      
      * tighten the user-creation logic
      
      - make the check correct
      - account for archived users
      
      Co-authored-by: default avatarJohn Swanson <john.swanson@metabase.com>
      
      * check airgap user count
      
      setting premium-embedding-token
      app startup
      
      * move decryption code into ee namespace
      
      * add some tests for token decryption
      
      * fix tests and add tests
      
      * move ee features into ee tests
      
      * add typehint + warn on reflection
      
      * add a check for missing public key resource
      
      * respond to review
      
      - add docstring to AirgapToken
      - remove outdated comment
      - fix off-by-1 error
      
      * valid-now? takes a TokenStatus instead of a :map
      
      * revert usage of mt/with-temporary-setting-values
      
      ---------
      
      Co-authored-by: default avatarJohn Swanson <john.swanson@metabase.com>
      Unverified
      bcda8468
  13. Feb 29, 2024
    • bryan's avatar
      Saml2 slo (#39034) · b2d7dc6c
      bryan authored
      
      * wip
      
      * SLO works with auth slo handler route
      
      * move slo handling endpoint to /auth/sso/handle_slo
      
      * fix slo redirect url
      
      * SLO works, and the sso-handle-slo for saml is where it belongs
      
      - a ton of cleanup
      
      * fix api/session namespace + add docstrings
      
      * cleaning up logout action
      
      * add slo logout test along with slo response xml
      
      * whitespace + linter
      
      * add docstring
      
      * update exclusions in deps.edn
      
      * un-require metabase-enterprise ns from oss ns
      
      * add docs for how to setup SLO to metabase docs
      
      * docs: clarify that setting up SLO is optional
      
      * move slo logout endpoint into ee code
      
      - removes sso-info defenterprise since it is no longer needed
      
      * use current version of saml20-clj
      
      ---------
      
      Co-authored-by: default avatarNick Fitzpatrick <nickfitz.582@gmail.com>
      Unverified
      b2d7dc6c
  14. Dec 14, 2023
    • Ryan Kienstra's avatar
      Move `sample-dataset` into `test-data` for backend tests (#35973) · 26bbec63
      Ryan Kienstra authored
      * Move sample-dataset.edn into test-data.edn
      
      Replace (mt/dataset sample-dataset with (mt/dataset test-data
      
      Replace more references to sample-dataset with test-data
      
      Fix the format of the combined data
      
      Might revert: remove test that doesn't apply, now that there's 1 DB
      
      Make api.database-test pass, though expected could be wrong
      
      * Update unit tests for combined dataset
      
      * Bump Bigquery version from v3_ to v4_
      
      * Bump v3_test-data to v4_test-data
      
      * Remove wrapping with mt/dataset
      
      Alphabetize fk-mappings
      
      * Remove needless whitespace edits
      
      * Fix failed e2e_test by removing reference to sample-dataset
      
      * Fix tests for Mongo, Oracle, Snowflake, and Presto
      
      * Fix unit tests again for Mongo, Presto, and Snowflake
      
      * Will revert: run driver tests on my fork
      
      * Will revert: run driver tests on my draft fork
      
      * Revert "Will revert: run driver tests on my draft fork"
      
      This reverts commit 078c8af1.
      
      * Revert "Will revert: run driver tests on my fork"
      
      This reverts commit e3e2922f.
      
      * Make the postgres driver test pass again by reverting a change
      
      * Apply Case Nelson's patch to fix Athena test
      
      https://github.com/metabase/metabase/pull/36064#issuecomment-1824837705
      Props @snoe
      
      * Remove (mt/dataset sample-dataset) from new tests
      
      * Maybe fix Athena driver tests
      
      Revert needless deletions of (mt/dataset test-data
      Maybe those deletions caused the
      failing Athena driver tests.
      But those deletions are out of scope
      for this PR either way.
      
      * Remove sample-dataset reference from a test in the master merge
      
      * In card_test.clj, replace sample-dataset with test-data
      
      * Merge in master, resolve conflict in pivot-from-model-test
      
      * Merge in master, resolve conflict in pivot-from-model-test
      
      * Must revert: allow databse creation
      
      To see if it will fix:
      https://github.com/metabase/metabase/actions/runs/7120808552/job/19388845720?pr=36064#step:3:441
      
      
      Athena database creation is disabled: not creating database v2_test_data. Tests will likely fail.
      
      * Revert "Must revert: allow databse creation"
      
      This reverts commit d4c8f129.
      
      * Add back in (mt/dataset where I deleted it
      
      But replace sample-dataset with test-data.
      This might be wrong, or maybe it's not needed in
      so many places.
      But it could show if this is the problem.
      
      * Fix the failed sync test
      
      ---------
      
      Co-authored-by: default avatarCase Nelson <case@metabase.com>
      Unverified
      26bbec63
  15. Dec 06, 2023
  16. Nov 17, 2023
  17. Oct 20, 2023
  18. Oct 18, 2023
  19. Oct 03, 2023
  20. Sep 27, 2023
  21. Jul 14, 2023
  22. Jun 21, 2023
  23. Jun 07, 2023
    • bryan's avatar
      Autoload instance analytics content (when EE and avaliable) (#31314) · 4cbbc961
      bryan authored
      * wip
      
      * fix caching behavior for audit db in database-id->connection-pool
      
      * test that caching behavior works as advertised
      
      - db->pooled-connection-spec always returns the same pool for audit-db
      - audit-db-id is not in the database-id->connection-pool cache
      
      * DISABLE audit db exposure through GET api/database
      
      * Lots of things
      
      - automagically loads instance analytics on app startup
      - TODO: logging in after that is bokred
      
      * add some logs / fix comment
      
      * remove internal_analytics resource
      
      * fix linter issues + update logging
      
      * add tests for existing and missing content
      
      - add test replica of content into test-resources
      
      * remove unused require
      
      * delete sample db + personal collection from test-resources
      
      * get instance_analytics resource off the resource path
      
      * point it to the proper IA resource
      
      * un-hotwire the change to show audit DB on GET /databases
      
      * fix test + lookup the right resource
      
      * remove creator_id references from instance_analytics export test data
      
      - get test feedback
      
      * Revert "remove creator_id references from instance_analytics export test data"
      
      This reverts commit 1aa9d4b1dad304ac0c6d88221f81432d78fc88f0.
      
      * fix tests
      
      * lint
      
      * fix tests
      
      * more test fixing
      
      * linter fix
      
      * revert yarn.lock
      
      * Look up the correct instance_analytics resource
      
      * cleanup comment in serialization/cmd.clj
      
      * silence noisy serialization import logs
      
      * remove a bunch of unused serialization files
      
      * rename Audit Database + docstring
      
      * rename audit database everywhere
      
      * Put the database and tables back
      
      * constrain tests to postgres
      
      * ignore ia data in a test
      Unverified
      4cbbc961
  24. Apr 13, 2023
  25. Apr 03, 2023
    • Mark Bastian's avatar
      Added pretty? option to POST api/dataset/native route (#29336) · 220ad8f1
      Mark Bastian authored
      Added `pretty` option to POST api/dataset/native route. Defaults to `true` such that invocations of this endpoint will return pretty-formatted SQL. In the case of previewing the native SQL editor with templating, we pass `false` so that what is typed is what is presented. In all other cases we accept the default.
      Unverified
      220ad8f1
  26. Jan 23, 2023
  27. Dec 28, 2022
  28. Dec 13, 2022
  29. Sep 23, 2022
  30. Aug 02, 2022
  31. Jul 06, 2022
  32. Jun 08, 2022
  33. Jun 02, 2022
    • adam-james's avatar
      Adjust JWT and SAML fetch-and-update user to save new attributes (#23005) · 174afe58
      adam-james authored
      * Adjust JWT and SAML fetch-and-update user to save new attributes
      
      Before this change, JWT/SAML logins would attempt to update attributes, but never considered the first-name or
      last-name attributes.
      
      * Attempts to fix tests to prevent pulluting test users with "Unknown"
      
      * No deleting users.
      
      * Unit tests checking that first/last names are updated for SSO users
      
      When an SSO user is first logged in, they might not have first_name and/or last_name keys. This is allowed, but the
      names will be "Unknown" in the app-db. Subsequently, a User may log in again with SSO but have fisrt/last name
      attributes, which should update the Metabase user data in the app-db.
      
      These unit tests set up such a scenario to check that the :first_name and :last_name keys are indeed updated.
      
      * Adjust Enterprise LDAP to also use SSO-UTILS
      
      Trying to unify the LDAP implementation with JWT/SAML a bit here.
      
      * Lint error
      
      * Reverting LDAP ns changes to get the PR unstuck
      
      This is to keep the ball rolling on SSO fixes. I'll add LDAP as an item in the Epic to address this separately.
      Unverified
      174afe58
  34. May 09, 2022
  35. Apr 07, 2022
    • Ngoc Khuat's avatar
      Fix SSO failed to sync admin group (#20991) · 0708ce0a
      Ngoc Khuat authored
      * fix failed to sync admin group
      
      * address noah's comments and add migration script
      
      * document for run-with-data-migration-index
      
      * update comments
      
      * fix name space
      
      * adding data_migrations tests
      
      * add docg
      
      * make sure we don't remove admin group if sso and ldap are not configured
      
      * fix tests for be-ee
      
      * fix tests for oss
      
      * misc docs updates
      
      * remove data-migration-index
      
      * return some newlines
      
      * is it failling here?
      
      * update data_migration docs
      
      * update data_migration docs
      
      * fix all styling comments
      
      * make migration to run both in oss and enterprise and make sure the tests are accounted for that
      
      * fix failed namespace checks
      
      * Add a comment to the test
      
      * fix per comments
      
      * Update permissions.clj
      
      * tweaking with the :warning: icon
      
      * refactor with-temporary-raw-setting-values
      
      * update comments
      
      * Add extension for cert file
      
      * address Noah's comments
      Unverified
      0708ce0a
  36. Jan 06, 2022
Loading