This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Feb 18, 2023
-
-
Nemanja Glumac authored
-
- Feb 17, 2023
-
-
john-metabase authored
* Removes :presto driver and tests * Merges :presto-common into :presto-jdbc * Adds migration to update presto databases to presto-jdbc --------- Co-authored-by:
Cam Saul <github@camsaul.com>
-
Nemanja Glumac authored
This makes it possible to have these matrix-generated jobs mark as required, even in situations when file-path filter doesn't trigger the original test.
-
Nemanja Glumac authored
[ci skip]
-
Nemanja Glumac authored
[ci skip]
-
- Feb 16, 2023
-
-
Nemanja Glumac authored
[ci skip]
-
Gustavo Saiani authored
-
Luis Paolini authored
-
- Feb 15, 2023
-
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
- Feb 14, 2023
-
-
Aleksandr Lesnenko authored
-
Nemanja Glumac authored
-
- Feb 10, 2023
-
-
Anton Kulyk authored
* Add script validating e2e test file names * Move helper files to helper directories * Fix whitespace before the first file name * Add node shebang Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * Check if staged files include relevant files from `scenarios` folder * Distinguish between staged files and all files * Add precommit hook * Update binning folder structure * Improve glob pattern * Add back forgotten binning constants * Update cross-version folder structure * Update embedding folder structure * Update embedding folder structure * Update dashboard-filters folder structure * Use all caps for global vars * Address feedback: consistency * Simplify functions * Actually exit the process * Adjust script for use with `lint-staged` * Apply another suggestion to optimize script * Improve naming of boolean checks * Fix the init logic --------- Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
Nemanja Glumac authored
-
- Feb 09, 2023
-
-
Aleksandr Lesnenko authored
-
Nemanja Glumac authored
-
- Feb 08, 2023
-
-
Aleksandr Lesnenko authored
-
Braden Shepherdson authored
This is needed with the move to `deps.edn` for tracking all dependencies, since it makes shadow-cljs rely on the `clojure` binary.
-
Cam Saul authored
-
- Feb 06, 2023
-
-
Aleksandr Lesnenko authored
* Update PR template * review
-
- Feb 02, 2023
-
-
Mahatthana (Kelvin) Nomsawadi authored
* `nock` behave differently between v14 and v16+ * Remove xmlhttprequest * [ci skip] Add a comment warning people to not upgrade CI node version As it might break the unit tests.
-
dpsutton authored
Originally made all "drivers" tests skip the :mb/once test selected test namespaces. But we use the drivers matrix to test the different app-db types (mysql, postgres). So this moves the `:exclude-tags [:mb/once]` selector off of the drivers job and into particular driver jobs. ```clojure user=> (letfn [(uses-exclude? [[job-name job]] (let [steps (:steps job)] (reduce (fn [uses? step] (if-let [with (:with step)] (if (= ":exclude-tags '[:mb/once]'" (:test-args with)) (reduced true) uses?) uses?)) false steps)))] (-> (group-by uses-exclude? (:jobs (yaml/from-file ".github/workflows/drivers.yml"))) (update-vals (fn [jobs] (map key jobs))))) {true (:be-tests-athena-ee :be-tests-bigquery-cloud-sdk-ee :be-tests-druid-ee :be-tests-googleanalytics-ee :be-tests-mongo-4-2-ee :be-tests-mongo-4-2-ssl-ee :be-tests-mongo-5-0-ee :be-tests-mongo-5-0-ssl-ee :be-tests-mongo-latest-ee :be-tests-oracle-18-4-ee :be-tests-oracle-21-3-ee :be-tests-presto-186-ee :be-tests-presto-jdbc-ee :be-tests-redshift-ee :be-tests-snowflake-ee :be-tests-sparksql-ee :be-tests-sqlite-ee :be-tests-sqlserver-ee :be-tests-vertica-ee), false (:be-tests-google-related-classpath-ee ;; includes an :only selector :be-tests-mariadb-10-2-ee :be-tests-mariadb-latest-ee :be-tests-mysql-5-7-ee :be-tests-mysql-latest-ee :be-tests-postgres-ee :be-tests-postgres-latest-ee)} ``` These maria/mysql/postgres tests all specify `MB_DB_TYPE` so we omit the `exclude-tags` selector to run all tests. The only strange one here is the `:be-tests-google-related-classpath-ee` job which includes an :only selector: ```yaml steps: - uses: actions/checkout@v3 - name: Test Google Related Classpath drivers uses: ./.github/actions/test-driver with: junit-name: 'be-tests-${{ matrix.driver }}-classpath-ee' test-args: ':only "[metabase.query-processor-test.expressions-test metabase.driver.google-test metabase.driver.googleanalytics-test]"' ```
-
- Jan 26, 2023
-
-
Nemanja Glumac authored
Resolves #18301
-
Ariya Hidayat authored
For some reasons, snowplow/igluctl as the service container in GitHub Action workflow does not work anymore. Therefore, just invoke it directly with `docker run`.
-
- Jan 24, 2023
-
-
Ariya Hidayat authored
-
- Jan 23, 2023
-
-
Tim Macdonald authored
This version fixes a bug where Malli was generating types unknown to Kondo and Kondo was flagging an erroneous type mismatch. See the changelog for more details: https://github.com/clj-kondo/clj-kondo/blob/master/CHANGELOG.md#20230120
-
dpsutton authored
We can now filter out any ns tag for tests.
-
- Jan 18, 2023
-
-
Tim Macdonald authored
* Bump clj-kondo to 2022.12.10 [Fixes #27512] * Use Kondo's :config-in-call instead of grosser hacks
-
- Jan 17, 2023
-
-
metamben authored
Use the vertica/vertica-ce:12.0.2-0 image.
-
- Jan 13, 2023
-
-
Nemanja Glumac authored
-
- Jan 09, 2023
-
-
Ariya Hidayat authored
-
metamben authored
-
- Jan 05, 2023
-
-
dpsutton authored
* upgrade clojure cli version * bump clojure cli in dockerfile * use expanded cache paths * list cache contents * ls repository * enumerate m2 cache * remove count of cached dirs * restore `~` in cache paths * Revert "remove count of cached dirs" This reverts commit e768912b31075c7b19b4a3ccdb66c0248ea06c87. * Revert "Revert "remove count of cached dirs"" This reverts commit 9eeaff2190d78714770d8ec9f64b015c75085876. * trailing slash seems harmless but unnecessary
-
- Jan 04, 2023
-
-
metamben authored
* Implicit action pre-fetch values (#25940) * [Apps] Implicit action pre-fetch values WIP To return a parameter-id: value map in order to prefill ui. * Use jsonstring encoded parameters * Change parameters exposed by implicit actions Previously, we would look at a model's source-table to determine which parameters were valid for implicit actions. So if an implicit action is on a User model that hides the user.password column, you could still update or insert the password. With this commit, if the model doesn't expose a source table column, it is not a valid parameter. In the example user.password could not be inserted/updated or fetched for prefilling. * Fixing tests * Show data app page ID params in editing mode (#25943) * Data apps layout updates (#25930) * play with grid sizes to make apps feel appier [ci skip] * move app nav to bar inside app * only hide other header buttons outside of edit mode * tweak overflow issue * fix header width on data apps * add control to see app contents * set data apps layout constants contextually [ci skip] * remove hardcoded value [ci skip] * extract conextual header styles [ci skip] * set max-width on paramaters for data apps [ci skip] * move data apps nav deeper, only show if not editing [ci skip] * add spacing to contents trigger, rm old code [ci skip] * rm table thing for now [ci skip] * Fixes for data app layout updates (#25962) * Reorder import * Fix type * Fix missing translation, move out URL * Remove not used import * Rework `getSelectedItems` utility for data apps * Fix selected data app page highlighting * Don't reload app navbar on page change * Change nav item links look * Remove `DataAppPageSidebarLink` * Turn nav into HTML list * Use styled components * Fix edit button covered by visualizations * Fix opening homepage * Remove redundant prop Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com> * First take at parameterized data app page titles (#25938) * Bring `DataAppContext` back * Pass `onFocus` and `onBlur` to `EditableText` * Export `EditableTextProps` * Add basic `DataAppPageTitle` component * Use `DataAppPageTitle` * Fix component name * Add primitive autocompletion to page title input * Add `title_template` to `DataAppNavItem` type * Tweak value management in `DataAppPageTitle` * Handle `null` values in titles more gracefully * Don't show suggestions without detail cards * Don't add whitespace when pasting a token * Don't update app's collection all the time * Add data app related selectors to dashboard selectors * Add redux state to keep title template changes * Update page title template on page save * Wire up `DataAppPageTitle` with dashboard code * Fix unit tests * Reset state on exiting editing mode * Add back button to template data picker * Fix test that didn't include pk on insert * Use the actual pk value Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com> Co-authored-by:
Kyle Doherty <5248953+kdoh@users.noreply.github.com> * Revert "Remove data app permission code (#26016)" This reverts commit b8c92cf1. * Remove unused imports * Don't require the table_id on result_metadata elements (#26073) In some cases (which ones still has to be clarified) the result metadata doesn't contain the table_id and so no parameters are provided. In fact the table ID is probably not needed anyway because fields are already table specific. * Support filtering cards by used model (#26088) This change adds a new filter option for the GET /card endpoint. * Support filtering apps using a given model (#26124) * Handle type errors more cleanly (#26120) * [Apps] Handle type errors more cleanly Adds a number of tests for different db datatypes, these can be expanded on as we solve. Catches most exceptions during execution and logs then throws a generic message that leaks less of the details. * Make sure we order-by expected results * Fix tests, allow purposeful exception through * Accept model-ids for scaffolding apps (#26139) * [Apps] Accept model-ids for scaffolding apps WIP - accept model-ids but there's still some issues, might be able to start building UI from this point though. * Maybe working model * Work with card__n table-ids passed in. Fix problems with detail page * Dynamically add actions that exist on models * Update tests for existing custom actions * Can't def tru * Address review comments * Add required to action parameters (#26296) Looks at `database_required` field values for implicit actions, and `required` template-tags for custom query actions. Bubble those values up onto `action.parameters`. Finally, look at `requires_pk` to see if pk fields should be marked as required regardless. * Cleanup scaffolded back button (#26317) * Forward action execution error messages to the frontend (#26469) This is a crude temporary solution necessary to be able to debug problems related to executing actions. Although error parsing has been implemented for Postgres (only) with the goal to provide information for the FE like `{"errors":{"id":"violates foreign key constraint note_subject_id_fkey"}}`. This code doesn't care about the error message itself, it just forwards the error message from the DB to the FE. * Actions for public pages (#26554) * [Apps] Testing out public dashboards * Add WIP endpoints for public execution * Add throttle check to public execution route * Bump attempts-threshold to 1000 * Bump threshold to 5000 * Add test * Fix linter * Review changes * Fix lint * Run publicly shared actions with full permissions (#26610) * Support actions with MySQL and MariaDB (#26573) Support actions with MySQL/MariaDB * Check permissions for implicit actions (#26652) * Check permissions when executing implicit actions * Fix some action tests and reduce permissions boilerplate * Revert "[Apps] Disable data-apps prior to release (#25982)" This reverts commit 51147027. * WIP: Unify action representation (#26717) (#27349) * [Apps] WIP initial db migrations for giving implicit actions an action_id and removing card from query_action * Make crud work for http actions * Make implicit crud work * Rename implicit_action.namespace to kind. Rewrite merged-model-actions to actions-with-implicit-parameters * Fix query action creation * Make actions.test-util/with-action create a holding model * Fix unified-action-create-test * Fix get-action-test * Add tests for creating implicit and http dashcard actions * Enable query action in dashcard-action-create-update-test * Fix metabase.api.dashboard-test/dashcard-query-action-execution-test * Fix metabase.api.dashboard-test/dashcard-http-action-execution-test * Fix metabase.api.dashboard-test/dashcard-action-execution-auth-test * Fix metabase.api.dashboard-test/dashcard-action-execution-granular-auth-test * Make implicit action execution work * Scaffolding implicit actions from table * Fix metabase.api.action-test * Make scaffolding work with existing models. Update with-action macro to allow multiple actions * Fix metabase.api.public-test * Remove unused names from metabase.models.action * Remove some unused imports * Remove an unused import * Remove model_action and fix a bunch of tests * Fix dashcard-implicit-action-only-expose-and-allow-model-fields * Fix action type inheritance * Fill in remarks and add description to action * Add forward migration for existing actions and rollbacks that remove existing actions * Prevent overwriting parameters of custom actions * Support setting description on actions * Update migration to work with mysql - rollback is still not quite working in mysql due to database_id fk * Rename with-action macro to with-actions and document it * Remove report_card.is_write * Fix some more tests * Fix rollback across all appdb drivers, add not null constraints, use action.name to hold implicit slugs * Pull name and description from is_write card * Add name to scaffolded implicit actions * Remove ModelAction * Remove is_write from comments too * Different databases reference capture groups in regexp_replace differently. Also drop model_action table * Update migrations to pass linter. Introduce ${capturegroup.ref} to handle the different ways to reference capture groups within a regexp_replace. This allows collapsing large data migrations into a single `sql` element that the linter requires. * Add kind to action-mapper so we can sort as we wish * Add name to with-temp Action * Adjust FE to query actions migration (#26764) * Remove `is_write` card notion * Remove action `slug` from action types * Fix typo in `estimateCardSize` name * Remove hanging card's `is_write` prop * Remove not used writeback actions * Update endpoints * Remove not used prop * Remove action `slug` usage * Update actions entity * Tweak action creator to handle new actions shape * Fix saving action dashcards * Fix actions API usage How did that work before?
* Pass `database_id` when creating query actions * Remove custom list API implementation for actions * Clean up types Co-authored-by:Tamás Benkő <tamas@metabase.com> * Change regexp_replace to substring to support mysql - this is ok because we have consistent json serialization. * Check permissions on the model in the action API * Remove unused required namespace * Throw an exception when demoting a model with actions to question * Allow saved parameters on implicit actions to add to implicit parameters Co-authored-by:
Case Nelson <case@metabase.com> Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com> Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> Co-authored-by:
Case Nelson <case@metabase.com> * empty commit to kick CI * bump CI * Fix down migrations change v45.00-002 sets up a fk fk_query_action_ref_action_id. h2 v2 for some strange reason requires us to remove the constraint before we can remove the primary key. But then we have to restore the state that v45.00-002 creates manualy * Allow for version for `(migrate! :down 45)` * Remove data apps parts not planned for 0.46 Removed app container, app scaffolding and pages (dashboards with is_app_page) * Address linter issues * Make some cosmetic changes to reduce the diff * Make new permission API endpoints use defendpoint-schema * Fix bad automerge * Skip Mongo 4.2 instead of 4.0 Co-authored-by:
Case Nelson <case@metabase.com> Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com> Co-authored-by:
Kyle Doherty <5248953+kdoh@users.noreply.github.com> Co-authored-by:
dan sutton <dan@dpsutton.com>
-
- Jan 03, 2023
-
-
Case Nelson authored
* Fix mongo version checking for now * Add minor versions for comparison * Handle nil case * newline * Replace _ * Use dbms-version semantic-version instead * Compare only the major and minor version * Fix mongo database-supports? * Fix duplicate require * Fix typo * Remove expressions from version check * Fix various mongo expressions `trim`, `rtrim`, `ltrim` needed to be wrapped in `{"input" expr}` object `replace` needed to be wrapped in `{"input" expr "find" ... "replacement" ...}' object `substring` needed to fill in the 3rd argument, optional in mbql but required in mongo. Also to use a 1 based index * Generalize semantic-version-gte * Used synced dbms_version for testing feature support * Expressions are only supported by mongo 4.2+ * Disable some tests * Fix mongo division Handle nulls with an upfront condition check. Handle multiple divisors. * Remove unused namespace * Throw exeception if using replace on mongo < 4.4 * Skip test because of #27249 * Move minimum Mongo CI version to 4.2 * Fix sorting by expressions $sort needs to come before $project otherwise we can only see the projected fields, however expressions are only added in $project. So now if a sort includes an expression, we will use $addFields to be able to sort by that expression. * Disable tests for expressions inside aggregations To be addressed by #27275 * Handle aggregation nested in an expression * Remove :truncation-start workaround * Enable tests for expressions inside aggregations * Fix datetime-math-tests * Make sure dbms_version is included when fetching database for store * Update doc for replace to indicate it should replace all occurrences * Fix order-by-test * Handle embedded special aggregations (#27315) * Handle embedded special aggregations * Preserve aggregation options for nested aggregations * Use top-level aggregation name as group name * Disable nil punning on semantic version check (#27317) * Optimize produced query for division when dividing by literals * Rename var * Use reduce to build division * Fix reduction * Clean up formatting and document some details Co-authored-by:
Callum Herries <hi@callumherries.com> Co-authored-by:
Tamás Benkő <tamas@metabase.com> Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
- Dec 28, 2022
-
-
Nemanja Glumac authored
This reverts commit a63f9bd1.
-
metamben authored
* Use gvenzl/oracle-xe docker to test Oracle * Configure SSL connection for Oracle 21.3 * Fix secret handling
-
- Dec 26, 2022
-
-
Nemanja Glumac authored
* Do not run backend workflow when in draft mode * Do not run FE unit tests when in draft mode * Let BE `kondo` linter run even in the draft mode * Run `be-java-11-ee` even in the draft mode * Remove `matrix` from the job condition * Add `java-11-ee` pre-check in draft mode * Run both BE and FE workflows when PR is marked for review * Name the pre-check java-11 job accordingly
-
Nemanja Glumac authored
-
Cam Saul authored
* Switch back to main fork of `clojure.java-time` and bump version * Run uberjar build steps in one command (faster CI) * Fix `truncate-to` for new version of `clojure.java-time`
-