This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Aug 02, 2023
-
-
Kamil Mielnik authored
* Add actions dropdown to object detail modal (#32331) * Rename showActions to showControls * Use Flex * Import Flex from local modules * Make horizontalAttachments a prop in EntityMenu * Use EntityMenu to create actions dropdown * Render actions menu conditionally * Add useActionListQuery * Fetch actions in ObjectDetailHeader * Remove unused canRunActions prop * Move logic to root component * Fix tests * Use canRunAction and fetch databases in ObjectDetail view * Rename actions to actionItems and getActions to getActionItems * Extract getActionItems to utils * Update tests * Rename modelActions to actions * Extract isValidImplicitDeleteAction and isValidImplicitUpdateAction out of getActionItems * Consolidate getActionItems * Use theme scale values for Mantine Flex component * Either render all controls or none * Fix default props/state in EntityMenu * Fix props * Update ObjectDetail unit tests * Add unit tests for isValidImplicitDeleteAction and isValidImplicitUpdateAction * Update tests with more specific non-implicit action cases * Use singular form to match function interface * Add unit tests for getActionItems * Update test case name * Avoid using Database constructor - Use metadata.database() instead * Add integration tests for basic cases when action menu is rendered and not * Fix post-merge error * Endpoint to fetch implicit actions param values (#32466) * Add default update action to actions dropdown in object detail modal (#32433) * Rename showActions to showControls * Use Flex * Import Flex from local modules * Make horizontalAttachments a prop in EntityMenu * Use EntityMenu to create actions dropdown * Render actions menu conditionally * Add useActionListQuery * Fetch actions in ObjectDetailHeader * Remove unused canRunActions prop * Move logic to root component * Fix tests * Use canRunAction and fetch databases in ObjectDetail view * Rename actions to actionItems and getActions to getActionItems * Extract getActionItems to utils * Update tests * Rename modelActions to actions * Extract isValidImplicitDeleteAction and isValidImplicitUpdateAction out of getActionItems * Consolidate getActionItems * Use theme scale values for Mantine Flex component * Either render all controls or none * Fix default props/state in EntityMenu * Fix props * Update ObjectDetail unit tests * Add unit tests for isValidImplicitDeleteAction and isValidImplicitUpdateAction * Update tests with more specific non-implicit action cases * Use singular form to match function interface * Add unit tests for getActionItems * Update test case name * Sort imports * Rename initialValues to values * Rename dashcardParamValues to initialValues * Lift fetchInitialValues up from ActionParametersInputForm * Rename refetchValues to prefetchValues * Fix tests * Refactor shouldPrefetch to be a prop * Get rid of dashboard and dashcard props from ActionParametersInputForm * Lift the canPrefetch condition up as it is not desired outside of dashboards * Hook update action with temporary API * Use executeActionId in fetchInitialValues * Fix post-merge conflict * Rename prefetchValues to prefetchDashcardValues * Use the new endpoint * Use rem values instead of scale values - See https://github.com/metabase/metabase/pull/32331#discussion_r1267827835 * Lift data reloading out of executeRowAction * Add onSuccess prop to ActionExecuteModal * Use onSubmitSuccess from ActionParametersInputForm * Reload question after action is successful * Fix stale prop issues in ActionParametersInputForm * Fix object id in initialValues * Add prefetchesInitialValues prop to make useActionForm more generic * Ignore public actions for now * Fix id mixup * Update unit test * Remove redundant memoization * Use modern JS syntax instead of noop * Move getNextId to __support__/utils * Extract isImplicitDeleteAction & isImplicitUpdateAction * Reuse isImplicitDeleteAction * Log error to console * Get rid of useLatest * Fix post-merge build error * Add default delete action to actions dropdown in object detail modal (#32556) * Rename showActions to showControls * Use Flex * Import Flex from local modules * Make horizontalAttachments a prop in EntityMenu * Use EntityMenu to create actions dropdown * Render actions menu conditionally * Add useActionListQuery * Fetch actions in ObjectDetailHeader * Remove unused canRunActions prop * Move logic to root component * Fix tests * Use canRunAction and fetch databases in ObjectDetail view * Rename actions to actionItems and getActions to getActionItems * Extract getActionItems to utils * Update tests * Rename modelActions to actions * Extract isValidImplicitDeleteAction and isValidImplicitUpdateAction out of getActionItems * Consolidate getActionItems * Use theme scale values for Mantine Flex component * Either render all controls or none * Fix default props/state in EntityMenu * Fix props * Update ObjectDetail unit tests * Add unit tests for isValidImplicitDeleteAction and isValidImplicitUpdateAction * Update tests with more specific non-implicit action cases * Use singular form to match function interface * Add unit tests for getActionItems * Update test case name * Sort imports * Rename initialValues to values * Rename dashcardParamValues to initialValues * Lift fetchInitialValues up from ActionParametersInputForm * Rename refetchValues to prefetchValues * Fix tests * Refactor shouldPrefetch to be a prop * Get rid of dashboard and dashcard props from ActionParametersInputForm * Lift the canPrefetch condition up as it is not desired outside of dashboards * Hook update action with temporary API * Use executeActionId in fetchInitialValues * Fix post-merge conflict * Rename prefetchValues to prefetchDashcardValues * Use the new endpoint * Use rem values instead of scale values - See https://github.com/metabase/metabase/pull/32331#discussion_r1267827835 * Lift data reloading out of executeRowAction * Add onSuccess prop to ActionExecuteModal * Use onSubmitSuccess from ActionParametersInputForm * Reload question after action is successful * Fix stale prop issues in ActionParametersInputForm * Fix object id in initialValues * Add prefetchesInitialValues prop to make useActionForm more generic * Ignore public actions for now * Fix id mixup * Update unit test * Add DeleteObjectModal * Introduce useActionQuery * Use useActionQuery in DeleteObjectModal * Hook action execution * Fix typo in copy * Sort exports * Remove redundant memoization * Use modern JS syntax instead of noop * Move getNextId to __support__/utils * Extract isImplicitDeleteAction & isImplicitUpdateAction * Reuse isImplicitDeleteAction * Fix object modal getting closed with Escape key when delete or update modals are open * Rename isUpdateModalOpen to isActionExecuteModalOpen, updateActionId to actionId * Navigate to sibling row or close the modal on deletion * Revert "Navigate to sibling row or close the modal on deletion" This reverts commit 8b24685eee5cd968f53cc14b7194a66588fb5845. * Close object detail on deletion * Add error handling * Add error handling * Greatly simplify DeleteObjectModal - remove useActionQuery usage - remove useActionQuery - remove DeleteObjectModal.styled.tsx * Improve diff * Shorten code * Always cast objectId to number - See https://metaboat.slack.com/archives/C057T1QTB3L/p1690292706101109?thread_ts=1690279562.697669&cid=C057T1QTB3L "the reason you’re not seeing it fail on the sample dataset is probably because you’re using h2 for sample-dataset. it’ll fail the same if you use a postgres one. h2 is probably more loose in type so it allows sending a string for id. nevertheless, I think you can use cast it to the correct type using the param type. I think we did that on the UI where we execute actions from model details page." * Inline disabled into JSX * Use a more friendly error message when failed to delete an object because it's referenced by other objects - See: https://metaboat.slack.com/archives/C057LE0Q4PQ/p1690377421352469?thread_ts=1690208614.530869&cid=C057LE0Q4PQ * Revert "Use a more friendly error message when failed to delete an object because it's referenced by other objects" This reverts commit 28327ac9b53ae92300e579d047b7f136d54e581e. Friendly message is going to be implemented in https://github.com/metabase/metabase/issues/32694 * Rename initialValues back to dashcardParamValues in ActionVizForm * Tests for basic deletes and updates on object detail views (#32525) * Rename showActions to showControls * Use Flex * Import Flex from local modules * Make horizontalAttachments a prop in EntityMenu * Use EntityMenu to create actions dropdown * Render actions menu conditionally * Add useActionListQuery * Fetch actions in ObjectDetailHeader * Remove unused canRunActions prop * Move logic to root component * Fix tests * Use canRunAction and fetch databases in ObjectDetail view * Rename actions to actionItems and getActions to getActionItems * Extract getActionItems to utils * Update tests * Rename modelActions to actions * Extract isValidImplicitDeleteAction and isValidImplicitUpdateAction out of getActionItems * Consolidate getActionItems * Use theme scale values for Mantine Flex component * Either render all controls or none * Fix default props/state in EntityMenu * Fix props * Update ObjectDetail unit tests * Add unit tests for isValidImplicitDeleteAction and isValidImplicitUpdateAction * Update tests with more specific non-implicit action cases * Use singular form to match function interface * Add unit tests for getActionItems * Update test case name * Sort imports * Rename initialValues to values * Rename dashcardParamValues to initialValues * Lift fetchInitialValues up from ActionParametersInputForm * Rename refetchValues to prefetchValues * Fix tests * Refactor shouldPrefetch to be a prop * Get rid of dashboard and dashcard props from ActionParametersInputForm * Lift the canPrefetch condition up as it is not desired outside of dashboards * Hook update action with temporary API * Use executeActionId in fetchInitialValues * Fix post-merge conflict * Rename prefetchValues to prefetchDashcardValues * Use the new endpoint * Use rem values instead of scale values - See https://github.com/metabase/metabase/pull/32331#discussion_r1267827835 * Lift data reloading out of executeRowAction * Add onSuccess prop to ActionExecuteModal * Use onSubmitSuccess from ActionParametersInputForm * Reload question after action is successful * Fix stale prop issues in ActionParametersInputForm * Fix object id in initialValues * Add prefetchesInitialValues prop to make useActionForm more generic * Add test cases for other types of actions * Ignore public actions for now * Add e2e test for actions in object detail view * Add second step and extract helpers * Remove duplication by changing hierarchy * Add step with enabling model actions * Fix visiting model page * Remove redundant code * Ignore public actions for now * Fix id mixup * Update unit test * Add objectId argument and function to open the modal * Define whole order object to reuse * Implement assertOrderFormPrefilled * Assert Created At * Add assertion to check whether object with new id has been reloaded * Use all caps for constants * Verify updating an object * Fix test name * Assert toast is shown on update * Format code * Use writable tables instead of sample db to avoid persisting updates between tests - do not mock objects, assert against whatever comes from API * Format code to wake GitHub up * Add DeleteObjectModal * Introduce useActionQuery * Use useActionQuery in DeleteObjectModal * Hook action execution * Fix typo in copy * Sort exports * Remove redundant memoization * Use modern JS syntax instead of noop * Move getNextId to __support__/utils * Extract isImplicitDeleteAction & isImplicitUpdateAction * Reuse isImplicitDeleteAction * Fix object modal getting closed with Escape key when delete or update modals are open * Rename isUpdateModalOpen to isActionExecuteModalOpen, updateActionId to actionId * Navigate to sibling row or close the modal on deletion * Revert "Navigate to sibling row or close the modal on deletion" This reverts commit 8b24685eee5cd968f53cc14b7194a66588fb5845. * Close object detail on deletion * Add error handling * Add error handling * Greatly simplify DeleteObjectModal - remove useActionQuery usage - remove useActionQuery - remove DeleteObjectModal.styled.tsx * Improve diff * Shorten code * Rename initialValues back to dashcardParamValues in ActionVizForm * Extract assertScoreUpdatedInTable * Extract visitModelDetail * Add deletion and toast assertion * Remove unused arguments * Assert delete failed * Update tests order after starting with writable db * Move assertions to beginning of the test, remove enableDatabaseActions * Test disabling model actions * Add extra assertion * Update names * Update the deletion assertion * Remove unused code * Wrap tests in another describe, setup dashboard test * Fix setup, use asAdmin util * Add assertion for dashboard object view * Update test names * Extract actions to a constant * Add test to open update object modal * Update assertion order * Add test to open delete object modal * Organize tests * Add a test case for implicit public delete action & implicit archived delete action * Remove redundant async * Reuse findActionInActionMenu * Remove redundant constant * Fix tests * Add a test case for databases with disabled actions * Update wording * Use dataset instad of a query question * Revert name change as it does not make sense * Format code * Add a test case for users with no write permission * Add a test case for when showControls is false * Add a test case for models with clauses * Use metadata.question() instead of new Question() * Tests for various number of PKs in a model (#32784) * Add a test case for 0 PKs in a model * Add a test case for 2 PKs in a model * Improve test names * Fix typo * Use plural form for "PK" --------- Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
Mahatthana (Kelvin) Nomsawadi authored
* Simplify the code that fixes dashboard tab race condition Remove a part of dashboard reducer that addressed the race condition from https://github.com/metabase/metabase/pull/31578/files#r1240203745. I revert the code back to make it simpler and fix the race condition by calling certain actions in the right order. * Update the todo comment to use more standard todo tag * Prevent fetching a dashcard when the previous API isn't done and is auto-refresh * Only skip loading new dashcard on dashcoard auto refresh * fixup! Simplify the code that fixes dashboard tab race condition * Clean up dashboard action Rename an action with misleading name * Make the boolean flag easier to understand * fixup! Make the boolean flag easier to understand * Add E2E * Remove commented out code * Correct `startTime` behavior * Fix the case when navigating between dashboards * Make isRefreshing logic easier to follow * Fix failed unit tests
-
Nemanja Glumac authored
#32734 introduced a commit that removed "Chrome" as a predefined browser that Cypress runs on. This was needed due to frequent failures that were interfering with the release process. Even if we decide to switch to Electron, let's do it in a dedicated commit for easier git blame. We'll forget in a month already why a commit called "Disallow new H2 connections" switched E2E tests to Electron.
-
Nemanja Glumac authored
Breaking change was introduced in #32791.
-
- Aug 01, 2023
-
-
Ryan Laurie authored
* when embedded, force showing side nav when top nav is hidden * don't force open navbar on visible paths * update e2e tests * fix types
-
Uladzimir Havenchyk authored
* Allow selecting time on datepicker at dashboard filter * Add e2e test * Rename variable
-
Cam Saul authored
* Prevent malicious H2 connection string properties * Disallow new H2 connections * Fix Kondo lint warning * Test fix
--------- Co-authored-by:dan sutton <dan@dpsutton.com>
-
Alexander Polyankin authored
-
Ryan Laurie authored
-
Nemanja Glumac authored
* Move util functions inside the `visitEmbeddedPage` helper * Clean up `cy.exec` comand * Tighten the scope of `cy.exec` * Use query string to set filters * Construct url hash from page style and hidden filters * Improve JSDoc
-
- Jul 31, 2023
-
-
shaun authored
-
Ryan Laurie authored
* debounce link viz input blur * make blur bouncier
-
Nick Fitzpatrick authored
-
Kyle Doherty authored
* revert dr removal * revert some more code that the data reference needed * Bring back `db_metadata` endpoint reference * model test fixes --------- Co-authored-by:
Ryan Laurie <iethree@gmail.com> Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
-
Ryan Laurie authored
-
Alexander Polyankin authored
-
- Jul 29, 2023
-
-
Uladzimir Havenchyk authored
* Rework default exports to named * Fix UX for empty dashboard filter with multiple choices * Update e2e/test/scenarios/dashboard-filters/dashboard-filters-text-category.cy.spec.js Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
- Jul 28, 2023
-
-
Nick Fitzpatrick authored
* SecretKeyWidget accepts confirmation header and dialogs * removing default confirmation values, adding e2e test
-
- Jul 27, 2023
-
-
Nick Fitzpatrick authored
-
Oisin Coveney authored
-
Nemanja Glumac authored
* Customize and style Cypress `log` command This PR will add a background color to the Cypress log command, in order to make it stand out. This should help with reviewing Cypress recorded runs and with the general E2E tests debugging experience. * Remove acii art prefix Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Update the background color Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Apply Kamil's suggetion * Improve performance and readability * Extract id for the custom style element --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
- Jul 26, 2023
-
-
Nemanja Glumac authored
* Adapt and improve embedding smoketests This commit deals with the 'embedding is not yet enabled' section. * Add test ids to embedding page * Adapt and improve embedding smoketests This commit deals with the 'embedding enabled' section. * Expand embedding smoketests - Make sure we can regenerate the token - Make sure the old embedding url doesn't work after that * Run full-app embedding tests only with token * Improve assertions
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix jarring scalar viz font-size change on dashcard * Fix render scalar on dashboard to render the correct size * Improve test readability * Make timeout clear which one we're using * Improve test stability on CI * Fix failed E2E repro
-
- Jul 25, 2023
-
-
Nick Fitzpatrick authored
-
Uladzimir Havenchyk authored
* Show filter mapping options on mobile * Revert "Show filter mapping options on mobile" This reverts commit bb2ad6c517f41ec4a92c0e726932497abb1a0718. * Do not show edit dashboard button on small screens * Update frontend/src/metabase/dashboard/containers/DashboardHeader.styled.tsx Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Update frontend/src/metabase/dashboard/containers/DashboardHeader.styled.tsx Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Rename variable --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Noah Moss authored
* untangle ldap circular dependency * only try to require ee code when ee is available * LDAP login e2e tests * fix eslint errors * Update e2e/test/scenarios/admin/settings/sso/ldap.cy.spec.js Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * update command in e2e-ldap-helpers.js --------- Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
- Jul 24, 2023
-
-
Emmad Usmani authored
* fix dashboard empty state logic * address comments
-
Nick Fitzpatrick authored
-
- Jul 21, 2023
-
-
Nick Fitzpatrick authored
* Adding collection_id to search results, handling undefined collection * Adding isPersonalCollectionChild check * e2e test for nested collection scenario * adding e2e test for item serach * more changes
-
shaun authored
* month-year formats (“January, 2023” → “January 2023”) * quarter-year formats (“Q1 - 2023” or “Q1, 2023” → “Q1 2023”)
-
Nick Fitzpatrick authored
* Check can_write() on upload db, e2e test * test change * simplifying e2e test
-
- Jul 20, 2023
-
-
Jesse Devaney authored
* basic unsubscribe functionality * add undo unsubscribe and error display * refactor successful request display * refactor interface name * add tests and helpers for unsubscribing non-users * remove placeholder comment * undo deletion * improve type safety
-
Nick Fitzpatrick authored
* ordering users by first name in API responses * adjusting e2e tests * Adding Normal Personal Collection ID to cypress data
-
- Jul 19, 2023
-
-
Mahatthana (Kelvin) Nomsawadi authored
* WIP remove unnesessary call * Add test to the PUT dashboard unnecssary API call * Prevent calling save dashboard cards when not necessary * Call only necessary API when updating single dashboard attribute * Organize tests * Simplify test assertions * Simplify implementation * Simplify implementation * Rename a function making it closer to what it does * Rename a function making it closer to what it does * Clean up Cypress tests * Fix conflict from master
-
- Jul 18, 2023
-
-
Emmad Usmani authored
* fix error when archiving custom homepage dashboard * add e2e test case * fix type error * update unit test
-
- Jul 17, 2023
-
-
Alexander Polyankin authored
-
Uladzimir Havenchyk authored
* Fix setup alert right after question creation * Provide keys to react elements * Rework class based components to functional
-
- Jul 14, 2023
-
-
Braden Shepherdson authored
Previously this was done by checking if the FE had included `:collection "some_table"` on the native query, but that's been included for SQL queries lately, and broke "Explore Results". Includes new e2e tests: one for this issue itself, and another that the fix doesn't break real Mongo native queries. Fixes #32121.
-
Nick Fitzpatrick authored
* adjusting minimum size for scalar (number) cards * adjusting resize e2e test * simplfying cy intercept * reverting e2e test change
-
Oisin Coveney authored
-