Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. May 13, 2024
  2. May 09, 2024
  3. May 08, 2024
  4. May 07, 2024
  5. May 01, 2024
  6. Apr 30, 2024
    • adam-james's avatar
      Store Parameter Values Set by User on a per-user basis (#40415) · 2d29f05f
      adam-james authored
      * Store Parameter Values Set by User on a per-user basis
      
      This is a WIP for #28181 and the notion doc:
      
      https://www.notion.so/metabase/Tech-Maintain-user-level-state-in-dashboards-for-filters-fc16909a3216482f896934dd94b54f9a
      
      Still to do:
      
      - [ ] validate the table/model design
      - [ ] hook up the endpoints mentioned in the doc (2 in api/dashboard)
      - [ ] return the user specific parameter values on /api/dashboard/:dashboardID endpoints
      - [ ] write a few tests to capture the intent of this feature
      
      * Accidentally deleted a digit in the change ID timestamp
      
      * first pass at writing user param values to the db.
      
      It's in a doseq here which is probably not the correct way to go yet, but it's a step in the right direction.
      
      * Hydrate dashboard response with `:last_used_param_values` key
      
      If the user has previously set a parameter's value, it will show up in the map under that parameter id.
      
      If the user has no parameter value set, that entry will be 'null'.
      
      * Use proper fn name
      
      * Only save or retreive user params if there's a current user id
      
      * Add model to necessary lists
      
      * Only run query when there are parameter ids to run it with
      
      * Add a test to confirm that last_used_param_values works
      
      * Add models test namespace for CRUD test
      
      * The hydration is checked in the dashboard api test already
      2d29f05f
  7. Apr 29, 2024
  8. Apr 26, 2024
  9. Apr 25, 2024
  10. Apr 24, 2024
  11. Apr 22, 2024
  12. Apr 19, 2024
  13. Apr 18, 2024
  14. Apr 17, 2024
  15. Apr 16, 2024
  16. Apr 15, 2024
  17. Apr 12, 2024
  18. Apr 10, 2024
  19. Apr 08, 2024
    • Alexander Solovyov's avatar
      cache invalidation (#40774) · 84642517
      Alexander Solovyov authored
      New endpoint accepts entity and entity ids in form of `database=1&dashboard=2&question=3`. If you don't supply
      `&include=overrides`, then it tries to find configs directly referencing supplied entities and updates their
      `invalidated_at`. If you supply `&include=overrides`, all the referenced cards are
      updated (`report_card.cache_invalidated_at`).
      
      Cache strategies then select the maximum `invalidated_at` in their logic. EE-only.
      
      resolves #40548
      84642517
  20. Apr 03, 2024
  21. Apr 02, 2024
  22. Mar 28, 2024
    • adam-james's avatar
      Make format export optional (#40606) · 347c5ef4
      adam-james authored
      
      * Make Formatting on Exports Optional
      
      Formatting on exports can be turned off via a middleware key:
      
      `:format-export?` which will control if the 'app style' formatting will be applied to the exported results.
      `:format-export? false` will return the file as in previous Metabase versions.
      
      * format_export's default value provided in the QP middleware
      
      Should still default to formatted for v. 49, as the formatting is intended as a feature. This default value should be
      provided in a central place, so is added to the middleware and is therefore not necessary for the API to provide a default.
      
      * weird indentation
      
      * Add format_export param to dashboard dashcard query endpoint
      
      * Add format_export option to embedded dashboard downloads endpoint
      
      * Move default true value to the streaming-results-writer impls
      
      * Default true but for real this time
      
      * Add format_export to the public Question endpoint
      
      * Add test to card api
      
      * Dashboard exports endpoint test
      
      * Add test to dashboard embeds
      
      Test still fails and I don't know why yet
      
      * the dangers of println debugging....
      
      Well, I was passing a string false the whole time. Turns out the problem was me
      
      * Public Card downloads endpoint now has format_export and test
      
      * export_format also works for adhoc queries using api/dataset
      
      * Let defendpoint do the boolean parsing
      
      * Embed endpoint should now work too.
      
      * Unify format-rows and format-export middlewares
      
      * Sneaky endpoint!
      
      * In xlsx, always parse temporal strings so that viz-settings formatting is applied
      
      * Snuck in an incomplete change by accident. removed it.
      
      * Can now specify format/no format on subscriptions
      
      * Fix and move migration
      
      * default format rows to true in attachments
      
      * Ok, I think that should actually work for subscriptions.
      
      * Change endpoints to use format_rows instead of confusing format_export
      
      * format_rows everywhere
      
      * Fix more test failures
      
      * redef'd function had wrong signature
      
      * Make format export optional (FE part) (#40643)
      
      * Refactor download URL builder code
      
      Need to handle query `params` and request `body` separately
      
      * Export `useHover` from `metabase/ui`
      
      * Add unformatted export for dashboard cards
      
      * Add unformatted export for saved questions
      
      * Fix POST body encoding
      
      * Add unformatted export for ad-hoc questions
      
      * Ensure `format_export` is always false for Excel
      
      * Add unformatted export to public questions
      
      * Add unformatted export to embedded questions and dashboards
      
      * Fix behavior for PNG format
      
      * Add tests for `QueryDownloadPopover`
      
      * Fix e2e downloads helper (allow URL query params)
      
      * Rework alt key handling
      
      * Add e2e test
      
      * Switch to `format_rows` instead of `format_export`
      
      * Add unformatted export option to subscriptions
      
      * Fix `isHoldingAltKey` initial state
      
      * Rework e2e test to use Total column
      
      * Fix initial checkbox state for subscriptions
      
      * Use "Alt" in tooltip label for Windows/Linux
      
      * Show the subscriptions toggle only for CSV attachments
      
      ---------
      
      Co-authored-by: default avataradam-james <21064735+adam-james-v@users.noreply.github.com>
      
      * Address review feedback
      
      ---------
      
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      347c5ef4
    • Tim Macdonald's avatar
      ParseSQL: select * (#40637) · df1366e1
      Tim Macdonald authored
      * Parse wildcards in native queries
      
      Add query_field.direct_reference
      
      * Do away with old Model refs in Card model test
      
      * Do not show stale cards with a select *
      df1366e1
  23. Mar 27, 2024
  24. Mar 26, 2024
    • Denis Berezin's avatar
      Embedding SDK - integration commit (#40198) · 98f6cd82
      Denis Berezin authored
      * Minimal SDK code
      
      * Fix viz, styles
      
      * Move SDK code to enterprise folder
      
      * Fix files structure
      
      * Clean-up
      
      * Review fixes
      
      * Review fixes
      
      * Review fixes
      
      * Remove elementid
      
      * Reuse some options from main webpack config
      
      * Actualize package.json
      
      * Actualize package.json
      98f6cd82
  25. Mar 25, 2024
  26. Mar 21, 2024
  27. Mar 20, 2024
  28. Mar 15, 2024
Loading