Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. May 31, 2022
    • Dalton's avatar
      Migrate dashboard parameter utils to TypeScript (#22985) · 37c4d3bf
      Dalton authored
      * Convert dashboard parameter utils to TypeScript
      
      * Remove unused imports
      Unverified
      37c4d3bf
    • Dalton's avatar
      Fix missing 'meta' variable (#23016) · 6b43a560
      Dalton authored
      Unverified
      6b43a560
    • dpsutton's avatar
      Fix deadlock in pivot table connection management (#22981) · a15fc4ea
      dpsutton authored
      Addresses part of https://github.com/metabase/metabase/issues/8679
      
      Pivot tables can have subqueries that run to create tallies. We do not
      hold the entirety of resultsets in memory so we have a bit of an
      inversion of control flow: connections are opened, queries run, and
      result sets are transduced and then the connection closed.
      
      The error here was that subsequent queries for the pivot were run while
      the first connection is still held open. But the connection is no longer
      needed. But enough pivots running at the same time in a dashboard can
      create a deadlock where the subqueries need a new connection, but the
      main queries cannot be released until the subqueries have completed.
      
      Also, rf management is critical. It's completion arity must be called
      once and only once. We also have middleware that need to be
      composed (format, etc) and others that can only be composed
      once (limit). We have to save the original reducing function before
      composition (this is the one that can write to the download writer, etc)
      but compose it each time we use it with `(rff metadata)` so we have the
      format and other middleware. Keeping this distinction in mind will save
      you lots of time. (The limit query will ignore all subsequent rows if
      you just grab the output of `(rff metadata)` and not the rf returned
      from the `:rff` key on the context.
      
      But this takes the following connection management:
      
      ```
      tap> "OPENING CONNECTION 0"
      tap> "already open: "
        tap> "OPENING CONNECTION 1"
        tap> "already open: 0"
        tap> "CLOSING CONNECTION 1"
        tap> "OPENING CONNECTION 2"
        tap> "already open: 0"
        tap> "CLOSING CONNECTION 2"
        tap> "OPENING CONNECTION 3"
        tap> "already open: 0"
        tap> "CLOSING CONNECTION 3"
      tap> "CLOSING CONNECTION 0"
      ```
      
      and properly sequences it so that connection 0 is closed before opening
      connection 1.
      
      It hijacks the executef to just pass that function into the reducef part
      so we can reduce multiple times and therefore control the
      connections. Otherwise the reducef happens "inside" of the executef at
      which point the connection is closed.
      
      Care is taken to ensure that:
      - the init is only called once (subsequent queries have the init of the
      rf overridden to just return `init` (the acc passed in) rather than
      `(rf)`
      - the completion arity is only called once (use of `(completing rf)` and
      the reducing function in the subsequent queries is just `([acc] acc)`
      and does not call `(rf acc)`. Remember this is just on the lower
      reducing function and all of the takes, formats, etc _above_ it will
      have the completion arity called because we are using transduce. The
      completion arity is what takes the volatile rows and row counts and
      actually nests them in the `{:data {:rows []}` structure. Without
      calling that once (and ONLY once) you end up with no actual
      results. they are just in memory.
      Unverified
      a15fc4ea
    • Benoit Vinay's avatar
      Alert to typescript (#22832) · e8ba7d53
      Benoit Vinay authored
      * Types added to Alert
      
      * Alert package created
      
      * utils added to Alert
      
      * Clean up Question
      
      * alertType back in
      
      * Query import added back in
      
      * Types imports updated
      
      * Fix Dashboard types
      Unverified
      e8ba7d53
    • Anton Kulyk's avatar
      Refactor `TableSimple` visualization (#22982) · a2e90b15
      Anton Kulyk authored
      * Refactor TableSimple
      
      * Fix sorting
      
      * Move TableSimple to own directory
      
      * Move TableCell to own file
      
      * Migrate TableSimple to styled components
      
      * Migrate TableCell to styled components
      
      * Extract TableFooter component
      
      * Fix table cell selectors in cypress
      
      * Fix E2E tests
      Unverified
      a2e90b15
    • Natalie's avatar
      docs - update saml & sso (#22954) · eb5ea93e
      Natalie authored
      Unverified
      eb5ea93e
    • Nemanja Glumac's avatar
    • Alexander Polyankin's avatar
      Unverified
      4d119be7
  2. May 30, 2022
  3. May 28, 2022
  4. May 27, 2022
  5. May 26, 2022
  6. May 25, 2022
Loading