This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 18, 2024
-
-
Aleksandr Lesnenko authored
* remove LegendVertical logic that preserves legend width * memoize pie legend items * prevent pie from jumping when toggle legend * fix responsive legend logic, cleanup * drop hyphens from the pie legend (#29597) * eliminate flickering on render due to not having dimensions * shortcut * specs * test vertical layout has no hyphens * setup func * set explicit showLegend=true default
-
Oleksandr Yakushev authored
* [xlsx-export] Cache the custom datetime formatter * [xlsx-export] Optimize functions in m.q_p.pivot.postprocess * cljfmt --------- Co-authored-by:
Adam James <adam.vermeer2@gmail.com>
-
Cam Saul authored
-
Ryan Laurie authored
-
Jeff Bruemmer authored
-
Nick Fitzpatrick authored
-
Nicolò Pretto authored
* Revert "fix(sdk): put a bandage on the flashing error on static question in strict mode (#49659)" This reverts commit c57b3a38. * refactor(sdk): use ignore flag instead of mounted ref
-
Chris Truter authored
-
Kamil Mielnik authored
* Fix flaky test * Add extra assertion * Reset hover state * Change order of assertions
-
lbrdnk authored
* Add temporal unit to display name * Remove temporal unit adjustments from FE * formatColumn to displayNameForColumn * Factor out getFriendlyName * Adjust BE tests * Add require * Adjust FE unit tests * Adjust temporal-unit-parameters.cy.spec.js * Adjust dashboard-reproductions.cy.spec * Convert formatColumn occurrence * Adjust legacy display name logic generation After `getFriendlyName` was removed from FE, capitalization of display name should happen here. Logic is similar, should be adjusted prior merging the PR. * Adjust embedding-linked-filters.cy.spec.js * Adjust joins-reproductions.cy.spec.js * Adjust metrics-editing.cy.spec.js * Adjust timelines-question.cy.spec.js * Adjust offset.cy.spec.ts * TMP Avoid duplication of temporal unit in display name in MLv2 code * Probably FE fix: add default temporal bucket only if not present * WIP Add ends-with-temporal-unit? function Current strategy is to add temporal units to display names if same is not already present * Adjust display-name-method :metadata/column Append TU to display name only if different to what's already present * Adjust FE: show temporal unit that's present on field instead of default on hover on QueryColumnPicker element * Return also temporal-unit from visible-columns * Enable tempora-unit to be returned from previous-stage-or-source-visible-columns * WIP Adjust multi breakout multi stage e2e multiple-column-breakouts.cy.spec * Adjust multiple-column-breakouts.cy.spec.ts * It was not a bug. * Revert changes in _BaseBucketPickerPopover * Restore temporal-unit for next stages removal in stage.cljc * Add inherent-temporal-unit * Adjust display name temporal bucket logic * Rename to inherited-temporal-unit * Shutdown too broad display name capitalization * Eastwood * Adjust pivot-rows-order-test * Adjust pivot-non-numeric-values-in-aggregations * Adjust inherent to inherited * Rename to inherited * Add inherent-temporal-unit only to returned-columns * Update e2e/test/scenarios/dashboard-filters/temporal-unit-parameters.cy.spec.js * Update e2e/test/scenarios/question/multiple-column-breakouts.cy.spec.ts * Update consistent-date-formatting-test * Update dashboard/x-rays.cy.spec.js * Update waterfall.cy.spec.js * Return month default for default inherited-temporal-unit * Update reproductions-3.cy.spec.js * Update downloads/downloads.cy.spec.js * Update legend.cy.spec.js * Update pie_chart.cy.spec.js * Update click-behavior.cy.spec.js * Update embedding-linked-filters.cy.spec.js * Return QueryColumnPicker's condition to original state * Remove reundant export * Update e2e/test/scenarios/question/multiple-column-breakouts.cy.spec.ts * Comment * Update nested.cy.spec.js * Update e2e/test/scenarios/sharing/sharing-reproductions.cy.spec.js * Adjust to TS types * Adjust for cljfmt * Capitalize * Add propagation tests * Add inherited-temporal-unit propagation for expressions * Add default inherited-temporal-unit test cases * Add qp temporal-bucket-test ns * Simplify default unit logic * Comment * Use NULL_DISPLAY_VALUE * Comment * Comment * Comment * Comment * Comment * Comment * Remove redundant code (for now) * Update comments * Comment * Restore way too daring simplification * cljfmt * Adjust capitalize * Update comment * Update test * Address remarks in tests * Update test * Address remarks * typo
-
Uladzimir Havenchyk authored
* fix: pass noop as navigateToNewCardFromDashboard from public or embedded dashboard * add e2e test * rework a fix
-
Romeo Van Snick authored
* Use Flex instead of Group for items in button * Allow column picker to stretch to match the height of the element * Fix height of data picker buttons * Make sure the whole button is clickable * Add e2e test for metabase/metabase#50038 * Use correct id for issue in e2e test Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Chris Truter authored
-
Kamil Mielnik authored
-
Nicolò Pretto authored
* attempt to fix 49537 by removing position relative from the tooltip container * Make echart tooltip container cover all iframe area * Update the E2E test * Update loki snapshots from CI * Re-enable echarts tooltip assertion. I couldn't find a better way to fail these assertions on the previous version of the code, but these assertions are better than nothing. --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
- Nov 16, 2024
-
-
Oleksandr Yakushev authored
-
- Nov 15, 2024
-
-
Case Nelson authored
* fix: Sync postgres materialized view fields Fixes: #49912 * Disable test for redshift * Fix formatting
-
adam-james authored
* XLSX Pivot Export - Initialize Pivot Table with Small Area Ref This PR changes the native pivot export so that we first initialize the pivot table with an area ref that's only the first 2 rows. Prior, I used `AreaReference/GetWholecolumn` which had the side effect of using lots of memory. I think this is related to how the Pivot Table's Cache is built up as you add rows/cols to the pivot definition. So, if you keep the area ref only as wide as the number of columns in the raw data, and just 2 rows, then the cache can stay small. After adding row/column data to the pivot table, you can then modify the area ref to be all rows in the relevant columns (`A:E` for example). This keeps the pivot-table object much smaller in size. * need the extra xml schemas to get this to work I'd like to try find a way around including this extra dep, it's a 13mb jar (ish), and I think that's a little bigger than I'd like * oops, didnt mean to have this in * Add test for pivot table initialization being fast and lean on memory * remove time based assertion, add comments in impl * cljfmt * fix test * Pesky little whitespace --------- Co-authored-by:
Oleksandr Yakushev <alex@bytopia.org>
-
Noah Moss authored
-
Noah Moss authored
Make sure the query to fetch result_metadata for native sandboxes doesn't use the streaming results handler (#50049)
-
adam-james authored
* XLSX Pivot Exports Now Use The Sort Settings from Viz Settings Prior to this PR, the xlsx pivot exports worked correctly except for the fact that no sorting (ascending or descending) was applied to the pivot rows or columns. Now, those settings are used when they exist. * only try to set sort when a correct setting exists * add ooxml-full dep for correct classes * Update src/metabase/query_processor/streaming/xlsx.clj Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> --------- Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
Noah Moss authored
-
Case Nelson authored
Fixes: #50072 When we `describe-fields` we are passing db details, but sometimes we have the database name in `dbname` rather than in `db` depending on the connection specs and possibly environment. So we check for both now.
-
Dennis Schridde authored
== Goal == Hide attached DWH database details from anyone incl. admins: * Do not show them in the UI * Do not permit to change them * Do not serialize them - This is what we're adding for H2 snapshots (dumps) with this PR. The aim is that customers cannot gain access to (parts of) credentials, and they cannot break a feature they are paying for by changing connection details. == Implementation == In 592360c9 I wrongly understood that database details would be omitted when dumping to H2, but this is only true for dumping H2 databases. Fix this by omitting database details also when dumping databases with `is_attached_dwh` set. == How to test == To prepare, download a H2 JAR matching the H2 version used by Metabase: ``` wget https://repo1.maven.org/maven2/com/h2database/h2/2.1.214/h2-2.1.214.jar ``` If the H2 version does not match, you will get an error when trying to open the H2 shell: ``` Exception in thread "main" org.h2.jdbc.JdbcSQLNonTransientConnectionException: Unsupported database file version or invalid file header in file "[REDACTED]" [90048-232] ``` === New behaviour === Setting the `is_attached_dwh` field hides the database details from H2 dumps: 1. Configure a database as described in https://www.metabase.com/docs/latest/configuring-metabase/config-file#databases. - In addition to the fields you would normally set, also set `is_attached_dwh: true`. - This also works when adding this flag to a database that previously did not have this flag set. 2. Start your Metabase instance. 3. Run `${metabase} dump-to-h2 ./dump-file-h2` to create the H2 snapshot file. 4. Run `java -cp h2-2.1.214.jar org.h2.tools.Shell -url "jdbc:h2:file:./dump-file-h2;ifexists=true"` to open a H2 shell. 5. Verify that `SELECT name,details FROM metabase_database;` shows `{}` for the database you added in step 1 === Original behaviour === Behaviour without setting the `is_attached_dwh` field is unchanged: 1. Configure a database as described in https://www.metabase.com/docs/latest/configuring-metabase/config-file#databases. - Only set the fields you would normally set. Do not set `is_attached_dwh` (or set it to `false`). 2. Start your Metabase instance. 3. Run `${metabase} dump-to-h2 ./dump-file-h2` to create the H2 snapshot file. 4. Run `java -cp h2-2.1.214.jar org.h2.tools.Shell -url "jdbc:h2:file:./dump-file-h2;ifexists=true"` to open a H2 shell. 5. Verify that `SELECT name,details FROM metabase_database;` shows a non-empty object (i.e. not `{}`) for the database you added in step 1 Fixes: 592360c9 Closes: https://github.com/metabase/harbormaster/issues/5526
-
Nicolò Pretto authored
* fix(sdk): remove `Cannot update a component XX while rendering a different component` error * test(sdk): introduce jest test to make sure api.basename is set before loading the locale
-
Uladzimir Havenchyk authored
-
Chris Truter authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Update doc on Next JS examples * Make comments consistent and remove typos * Address review Co-Authored-by:
Poom <poom@poom.dev> * Address review Co-authored-by:
Nicolò Pretto <info@npretto.com> --------- Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
Nicolò Pretto authored
-
Chris Truter authored
-
- Nov 14, 2024
-
-
Aleksandr Lesnenko authored
* fix hiding incorrect y-axis on hover * Update Loki Snapshots --------- Co-authored-by:
Metabase Automation <github-automation@metabase.com>
-
Jeff Bruemmer authored
-
Abed Habli authored
-
Cam Saul authored
-
Oisin Coveney authored
-
Noah Moss authored
-
dpsutton authored
* sync the attached datawarehouse requires either "sync_db" true or a table name it will error ```shell ❯ http post 'localhost:3000/api/notify/db/attached_datawarehouse' x-metabase-apikey:apikey -pb Must provide `sync_db` or a `table_name` to sync ``` It will sync the db when sync_db is true [NOTE: this is outdated. now just omitting the table name will sync the db] ```shell ❯ echo '{"synchronous?": true, "sync_db": true}' | http post 'localhost:3000/api/notify/db/attached_datawarehouse' x-metabase-apikey:apikey -pb { "success": true } ``` It will sync existing tables ```shell ❯ http post 'localhost:3000/api/notify/db/attached_datawarehouse' table_name=existing schema_name=public x-metabase-apikey:apikey -pb { "success": true } ``` it will error if it cannot find a table ```shell ❯ http post 'localhost:3000/api/notify/db/attached_datawarehouse' table_name=new schema_name=public x-metabase-apikey:apikey -pb { "cause": "Unable to identify table 'public.new'", "data": { "schema_name": "public", "status-code": 404, "table_name": "new" }, "message": "Unable to identify table 'public.new'", "schema_name": "public", "table_name": "new", "trace": [], "via": [ { "data": { "schema_name": "public", "status-code": 404, "table_name": "new" }, "message": "Unable to identify table 'public.new'", "type": "clojure.lang.ExceptionInfo" } ] } ``` if i create that table ```sql attached=# create table new (id int); CREATE TABLE ``` it will then find and sync it ```shell ❯ http post 'localhost:3000/api/notify/db/attached_datawarehouse' table_name=new schema_name=public x-metabase-apikey:apikey -pb { "success": true } ``` * formatting * Tests for attached datawarehouse * PR nits typo in `thorw` -> `throw` comment explaining why `find-and-sync-new-table` is always sync gensym the db name in test remove a binding for a fn `sync!` that's only called once test `{:sync_db true}` syncs the whole db * stupid formatting
* Use absence of table_name as indicator to sync database -
Mahatthana (Kelvin) Nomsawadi authored
* Fix smartscalar texts to use user locale * Fix Pie chart texts to use user locale * Fix line chart tooltip texts to use user locale * Add trend chart assertions * Add pie chart assertions * Add line chart other series tooltip assertions * Update frontend/src/metabase/visualizations/echarts/pie/constants.ts Co-authored-by:
Nicolò Pretto <info@npretto.com> * Fix failed E2E tests --------- Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
Nicolò Pretto authored
-
Chris Truter authored
-