Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Feb 12, 2024
  2. Feb 11, 2024
  3. Feb 10, 2024
  4. Feb 09, 2024
  5. Feb 08, 2024
    • Braden Shepherdson's avatar
      [MLv2] Use the provided `column-ref` for drills (#38047) · f47b0ae1
      Braden Shepherdson authored
      There are cases where the ref as provided is not the same as what a
      fresh `(lib.ref/ref column)` would give. This seems mostly to affect
      models, where the metadata leaks some of the underlying details like
      joins.
      
      Fixes #38034.
      Unverified
      f47b0ae1
    • Kyle Doherty's avatar
    • Kyle Doherty's avatar
      Update default sizes for new dash width (#38450) · d7c4fdd3
      Kyle Doherty authored
      
      * Migration adding 'width' to Dashboards
      
      3 migrations:
       - 1st adding the width column with default value of 'fixed'
       - 2nd updating all existing dashboards to have width 'full', which corresponds to what the current behaviour is (will
       be the 'old' behaviour after the fixed-width project lands).
         - The rolloback here is necessary but we don't care what happens as the column will be dropped immediately in the
         next rollback anyway
       - 3rd sets the notNullableConstraint. DefaultNull is 'full' here, just in case there's an existing dashboard whose
       width value is not yet set from the 1st migration. Don't know how that could happen, but its here in case
      
      * Dashboard PUT api endpoint accepts width changes and updates appdb
      
      update-dashboard function now is aware of the :width key so those changes can end up in the transaction.
      
      Also added a width test that asserts that the value's default is "fixed", it can be changed, eg. to "full", but cannot
      be changed to other values.
      
      * Add width to revision tests
      
      * Fix dashboard revision tests.
      
      :width key is now needed in some revision tests. As well we need a string communicating that the :width setting has
      changed from 'full' to 'fixed' or vice-versa.
      
      * Fix comments/remarks in migration to be accurate
      
      * Attempt to fix default not working mysql/mariadb
      
      * Set default in dashboard model
      
      Signed-off-by: default avatarAdam James <adam.vermeer2@gmail.com>
      
      * Revert default :width 'fixed' value.
      
      * Explicitly add default value 'fixed' for MySQL/MariaDB
      
      * dashboard fixed width FE implementation
      
      * adjust popover shadow styling as the popover was blending in with the header
      
      * adjust extra button popover offset
      
      * add E2E to validate behavior
      
      * add fixed width container to public dashboards
      
      * fix public embedding not respecting dashboard width setting
      
      * add test for public dashboards
      
      * Fix embed test failures
      
      * add fixed width to x-ray dashboards
      
      * reduce code duplication
      
      * move FixedWidthContainer into DashboardGridConnected
      
      - We get the fixed-width w/o code duplication across AutomaticDashboardApp, PublicDashboard, and Dashboard
      
      * update E2E tests to reflect actual intended behavior
      
      * fix type errors
      
      * tweak default width of cards to accomodate fixed width
      
      * adjust tooltip button after merging changes from master
      
      * fix bar chart test failure
      
      * fix dashboard filters date test failure
      
      - new ellipsis button in dashboard edit mode broke the test
      
      * adjust test for new fixed width dashboards
      
      * adjust test for new fixed width dashboards
      
      * adjust test for new fixed width dashboards
      
      * bump funnel default width
      
      * adjust test for new fixed width dashboards
      
      * Fix double overlay for LineAreaBarChart dash-cards
      
      - No longer has an overlay that persists from editing mode to  viewing mode
      - Adjust click-behavior tests to account for new grid-width. Old test relied on a dashcard being taller than they will now default to being. i.e. Move the chosen point/row to down an index.
      
      * Merge FixedWidthContainer with dashboard grid div
      
      * supress brush events while editing timeseries line charts on dashboard
      
      * fix failing test
      
      - test failed because I did not update this assertion based on previous changes
      
      * fix broken link input in editing mode
      
      * fix pointer events issue on text cards in edit mode
      
      * update tests for new dash-card default sizes
      
      * update tabs card moving test because of new default card sizes
      
      ---------
      
      Signed-off-by: default avatarAdam James <adam.vermeer2@gmail.com>
      Co-authored-by: default avatarAdam James <adam.vermeer2@gmail.com>
      Co-authored-by: default avataradam-james <21064735+adam-james-v@users.noreply.github.com>
      Co-authored-by: default avatarJesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@gmail.com>
      Unverified
      d7c4fdd3
    • Anton Kulyk's avatar
      Fix card query endpoint usage on dashboards (#38547) · 83aeb32c
      Anton Kulyk authored
      * Don't reload dashcards in edit mode
      
      * Update and unskip repro
      
      * Extend "duplicate tab" e2e test
      
      * Fix implicit request body schema when fetching dashcard data
      
      * Disable dashcard data refetching in edit mode
      
      * Revert `Dashboard` useEffect changes
      
      * Fix tests
      Unverified
      83aeb32c
    • Raphael Krut-Landau's avatar
    • Nicolò Pretto's avatar
      Meet embedders - minimal version (#38520) · d88d32e5
      Nicolò Pretto authored
      
      * refactor: prepare SettingsPage to have conditionally rendered steps (#38201)
      
      * refactor: prepare SettingsPage to have conditionally rendered steps
      
      * fix tests missing props
      
      * Usage reason question (#38267)
      
      * Invactive -> Inactive
      
      * add question
      
      * fix e2e test
      
      * small refactor
      
      * Update frontend/src/metabase/setup/components/UsageQuestionStep/UsageQuestionStep.tsx
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      
      ---------
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      
      * Hide "Add your data" step for people interested in embedding (#38390)
      
      * hide 'Add your data' step when user is interested in embedding
      
      * add other test cases
      
      * refactor: create selector
      
      * address pr feedback
      
      * adds minimal embed focused homepage (#38402)
      
      * very minimal homepage
      
      * fixed text color
      
      * minimal e2e + actual logic that i forgot lol
      
      * refactor the list to not have the numbers in the content
      
      * rename util functions
      
      * use button to have cursor when hovering + accessibility
      
      * refactor: move the waitFor inside the submit step
      
      * fix: make sure state is clean on multiple installs in a row
      
      * test: check that the homepage persists reload + removed typos
      
      * rename s to state
      
      * moved util functions up to home/utils.ts
      
      * adds key to avoid react warning
      
      * refactor and tests for [meet embedders] (#38465)
      
      * test: check all numbered steps during the setup flow
      
      * refactor: introduce getSteps and start using the step name instead of a number to identify steps
      
      * refactor: remove map of the steps, use step names directly
      
      * refactor: getNextStep
      
      * include 'hidden' steps in getSteps so that it won't mess up with analytics
      
      * fix after rebase issue
      
      * use full name instead of s, s -> step
      
      * analytics for meet-embedders (#38521)
      
      * refactor: extract schema version and onboarding version into constants
      
      * remove old ga events
      
      * trackUsageReasonSelected
      
      * update trackStepSeen to send the correct index
      
      * copy old schema for better diff
      
      * adds new snowplow event for usage_reason step
      
      * schema and e2e update for usage_reason_selected
      
      * adds utm tag to the link in the minimal embed homepage
      
      ---------
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      Unverified
      d88d32e5
    • Nemanja Glumac's avatar
    • bryan's avatar
      load analytics only when changed using a checksum (#38280) · 9e1e8e8e
      bryan authored
      * load analytics only when changed using a checksum
      
      - over audit deserialization files
      
      * update docstrings
      
      * fix testing wording
      Unverified
      9e1e8e8e
    • Uladzimir Havenchyk's avatar
      Avoid unnecessary re-renderings in because of getQuestions selector (#38548) · 179a5d22
      Uladzimir Havenchyk authored
      * Avoid unnecessary re-renderings in DashboardSharingEmbeddingModal
      
      * Add deep equal selector
      
      * drop underscore
      Unverified
      179a5d22
Loading