Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Sep 01, 2021
  2. Aug 31, 2021
    • Cam Saul's avatar
      Test init code: read driver parents from driver deps.edn (#17612) · 65932665
      Cam Saul authored
      * Test init code: read driver parents from driver deps.edn
      
      * Rename :metabase.build-driver/parents -> :metabase.driver/parents
      Unverified
      65932665
    • Nemanja Glumac's avatar
      #17658 Repro: Not possible to delete dashboard subscription unless dashboard... · 404e6f88
      Nemanja Glumac authored
      #17658 Repro: Not possible to delete dashboard subscription unless dashboard is in root collection (#17699)
      
      Unverified
      404e6f88
    • Cam Saul's avatar
      Fix setting Block permissions in the permissions/graph API endpoints (#17651) · e6358cc9
      Cam Saul authored
      * Fix setting Block permissions in the permissions/graph API endpoints
      
      * Revert changes to .dir-locals
      
      * Perms graph: don't validate DB :schemas + :native unless both are present.
      
      * PR feedback
      Unverified
      e6358cc9
    • Noah Moss's avatar
    • dpsutton's avatar
      Svg test improvements (#17652) · 538c94a9
      dpsutton authored
      * Ensure that data_readers functions are included in tests
      
      `clj -X:dev:test :only metabase.pulse.render.js-svg-test` uses the
      `#t` data reader, which passes the value to
      `metabase.util.date-2/parse` but this function hasn't been evaluated
      yet and it errors
      
      ```shell
      % clj -X:dev:test :only metabase.pulse.render.js-svg-test
      Warning: environ value /Users/dan/.sdkman/candidates/java/current for key :java-home has been overwritten with /Users/dan/.sdkman/candidates/java/11.0.11.hs-adpt
      Running tests in metabase.pulse.render.js-svg-test
      Syntax error reading source at (metabase/pulse/render/js_svg_test.clj:71:27).
      Attempting to call unbound fn: #'metabase.util.date-2/parse
      ```
      
      * Throw an error if resource is not found when loading sources
      
      ```shell
      ERROR in metabase.pulse.render.js-svg-test/categorical-donut-test (js_engine.clj:37)
      Uncaught exception, not in assertion.
      
      clojure.lang.ExceptionInfo: Javascript resource not found: frontend_client/app/dist/lib-static-viz.bundle.js
          source: "frontend_client/app/dist/lib-static-viz.bundle.js"
         metabase.pulse.render.js-engine/load-resource    js_engine.clj:   37
          metabase.pulse.render.js-svg/load-viz-bundle       js_svg.clj:   94
       metabase.pulse.render.js-svg/static-viz-context       js_svg.clj:  100
                       metabase.pulse.render.js-svg/fn       js_svg.clj:  106
                                                   ...
                                    clojure.core/deref         core.clj: 2324
      metabase.pulse.render.js-svg/timelineseries-line       js_svg.clj:  167
               metabase.pulse.render.js-svg-test/fn/fn  js_svg_test.clj:   75
                  metabase.pulse.render.js-svg-test/fn  js_svg_test.clj:   74
                              clojure.test/test-var/fn         test.clj:  717
                                 clojure.test/test-var         test.clj:  717
                         metabase.test-runner/run-test  test_runner.clj:  107
      
      ...
      ```
      
      ```shell
      ERROR in metabase.pulse.render.js-svg-test/categorical-donut-test (Objects.java:221)
      Uncaught exception, not in assertion.
      
      java.lang.NullPointerException:
                      java.util.Objects.requireNonNull     Objects.java:  221
            org.graalvm.polyglot.Source$Builder.<init>      Source.java:  725
                org.graalvm.polyglot.Source.newBuilder      Source.java:  546
         metabase.pulse.render.js-engine/load-resource    js_engine.clj:   34
          metabase.pulse.render.js-svg/load-viz-bundle       js_svg.clj:   94
       metabase.pulse.render.js-svg/static-viz-context       js_svg.clj:  100
                       metabase.pulse.render.js-svg/fn       js_svg.clj:  106
      ```
      
      * Sort effects namespace
      Unverified
      538c94a9
    • Noah Moss's avatar
    • Ariya Hidayat's avatar
      Remove some superfluous return types in the queries library (#17681) · 01659807
      Ariya Hidayat authored
      All of these can be correctly inferred already, thus there is no need to
      the explicit type annotations.
      Unverified
      01659807
    • Nemanja Glumac's avatar
      Add "on" string to translation (#17696) · 8e4dc296
      Nemanja Glumac authored
      Unverified
      8e4dc296
    • dpsutton's avatar
      Turn dataset_query into structured data in search results (#17690) · fd6414e8
      dpsutton authored
      
      * Turn dataset_query into structured data in search results
      
      * sort scoring test ns
      
      * Fixup tests
      
      we are no longer returning string results. The cards in the test have
      empty queries, which the model turns into {} but normalization removes
      empty clauses and returns nil. The tests would be too annoying to hook
      this up to work properly and this functionality is tested in other
      places.
      
      * Unskip repro for #15959
      
      * Update repro test
      
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      Unverified
      fd6414e8
    • dpsutton's avatar
      Add i18n to js engine (INTL) (#17688) · ab75c941
      dpsutton authored
      Unverified
      ab75c941
    • Anton Kulyk's avatar
      Allow joins on multiple fields in the notebook editor (#17633) · 7eb47a92
      Anton Kulyk authored
      * Separate Join unit tests with newlines
      
      * Refactor Join's unit tests
      
      * Add join type getters (by conditions count)
      
      * Add getter and setter for join conditions by index
      
      * Remove old comment
      
      * Extract method converting dimensions
      
      * Update setParentDimension
      
      * Update setJoinDimension
      
      * Update joinDimensions method
      
      * Update joinDimensions method
      
      * Update join alias setter
      
      * Update default condition setter
      
      * Update isValid method
      
      * Add getConditions method
      
      * Add addEmptyDimensionsPair method
      
      * Render multiple join conditions
      
      * Fix JoinStep align-items
      
      * Fix join dimension methods usage
      
      * Fix join dimensions alignment
      
      * Temporary disable auto opening pickers
      
      * Test adding a new dimensions pair
      
      * Fix "add" join icon visibility
      
      * Add "on" label between join conditions
      
      * Remove redundant `else`
      
      * Add `removeCondition` method for `Join`
      
      * Fix JoinDimensionPicker's prop types
      
      * Allow removing empty dimension pairs
      
      * Add space between join dimensions
      
      * Simplify JoinStep tests setup
      
      * Automatically open dimension pickers
      
      * Test JoinStep updates `Join` instance correctly
      
      * Display dimensions source name
      
      * Allow overwriting NotebookCell's padding
      
      * Fix JoinStep layout
      
      * Allow to clear a selected dimension
      
      * Disable "no-unused-vars" for Join file
      
      * Fix parentDimension usage
      
      * Fix StructuredQuery's `Join` usage
      
      * Update notebook visual test
      
      * Fix E2E test
      
      * Fix JoinStep look when no dimensions selected
      
      * Extract JoinDimensionsRightControl component
      
      * Extract JoinDimensionCellItem component
      
      * Increase JoinStep's tests timeout
      
      * Extract `_getExplicitJoinsSet` from StucturedQuery
      
      * Fix unused variables in Join class
      
      * Add a comment about setTimeout
      
      * Fix join condition label
      
      * Fix dimensions picker opens when dimension is set
      
      * Make table icon container clickable
      
      * Hide fields picker tooltip on picker open
      
      * Fix Preview button overflowing JoinStep
      
      * Fix table picker click area
      Unverified
      7eb47a92
    • Noah Moss's avatar
      unskip repro (#17674) · 0c48f947
      Noah Moss authored
      Unverified
      0c48f947
    • Nemanja Glumac's avatar
      Fix #17657: No recipients causes error resulting in blank screen (#17668) · e55cbe36
      Nemanja Glumac authored
      * Invalidate the pulse if it contains no recipients
      
      Switch statement was returning `true`, resulting in falsely "valid" pulse
      in the case there were no recipients but the schedule was set to month.
      
      This commit fixes that.
      
      * Move all conditions before the switch statement
      
      * Enable repro for #17657
      
      * Guard against the error that causes the white screen
      
      * Add another repro for #17657
      
      * Fix typo in the test name
      
      * Fix typo in the unrelated comment
      Unverified
      e55cbe36
    • Gustavo Saiani's avatar
    • Alexander Polyankin's avatar
    • Ariya Hidayat's avatar
      CI with GitHub Actions: bump the timeout for front-end unit tests (#17682) · b0a9dbee
      Ariya Hidayat authored
      With the code being instrumented for code coverage, and another
      additional time to analyze + send the code coverage to codecov.io,
      the typical execution runs awfully close to the 10-min limit.
      Hence, add some extra room.
      Unverified
      b0a9dbee
  3. Aug 30, 2021
  4. Aug 28, 2021
Loading