This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Sep 01, 2021
-
-
Cam Saul authored
Make sure built drivers do not contain clojure core classes. Handle either string or keyword args to build scripts (#17608) * No Clojure core classes please * Don't try to make paths absolute twice. Build scripts should handle keyword args like ':driver' * parse-as-keyword should return keywords as is * Test fix
* Test fix * Test fix part 2 -
Dalton authored
* use preventScroll in focus call in ListSearchField * add a few ListSearchField unit tests
-
Dalton authored
* only apply DataSelectorContainer hack in QuestionDataSelector * unskip repro
-
Anton Kulyk authored
-
Noah Moss authored
-
Anton Kulyk authored
* Install jest-watch-typeahead
-
Gustavo Saiani authored
-
Gustavo Saiani authored
-
dpsutton authored
* Collapse small donut slices into a single "Other" category * Locale aware decimal formatting A followup PR will add all of the formatting options for scalars and smart scalars so this function is largely temporary and will be subsumed into a namespace that knows about all formatting options. * empty with no cache [ci nocache]
-
Nemanja Glumac authored
Since the Webpack and Babel upgrades, this shouldn't be needed any more. In the past, we had to explicitly resolve to the specific version of Cypress. Now it resolves to this version by default.
-
Nemanja Glumac authored
* Remove white background from `Select` component's container * Remove superfluous `text-bold` class from the `Select` component
-
Luis Paolini authored
The node_modules folder was being persisted in the first step (checkout) as it's doing the building of the static viz package. This had an impact in the fe-deps step, so wiping the folder and doing a clean install should make the trick
-
pawit-metabase authored
* update sqlite-jdbc to 3.36.0.1 The new version includes arm64 binaries and allows Cypress, which uses SQLite, to run on Apple Silicon. * Improve date/time handling in SQLite
-
Cam Saul authored
-
- Aug 31, 2021
-
-
Cam Saul authored
* Test init code: read driver parents from driver deps.edn * Rename :metabase.build-driver/parents -> :metabase.driver/parents
-
Nemanja Glumac authored
#17658 Repro: Not possible to delete dashboard subscription unless dashboard is in root collection (#17699)
-
Cam Saul authored
* Fix setting Block permissions in the permissions/graph API endpoints * Revert changes to .dir-locals * Perms graph: don't validate DB :schemas + :native unless both are present. * PR feedback
-
Noah Moss authored
-
dpsutton authored
* Ensure that data_readers functions are included in tests `clj -X:dev:test :only metabase.pulse.render.js-svg-test` uses the `#t` data reader, which passes the value to `metabase.util.date-2/parse` but this function hasn't been evaluated yet and it errors ```shell % clj -X:dev:test :only metabase.pulse.render.js-svg-test Warning: environ value /Users/dan/.sdkman/candidates/java/current for key :java-home has been overwritten with /Users/dan/.sdkman/candidates/java/11.0.11.hs-adpt Running tests in metabase.pulse.render.js-svg-test Syntax error reading source at (metabase/pulse/render/js_svg_test.clj:71:27). Attempting to call unbound fn: #'metabase.util.date-2/parse ``` * Throw an error if resource is not found when loading sources ```shell ERROR in metabase.pulse.render.js-svg-test/categorical-donut-test (js_engine.clj:37) Uncaught exception, not in assertion. clojure.lang.ExceptionInfo: Javascript resource not found: frontend_client/app/dist/lib-static-viz.bundle.js source: "frontend_client/app/dist/lib-static-viz.bundle.js" metabase.pulse.render.js-engine/load-resource js_engine.clj: 37 metabase.pulse.render.js-svg/load-viz-bundle js_svg.clj: 94 metabase.pulse.render.js-svg/static-viz-context js_svg.clj: 100 metabase.pulse.render.js-svg/fn js_svg.clj: 106 ... clojure.core/deref core.clj: 2324 metabase.pulse.render.js-svg/timelineseries-line js_svg.clj: 167 metabase.pulse.render.js-svg-test/fn/fn js_svg_test.clj: 75 metabase.pulse.render.js-svg-test/fn js_svg_test.clj: 74 clojure.test/test-var/fn test.clj: 717 clojure.test/test-var test.clj: 717 metabase.test-runner/run-test test_runner.clj: 107 ... ``` ```shell ERROR in metabase.pulse.render.js-svg-test/categorical-donut-test (Objects.java:221) Uncaught exception, not in assertion. java.lang.NullPointerException: java.util.Objects.requireNonNull Objects.java: 221 org.graalvm.polyglot.Source$Builder.<init> Source.java: 725 org.graalvm.polyglot.Source.newBuilder Source.java: 546 metabase.pulse.render.js-engine/load-resource js_engine.clj: 34 metabase.pulse.render.js-svg/load-viz-bundle js_svg.clj: 94 metabase.pulse.render.js-svg/static-viz-context js_svg.clj: 100 metabase.pulse.render.js-svg/fn js_svg.clj: 106 ``` * Sort effects namespace
-
Noah Moss authored
-
Ariya Hidayat authored
All of these can be correctly inferred already, thus there is no need to the explicit type annotations.
-
Nemanja Glumac authored
-
dpsutton authored
* Turn dataset_query into structured data in search results * sort scoring test ns * Fixup tests we are no longer returning string results. The cards in the test have empty queries, which the model turns into {} but normalization removes empty clauses and returns nil. The tests would be too annoying to hook this up to work properly and this functionality is tested in other places. * Unskip repro for #15959 * Update repro test Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
dpsutton authored
-
Anton Kulyk authored
* Separate Join unit tests with newlines * Refactor Join's unit tests * Add join type getters (by conditions count) * Add getter and setter for join conditions by index * Remove old comment * Extract method converting dimensions * Update setParentDimension * Update setJoinDimension * Update joinDimensions method * Update joinDimensions method * Update join alias setter * Update default condition setter * Update isValid method * Add getConditions method * Add addEmptyDimensionsPair method * Render multiple join conditions * Fix JoinStep align-items * Fix join dimension methods usage * Fix join dimensions alignment * Temporary disable auto opening pickers * Test adding a new dimensions pair * Fix "add" join icon visibility * Add "on" label between join conditions * Remove redundant `else` * Add `removeCondition` method for `Join` * Fix JoinDimensionPicker's prop types * Allow removing empty dimension pairs * Add space between join dimensions * Simplify JoinStep tests setup * Automatically open dimension pickers * Test JoinStep updates `Join` instance correctly * Display dimensions source name * Allow overwriting NotebookCell's padding * Fix JoinStep layout * Allow to clear a selected dimension * Disable "no-unused-vars" for Join file * Fix parentDimension usage * Fix StructuredQuery's `Join` usage * Update notebook visual test * Fix E2E test * Fix JoinStep look when no dimensions selected * Extract JoinDimensionsRightControl component * Extract JoinDimensionCellItem component * Increase JoinStep's tests timeout * Extract `_getExplicitJoinsSet` from StucturedQuery * Fix unused variables in Join class * Add a comment about setTimeout * Fix join condition label * Fix dimensions picker opens when dimension is set * Make table icon container clickable * Hide fields picker tooltip on picker open * Fix Preview button overflowing JoinStep * Fix table picker click area
-
Noah Moss authored
-
Nemanja Glumac authored
* Invalidate the pulse if it contains no recipients Switch statement was returning `true`, resulting in falsely "valid" pulse in the case there were no recipients but the schedule was set to month. This commit fixes that. * Move all conditions before the switch statement * Enable repro for #17657 * Guard against the error that causes the white screen * Add another repro for #17657 * Fix typo in the test name * Fix typo in the unrelated comment
-
Gustavo Saiani authored
-
Alexander Polyankin authored
-
Ariya Hidayat authored
With the code being instrumented for code coverage, and another additional time to analyze + send the code coverage to codecov.io, the typical execution runs awfully close to the 10-min limit. Hence, add some extra room.
-
- Aug 30, 2021
-
-
Gustavo Saiani authored
-
Nemanja Glumac authored
-
Kyle Doherty authored
-
Jeff Evans authored
* Randomize BigQuery test view names Use tu/random-name instead of a name based on the output of gensym * Add extra prefix for legacy BigQuery driver created databases * Update legacy BigQuery driver to have unique name for transient datasets For those datasets created and destroyed by the legacy BigQuery driver QP tests, add an additional prefix so that it doesn't conflict with the new BigQuery driver tests
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Nemanja Glumac authored
* Rename file to make it more specific * Extract dashboard sql filters into separate folder and CI group * Add short descriptions to dashboard filters repros * Extract dashboard sql filters helpers (data objects)
-
Ariya Hidayat authored
-
- Aug 28, 2021
-
-
Nemanja Glumac authored
-
Gustavo Saiani authored
-