Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Nov 26, 2020
  2. Nov 09, 2020
    • Nemanja Glumac's avatar
      Port Cypress fixes/updates from `master` into `release-x.37.x` (#13743) · 8be8f81f
      Nemanja Glumac authored
      
      * Quarantine flaky tests (#13682) (#13683)
      
      * Quarantine flaky tests (#13682)
      
      * Add TODO note re: `describeWithToken`
      
      Co-authored-by: Nemanja Glumac
      
      * Add a circleci workflow that runs a set of Cypress smoketests (#12775)
      
      * Add a circleci nightly workflow that runs a bigger set of Cypress smoketests
      
      * Run this every hour while we're testing it, add a small fix to the admin test
      
      * Smoketests: Skip some known failing tests
      
      Co-authored-by: default avatarAriya Hidayat <ariya@metabase.com>
      
      * Narrow down the quarantine for chart_drill spec (#13682) (#13699)
      
      * CI: Fix the cache key for uberjar for running smoketest (#13698)
      
      Smoketest for OSS edition (for now)
      
      * Fix `settings/settings.cy.spec.js` flakes (#13701)
      
      - isolated flake (`it.only("should surface an error when validation for any field fails (metabase#4506)", () => {...})`) passed 10x (https://github.com/nemanjaglumac/metabase-tests/actions/runs/348275781)
      - the whole spec passed 20x (https://github.com/nemanjaglumac/metabase-tests/actions/runs/348306177)
      
      * CI: Update uberjar oss key for smoketest (#13704)
      
      * Fix Cypress flakes in `dashboard/dashboard.cy.spec.js` file (#13703)
      
      * Fix flakes in `revisions screen` block
      
      * Improve test assertions (there were some rendering problems, so I adjusted the assertions)
      
      * Narrow down the quarantine for dash_drill spec (#13682) (#13706)
      
      * Fix `metrics.cy.spec.js` flakes (#13709)
      
      * Fix `metrics.cy.spec.js` flakes (#13682)
      
      * Refactor the test using API
      
      * Smoketest: run nightly at 1am PST (#13711)
      
      1 am PST = 09:00 UTC
      
      CircleCI cron is for UTC:
      https://circleci.com/docs/2.0/workflows/#scheduling-a-workflow
      
      * Upgrade Cypress to v5.5.0 (#13674)
      
      * Upgrade Cypress to v5.5.0
      
      * Needed to unset the `DISPLAY` ENV through `config.yml` to finally make this work! (Reference: https://github.com/cypress-io/cypress/issues/4034#issuecomment-486773042
      
      )
      
      * Improve `segments` tests with the use of API (#13718)
      
      * Unquarantine `scenarios/pulse/pulse.cy.spec.js` (#13727)
      
      * Unset `DISPLAY` ENV in smoketests CI group (#13732)
      
      * Unquarantine ee `custom_drill_through/drill_through.cy.spec.js` [ci skip] (#13734)
      
      * Unquarantine `question/nested.cy.spec.js` (#13733)
      
      Co-authored-by: default avatarAriya Hidayat <ariya@metabase.com>
      Co-authored-by: default avatarDamon P. Cortesi <d.lifehacker@gmail.com>
      Unverified
      8be8f81f
  3. Nov 04, 2020
  4. Oct 28, 2020
  5. Oct 23, 2020
  6. Oct 19, 2020
  7. Oct 15, 2020
    • Nemanja Glumac's avatar
      Convert e2e tests to Cypress (#13418) · b9ac0ef6
      Nemanja Glumac authored
      
      * Convert `drillthroughs.e2e` tests to Cypress (#13128) [ci skip]
      
      Convert e2e tests from drillthroughs.e2e.spec.js to Cypress tests:
      - frontend/test/metabase/scenarios/visualizations/drillthroughs/chart_drill.cy.spec.js
      - frontend/test/metabase/scenarios/visualizations/drillthroughs/dash_drill.cy.spec.js
      
      Note:Squashed all previous commits in a branch for cleaner output.
      Co-authored-by: @nemanjaglumac
      
      * Convert `Visualization.e2e` tests to Cypress (#13021) [ci skip]
      
      Convert e2e tests from Visualization.e2e.spec.js to Cypress tests:
          - frontend/test/metabase/scenarios/dashboard/text-box.cy.spec.js
      
      Original note by @Opalevanescence : "Some of these tests weren't in Cypress yet, so I added them in."
      
      Note: Squashed all previous commits in a branch for cleaner output.
      Co-authored-by: @nemanjaglumac
      
      * E2e to cy/port/dashboard (#13013) [ci skip]
      
      Convert e2e tests from dashboard.e2e.spec.js to Cypress tests:
      - frontend/test/metabase/scenarios/dashboard/dashboard.cy.spec.js
      
      Affected files:
      - frontend/test/metabase/scenarios/dashboard/parameters-embedded.cy.spec.js
      - frontend/test/metabase/scenarios/dashboard/parameters.cy.spec.js
      
      * Quarantined breaking Cypress tests (breaking changes introduced with the work on the dashboard UI)
      
      Note: Squashed all previous commits in a branch for cleaner output.
      Co-authored-by: @nemanjaglumac
      
      * Convert `alert.e2e` tests to Cypress (#12969) [ci skip]
      
      Convert e2e tests from alert.e2e.spec.js to Cypress tests:
      - frontend/test/metabase/scenarios/alert/alert.cy.spec.js
      - frontend/test/metabase/scenarios/alert/alert_auth.cy.spec.js
      
      * Quarantined breaking Cypress tests (cannot use email setup in CI)
      
      Note: Squashed all previous commits in a branch for cleaner output.
      Co-authored-by: @nemanjaglumac
      
      * Convert `initial_collection.e2e` tests to Cypress (#12968)
      
      Convert e2e tests from initial_collection.e2e.spec.js to Cypress tests:
      - frontend/test/metabase/scenarios/collection_defaults.cy.spec.js
      
      * Quarantined breaking Cypress tests (cannot use email setup in CI)
      
      Note: Squashed all previous commits in a branch for cleaner output.
      Co-authored-by: @nemanjaglumac
      
      * Delete `PivotByCategoryDrill` e2e test [ci skip]
      
      * Delete `metadata` e2e tests
      
      * Add `metadata` Cypress test [ci skip]
      
      - remapped column value (Product ID => Title)
      
      * Delete `SettingsAuthenticationOptions` e2e test [ci skip]
      
      NOTE: we already have similar CY test in `frontend/test/metabase/scenarios/admin/settings/settings.cy.spec.js`:
      - `it("should render the proper auth options", () => {...})`
      
      * Delete `segments` e2e test [ci skip]
      
      existing CY test file: `frontend/test/metabase/scenarios/admin/datamodel/segments.cy.spec.js`
      
      * Delete end-to-end related support and helper files
      
      * Remove e2e tests from CircleCI config [ci skip]
      
      * Delete references of e2e tests in documentation and replace them with Cypress [ci skip]
      
      * Fix and update dashboard related Cypress tests
      
      * Fix `parameters` cy test
      
      * Fix `metadata` failing test
      
      * Fix `parameters` failing test
      
      Note:
      - Asserting on "Rows 1-1 of 2000" was bad idea because card is different size in CI.
      - The number of visible rows directly depend on the card size
      
      Co-authored-by: default avatarJessica DeWitt <58329466+Opalevanescence@users.noreply.github.com>
      Unverified
      b9ac0ef6
  8. Oct 08, 2020
  9. Oct 07, 2020
  10. Oct 05, 2020
    • Nemanja Glumac's avatar
      Upgrade Cypress to v5.3.0 (#13343) · d9eb1b01
      Nemanja Glumac authored
      * Upgrade Cypress to v5.3.0
      * Add Cypress test retries to the config (2 for the "run" mode and 0 for the "open" mode)
      
      Notes:
      - upgrading `@testing-library/cypress` was not possible at this point. It would almost certainly require upgrading webpack, and maybe adjusting babel settings.
      - `yarn resolutions` will not be needed once we properly upgrade weback and all libraries that have "Cypress" as a dependency
      Unverified
      d9eb1b01
  11. Sep 08, 2020
  12. Jul 21, 2020
    • Robert Roland's avatar
      Adds a is-empty/not-empty for strings (#12947) · 33403173
      Robert Roland authored
      
      * Adds a is-empty/not-empty for strings
      
      What the UI calls "is empty" / "not empty" right now is a null check,
      not a null and "" string check.
      
      This adds is-empty / not-empty operators in the query processor, and
      reworks the UI to use those. Any existing query that previously used the
      is-null / not-null operators will show (as "Is null" / "Not null") but
      any newly made queries will not be able to select "Is null" / "Not null"
      for text type fields.
      
      This will allow backwards compatibility with existing questions, while
      promoting use of the new "is-empty"/"not-empty" operators.
      Added Cypress test to make sure the proper operators show up when asking
      questions
      
      Update memoize util to allow variable number of args
      
      Resolves #5299
      
      Co-authored-by: default avatarPaul Rosenzweig <paul.a.rosenzweig@gmail.com>
      Unverified
      33403173
  13. Jul 20, 2020
    • Robert Roland's avatar
      Update eslint (#12951) · d86b85ce
      Robert Roland authored
      
      * Update eslint
      
      Updates eslint, babel and plugins to the latest compatible versions
      
      Drops the 'no-color-literals' parameter which doesn't exist (looks like
      it's actually part of eslint-plugin-react-native which we don't use)
      
      adding a dirlocal to make sure js2-mode doesn't confuse you with type
      errors that aren't actually errors because of flowtype and such
      
      * update generated css classes in snapshots
      
      Co-authored-by: default avatarPaul Rosenzweig <paul.a.rosenzweig@gmail.com>
      Unverified
      d86b85ce
  14. Apr 10, 2020
  15. Mar 06, 2020
    • Tom Robinson's avatar
      Expressions: filter expressions, case statements, string extracts, and share aggregations (#11868) · 09001d6c
      Tom Robinson authored
      
      * Upgrade Chevrotain to v6.5.0
      
      * Switch from embedded actions to visitor
      
      * rename tokens to lexer, remove no-longer needed Chevrotain hack from webpack.config.js
      
      * get tests passing again
      
      * progress converting syntax parser
      
      * got intermediate Sum(A) test passing
      
      * more progress on parsing expressions
      
      * get complex expression passing
      
      * prettier
      
      * linting
      
      * Add TokenizedExpression snapshot test
      
      * Add support to parser for recovering whitespace tokens
      
      * Add case clause [ci all]
      
      * fix test [ci all]
      
      * Harden test [ci all]
      
      * More tests [ci all]
      
      * Correctly infer case return type [ci all]
      
      * Fix test [ci all]
      
      * Fix tests [ci all]
      
      * Improved syntax parser
      
      * More parser cleanup + start adding filters and functions
      
      * Add CASE and partial filter support, cleanup tests
      
      * Add string extracts [ci all]
      
      * Typo [ci all]
      
      * Make linter happy [ci all]
      
      * Add regex-match-first [ci all]
      
      * Fix arglist [ci all]
      
      * Fix test [ci all]
      
      * Add sum-where count-where and share support. Refactor aggregation tokens
      
      * Fix tests [ci all]
      
      * Add ns prefixes [ci all]
      
      * Add ns qualifiers [ci all]
      
      * Fix trim [ci all]
      
      * Tests: ensure stable ordering of results [ci all]
      
      * Fix trim [ci all]
      
      * Support only 1-arg trim [ci all]
      
      * Fix ns prefixes [ci all]
      
      * Fix psql [ci all]
      
      * Fix redshift [ci redshift]
      
      * Refactor/simplify grammer to consolidate aggregation, expression, and filter functions
      
      * Add isCase to isExpression
      
      * Directly splice regex pattern for psql & redshift [ci all]
      
      * Fix schema [ci all]
      
      * Redshift: splice replace args [ci redshift]
      
      * Add ns prefix [ci redshift]
      
      * Typo [ci redshift]
      
      * Filter expressions
      
      * Add metrics and segments back in to expressions
      
      * Disable tokenized editing
      
      * Update tests to clojure.test [ci all]
      
      * Add concat to sqlite [ci all]
      
      * Add length [ci all]
      
      * Add missing ns [ci all]
      
      * Fix test [ci all]
      
      * Fix messed up multimethods [ci all]
      
      * Fix mssql [ci all]
      
      * Fix sqlite concat [ci all]
      
      * sqlite: correctly qoute literal strings [ci all]
      
      * Misc improvements to syntax highlighting etc
      
      * Cleanup tests [ci all]
      
      * Reoder defs [ci all]
      
      * Make linter happy [ci all]
      
      * Mongo: add case [ci mongo]
      
      * mongo: fix switch [ci mongo]
      
      * typo [ci mongo]
      
      * Improve syntax highlighter and suggestions
      
      * Mongo: always have default fallback in case [ci mongo]
      
      * Rearrange test to split out ones using expressions [ci mongo]
      
      * Remove uneeded merge [ci all]
      
      * misc
      
      * Much improved syntax highlighting using recovery mode and partial CST
      
      * Improved suggestions
      
      * try monospace font for expressions
      
      * Better typing in parser, various other fixes
      
      * Avoid parsing multiple times
      
      * Fix tests
      
      * Fix tests
      
      * More test fixes
      
      * Special case for UnderlyingRecords drill with sum-where/count-where/share
      
      * switch back to square brackets for identifiers
      
      * change extract to regexextract
      
      * Lift expressions to subselect [ci all]
      
      * Commit on enter
      
      * rename extract to substitute, fix tests
      
      * Refactor [ci all]
      
      * Fix normalization [ci all]
      
      * Correctly handle joins [ci all]
      
      Co-authored-by: default avatarDaniel Higginbotham <daniel@flyingmachinestudios.com>
      Co-authored-by: default avatarSimon Belak <simon@metabase.com>
      Co-authored-by: default avatarMaz Ameli <maz@metabase.com>
      Unverified
      09001d6c
  16. Jan 28, 2020
  17. Jan 21, 2020
  18. Jan 17, 2020
  19. Jan 09, 2020
  20. Jan 08, 2020
  21. Dec 18, 2019
  22. Dec 12, 2019
  23. Dec 11, 2019
  24. Dec 09, 2019
  25. Dec 05, 2019
  26. Dec 02, 2019
  27. Nov 25, 2019
  28. Nov 07, 2019
  29. Oct 30, 2019
  30. Oct 28, 2019
    • Paul Rosenzweig's avatar
      Timezone aware scale (#11111) · 3b6f8871
      Paul Rosenzweig authored
      * copy over code from pr
      
      * remove chronological
      
      * remove tick formatting
      
      * remove chronological
      
      * use reporting_timezone
      
      * remove unneeded tests
      
      * remove import
      
      * add timeseriesScale tests/fixes
      
      * eslint
      
      * more timeseriesScale tests
      
      * remove now unneeded rangeFn
      
      * more timeseriesScale tests
      
      * report_timezone to actual_timezone
      
      * display warning if timezones are mismatched
      
      * extract getTimezone
      
      * don't error if series doesn't have a card (in tests)
      
      * move expected/actual timezones into data, add warning when series have different timezones
      
      * fixes
      
      * make sure getTimezone works on transformed series
      
      * update actual/expected to results/requested
      
      * call getTimezone from LAB renderer rather than apply axis
      
      * include timezone as part of a timeseries interval
      
      * missed variable
      
      * include timezone when updating timeseries interval
      
      * remove "report_timezone"
      
      * add timezone fields to DatasetData flow type
      
      * make the fields optional
      
      * Fill data using timezone scale (#11143)
      Unverified
      3b6f8871
  31. Oct 07, 2019
  32. Sep 05, 2019
  33. Sep 02, 2019
  34. Aug 06, 2019
  35. Jul 30, 2019
  36. Jun 19, 2019
  37. Jun 14, 2019
Loading