Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Nov 30, 2023
  2. Nov 29, 2023
  3. Nov 28, 2023
    • shaun's avatar
      Migrate SettingsJWTForm to formik (#35969) · 0bb85bf4
      shaun authored
      0bb85bf4
    • Mark Bastian's avatar
      Adding Percent Metadata Type (#36145) · c35a6fe9
      Mark Bastian authored
      
      * Adding Percent Metadata Type
      
      This adds the :type/Percentage metadata type to Metabase. It does
      not currently do any fingerprinting. It just enables setting of the
      type for the FE.
      
      * Making :type/Percentage a semantic type as well as a decimal.
      
      * support Percentage setting in the semantic type editor, infer percentage column formatting default
      
      * Support for static-viz rendering when user metadata is `:type/Percentage`
      
      This PR adds in user-defined metadata in `prep-for-html-rendering` so that `number-formatter` can properly render the column as a percentage. This may actually fix a family of issues as user-defined metadata doesn't appear to be used anywhere in this ns. We still need to consider cases where the formatting is specified by the viz settings, but this one step in the right direction.
      
      * Percent semantic types render as percents in tables
      
      This PR adds logic to properly capture a percent semantic type and renders it as such in a table static viz. Note that the `number-formatter` function in `metabase.pulse.render.common` has logic that renders the percent as a truncated int. IDK if this the desired long term behavior. I'll have to ask product that, but if we just make the change it could have potential impacts on places that expect this behavior. It seems like it would make more sense to be like Excel and allow each column to set its significant digits.
      
      * Revert "support Percentage setting in the semantic type editor, infer percentage column formatting default"
      
      This reverts commit e001e6312e6f0bd5700c1d9eb28c88829d87a70a.
      
      ---------
      
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@gmail.com>
      c35a6fe9
    • Mark Bastian's avatar
      Fix event logging to print correct output (#36179) · 57103056
      Mark Bastian authored
      The fix in #35895 included reducing the size of the printed object, but the drilled elements needed to be pulled from the object key in the event, not the event itself. This fixes that.
      57103056
    • Ngoc Khuat's avatar
    • Oleg Gromov's avatar
      Emotion: suppress SSR warnings (#36134) · 7ebdea17
      Oleg Gromov authored
      7ebdea17
    • Uladzimir Havenchyk's avatar
      600d38c4
  4. Nov 27, 2023
  5. Nov 24, 2023
    • lbrdnk's avatar
      Use `mysql:latest` for mysql CI job and update driver code accordingly (#36025) · f21c4385
      lbrdnk authored
      * Adjust mysql container env
      
      * Setting the HOST can cause trouble they said
      
      https://hub.docker.com/_/mysql. Let's try it without then.
      
      * Also MYSQL_USER doesn't play well with empty password
      
      * Cast results of temporal extract to decimal
      
      * Update test
      
      * Update test
      
      * Revert casting temporal-extract results to decimals
      
      * Handle mysql YEAR type as a number instead of a date
      
      * Cleanup
      f21c4385
    • lbrdnk's avatar
      Use sessions in mongo aggregation pipelines (#35680) · e357b238
      lbrdnk authored
      * Use mongo sessions in aggregation pipelines
      
      Using sessions, cancel signal from streaming response can be handled
      correctly - query is killed also on database side.
      
      * Update tests
      
      * Let the middleware handle the exception
      
      While coding the other test, I've found out that if exception is handled
      in the `reducible-results`, code clogs for 3 minutes,
      which is `.maxTime` for aggregation. I don't know the exact reason yet,
      but for time being I'm leaving the exception handling to middleware.
      
      * Add testing string
      
      * Encode aggregation results as `BasicDBObject`
      
      Use this type instead of BSON's Document because code transforming
      DBObject to clojure structures is already in place.
      
      * Update exceptions handling and tests
      
      Exception handling now more resembles code in other drivers. Tests were updated
      to use mbql query instead of raw native to avoid differences between various
      mongodb versions. `$dateTrunc` was not available in version 4.
      
      * Increase cancelation interval in tests
      
      * Address remarks and update test to handle cold start
      
      By cold start I mean running it before dataset is initialized.
      
      * Remove unnecessary hint
      e357b238
    • Alexander Solovyov's avatar
Loading