This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 05, 2020
-
-
Damon P. Cortesi authored
-
Nemanja Glumac authored
- isolated flake (`it.only("should surface an error when validation for any field fails (metabase#4506)", () => {...})`) passed 10x (https://github.com/nemanjaglumac/metabase-tests/actions/runs/348275781) - the whole spec passed 20x (https://github.com/nemanjaglumac/metabase-tests/actions/runs/348306177)
-
Ariya Hidayat authored
Smoketest for OSS edition (for now)
-
Ariya Hidayat authored
-
Damon P. Cortesi authored
* Add a circleci nightly workflow that runs a bigger set of Cypress smoketests * Run this every hour while we're testing it, add a small fix to the admin test * Smoketests: Skip some known failing tests Co-authored-by:
Ariya Hidayat <ariya@metabase.com>
-
dpsutton authored
* If scheduled analyze task is short, refingerprint tables - make the sync steps return their values rather than log and nil - dynamic var in fingerprint.clj to swap out query clauses for fields - update the fingerprint runner to not consume whole list when refingerprinting - algorith for fields to refingerprint: shuffle table and do up to 1000 fields - we refingerprint after analyzing in the task if two conditions hold: 1. the analysis lasted under 5 minutes Don't want to hog our CPU or connections 2. no fields were fingerprinted. The first analysis will fingerprint everything and analyze fields base on that. Seems subsequently we almost never fingerprint unless its a new field. TODO for the future to make it better: - manual overrides to prevent these refingerprinting (might be necessary before this goes live. I lean towards actually doing this and making it opt IN so that people can enable. We verify that its working frequently enough to be helpful but not causing problems. Then in 38 or 39 we flip it and make it opt OUT) - better strategies for what to refingerprint. Right now just picks tables at random. We don't have a place to write down frequency of use of tables nor if the fingerprints are changing substantially (for some notion of substantial). Also, only date and number fingerprints are used by the app at the moment. Could just bias to these fields for the moment. - Our analysis doesn't override if there's already a special_type (Or other field things). We don't capture if special_type and other aspects of a field are manually computed (and therefore a candidate to use ongoing fingerprint results (state fields based on percentage of state values, etc). If this becomes the case and our analysis can become more mature to improving insights and knowing its not clobbering a human override/input we could just make the initial fingerprint smarter. As it stands this step is after the normal fingerprinting so that we don't accidentally do too much work and because we can't really use the information in the analysis/classify steps yet. Docstrings for linter * Add refingerprint column to Database its nullable now so that people can opt in and we can migrate to opt out in the future with the following strategy: if null, set to True, set default to True. This allows us to respect people who have turned it off and enabling in a future release when we are sure the performance ramifications are not too severe. * Add tests for refingerprinting * Test for refingerprinting being bounded * Update UI verbiage for refingerprinting
-
Kyle Doherty authored
* fix ProgressBar component * [styleguide] - add some simple stats * update ProgressBar snap * cleanup
-
Nemanja Glumac authored
* Add repro for #12928 [ci skip] (Cannot join Saved Questions that themselves contains joins)
-
- Nov 04, 2020
-
-
Ariya Hidayat authored
* Quarantine flaky tests (#13682) * Add TODO note re: `describeWithToken` Co-authored-by: Nemanja Glumac
-
Cam Saul authored
Merge release-x.37.x 11/04/2020
-
Cam Saul authored
-
Nemanja Glumac authored
* Add repro for #13626 [ci skip] Note: Once this issue is fixed, add a positive assertion to the Cypress test.
-
Paul Rosenzweig authored
* upgrade some deps to fix warnings * add back lint-yaml scrip * remove e2e/karma references
-
- Nov 03, 2020
-
-
Nemanja Glumac authored
* Add repro for #13235 [ci skip] (Cannot filter by selecting remapped display value from dropdown list)
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
- Nov 02, 2020
-
-
Nemanja Glumac authored
* Fix Cypress flake `should allow bulk hiding tables` * Fix Cypress flake `should save a setting` in `settings/settings.cy.spec.js` * Quarantine `view embedded questions` test(s) in `public.cy.spec.js`
-
Nemanja Glumac authored
* Fix obsolete MBQL syntax in `localization.cy.spec.js` [ci skip] Introduced in: https://github.com/metabase/metabase/commit/6b5765718daff384a1831cd7383401369b8c1725. * Fix obsolete MBQL syntax in `dashboard.cy.spec.js` [ci skip] Introduced in: https://github.com/metabase/metabase/commit/2958b836cc73c16b74b6e6e8fd96a6dabd12f60e. * Fix obsolete MBQL syntax in `nested.cy.spec.js` [ci skip] Introduced in: https://github.com/metabase/metabase/commit/ab762e1ffb8cd79fedc050709c059e8c8b87ef9b. * Fix obsolete MBQL syntax in `dashboard-drill.cy.spec.js` [ci skip] Introduced in: https://github.com/metabase/metabase/commit/cb4371e9fcc45ec242d106c4a01c4a0d68d4c324. * Fix obsolete MBQL syntax in `nulls.cy.spec.js` Introduced in: https://github.com/metabase/metabase/commit/854f5317df724abc0a6026b06bfa539d15d34fa6. * Add positive assertion for repro for #13571
-
Alex Ghiculescu authored
-
Kyle Doherty authored
-
Reza Lotun authored
Added a feature implementation issue template
-
- Oct 30, 2020
-
-
Ariya Hidayat authored
* Linux tools requirement as `apt install` step [ci skip] * Exlude `clojure` since `lein` is sufficient for development
-
Ariya Hidayat authored
Before: find ./docs -type f -iname '*.png' -exec du -ch {} + | tail -1 33M total After: find ./docs -type f -iname '*.png' -exec du -ch {} + | tail -1 16M total
-
Nemanja Glumac authored
* Add repro for #12872 (Between Dates filter behaves inconsistently based on whether the column is from a joined table or not)
-
Robert Roland authored
When a database is updated via the admin interface, any sensitive data (private keys, passwords, etc) should be handled on an "upsert" basis - only modify those fields if they were changed from the "protected password" value. This affects all database drivers. Resolves #13442
-
Nemanja Glumac authored
- Summarizing by Distinct datetime column always sets granularity to Month
-
- Oct 29, 2020
-
-
Cam Saul authored
* Fix collections/graph stack overflow * Test fixes
[ci postgres] [ci mysql] * Show engine in Task trouble shooting logs (#13608) * Show engine in Task trouble shooting logs in an effort to get better feedback when people raise issues about long running sync processes, include the database engine in the logs. Also wrapped `th` in a `tr` inside the `thead` to remove react warning * Const intead of let on the db_id_to_engine * Swap db id for db name * Move comment out of jsx * fixup! Merge branch 'release-x.37.x' into fix-collections-graph-stack-overflow Co-authored-by:dpsutton <dan@dpsutton.com>
-
Cam Saul authored
-
Cam Saul authored
Merge master into release-x.37.x 10-29-2020
-
Cam Saul authored
Migrate build/upload Elastic Beanstalk artifact code into main release script and other improvements (#13635) * Always use current branch; determine CE vs EE build based on version number * Rename delete-file! -> delete-file-if-exists! * Dox & TODO message * Move draft release template * Some logging tweaks for deleting files * Move s3 upload code to common namespace * Integrate EB artifact logic * Move .ebextensions -> release * Remove old EB release scripts
-
Cam Saul authored
-
Ariya Hidayat authored
-
Nemanja Glumac authored
* Update obsolete repro for #12985 * Remove `funnel_add` icon
-
Nemanja Glumac authored
-
- Oct 28, 2020
-
-
Ariya Hidayat authored
* Put yaml-lint into devDependencies That way, the CI run is more reproducible (no need to install yaml-lint on the fly). * Attempt to lint YAML files via yarn run * Update the CI workflow dependency for yaml-linter
-
dpsutton authored
* Show engine in Task trouble shooting logs in an effort to get better feedback when people raise issues about long running sync processes, include the database engine in the logs. Also wrapped `th` in a `tr` inside the `thead` to remove react warning * Const intead of let on the db_id_to_engine * Swap db id for db name * Move comment out of jsx
-
- Oct 27, 2020
-
-
Nemanja Glumac authored
* Fix failing Cypress test in `dashboard-drill` spec file * Assert that the page content rendered (as per @dacort 's suggestion)
-
Tim Macdonald authored
* [Fixes #11879] [Fixes #8410] Don't wrap email attachment filenames * Non-ASCII characters in filenames are encoded [as per IETF RFC 2047](https://tools.ietf.org/html/rfc2047) (c.f. #8410) * Sufficiently-long _encoded_ filenames are sent over multiple lines as per [RFC 2184 section 3](https://tools.ietf.org/html/rfc2184#section-3), for example: ``` Content-Disposition: attachment; filename*0="=?UTF-8?Q?T=C3=A9=C5=BFting_non-ASCII_=C4=8D=C4=A5=C3=A4ract"; filename*1="ers.xlsx?=" ``` * Many mail clients do the right thing, but Gmail does not This commit therefore turns off wrapping, as per [Bill Shannon's Stack Overflow answer re. an undocumented system property](https://stackoverflow.com/a/53344141/220529) (Bill Shannon co-wrote the Java email library, which is used by postal (the Clojure wrapper we use). * (Hopefully) fix race condition in dashboard drill Cypress spec Suggested by @flamber * Skip flaky Cypress tests (per Nemanja) * Only set `mail.mime.splitlongparameters` once
-
dpsutton authored
* Adds dev/src/dev/nocommit to ignore file [ci skip] now you can create a folder nocommit/ under the dev classpath root so you can keep some namespaces around as you work on features. Ex: ```clojure (ns dev.nocommit.oom (:require [metabase.models [database :refer [Database]] [field :refer [Field]] [table :refer [Table]]] [metabase.sync.analyze [fingerprint :as analyze.fingerprint]] [metabase.sync :as sync] [metabase.sync [field-values :as sync.field-values]] [metabase.models.field-values :as field-values] [metabase.sync.analyze.fingerprint.fingerprinters :as fingerprinters] [metabase [util :as u]] [metabase.sync.sync-metadata.fields :as metadata.fields] [metabase.sync.sync-metadata.fields.fetch-metadata :as fetch-metadata] [metabase.query-processor :as qp] [toucan.db :as db] [metabase.db [metadata-queries :as metadata-queries]])) (def pg (Database 4)) (comment (fetch-metadata/db-metadata pg emails-table) (metadata.fields/sync-fields! pg) (sync/sync-database! pg)) (clojure.test/run-tests 'whatever-namespace) ``` I ended up with lots of `(comment ...)` blocks in lots of different namespaces and this has helped keep my worktree clean. * Empty commit to trigger CI [ci skip] skipping ci thought so hopefully the checks on Github are satisified.
-
Kyle Doherty authored
-