Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Apr 15, 2024
  2. Apr 12, 2024
  3. Apr 11, 2024
  4. Apr 10, 2024
    • Raphael Krut-Landau's avatar
    • adam-james's avatar
      Fix embed download endpoint (#41264) · 9cdf2340
      adam-james authored
      * Fix embed download endpoint
      
      We have added format_rows as a query parameter. In most endpoints this just works fine.
      
      Here, however, the problem is that we use query parameters to pass parameter values. We run some validation over these
      provided parameter values (eg. don't allow a user to over ride a 'locked' parameter). Since we have these 2 different
      use cases for query parameters, the validation was failing on :format_rows, which isn't expected to exist at all.
      
      Here, I dissoc the :format_rows key prior to this validation step, so normal validation can continue.
      
      * Add test that uses this card embedding endpoint
      Unverified
      9cdf2340
Loading