This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Feb 23, 2023
-
-
Cal Herries authored
* Decouple checking ddl from classifying h2 stmts - should enable followup for easily blocking more kinds of queries - check all statements to make sure they aren't "ddl". * fix classify-query * linter fixes + get-field refactor * return the CommandInterface values as ints Reach into the CommandList when needed * docstring wording * catch invalid queries -- they can't be classified * Remove action subtypes from inlined-models * Add ddl check for `execute-write-query!` * Remove ACCESS_MODE_DATA * Check queries are single select statements * Add test for sample database privileges * Fix single-select check * Add single-select test * Rename and add more tests for checking read only commands * commands -> statements * Fix check-disallow-ddl-commands * new line * Add more read-only statements to the tests * Update error text * Use are * Add integration test for executing actions with disallowed commands * Add test before inserting row * Run GRANT ALL ON SCHEMA "PUBLIC" TO GUEST * Restore classify-query * whitespace --------- Co-authored-by:
Bryan Maass <bryan.maass@gmail.com>
-
Ngoc Khuat authored
* add logics to skip generate subscription contents for link cards and actions
-
Tim Macdonald authored
* Add `model_id` to action search results so that URLs can be made [Fixes #28565] * Fix typo in Cypress filename
-
Case Nelson authored
* Strip semicolons from card refs in native queries Fixes #28218 While source-query substitution handled semicolons in native questions within outer mbql queries, we used a different code path when splicing into native queries. This brings the two paths inline. * Reference issue in testing * Add docstring
-
- Feb 22, 2023
-
-
metamben authored
* Resolve nested questions in native queries Fixes #25988.
-
Bryan Maass authored
* Decouple checking ddl from classifying h2 stmts - should enable followup for easily blocking more kinds of queries - check all statements to make sure they aren't "ddl". * fix classify-query * linter fixes + get-field refactor * return the CommandInterface values as ints Reach into the CommandList when needed * docstring wording * catch invalid queries -- they can't be classified * respond to review comments - fix see: comment - remove CommandList typehint - rename command-list -> command - skip checking disallowed ddl commands when query is `nil` then also: - fix a linter error - add a test for `nil` query ddl command checking * rename command-list-type -> first-command-type * fix schema + handle h2-parser build failure
-
Cal Herries authored
* Fix action loading and extraction of action type * Remove comment * Fix handling required parameters for public basic actions (#28415) * Fix presenting required parameters * Add tests * Add explanation text to the action editor (#28406) * Add explanation text to the action editor * Replace link * Add missing `nock.cleanAll` calls (#28441) * [CI] Improve `codenotify` workflow (#28432) * Add path filtering to codenotify workflow * Upgrade action to its latest version (v0.6.4) * [E2E] Prevent app permission flakes (#28445) * Ensure dashcards are deleted after actions are deleted (#28446) (c.f. discussion at https://metaboat.slack.com/archives/C04FG88HL95/p1676649795131089 ) * Show not found view when opening archived model (#28443) * Add `isArchived` method to `Question` class * Show nice not found view when opening archived model * [CI] Unify E2E tests workflows (#28431) * [Ci] Fix wildcard glob pattern in path filters (#28447) [ci skip] * Remove dupe tests * Add database_id to implicit actions * Tidy * Update select-actions docstring * Add test for database_id in action dashcards * Remove database_id before insert and update * whitespace * Refactor select-actions * Add database_id to action-create-test * Add test for create+update+select for implicit actions * Fix test * Remove conditional * style --------- Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com> Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by:
Tim Macdonald <tim@metabase.com>
-
Tim Macdonald authored
* If a model is converted to a card, archive the associated actions * If an action is unarchived and its model _is_ a card, throw an error
-
- Feb 21, 2023
-
-
Cam Saul authored
* MISC improvements * Update test/metabase/models/secret_test.clj Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Update .clj-kondo/hooks/clojure/test.clj Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Update .clj-kondo/hooks/clojure/test.clj Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
dpsutton authored
* Custom migrations Current syntax: specify the migration with ``` - changeSet: id: v46.00-080 author: dpsutton comment: Uppercases all Card names changes: - customChange: class: "metabase.db.custom_migrations.ReversibleUppercaseCards" ``` and in the new namespace metabase.db.custom-migrations: ```clojure (defmigration UppercaseCards (db/execute! {:update :report_card :set {:name :%upper.name}})) (def-reversible-migration ReversibleUppercaseCards (db/execute! {:update :report_card :set {:name :%upper.name}}) (db/execute! {:update :report_card :set {:name :%lower.name}})) ``` * Use db provided by liquibase * edit docstring * set *warn-on-reflection* to fix lint error & rebase --------- Co-authored-by:
Noah Moss <noahbmoss@gmail.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
Cam Saul authored
* Misc QP test improvements * Add test
-
Tim Macdonald authored
This'll be revisited as part of v47 [Fixes #28425]
-
- Feb 20, 2023
-
-
Case Nelson authored
* Fix linter * Make sure we're inlining num in substitution and sum aggregations * Set hsql version * Fixing tests * Fixing tests after the h2 conversion * Use h2x/extract in h2, fix test differences * Fixing tests for honeysql2 * Only numbers get inlined * More test fixes * Fixing tests * Undo bad commit * Inline Ratio must produce doubles or h2 will do integer division where 1/2 = 0 * Fix bad case statement * We can't run native queries with AS for oracle --------- Co-authored-by:
Cam Saul <github@camsaul.com> Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com>
-
metamben authored
* Make joins work * Run fuzzy-field-info-test only against H2 * Set driver/*driver* when performing actions * Restrict expressions+joins-test to DBs supporting date arithmetics * Fix ordering of (top level) fields in mongo tables * Explicitly exclude mongo from tests requiring foreign key support * Optimize away $sort stage for implicit order-by.
-
Cal Herries authored
* Fix action loading and extraction of action type * Remove comment
-
Ryan Laurie authored
* add dashcard testing mocks * improve virtual card overlays * update types * add search entity types * add metabase entity support to link cards * simplify link displays * update types and support collections and tables * use edit button to replace entity * test entity links * fix rebase * update types * address review comments * handle restricted link entities * Hydrate link cards info (#28297) * hydrate link cards info * we need to hydrate collections too * Address Cal's comments: - model use keywrod -> string - use model hydration - comments here and there * Link cards serdes (#28321) --------- Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
- Feb 17, 2023
-
-
john-metabase authored
* Removes :presto driver and tests * Merges :presto-common into :presto-jdbc * Adds migration to update presto databases to presto-jdbc --------- Co-authored-by:
Cam Saul <github@camsaul.com>
-
john-metabase authored
* Updates param parser to ignore SQL comments * Adds code to disable SQL comment handling in Mongo native query param parsing
-
Tim Macdonald authored
-
Tim Macdonald authored
-
Cal Herries authored
* Fix null parameters for implicit actions * Fix test for dashboard and add action_id GET /api/dashboard/:id/cards endpoint schema * Fix endpoint * Update src/metabase/models/action.clj Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> --------- Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
Cam Saul authored
* Spark SQL => Honey SQL 2 * Fix stuff
-
Cam Saul authored
* Oracle Honey SQL 2 * Remove debugging function * Fix concat() * Oracle should use numbers for booleans when loading test data
-
- Feb 16, 2023
-
-
Cam Saul authored
* Remove driver methods deprecated in 43 and older * Oops don't delete read-column-thunk * Update Vertica to implement read-column-thunk instead of read-column * Remove stray reference to syncable-schemas --------- Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
Mark Bastian authored
The `personal_owner_id` field is now added to the Collection when computing collection ancestors.
-
Cal Herries authored
-
Cam Saul authored
-
Mark Bastian authored
Added logic to get column ids from model metadata if possible.
-
Cam Saul authored
* Port `:vertica` driver to Honey SQL 2 * Fix
* One last test fix -
Cam Saul authored
* Fix `escape-join-aliases` middleware not properly deduplicating all aliases * Fix join resolution order * Appease Eastwood * Test fixes
* Ambiguous join aliases inside join conditions should prefer the joins from source queries * One more test
-
- Feb 15, 2023
-
-
Cam Saul authored
-
Tim Macdonald authored
* Update H2 command * Clarify documentation for token check
-
Cal Herries authored
-
Cam Saul authored
-
- Feb 14, 2023
-
-
Bryan Maass authored
* adding v2 data and query paths into the parser * add example test * adjust graph test output - seems kinda wrong, could use some guidance * add some more tests * temporarily add rcf tests * balance parens in deps.edn * dirty commit + making progress - need to make sure the spec is correct on this * tests for permission graph v2 api * Fix :data and :query keys in permissions graph v2 - adds tests for v2 graph read endpoint - rename some malli schemas - remove a few simple defendpoint-schema * transfer rcf/tests into deftests - fix a bug with native data permission path parsing - remove inline defs - add more tests for v2 style permission path parsing * take out c.t.l/log * formatting * move more tests around * lint fix * update docstrings - add / remove newlines
-
Cal Herries authored
* Add public_uuid and made_public_by_id to actions table & endpoints to enable/disable the public sharing on individual actions (#27721) * Add migration for public_uuid (indexed) and made_public_by_id * Add UUIDString schema * Add endpoints for enabling/disabling sharing of actions * Test that the new fields are returned with `GET /api/action/:id` * Remove validCheckSum on migration * Remove trailing whitespace * Fix DELETE test * Fix tests * Please migration linter * Update the default public_uuid every test run * Please migration linter * Add FK onDelete cascade * Replace ü * Add GET endpoint and post-select for action * Revert "Add GET endpoint and post-select for action" This reverts commit 8cc8b57d6034146dd726b54bc4199830ec1fda21. * Fix merge * Reorder migrations * Update test for GET `api/action?model-id=<id>` endpoint to include public sharing keys (#27802) * Add GET: /api/public/action/:uuid endpoint (#27781) * Add test * Remove non-public columns and check for 404 * Fix docstring * Rename for clarity * Fix missing ns * Remove unneccessary keys from action * Update test * Remove unused refer * Reorder migrations * Use mt * Add require and refactor * Use mt * Add endpoint for executing a public action (#27793) * Add endpoint and test * Add more tests and TODOs * Use mt * Reorder migrations * Remove unused require * Rate limit actions at 1 per second * Fix the tests for the throttle * Refactor tests * Fix test * Fix docstring * Add test for failed execution if actions are disabled * Use crowberto in tests * Fix using crowberto in tests * Fix cyclic load dependency * Add GET api/action/public endpoint * Use defendpoint * Add action-api-test * Add model_id to GET action/public response * Update GET api/action/public test for model_id * Add actions to public sharing admin settings (#27675) * Add actions to public sharing admin settings * Add public action in public sharing admin settings tests --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
Tim Macdonald authored
[Fixes #28298]
-
Braden Shepherdson authored
A `metabase.domain-entities.malli/defn` macro that (in CLJS) uses the schemas for the arguments to drive wrapping of vanilla JS objects for idiomatic use in CLJC code. See the first two functions in `metabase.domain-entities.queries.util` which get passed vanilla JS objects but can use them as CLJS maps.
-
Luiz Arakaki authored
-
Tim Macdonald authored
* Add action.archived and search Constituent commits: Basic action archiving and search; no perms Only show actions in search with appropriate permissions archive test Make search tests more tolerant of local DB state Show model that actions come from in search results Test action search properly Per Conor/Bruno, actions have higher search precedence than pulses Don't return archived actions from the main GET endpoint Clean things up based on PR review Don't show archived actions in most endpoints Remove actions from search so this can be merged sooner Delete associated DashboardCard when Action is archived Add a few more tests
-