This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 15, 2024
-
-
Nicolò Pretto authored
* fix(sdk): remove `Cannot update a component XX while rendering a different component` error * test(sdk): introduce jest test to make sure api.basename is set before loading the locale
-
- Nov 14, 2024
-
-
Oisin Coveney authored
-
Noah Moss authored
-
Oisin Coveney authored
-
Mahatthana (Kelvin) Nomsawadi authored
-
Phoomparin Mano authored
* add background-disabled color * expect background-disabled to be mapped in tests
-
- Nov 13, 2024
-
-
Nicolò Pretto authored
* wip: Alert component for SDKError * use the alert component for the default sdk error component * fix tests * update e2e
-
Chris Truter authored
-
- Nov 12, 2024
-
-
Mahatthana (Kelvin) Nomsawadi authored
* Update workflow on master * [DEBUG] Disable steps for testing * Add alberto as a reviewer * [DEBUG] modify the branch name for testing * Revert "[DEBUG] modify the branch name for testing" This reverts commit 7d5d8bf8. * Revert "[DEBUG] Disable steps for testing" This reverts commit a8662c9e.
-
Cam Saul authored
* Try snowflake 3.19.0 * Deafault to java 21 for drivers * Trigger CI * Try running things with --add-opens to see if it solves our problems * Fix `update-view-dashboard-timestamp-test` * Try snowflake 3.19.0 * Deafault to java 21 for drivers * Try running things with --add-opens to see if it solves our problems * Fix `update-view-dashboard-timestamp-test` * Update deps.edn * Switch to Java 21 * Docker image needs to use --add-opens option * Add note about change to Java 21 to driver changelog --------- Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by:
Luis Paolini <paoliniluis@gmail.com>
-
Phoomparin Mano authored
* add filter picker skeleton * add filter picker skeleton * add picker in popover use case * reuse FilterColumnPicker * add question filter logic * remove fixed width from popover * add onClose handler * add e2e test skeleton * contain FilterBar in Box in story * add a test for adding filters * update e2e tests * add filter picker to the docs * inline props and functions * update the props
-
Noah Moss authored
-
Noah Moss authored
-
Oisin Coveney authored
-
Chris Truter authored
-
- Nov 11, 2024
-
-
Chris Truter authored
-
- Nov 08, 2024
-
-
Noah Moss authored
-
Phoomparin Mano authored
-
Phoomparin Mano authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Correct embedding hash options type semantically * Pass `X-Metabase-Locale` to embed downloads * wip locale header middleware * Allow smart scalar text to be translated * Stop using global variable * Add more details to embedding types * Extend the E2E util type and correct some properties types * Add e2e test * Fix dashboard name * Add a test for static embed question * Make a type name follows a convention Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Fix failed E2E tests due to missing default values * Fix public embed not working with `?locale` anymore * Revert "wip locale header middleware" This reverts commit 83d8d135. * Preserve locale when in the `as-admin` macro is used Motivating issue: ```shell ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124' x-metabase-locale:fr -pb | jq '.data|.cols|map(.display_name)' [ "State", "Count" ] ``` I'm running a query that has aggregated columns and it is returning the untranslated. Note that these are computed and dynamically given a display name. ```clojure (case tag :count (i18n/tru "Count") :cum-count (i18n/tru "Cumulative count")) ``` The problem is that we run embedding things as admin. And that gets the current user, which in embed and public spaces is nil, and so binds a nil to user-locale, which defaults to english when translating. After: ``` ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124' x-metabase-locale:fr -pb | jq '.data|.cols|map(.display_name)' [ "State", "Nombre de lignes" ] ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124' x-metabase-locale:zh -pb | jq '.data|.cols|map(.display_name)' [ "State", "行数" ] ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124 ' x-metabase-locale:es -pb | jq '.data|.cols|map(.display_name)' [ "State", "Contar" ] ``` This is fetching a dashboard's card which is a query of orders grouped by created at month, sum of total. --------- Co-authored-by:
Nicolò Pretto <info@npretto.com> Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> Co-authored-by:
dan sutton <dan@dpsutton.com>
-
- Nov 07, 2024
-
-
Nicolò Pretto authored
-
Oisin Coveney authored
-
Oisin Coveney authored
-
github-automation-metabase authored
-
- Nov 06, 2024
-
-
Noah Moss authored
-
Phoomparin Mano authored
* move the database prompt to the very beginning * ability to use sample database for cli * print username and password in console * no tenancy isolation as a default option * highlight sample credentials file * update credential log messages Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * continue without tenancy isolation --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
Alexander Solovyov authored
previously import would return 200 w/o regard if it was successful or not fixes #49602
-
Jeff Bruemmer authored
-
Nicolò Pretto authored
Co-Authored-by:
Poom <poom@poom.dev>
-
Nicolò Pretto authored
* refactor + more specific auth errors * fix linting issues * make tests pass, again * make test pass for real? * continues the refactor and hopefully makes tests pass * try to simplify the logic a little bit more * also logs to the console for the edge case of invalid session * remove setLoginStatus * fix typo * fix debug line that should have been commented * remove dead code * remove test for code that doesnt exist * address feedback from PR * update test copy * Update enterprise/frontend/src/embedding-sdk/store/auth.ts Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * Update enterprise/frontend/src/embedding-sdk/store/auth.ts Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * update copy for site settings error * ex -> exception * Update enterprise/frontend/src/embedding-sdk/store/auth.ts Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * Update enterprise/frontend/src/embedding-sdk/store/auth.ts Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * update tests to use the updated copy + small typos * refactor: use jest spy on to check for console.error Co-authored-by:
"Mahatthana (Kelvin) Nomsawadi" <me@bboykelvin.dev> * use full error message in test * renamed response to session * mock implementation of console.log * fix(49482): don't create a new store on each MetabaseProvider render (#49492) * fix(49482): don't create a new store on each MetabaseProvider render * remove store prop as it seems to not be used --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
Ngoc Khuat authored
-
- Nov 05, 2024
-
-
Ngoc Khuat authored
-
Alexander Polyankin authored
-
Denis Berezin authored
* Add possibility to hide columns in CollectionBrowser * Add tests * Review fixes * Fix e2e
-
Denis Berezin authored
* Add isOpen prop to control CreateDashboardModal * Add props to storybook
-
- Nov 04, 2024
-
-
Phoomparin Mano authored
feat(sdk): ability to enforce the destination collection to save to and hide the collection picker (#49251) * add ability to hide the collection picker * add save options * make sure collectionId is fresh * update sdk question form component * make collectionId accept null * apply saveOptions to sdk components * revert to use initialCollectionId as context name * target the correct collection id * add e2e tests * update e2e tests * move into within * update test * remove collectionId from default args * revert e2e of hide columns * make e2e helper more generic * use saveToCollectionId prop to save to a specific collection * update e2e tests * update comment formatting Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * clean up leftover changes from an earlier version * readme update * indicate that saveToCollectionId is only applicable to static questions * revert QuestionEditor.isSaveEnabled defaults * update comment format * remove unused initialCollectionId prop * experiment: try to fix failing custom-columns e2e --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
- Nov 03, 2024
-
-
Nick Fitzpatrick authored
* Adding moderated status to entity picker * adjusting verified icon size * size adjustments * e2e test adjustments * removing verified model icon * fixing e2e test * unit test * unit test adjustment
-
- Nov 01, 2024
-
-
Nick Fitzpatrick authored
* Adding moderation status to Dashboards * react sins * verification coll: subselect on card + dashboard * fix the 3 failing BE tests * add an api test for dashboard verification * verified dashboards are never stale * e2e tests * code cleanup * unit test and e2e test cleanup * PR Feedback * backend test fixes * Nick shouldn't touch clojure * type fix * indent * fix last 2 BE tests --------- Co-authored-by:
Bryan Maass <bryan.maass@gmail.com>
-
Denis Berezin authored
* Fix scroll for EditableDashboard in fullscreen mode * Fix scroll for InteractiveDashboard in fullscreen mode * Display fullscreen control to dashboards by default * Fix issue with public shared questions empty footer
-
- Oct 31, 2024
-
-
Jeff Bruemmer authored
-