Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 24, 2023
    • Cam Saul's avatar
      QP: use MLv2 metadata provider. Eliminate 50% of app DB calls and improve... · a66db9e9
      Cam Saul authored
      QP: use MLv2 metadata provider. Eliminate 50% of app DB calls and improve performance by 10%+ (#33221)
      
      * QP use MLv2 metadata provider (34/2)
      
      * (22/2)
      
      * (21 / 0)
      
      * (20 / 4)
      
      * (7 / 2)
      
      * (2/0)
      
      * Cleanup; (3/0)
      
      * Last two test fixes
      
      * (36 / 2)
      
      * (8 / 1)
      
      * Reorder stuff
      
      * Test fixes :wrench:
      
      * Test fixes
      
      * Some test fixes
      
      * More test fixes :wrench:
      
      * Test fix :wrench:
      
      * MongoDB test fix
      
      * B I G  cached metadata provider performance improvements
      
      * Revert breaking change
      
      * Fix Kondo
      
      * Make sure application database metadata provider returns Database :features
      
      * Test fix :wrench:
      
      * Parallel tests for QP macroexpansion middleware
      
      * `with-current-user` is fine in parallel tests.
      
      * Add test util remap metadata providers and rework remap middleware to use mock MLv2 data
      
      * Address PR feedback
      
      * Improve unrelated flaky test
      
      * Some test improvements
      
      * Fix lint error
      
      * MLv2-ize `nest-query-test`
      
      * Fix typo in PR feedback changes
      
      * More parallelization and test fixes :wrench:
      
      * Convert lots more tests to mock metadata
      
      * Test fix? :wrench:
      
      * Fix Card update logic
      
      * Another Card update logic fix :wrench:
      
      * Another round of fixes :wrench:
      
      * Hopefully no more test fixes :wrench:
      
      * Evil test fixes :wrench:
      
      * Test fix 1
      
      * Test fix
      Unverified
      a66db9e9
    • Ngoc Khuat's avatar
      Migrate to the new with-temp (#33440) · 742f4a61
      Ngoc Khuat authored
      Unverified
      742f4a61
  2. Aug 22, 2023
    • Cam Saul's avatar
      Parallelize QP tests (August 2023 attempt) (#33068) · d54caf88
      Cam Saul authored
      * Parallel QP tests; linter improvements; move QP test fns
      
      * Cleanup
      
      * Move query->expected-cols
      
      * Fix QP test namespace
      
      * Test fix :wrench:
      
      * Fix merge issues
      
      * Revert unrelated changes
      
      * Test fix :wrench:
      
      * Fix some things that are actually ^:parallel safe
      
      * Remove Oracle logic for destroying DBs from different sessions since we don't test on AWS anymore
      
      * Use ReentrantReadWriteLock for getting + creating test datasets to avoid race conditions
      
      * Add non-`metabase.test` versions of things to the disallowed list for `^:parallel` tests
      Unverified
      d54caf88
  3. Aug 06, 2023
    • Cam Saul's avatar
      QP: use Malli (#32657) · 18c1b198
      Cam Saul authored
      * QP: use Malli
      
      * Fix schema names
      
      * Fix missing namespaces
      
      * Fix busted stuff
      
      * Simplify the new schema
      
      * Test fix :wrench:
      
      * Test fixes :wrench:
      
      * MongoDB fixes :wrench:
      
      * FAST mu/defn
      
      * Malli registry
      
      * Misc fixes
      
      * Some cleanup
      
      * Misc cleanup and test fixes :wrench:
      
      * mu/disable-enforcement
      
      * Test fix
      
      * Fix Cljs version of `disable-enforcement`
      
      * Misc improvements
      
      * Update tests
      
      * Fix Kondo warnings
      
      * Fix Kondo warnings
      
      * Fix busted Malli schema
      
      * PR feedback
      
      * Fix busted schema
      
      * Kondo fixx
      
      * Test fixes :wrench:
      
      * Use Malli version of `describe` now that PR was merged
      
      * Work around https://github.com/metosin/malli/issues/924
      
      * Test fixes :wrench:
      
      * Improvements
      
      * Test fix
      Unverified
      18c1b198
  4. Aug 03, 2023
  5. Jul 31, 2023
  6. Jul 28, 2023
  7. Jul 25, 2023
  8. Jul 20, 2023
  9. Jul 14, 2023
  10. Jul 04, 2023
  11. Jun 27, 2023
    • Cam Saul's avatar
      Support Legacy Metrics in MLv1 (#31885) · f75ff350
      Cam Saul authored
      * Extra Metric tests; include `:description` in the Metric `display-info`
      
      * Add `available-metrics` function & TS wrappers
      
      * Support passing a Metric to `lib/aggregate`
      
      * Include `:selected` information in Metric display info
      
      * Fix indentation
      
      * Revert changes to arithmetic type-of calculation
      
      * Test fixes :wrench:
      
      * Address PR feedback
      
      * Address PR feedback
      
      * Update docstring
      Unverified
      f75ff350
  12. Jun 21, 2023
    • Cam Saul's avatar
      MLv2: remove the `source-table: card__<id>` hack once and for all (#31749) · d22a382d
      Cam Saul authored
      * Implement `suggested-join-condition`
      
      * Update docstring
      
      * OOOF fix typo in `filter-clause`
      
      * Fix premature i18n lookup
      
      * Address PR feedback
      
      * MLv2 JS join function wrappers
      
      * PR feedback from #31590
      
      * `join-conditions` returns raw MBQL clauses!
      
      * WIP
      
      * Simplify `with-join-alias` and `with-join-fields`
      
      * Simplify join and add with-join-conditions
      
      * Un-revert dev
      
      * Wow! Remove unresolved nonsense.
      
      * Remove dev
      
      * Remove dev
      
      * Test fixes :wrench:
      
      * PR feedback
      
      * WIP
      
      * defop doesn't need query or stage-number anymore
      
      * Fix Cljs tests for base PR
      
      * Test fixes :wrench:
      
      * Test fix :wrench:
      
      * Update JS wrappers
      
      * MLv2: remove the source-table: card__<id> hack once and for all
      Unverified
      d22a382d
  13. Jun 20, 2023
  14. Jun 17, 2023
  15. Jun 08, 2023
  16. Jun 02, 2023
  17. Jun 01, 2023
  18. May 12, 2023
    • Ngoc Khuat's avatar
      [Feature] Dashboard Tab basic functionality (#30177) · d617aecf
      Ngoc Khuat authored
      
      * Dashboard Tab entity (#29802)
      
      * add dashboard tab entity
      
      * Dashboard tabs CRUD (#29861)
      
      * Dashboard tabs frontend (#30189)
      
      * rename `DashboardHeader.tsx` to `DashboardHeaderView` to avoid collision with `DashboardHeader.jsx`
      
      commit-id:7cdfd86a
      
      * add tabs to dash
      
      commit-id:d3c2fa74
      
      * improve code structure and other fixes
      
      * rename `dashboardtab_id` to `dashboard_tab_id`
      
      * remove explicit `position` logic
      
      * improve code quality
      
      * add renaming functionality
      
      * add two new tabs when creating first tab
      
      * hide tabs if there is only one
      
      * add unit test for `DashboardTabs` component
      
      * refactor
      
      * fix type errors
      
      * add `tabId` to text cards
      
      * add `tabId` to link cards
      
      * add `tabId` to action button
      
      * use disabled state when only one tab remains
      
      * refetch cards with filter value when changing tabs
      
      * add e2e test
      
      * fix broken e2e tests
      
      * add horizontal scrolling
      
      * fix unit test
      
      * fix create tab button being on right
      
      * fix performance issue when switching tabs
      
      * add `ttag` to `tabs.ts`
      
      * use `aria-label` in e2e test helper
      
      * fix type error after rebasing
      
      * making ordered_tabs optional for tests purposes
      
      * fix failing unit tests
      
      * fix failing e2e tests
      
      * fix flaky revision history e2e test
      
      * fix type error after merging feature branch with master and rebasing
      
      * fix revisions unit test
      
      * fix `ActionParmatersInputsForm.tsx` to stop `actions-on-dashboards.cy.spec.js` from flaking
      
      ---------
      
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
      
      ---------
      
      Co-authored-by: default avatarEmmad Usmani <emmadusmani@berkeley.edu>
      Unverified
      d617aecf
  19. Apr 25, 2023
  20. Apr 20, 2023
  21. Apr 19, 2023
  22. Apr 18, 2023
  23. Apr 11, 2023
  24. Mar 31, 2023
    • Braden Shepherdson's avatar
      [MLv2] Test `metabase.lib.convert` by round-tripping every `mbql-query` (#29487) · 61d382f1
      Braden Shepherdson authored
      This is a great way to make sure the conversion in both directions
      is robust; every feature of MBQL is exercised somewhere in the BE tests.
      
      In a few cases the `mbql-query` is called from a context where a
      `(is ...)` test won't work - those places can use a `mbql-query-no-test`
      instead. There were actually only two of these.
      
      This exposed several issues in `->legacy-MBQL` which have now been fixed.
      Unverified
      61d382f1
  25. Mar 29, 2023
    • Cam Saul's avatar
      [MLv2] Basic QP support for MLv2 queries (#29635) · d6b958c1
      Cam Saul authored
      * [MLv2] Basic QP support for MLv2 queries
      
      * Fix data/id init on launch
      
      * Fix Kondo errors
      
      * Add missing docstrings
      
      * Seriously Kondo!
      Unverified
      d6b958c1
    • Braden Shepherdson's avatar
      [MLv2] Move template tag extraction into CLJC for use from BE (#29526) · 900651ca
      Braden Shepherdson authored
      This supports both parsing out the tags and constructing the template tags map, with `card-id` and all.
      
      This is not quite a FE no-op because the humanization of text is slightly different between `metabase.util.humanization` and the JS humanization library.
      
      This improves JS<->CLJS conversion to handle UUIDs and be smarter about enums, both of which were needed to handle converting template tag maps.
      
      Extracted a `js=` test helper to `metabase.test.util.js/=` since many tests need to compare JS objects, which are not JS `==` to each other.
      Unverified
      900651ca
  26. Mar 28, 2023
  27. Mar 27, 2023
    • Ngoc Khuat's avatar
      Convert simple-* to toucan2 (#29427) · 8b8669a2
      Ngoc Khuat authored
      * (db/simple-insert! Model opts) -> (t2/insert! (t2/table-name Model)
      opts)
      
      * (db/simple-delete! model opts) => (t2/delete! (t2/table-name) opts)
      
      * (db/simple-insert-many! Model opts) => (t2/insert! (t2/table-name Model) opts)
      Unverified
      8b8669a2
  28. Mar 24, 2023
  29. Mar 23, 2023
    • Ngoc Khuat's avatar
      db/count, db/exist? => toucan2 (#29432) · f31368f6
      Ngoc Khuat authored
      * db/count -> t2/count
      
      * db/exists -> t2/exists
      Unverified
      f31368f6
    • Cal Herries's avatar
      Use type/JSON for field base_type for postgres and mysql (#28849) · 48dcfc92
      Cal Herries authored
      * Use type/JSON instead of type/SerializedJSON
      
      * Tidy migration
      
      * Update migration
      
      * Fix rollback migration for h2
      
      * whitespace
      
      * Add test for migration
      
      * Fix test
      
      * Add rollback
      
      * whitespace
      
      * Test JSONB type as well as JSON
      
      * Don't fingerprint JSON columns
      
      * Remove comment, that might be wrong in the future
      
      * Update test
      
      * Add tests for fingerprinting
      
      * Use base-type JSON for fingerprinting base query
      
      * Add test for visibility-type=details-only
      
      * undo .
      
      * Change migration id
      
      * Fix migration test
      
      * Merge master
      
      * Exclude mariadb from tests
      
      * Make is-mariadb? public
      Unverified
      48dcfc92
    • Ngoc Khuat's avatar
      db/insert! to t2 (#29389) · fbfb7e9b
      Ngoc Khuat authored
      * convert db\/insert! to t2
      Unverified
      fbfb7e9b
  30. Mar 22, 2023
    • Braden Shepherdson's avatar
      [MLv2] Fix `mu/defn` in CLJS · 61ba33e0
      Braden Shepherdson authored
      It's broken there because it tries to capture the Var returned by
      `defn` in a `let`. Vars aren't real in CLJS, so this doesn't work.
      The compile succeeds but the JS output is subtly broken.
      61ba33e0
Loading