Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Oct 08, 2024
    • Phoomparin Mano's avatar
    • Kamil Mielnik's avatar
      [Epic] Search in selection in entity picker (#47755) · f6aab536
      Kamil Mielnik authored
      
      * Maintain selected folder state in Entity Picker (#47309)
      
      * Keep tabs mounted
      
      * Rename TablePicker onChange to onItemSelect to match QuestionPicker and also call it for folders
      
      * Inline small functions
      
      * Remove unused type
      
      * Rename
      
      * Remove TODOs
      
      * Remove duplication
      
      * Reduce diff
      
      * Rename
      
      * Lift state from TabsView
      
      * Remove redundant callback
      
      * Store folder state in DataPickerModal
      
      * Refactor computing tabs
      
      * Consolidate search tab definition with recents tab definition
      
      * Simplify computeInitialTab interface
      
      * Extract RECENTS_CONTEXT
      
      * Store tab state in DataPickerModal
      
      * Propagate initial tab state
      
      * Fix a flicker
      
      * Keep tab state in EntityPickerModal
      
      * Fix typing computeInitialTab
      
      * Remove Notebook prefix
      
      * Pass onItemSelect to individual tabs from EntityPickerModal
      
      * Auto select folder
      
      * Fix types
      
      * Adjust remaining tabs definitions to use render
      
      * Adjust tabs definitions to use render in tests
      
      * Fix inverted condition
      
      * Fix TS error
      
      * Fix types
      
      * Rename EntityTab to EntityPickerTab, TabId to EntityPickerTabId
      
      * Rename EntityTabRenderProps to EntityPickerTabRenderProps
      
      * Separate tab models from tab ids
      
      * ESLint
      
      * ESLint
      
      * Recognize folders inside EntityPickerModal
      
      * Add missing prop
      
      * Remove console.log
      
      * Simplify handleFolderSelect
      
      * Revert changes that will go to a different PR
      
      * Fix unit tests
      
      * Refactor
      
      * Remove keepMounted prop
      
      * Fix type
      
      * Remove useMemo from tabs computation (#47505)
      
      * Extract getTabs for DataPickerModal
      
      * Extract getTabs for EntityPickerModal
      
      * Add explicit return type
      
      * Revert "Add explicit return type"
      
      This reverts commit feb3f58c.
      
      * Revert "Extract getTabs for EntityPickerModal"
      
      This reverts commit 4e875a1f.
      
      * Revert "Extract getTabs for DataPickerModal"
      
      This reverts commit cdda8ea1.
      
      * Remove useMemo
      
      * Maintain tab state in Entity Picker (#47794)
      
      * Store picker path state in data picker modal
      
      * Adjust remaining QuestionPicker usages
      
      * Store collection picker state
      
      * Use dedicated onPathChange prop
      
      * Store dashboard picker state
      
      * Improve naming
      
      * Fix unit tests
      
      * Remove accidental code
      
      * Return to previously opened tab when search input is cleared in Entity Picker (#47798)
      
      * Restore previous tab when clearing search input
      
      * Add a unit test for new behavior
      
      * Update comment
      
      * Don't use effect
      
      * Add more tests
      
      * Reduce diff
      
      * Fix flakes
      
      * Change search input placeholder depending on selected folder & tab in Entity Picker (#47801)
      
      * Make TabFolderState generic, pass folder to EntityPickerSearchInput
      
      * Simplify interface
      
      * Extract getSearchInputPlaceholder
      
      * Reduce diff
      
      * Remove TODO
      
      * Implement it
      
      * Shorten code
      
      * Reduce diff
      
      * Use database to scope search if there's only 1 schema
      
      * Add scoped search in the Search tab in Entity Picker (#47839)
      
      * Cleanup entity picker search types (#48098)
      
      * Add e2e tests for local search in the entity picker (#48122)
      
      * Sync the value back into selectedItem when it changes
      
      * Await element
      
      * Handle empty tabs
      
      * Pick everywhere tab
      
      * Click Everywhere in unit tests
      
      * Use deep equality to sync value
      
      * Sync back the path value to the dashboard too
      
      * Run test as admin to avoid (unrelated) permissions issues
      
      * Filter scoped results too
      
      * Fix post-merge issues
      
      * Fix type issues
      
      * Fix null scoped search results
      
      * Sign in as admin to appease the tests
      
      * Use useDeepCompareEffect when syncing back state
      
      * Add default value for searchResultFilter to avoid double condition
      
      * Avoid using useEffect to sync selectedItem
      
      * Avoid overwriting path in useEnsureCollectionSelected
      
      * Fix e2e test
      
      ---------
      
      Co-authored-by: default avatarAlexander Polyankin <alexander.polyankin@metabase.com>
      Co-authored-by: default avatarRomeo Van Snick <romeo@romeovansnick.be>
      Unverified
      f6aab536
    • Oisin Coveney's avatar
      Removes unneeded query parameters (#48401) · 9f50306f
      Oisin Coveney authored
      Unverified
      9f50306f
    • Cam Saul's avatar
      :race_car::rocket::race_car::rocket: :race_car::rocket: SHAVE 7 MINUTES OFF OF NON-CORE DRIVER TEST RUNS IN CI :race_car::rocket::race_car::rocket: :race_car::rocket: (#47681) · cd4d7646
      Cam Saul authored
      * Parallel driver tests PoC
      
      * Set fail-fast to false for now
      
      * Try splitting up non-driver tests to see how broken tests are
      
      * Whoops fix plain BE tests
      
      * Ok nvm I'll test this in another branch
      
      * Fix fail-fast
      
      * Experiment with the improved Hawk split logic
      
      * Fix some broken/flaky tests
      
      * Experiment: try splitting MySQL 8 tests into FOUR jobs
      
      * Divide other Postgres and MySQL tests up and use num-partitions = 2
      
      * Another test fix :wrench:
      
      * Flaky test fix :wrench:
      
      * Try making more stuff fast
      
      * Make athena fast??
      
      * Fix a few more things
      
      * Test fixes? :wrench:
      
      * Fix configs
      
      * Fix Mongo job syntax
      
      * Fix busted test from #46942
      
      * Fix Mongo config again
      
      * wait-for-port needs to specify shell I guess
      
      * More cleanup
      
      * await-port can't have a timeout-minutes I guess
      
      * Let's only parallelize MySQL for now.
      
      * Cleanup action
      
      * Cleanup wait-for-port action
      
      * Fix another flaky test
      
      * NOW driver tests will be FAST
      
      * Need to mark driver tests too
      
      * Fix wrong tag
      
      * Use Hawk 1.0.5
      
      * Fix busted metabase.public-settings-test/landing-page-setting-test
      
      * Fix busted `metabase.api.database-test/get-database-test` etc. (hopefully)
      
      * Fix busted `metabase.sync.sync-metadata.fields-test/sync-fks-and-fields-test` for Oracle
      
      * Maybe this fixed `metabase.query-processor.middleware.permissions-test/e2e-ignore-user-supplied-perms-test` maybe not
      
      * Fix busted metabase.api.dashboard-test/dependent-metadata-test because endpoint had differemt sort order than test
      
      * Ok my test fix did not work
      
      * Fix metabase.sync.sync-metadata.fields-test/sync-fks-and-fields-test for Redshift
      
      * Better test name
      
      * More test fixes :wrench:
      
      * Schema fix
      
      * PR feedback
      
      * Split off test partitioning into separate PR
      
      * Fix failing Oracle tests
      
      * Another round of test fixes, hopefully
      
      * Fix failing Redshift tests
      
      * Maybe the last round of test fixes
      
      * Fix Oracle
      
      * Fix stray line
      Unverified
      cd4d7646
  2. Oct 07, 2024
  3. Oct 05, 2024
  4. Oct 04, 2024
  5. Oct 03, 2024
Loading