This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Apr 15, 2024
-
-
Ngoc Khuat authored
-
- Apr 12, 2024
-
-
Raphael Krut-Landau authored
Adds a Schedule strategy to the Admin / Performance page  [Loom](https://www.loom.com/share/5623cd5d772e417ba2e58c29ae1b8c14?sid=9844f0db-5bb1-4d35-af9b-206d263f5516) As discussed with @luizarakaki, rather than modify the legacy `SchedulePicker` to work with this use case, I made a new version of it - a `Schedule` component - that uses Mantine and a better (though imperfect) approach to localization. For now, the dropdowns are not vertically aligned in this Schedule picker - something I can try to remedy later if that is important. Tests for the Schedule component will be added in a follow-up PR.
-
Denis Berezin authored
* Add interactive question component * Remove excess click actions for embedding * Disable non-working drills * Cleaner components api * Clean up * Review fixes * Fix lint error * Review fixes --------- Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
Cal Herries authored
-
Nick Fitzpatrick authored
* no implicit any on callbacks * cleaning up use of any * small adjustments * PR feedback and unit test adjustment * typing click handler
-
- Apr 11, 2024
-
-
Raphael Krut-Landau authored
-
Cam Saul authored
* Convert `auto-bucket-datetimes` middleware to MLv2 * New Kondo rule time. * Test & lint fixes
* Fix typos * Apply suggestions from code review Co-authored-by:metamben <103100869+metamben@users.noreply.github.com> --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
Oisin Coveney authored
Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
Oisin Coveney authored
-
Nicolò Pretto authored
* .eslintrc -> .eslintrc.js * This might work? * add env for linting css modules class names * avoid extending postcss-modules/recommended, specify just the used rule instead * add missing . on comment * Remove unused .detailName references * Fix ManageApiKeys and GuiQueryEditor * Fix SettingText and DashboardControls * fix missing textUnspaced class * remove usave of S.headerButton, that's actually never used because we never pass headerLink to ReferenceHeader * Remove flexNoShrink --------- Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
- Apr 10, 2024
-
-
dpsutton authored
* Fix #39138 again Fixes #40934 Got unfixed somehow in #40578. seems like some file renames caught it off guard But the long and short is that its possible for a persisted model to end up in the state "refreshing" (possible an instance restart during refreshing). The refreshing job doesn't look for these so they become effectively invisible. Since the job to refresh them will only run one at a time cluster wide, any jobs that are in the "refreshing" state when the refresher begins to refresh are necessarilly stuck (no one else could currently be refreshing them). So we can just add them to the queue of models to refresh. ```clojure (jobs/defjob ^{org.quartz.DisallowConcurrentExecution true ;; <---- :doc "Refresh persisted tables job"} PersistenceRefresh [job-context] (refresh-job-fn! job-context)) ``` * Ensure ee/oss pathways are taken in tests Annoying little footgun here. CI does not run with an ee token, so in order to ensure that test pathway goes through ee version of a defenterprise we _must_ use the `mt/with-premium-features {:cache-granular-controls}`, but we also want to ensure that it goes through the oss version. So two options, a `doseq` on both features (empty set and the feature that triggers this). But want a test in the enterprise folder as well to ensure. The real trickiness comes from running tests at a repl and CLI. My REPL always has an ee token in it. My command line always lacks that as well. So want to be explicit about the token features in effect at test time. That's why I'm essentially duplicating tests (ee in ee folder, oss in regular pathway)
-
Cal Herries authored
-
Cal Herries authored
-
- Apr 08, 2024
-
-
Cam Saul authored
* Wow * Test fix
* Fixes * Actions should use strings for column names (fix :update-row and :create-row normalization) * MLv2 schema should check against keys for the other query type * Ok, have I fixed things? * More fixes * Fix indentation * Another round of test fixes. * Hopefully the last few test fixes * We need to test normalization for queries that have keyword keys as well. * Fix Cljs i18n namespaces * Sort namespaces * Only test against H2 * Rename `metabase.mbql` to `metabase.legacy-mbql` * Fix Kondo warnings * Test fixes * Register MBQL clause schemas and test fixes * Test fixes and PR feedback * Test fix * Remove the normalization tests * Test fixes * Fix kondo * Fix import * Another fix * Merge * FIXES * Add another missing REQUIRE * More Metric => LegacyMetric renaming * metabase.models.metric-important-field => metabase.models.legacy-metric-important-field * Even more renaming * More renaming * Even more fixes. * More renaming * Wow, even more renaming!! -
Alexander Solovyov authored
-
Cal Herries authored
-
Alexander Solovyov authored
New endpoint accepts entity and entity ids in form of `database=1&dashboard=2&question=3`. If you don't supply `&include=overrides`, then it tries to find configs directly referencing supplied entities and updates their `invalidated_at`. If you supply `&include=overrides`, all the referenced cards are updated (`report_card.cache_invalidated_at`). Cache strategies then select the maximum `invalidated_at` in their logic. EE-only. resolves #40548
-
Oisin Coveney authored
-
- Apr 06, 2024
-
-
Noah Moss authored
-
- Apr 05, 2024
-
-
Cam Saul authored
-
- Apr 04, 2024
-
-
Denis Berezin authored
* Add manual imports fixup * Fixes * Fixes * Review fixes * Review fixes
-
Chris Truter authored
-
- Apr 03, 2024
-
-
Raphael Krut-Landau authored
Adds: * Performance tab * Data caching settings tab * Two-panel strategy editor * "Don't cache" strategy * "TTL" strategy * "Duration" strategy * "Use default" option for databases * OSS page * Unit tests [Loom](https://www.loom.com/share/b1b173a52be9401588ffb63f718e052a?sid=bed4bdf5-f967-4d93-af55-9b96b6b52730)
-
Uladzimir Havenchyk authored
* Do not put js code into page title * Typecheck * Add e2e test * Update e2e/test/scenarios/question/document-title.cy.spec.js Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Mahatthana (Kelvin) Nomsawadi authored
* Remove old config + fix typo * Add new analytics for 4 new illustration settings
-
Cal Herries authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Add login page illustration (#39299) * Move Metabot setting to a new place * Add setting for login page illustration * fix UI styling * Fix not able to upload the same file twice * Update the admin > appearance > conceal metabase copy * Prepare the component for tests * Add some unit tests * Prevent settings not saved sometimes After setting the value to/from `custom` one of the setting could be failed to save, I suspect this happens because the race condition from trying to save the setting values relatively at the same time. * Make unit tests easier to read * Add all unit test test cases * Add basic E2E test * Show fallback icon for broken images * Make use of the proper component * Update the comment to affect the reality * Add an error message when file size is over 2MB * Show an error message when the file size > 2MB * Add the error message tests * Preserve the preview image aspect-ratio * Detect corrupted images * Fix failing unit tests * Address feedback: Type * Feedback: Create meaningful variables * Feedback: Make selector API more sensible * Prevent race condition Makes sure we save the settings completely before making other actions that also change settings otherwise, there could be race conditions. * Feedback: tighten up a type * Feedback: Fix inconsistency callback calls * 2. Add the rest 3 illustration settings (#40487) * Add the rest 3 illustration settings * Don't make the X icon feel lonely * Fix illustration widget saving * Fix type error * 3. Update the select UX to match new design (#40491) * Update the select UX to match new design * Move info dot next to file upload button * Simplify IllustrationWidget API * Update setting title copy * Clean up test comments * Feedback: Clarify `any` type * Feedback: Use shorthand object creation Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Feedback: Use global CSS glass instead of inlining values Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Feedback: Remove unnecessary curly brackets in JSX Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * 4. Connect illustrations to new setting values (#40139) * Wire landing page illustration to the setting value * Wire the unsubscribe page to the setting value * Prepare no rows error to be wired to the setting value * Wire no question results illustration to the setting value * Wire no search results illustration to setting value * Fix error from fixing conflict * Fix required unnecsseary prop on Image * Use Image component * Link dashboard card no results image to the setting value * Move the no data results to more a generic directory * Link collection picker no results image to the setting value * Make illustrations more accessible * Fix failed tests * Test unscribe page illustration + test no illustration * Add landing page tests * Simplify Cypress selectors * Refactor: Rename settings to match the new requirements No question data -> No Data No search results -> No object These changes are made so, these 2 settings are generic enough to include other illustrations later on. * Add no data illustration test * Add no object illustration tests * Fix unsubscribe page background style * Fix not able to build static viz * 5. Follow-up on milestone 1 (#40710) * Update custom background illustration scale behavior * Remove the need to put an SVG file in static folder * Fix test from rebasing off master with @testing-library/user-event upgrade --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-
- Apr 02, 2024
-
-
Denis Berezin authored
-
Maz Ameli authored
-
- Mar 28, 2024
-
-
Sloan Sparger authored
* upgrades @testing-library/user-event to v14, updates test to accomidate events always returning promises and other breaking API changes * Fixing up broken suites. Half way * rest of tests * green plz * Fix new entries of userEvent usage * unit test adjustments --------- Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com> Co-authored-by:
Uladzimir Havenchyk <uladzimir.dev@gmail.com>
-
Oisin Coveney authored
Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
Oisin Coveney authored
Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
- Mar 27, 2024
-
-
Sloan Sparger authored
-
John Swanson authored
Fixes #40328 [Our documentation](https://www.metabase.com/docs/latest/people-and-groups/managing#group-managers) states that: > Group managers can: > > - View all people in the Admin settings > People tab. This fixes enforcement to be aligned with the documentation. This behavior makes sense, because as the docs also state, Group Managers should be allowed to *add* people to the group they manage, which they can only do if they can see those people! Initially, I also removed a faulty test, which was described as: ``` ;; Non-segmented users are allowed to ask for a list of all of the users in the Metabase instance. Pulse email lists ;; are an example usage of this. Segmented users should not have that ability. Instead they should only see ;; themselves. This test checks that GET /api/user for a segmented user only returns themselves ``` but actually failed to test this in a relevant way (because it was testing the `GET /api/user` endpoint rather than the `GET /api/user/recipients` endpoint). The test had continued to pass only because the user was the only member of the group they managed. I initially thought this behavior wasn't desired, but as it turns out, it *is* in fact documented behavior to disallow sandboxed users from seeing any email suggestions. Investigating, I found that a bug was allowing sandboxed users to see all users on the `/api/user/recipients` endpoint if the user-visibility setting was set to `:all`. Thus, the second commit fixes the bug and re-adds the (fixed) test. A sandboxed user now only sees their own user when hitting `/api/user/recipients`.
-
Oisin Coveney authored
-
- Mar 26, 2024
-
-
Raphael Krut-Landau authored
* Revert "Remove Models from Browse data (#40108)" This reverts commit 45a2e868. * Make rtl friendly * Add 'no description' for blank-description models * Fix vertical position of collection header toggle * Move FixedSizeIcon into metabase/ui and increase height of empty state * Move FixedSizeIcon back into BrowseModels.styled.tsx * Localize 'No description' * Add comment * Fix type issue
-
Denis Berezin authored
* Minimal SDK code * Fix viz, styles * Move SDK code to enterprise folder * Fix files structure * Clean-up * Review fixes * Review fixes * Review fixes * Remove elementid * Reuse some options from main webpack config * Actualize package.json * Actualize package.json
-
Cam Saul authored
* Split from #40146: only the filter changes * Don't include format-rows changes here. * Test fixes
* Test fix * Misc test fixes * Test fix * Tweak SQL Server fix -
Oisin Coveney authored
-
- Mar 25, 2024
-
-
Alexander Solovyov authored
-