Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Nov 19, 2024
  2. Nov 18, 2024
    • Ngoc Khuat's avatar
    • Ryan Laurie's avatar
      Unverified
      320f0907
    • Ryan Laurie's avatar
      Add Hungarian language support (#50165) · 1a421b3a
      Ryan Laurie authored
      Unverified
      1a421b3a
    • Aleksandr Lesnenko's avatar
      Fix pie chart legend issues (#50116) · 42013c4e
      Aleksandr Lesnenko authored
      * remove LegendVertical logic that preserves legend width
      
      * memoize pie legend items
      
      * prevent pie from jumping when toggle legend
      
      * fix responsive legend logic, cleanup
      
      * drop hyphens from the pie legend (#29597)
      
      * eliminate flickering on render due to not having dimensions
      
      * shortcut
      
      * specs
      
      * test vertical layout has no hyphens
      
      * setup func
      
      * set explicit showLegend=true default
      Unverified
      42013c4e
    • Oleksandr Yakushev's avatar
      perf: Improve the performance of pivoted XLSX export (#50117) · 1ab3e4e9
      Oleksandr Yakushev authored
      
      * [xlsx-export] Cache the custom datetime formatter
      
      * [xlsx-export] Optimize functions in m.q_p.pivot.postprocess
      
      * cljfmt
      
      ---------
      
      Co-authored-by: default avatarAdam James <adam.vermeer2@gmail.com>
      Unverified
      1ab3e4e9
    • Cam Saul's avatar
      Revert remaining broken JAR path (#50162) · 0c442b62
      Cam Saul authored
      Unverified
      0c442b62
    • Ryan Laurie's avatar
      Update slack settings urls (#50042) · 4ab6c6eb
      Ryan Laurie authored
      Unverified
      4ab6c6eb
    • Jeff Bruemmer's avatar
      docs - sdk cli guide (#50098) · 2be5130e
      Jeff Bruemmer authored
      Unverified
      2be5130e
    • Nick Fitzpatrick's avatar
      search result order (#50048) · 21ae344b
      Nick Fitzpatrick authored
      Unverified
      21ae344b
    • Nicolò Pretto's avatar
      refactor(sdk): use ignore flag instead of mounted ref (#50069) · b3a46a77
      Nicolò Pretto authored
      * Revert "fix(sdk): put a bandage on the flashing error on static question in strict mode (#49659)"
      
      This reverts commit c57b3a38.
      
      * refactor(sdk): use ignore flag instead of mounted ref
      Unverified
      b3a46a77
    • Chris Truter's avatar
    • Kamil Mielnik's avatar
      Fix flaky x-rays test (#50131) · d291c150
      Kamil Mielnik authored
      * Fix flaky test
      
      * Add extra assertion
      
      * Reset hover state
      
      * Change order of assertions
      Unverified
      d291c150
    • lbrdnk's avatar
      Add temporal unit to display name (#48946) · 5203a15c
      lbrdnk authored
      * Add temporal unit to display name
      
      * Remove temporal unit adjustments from FE
      
      * formatColumn to displayNameForColumn
      
      * Factor out getFriendlyName
      
      * Adjust BE tests
      
      * Add require
      
      * Adjust FE unit tests
      
      * Adjust temporal-unit-parameters.cy.spec.js
      
      * Adjust dashboard-reproductions.cy.spec
      
      * Convert formatColumn occurrence
      
      * Adjust legacy display name logic generation
      
      After `getFriendlyName` was removed from FE, capitalization
      of display name should happen here. Logic is similar, should
      be adjusted prior merging the PR.
      
      * Adjust embedding-linked-filters.cy.spec.js
      
      * Adjust joins-reproductions.cy.spec.js
      
      * Adjust metrics-editing.cy.spec.js
      
      * Adjust timelines-question.cy.spec.js
      
      * Adjust offset.cy.spec.ts
      
      * TMP Avoid duplication of temporal unit in display name in MLv2 code
      
      * Probably FE fix: add default temporal bucket only if not present
      
      * WIP Add ends-with-temporal-unit? function
      
      Current strategy is to add temporal units to display names if same is not already present
      
      * Adjust display-name-method :metadata/column
      
      Append TU to display name only if different to what's already present
      
      * Adjust FE: show temporal unit that's present on field instead of default on hover on QueryColumnPicker element
      
      * Return also temporal-unit from visible-columns
      
      * Enable tempora-unit to be returned from previous-stage-or-source-visible-columns
      
      * WIP Adjust multi breakout multi stage e2e multiple-column-breakouts.cy.spec
      
      * Adjust multiple-column-breakouts.cy.spec.ts
      
      * It was not a bug.
      
      * Revert changes in _BaseBucketPickerPopover
      
      * Restore temporal-unit for next stages removal in stage.cljc
      
      * Add inherent-temporal-unit
      
      * Adjust display name temporal bucket logic
      
      * Rename to inherited-temporal-unit
      
      * Shutdown too broad display name capitalization
      
      * Eastwood
      
      * Adjust pivot-rows-order-test
      
      * Adjust pivot-non-numeric-values-in-aggregations
      
      * Adjust inherent to inherited
      
      * Rename to inherited
      
      * Add inherent-temporal-unit only to returned-columns
      
      * Update e2e/test/scenarios/dashboard-filters/temporal-unit-parameters.cy.spec.js
      
      * Update e2e/test/scenarios/question/multiple-column-breakouts.cy.spec.ts
      
      * Update consistent-date-formatting-test
      
      * Update dashboard/x-rays.cy.spec.js
      
      * Update waterfall.cy.spec.js
      
      * Return month default for default inherited-temporal-unit
      
      * Update reproductions-3.cy.spec.js
      
      * Update downloads/downloads.cy.spec.js
      
      * Update legend.cy.spec.js
      
      * Update pie_chart.cy.spec.js
      
      * Update click-behavior.cy.spec.js
      
      * Update embedding-linked-filters.cy.spec.js
      
      * Return QueryColumnPicker's condition to original state
      
      * Remove reundant export
      
      * Update e2e/test/scenarios/question/multiple-column-breakouts.cy.spec.ts
      
      * Comment
      
      * Update nested.cy.spec.js
      
      * Update e2e/test/scenarios/sharing/sharing-reproductions.cy.spec.js
      
      * Adjust to TS types
      
      * Adjust for cljfmt
      
      * Capitalize
      
      * Add propagation tests
      
      * Add inherited-temporal-unit propagation for expressions
      
      * Add default inherited-temporal-unit test cases
      
      * Add qp temporal-bucket-test ns
      
      * Simplify default unit logic
      
      * Comment
      
      * Use NULL_DISPLAY_VALUE
      
      * Comment
      
      * Comment
      
      * Comment
      
      * Comment
      
      * Comment
      
      * Comment
      
      * Remove redundant code (for now)
      
      * Update comments
      
      * Comment
      
      * Restore way too daring simplification
      
      * cljfmt
      
      * Adjust capitalize
      
      * Update comment
      
      * Update test
      
      * Address remarks in tests
      
      * Update test
      
      * Address remarks
      
      * typo
      Unverified
      5203a15c
    • Uladzimir Havenchyk's avatar
      fix: respect click behavior on public dashboards (#50067) · 552cf921
      Uladzimir Havenchyk authored
      * fix: pass noop as navigateToNewCardFromDashboard from public or embedded dashboard
      
      * add e2e test
      
      * rework a fix
      Unverified
      552cf921
    • Romeo Van Snick's avatar
      Fix button group breaking (#50064) · c8aa0a54
      Romeo Van Snick authored
      
      * Use Flex instead of Group for items in button
      
      * Allow column picker to stretch to match the height of the element
      
      * Fix height of data picker buttons
      
      * Make sure the whole button is clickable
      
      * Add e2e test for metabase/metabase#50038
      
      * Use correct id for issue in e2e test
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      
      ---------
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      Unverified
      c8aa0a54
    • Chris Truter's avatar
    • Kamil Mielnik's avatar
      Fix flaky test (#50077) · 17887dcd
      Kamil Mielnik authored
      Unverified
      17887dcd
    • Nicolò Pretto's avatar
      fix(49537): remove position relative from echarts tooltip container (#49964) · 7951b711
      Nicolò Pretto authored
      
      * attempt to fix 49537 by removing position relative from the tooltip
      container
      
      * Make echart tooltip container cover all iframe area
      
      * Update the E2E test
      
      * Update loki snapshots from CI
      
      * Re-enable echarts tooltip assertion.
      
      I couldn't find a better way to fail these assertions on the previous
      version of the code, but these assertions are better than nothing.
      
      ---------
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      Unverified
      7951b711
  3. Nov 16, 2024
  4. Nov 15, 2024
    • Case Nelson's avatar
      fix: Sync postgres materialized view fields (#50102) · 1ea55577
      Case Nelson authored
      * fix: Sync postgres materialized view fields
      
      Fixes: #49912
      
      * Disable test for redshift
      
      * Fix formatting
      Unverified
      1ea55577
    • adam-james's avatar
      XLSX Pivot Export - Initialize Pivot Table with Small Area Ref (#50060) · 520db041
      adam-james authored
      
      * XLSX Pivot Export - Initialize Pivot Table with Small Area Ref
      
      This PR changes the native pivot export so that we first initialize the pivot table with an area ref that's only the
      first 2 rows. Prior, I used `AreaReference/GetWholecolumn` which had the side effect of using lots of memory.
      
      I think this is related to how the Pivot Table's Cache is built up as you add rows/cols to the pivot definition. So,
      if you keep the area ref only as wide as the number of columns in the raw data, and just 2 rows, then the cache can
      stay small.
      
      After adding row/column data to the pivot table, you can then modify the area ref to be all rows in the relevant
      columns (`A:E` for example).
      
      This keeps the pivot-table object much smaller in size.
      
      * need the extra xml schemas to get this to work
      
      I'd like to try find a way around including this extra dep, it's a 13mb jar (ish), and I think that's a little bigger
      than I'd like
      
      * oops, didnt mean to have this in
      
      * Add test for pivot table initialization being fast and lean on memory
      
      * remove time based assertion, add comments in impl
      
      * cljfmt
      
      * fix test
      
      * Pesky little whitespace
      
      ---------
      
      Co-authored-by: default avatarOleksandr Yakushev <alex@bytopia.org>
      Unverified
      520db041
    • Noah Moss's avatar
    • Noah Moss's avatar
      Make sure the query to fetch result_metadata for native sandboxes doesn't use... · b9bc8c1c
      Noah Moss authored
      Make sure the query to fetch result_metadata for native sandboxes doesn't use the streaming results handler (#50049)
      
      Unverified
      b9bc8c1c
    • adam-james's avatar
      XLSX Pivot Exports Now Use The Sort Settings from Viz Settings (#50099) · 4d5aa805
      adam-james authored
      
      * XLSX Pivot Exports Now Use The Sort Settings from Viz Settings
      
      Prior to this PR, the xlsx pivot exports worked correctly except for the fact that no sorting (ascending or
      descending) was applied to the pivot rows or columns. Now, those settings are used when they exist.
      
      * only try to set sort when a correct setting exists
      
      * add ooxml-full dep for correct classes
      
      * Update src/metabase/query_processor/streaming/xlsx.clj
      
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      
      ---------
      
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      Unverified
      4d5aa805
    • Noah Moss's avatar
    • Case Nelson's avatar
      fix: MYSQL filter database with dbname in sync (#50091) · bc3c54b6
      Case Nelson authored
      Fixes: #50072
      
      When we `describe-fields` we are passing db details, but sometimes we
      have the database name in `dbname` rather than in `db` depending on the
      connection specs and possibly environment. So we check for both now.
      Unverified
      bc3c54b6
    • Dennis Schridde's avatar
      Omit database details from H2 dump when is_attached_dwh (#50036) · 13eb9ae2
      Dennis Schridde authored
      == Goal ==
      
      Hide attached DWH database details from anyone incl. admins:
      * Do not show them in the UI
      * Do not permit to change them
      * Do not serialize them
        - This is what we're adding for H2 snapshots (dumps) with this PR.
      
      The aim is that customers cannot gain access to (parts of) credentials,
      and they cannot break a feature they are paying for by changing
      connection details.
      
      == Implementation ==
      
      In 592360c9 I wrongly understood that
      database details would be omitted when dumping to H2, but this is only
      true for dumping H2 databases.
      
      Fix this by omitting database details also when dumping databases with
      `is_attached_dwh` set.
      
      == How to test ==
      
      To prepare, download a H2 JAR matching the H2 version used by Metabase:
      ```
      wget https://repo1.maven.org/maven2/com/h2database/h2/2.1.214/h2-2.1.214.jar
      ```
      
      If the H2 version does not match, you will get an error when trying to
      open the H2 shell:
      ```
      Exception in thread "main" org.h2.jdbc.JdbcSQLNonTransientConnectionException: Unsupported database file version or invalid file header in file "[REDACTED]" [90048-232]
      ```
      
      === New behaviour ===
      
      Setting the `is_attached_dwh` field hides the database details from H2 dumps:
      
      1. Configure a database as described in https://www.metabase.com/docs/latest/configuring-metabase/config-file#databases.
         - In addition to the fields you would normally set, also set
           `is_attached_dwh: true`.
         - This also works when adding this flag to a database that previously
           did not have this flag set.
      2. Start your Metabase instance.
      3. Run `${metabase} dump-to-h2 ./dump-file-h2` to create the H2 snapshot file.
      4. Run `java -cp h2-2.1.214.jar org.h2.tools.Shell -url "jdbc:h2:file:./dump-file-h2;ifexists=true"` to open a H2 shell.
      5. Verify that `SELECT name,details FROM metabase_database;` shows `{}` for the database you added in step 1
      
      === Original behaviour ===
      
      Behaviour without setting the `is_attached_dwh` field is unchanged:
      
      1. Configure a database as described in https://www.metabase.com/docs/latest/configuring-metabase/config-file#databases.
         - Only set the fields you would normally set.  Do not set
           `is_attached_dwh` (or set it to `false`).
      2. Start your Metabase instance.
      3. Run `${metabase} dump-to-h2 ./dump-file-h2` to create the H2 snapshot file.
      4. Run `java -cp h2-2.1.214.jar org.h2.tools.Shell -url "jdbc:h2:file:./dump-file-h2;ifexists=true"` to open a H2 shell.
      5. Verify that `SELECT name,details FROM metabase_database;` shows a non-empty object (i.e. not `{}`) for the database you added in step 1
      
      Fixes: 592360c9
      Closes: https://github.com/metabase/harbormaster/issues/5526
      Unverified
      13eb9ae2
Loading