Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Sep 12, 2024
  2. Sep 11, 2024
    • Raphael Krut-Landau's avatar
      ci(admin/performance): Test several caching strategies and methods (#45231) · 0833bebb
      Raphael Krut-Landau authored
      This PR tests that the user can assign any of three cache invalidation strategies ("duration", "adaptive", and "don't cache") to dashboards and questions. The tests check that the following things are true:
      * These strategies can be applied directly (via the sidebar)
      * Dashboards and questions can inherit their caching strategy from the database that underlies them
      * Dashboards and questions can inherit their caching strategy from the instance-wide default policy
      * When a question inside a dashboard has been assigned a strategy, this is overridden by the strategy assigned to the dashboard.
      
      What these tests do not examine:
      * the schedule strategy
      * the minimum query duration
      * edge-case strategies, such as very long durations or very large values for the adaptive strategy multiplier
      
      These may be addressed in follow-up work.
      
      Closes #45355
      Unverified
      0833bebb
    • Romeo Van Snick's avatar
      Always show metrics and models in menu (#47723) · e45836b8
      Romeo Van Snick authored
      * Alway render models and metrics links
      
      * Remove useHasMetrics and useHasModels helpers'
      
      * Update metrics test for metrics in sidebar
      
      * Fix unit test
      
      * Fix e2e tests
      Unverified
      e45836b8
    • Aleksandr Lesnenko's avatar
      fix static visualizations dashcard settings merging (#47789) · 1baad2a1
      Aleksandr Lesnenko authored
      * fix static visualizations dashcard settings merging
      
      * cleanup, fix types
      
      * drop an empty file
      Unverified
      1baad2a1
  3. Sep 10, 2024
  4. Sep 09, 2024
    • Aleksandr Lesnenko's avatar
      show additional columns in the tooltip (#47700) · 82b13c25
      Aleksandr Lesnenko authored
      * show additional columns in the tooltip
      
      * specs, tweaks
      
      * drop stack dependency
      
      * handle invalid columns
      
      * change copy
      Unverified
      82b13c25
    • Ryan Laurie's avatar
      Question Info + Settings Sidesheets (#47157) · b797ea4f
      Ryan Laurie authored
      * Question Settings Sidesheet (#47699)
      Unverified
      b797ea4f
    • Anton Kulyk's avatar
      Toggle series visibility from chart legend (pie charts) (#47581) · 41b4b687
      Anton Kulyk authored
      * Add series visibility props to `ChartWithLegend`
      
      * Mark pie slices as visible or hidden
      
      * Don't let to hide the last visible slice
      
      * Add space between legend dot and title
      
      * Fix legend dot outer circle is clipped by overflow
      
      * Use `ChartSettingSeriesOrder` for `pie.rows` setting
      
      * Actually hide slices and exclude from total calc
      
      * Don't show "0%" next to hidden slice legend items
      
      * Hide the "Other" slice
      
      * Make overflow slices popover interactive
      
      * Fix hover
      
      * Fix incorrect visibility state in legend popover
      
      * Add e2e test
      
      * Remove debug stuff
      
      * Fix hover and drill issues with slice index calc
      
      * Fix `pie.rows` ordering bug
      
      * Revert "Fix hover and drill issues with slice index calc"
      
      This reverts commit f104aaa5.
      
      * Fix hover and drill issues with slice index calc (2)
      
      `dataIndex` based approach
      
      * Use a special data key for the "Other" slice
      
      * Fixed viewport size in legend e2e test
      
      * Fix jumping legend width
      
      * Fix dot and label vertical alignment
      
      * Rework pie e2e test
      
      * Fix legend dot and label alignment
      Unverified
      41b4b687
    • Emmad Usmani's avatar
      handle errors without crashing in SliceNameWidget (#47729) · c1b850ef
      Emmad Usmani authored
      * handle errors without crashing in SliceNameWidget
      
      * add test
      Unverified
      c1b850ef
    • Phoomparin Mano's avatar
      fix(sdk): remove usage of legacy query in static question (#47727) · 4d9b144b
      Phoomparin Mano authored
      * remove legacy queries from static question in sdk
      
      * remove second query argument
      
      * remove the databaseSupportsPivotTables check from isSensible
    • Anton Kulyk's avatar
      Recalculate "graph.metrics" and "graph.dimensions" if empty (#47692) · 6cca5fb3
      Anton Kulyk authored
      * Add repro
      
      * Update `isValid` check for metrics and dimensions
      
      * Fix unit test
      Unverified
      6cca5fb3
    • Romeo Van Snick's avatar
      Browse metrics page (#47277) · d566fae9
      Romeo Van Snick authored
      
      * Add custom image for empty metrics
      
      * Add useFetchMetrics helper
      
      * Copy browse models page to metrics page
      
      * Add route for browse metrics page
      
      * Add useHasMetrics hook
      
      * Add link to browse metrics page to the sidebar
      
      * Simplify MetricsTable component
      
      * Render description markdown in table too
      
      * Add unit tests for browse metrics page
      
      * Remove custom padding
      
      * Fix line height of markdown cell
      
      * Add e2e tests for browse page
      
      * Fix metrics sorting
      
      * Fix types
      
      * Fix column widths and cell padding
      
      * Typo
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      
      * Remove name check
      
      * Simplify alphabet
      
      * Remove resetSnowplow
      
      * Use helper to get metric in table
      
      * Use MouseEvent from React directly
      
      * Use --mb-color-icon-primary
      
      * Test ellipsification of description
      
      * Simplify useHasMetrics
      
      * Move useHasMetrics MainNavBar
      
      * Merge sortMetrics and sortModels into sortCards
      
      * Fix metric default description
      
      * Extract SidebarSkeleton to a separate component
      
      * Test sorting via Collection too
      
      * Use ModelTableRow to fix cursor
      
      * Share more components between ModelsTable and MetricsTable
      
      * Use the same simplified structure in ModelsTable as for MetricsTable
      
      * Render block-level elements as inline so ellipsis detection works
      
      * Pick better testid for metric name
      
      * Remove delay
      
      * Avoid type specificty error in sortCards
      
      * Add test for not opening in new tab
      
      * Remove useFetchMetrics defaults
      
      * Fix unit test import
      
      * Test meta-click with cypress
      
      * Add comment on inline markdown elements
      
      * Use model-name test id
      
      * Use correct colors for icon
      
      * Remove delay from browse models page too
      
      * Make meta key in test platform-dependent
      
      * Fix hover color on metrics table
      
      * Add focus styling for celss in the models and metrics table
      
      * Use MarkdownPreview for table cells
      
      * Define --mb-color-icon-primary
      
      * Make the collection link take up the whole height of the cell
      
      * Remove tabIndex from table rows
      
      * Rename ModelsTable.module.css to BrowseTable.module.css
      
      * Rename CardsTable to BrowseTable
      
      * Remove single module.css class in favor of styled components
      
      * Allow customising allowed elements
      
      * Allow forcing all markdown on one line
      
      * Render bold and italics in markdown descriptions and move content onto one line
      
      * Fix legacy tooltip in test
      
      * Make sure getValueForSorting returns a string
      
      * Remove empty file
      
      * Remove icon for metrics in the table
      
      * Remove else statement.
      
      Co-authored-by: default avatarUladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
      
      * Remove async findBy where possible
      
      * Add github issue link for TODO item
      
      * Disambiguate between getMetricDescription type
      
      * Be explicit with sortModelOrMetric
      
      ---------
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      Co-authored-by: default avatarUladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
      Unverified
      d566fae9
  5. Sep 07, 2024
  6. Sep 06, 2024
  7. Sep 05, 2024
  8. Sep 04, 2024
  9. Sep 03, 2024
Loading