This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Sep 12, 2024
-
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Chris Truter authored
-
- Sep 11, 2024
-
-
Raphael Krut-Landau authored
This PR tests that the user can assign any of three cache invalidation strategies ("duration", "adaptive", and "don't cache") to dashboards and questions. The tests check that the following things are true: * These strategies can be applied directly (via the sidebar) * Dashboards and questions can inherit their caching strategy from the database that underlies them * Dashboards and questions can inherit their caching strategy from the instance-wide default policy * When a question inside a dashboard has been assigned a strategy, this is overridden by the strategy assigned to the dashboard. What these tests do not examine: * the schedule strategy * the minimum query duration * edge-case strategies, such as very long durations or very large values for the adaptive strategy multiplier These may be addressed in follow-up work. Closes #45355
-
Romeo Van Snick authored
* Alway render models and metrics links * Remove useHasMetrics and useHasModels helpers' * Update metrics test for metrics in sidebar * Fix unit test * Fix e2e tests
-
Aleksandr Lesnenko authored
* fix static visualizations dashcard settings merging * cleanup, fix types * drop an empty file
-
- Sep 10, 2024
-
-
John Swanson authored
* Move stale endpoint to /ee/stale/${collection-id} It's an enterprise-only endpoint, so it makes sense to put the whole thing under enterprise. * refactors ui to use ee stale endpoint lint fixes, change endpoint location fix failure e2e test * Fix endpoint location --------- Co-authored-by:
Sloan Sparger <sloansparger@gmail.com>
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Romeo Van Snick authored
* Add metric actions * Fix dot menu width * Refetch card when it's being (un-)bookmarked * Add tests for metric dot menu * Make sure bookmarked metric appears in sidebar * Make sure restoring a metric works * Add more tests for readonly users * Use non-root collection for metric test * Render Scalar metric values * Add tooltip * Render Scalar metric value using formatValue * Move isMetricScalar and getMetricValue to utils * Add e2e tests for scalar metric values * Fix unit tests * Add card query endpoint to metabase/api * Use card query from api instead of question loader * Add test for non-numeric scalar metric * Move providesCardQueryTag to utils * Use skipToken for query * Clean up getDatasetScalarValueForMetric
-
Alexander Polyankin authored
-
Romeo Van Snick authored
* Add metric actions * Fix dot menu width * Refetch card when it's being (un-)bookmarked * Add tests for metric dot menu * Make sure bookmarked metric appears in sidebar * Make sure restoring a metric works * Add more tests for readonly users * Use non-root collection for metric test
-
- Sep 09, 2024
-
-
Aleksandr Lesnenko authored
* show additional columns in the tooltip * specs, tweaks * drop stack dependency * handle invalid columns * change copy
-
Ryan Laurie authored
* Question Settings Sidesheet (#47699)
-
Anton Kulyk authored
* Add series visibility props to `ChartWithLegend` * Mark pie slices as visible or hidden * Don't let to hide the last visible slice * Add space between legend dot and title * Fix legend dot outer circle is clipped by overflow * Use `ChartSettingSeriesOrder` for `pie.rows` setting * Actually hide slices and exclude from total calc * Don't show "0%" next to hidden slice legend items * Hide the "Other" slice * Make overflow slices popover interactive * Fix hover * Fix incorrect visibility state in legend popover * Add e2e test * Remove debug stuff * Fix hover and drill issues with slice index calc * Fix `pie.rows` ordering bug * Revert "Fix hover and drill issues with slice index calc" This reverts commit f104aaa5. * Fix hover and drill issues with slice index calc (2) `dataIndex` based approach * Use a special data key for the "Other" slice * Fixed viewport size in legend e2e test * Fix jumping legend width * Fix dot and label vertical alignment * Rework pie e2e test * Fix legend dot and label alignment
-
Emmad Usmani authored
* handle errors without crashing in SliceNameWidget * add test
-
Phoomparin Mano authored
* remove legacy queries from static question in sdk * remove second query argument * remove the databaseSupportsPivotTables check from isSensible
-
Anton Kulyk authored
* Add repro * Update `isValid` check for metrics and dimensions * Fix unit test
-
Romeo Van Snick authored
* Add custom image for empty metrics * Add useFetchMetrics helper * Copy browse models page to metrics page * Add route for browse metrics page * Add useHasMetrics hook * Add link to browse metrics page to the sidebar * Simplify MetricsTable component * Render description markdown in table too * Add unit tests for browse metrics page * Remove custom padding * Fix line height of markdown cell * Add e2e tests for browse page * Fix metrics sorting * Fix types * Fix column widths and cell padding * Typo Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Remove name check * Simplify alphabet * Remove resetSnowplow * Use helper to get metric in table * Use MouseEvent from React directly * Use --mb-color-icon-primary * Test ellipsification of description * Simplify useHasMetrics * Move useHasMetrics MainNavBar * Merge sortMetrics and sortModels into sortCards * Fix metric default description * Extract SidebarSkeleton to a separate component * Test sorting via Collection too * Use ModelTableRow to fix cursor * Share more components between ModelsTable and MetricsTable * Use the same simplified structure in ModelsTable as for MetricsTable * Render block-level elements as inline so ellipsis detection works * Pick better testid for metric name * Remove delay * Avoid type specificty error in sortCards * Add test for not opening in new tab * Remove useFetchMetrics defaults * Fix unit test import * Test meta-click with cypress * Add comment on inline markdown elements * Use model-name test id * Use correct colors for icon * Remove delay from browse models page too * Make meta key in test platform-dependent * Fix hover color on metrics table * Add focus styling for celss in the models and metrics table * Use MarkdownPreview for table cells * Define --mb-color-icon-primary * Make the collection link take up the whole height of the cell * Remove tabIndex from table rows * Rename ModelsTable.module.css to BrowseTable.module.css * Rename CardsTable to BrowseTable * Remove single module.css class in favor of styled components * Allow customising allowed elements * Allow forcing all markdown on one line * Render bold and italics in markdown descriptions and move content onto one line * Fix legacy tooltip in test * Make sure getValueForSorting returns a string * Remove empty file * Remove icon for metrics in the table * Remove else statement. Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com> * Remove async findBy where possible * Add github issue link for TODO item * Disambiguate between getMetricDescription type * Be explicit with sortModelOrMetric --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
- Sep 07, 2024
-
-
Oisin Coveney authored
* Fix entity ID status * bump ci --------- Co-authored-by:
Bryan Maass <bryan.maass@gmail.com>
-
- Sep 06, 2024
-
-
Oisin Coveney authored
-
Ryan Laurie authored
* Basic Sidesheet Components * sidesheet samples and storybook stories * add unit tests and fix more imports * small styling updates * small styling updates * fix tests * Update frontend/src/metabase/common/components/Sidesheet/SidesheetCard.tsx Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com> * fix type problem --------- Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com>
-
Alexander Polyankin authored
-
Alexander Polyankin authored
* Add metric sidebar * Add tests * Rename ResizableNotebook to DatasetNotebook * Add tests * Add tests * Add tests * Add tests
-
Nicolò Pretto authored
* fix(sdk) default font on not working * fix initial state for the sdk
-
Ryan Laurie authored
* make custom disabled state more specific than transparent style * make it less nesty
-
- Sep 05, 2024
-
-
Oisin Coveney authored
-
Alexander Polyankin authored
-
Nicolò Pretto authored
* newsletter-toggle-clicked event * use ValidateEvent, * rename event -> simple_event and trackEvent -> trackSimpleEvent * use the renamed trackSimpleEvent function
-
Dennis Schridde authored
The way this was implemented, it also hid the section for management of uploaded CSV files. Further, admins might want to intentionally switch from uploading to the data warehouse provided by Metabase to one of their own. This reverts commit fbaf58ad. References: https://github.com/metabase/harbormaster/issues/5121 References: https://metaboat.slack.com/archives/C032LFJFANL/p1725296255637989
-
Romeo Van Snick authored
* Rename 'Date Filter' to 'All Options' in field filters * Fix i18n test
-
- Sep 04, 2024
-
-
Aleksandr Lesnenko authored
* fix hidden pivot table scroll bar in QB * Update Loki Snapshots * Update Loki Snapshots --------- Co-authored-by:
Metabase Automation <github-automation@metabase.com>
-
Emmad Usmani authored
-
Nicolò Pretto authored
* rename event -> simple_event and trackEvent -> trackSimpleEvent * add empty line at the end of the file Co-authored-by:
Thomas Schmidt <thomas@metabase.com> --------- Co-authored-by:
Thomas Schmidt <thomas@metabase.com>
-
Nick Fitzpatrick authored
-
Aleksandr Lesnenko authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Add E2E tests * Default locked parameter value to `[]` * Fix unit tests
-
- Sep 03, 2024
-
-
Oisin Coveney authored
-
Alexander Polyankin authored
-