This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Aug 02, 2024
-
-
Jeff Bruemmer authored
-
Jeff Bruemmer authored
* link fixes * more links
-
Uladzimir Havenchyk authored
* do not update size if width or height is 0 * add a comment
-
Alexander Solovyov authored
-
Nicolò Pretto authored
* update the UI of the downloads toggle to make it look like the others in the page * make unit tests pass * make e2e pass
-
Sloan Sparger authored
* updates the ordering of create queries permissions options so that granular permissions is the last option * fix unit test * move granular option above no
-
Nicolò Pretto authored
* update static_embed_code_copied to use downloads (#45944) * copy schema file for better diff * adds downloads field to appearance in embed_flow schema * update event to send `downloads` parameter, update e2e tests * fix test for dwonloads: false * fix: use correct schema version for embed flow analytics (#46053) * update `dashboard_pdf_exported` and use it in embedding context (#46076) * copy schema for better diff * adds `dashboard_accessed_via` to the `dashboard_pdf_exported` event * download_results_clicked event (#46132) * adds download_results_clicked event + e2e tests * make strings nullable * adds maxLength * switch back to if/then as it seems more readable * refactor: use the resourceType to determine the download params instead of re-doing the logic * fix ''question' is possibly 'undefined'.' * split resource_type into resource_type and accessed_via to also consider interactive-embedding and sdk * edit comment * adds test for ad-hoc-question * Update frontend/src/metabase/query_builder/actions/downloading.ts Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * makes describe message more consistent * "else if" => if * fix describe block name * convert downloads event to use enum for download_type and export_type * resource_type should be an enum too * fix line added in the wrong place during merges --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * Update frontend/src/metabase/public/components/EmbedFrame/EmbedFrame.tsx Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * adds enum schema to dashboard_accessed_via * fix accessed_via for sdk embeds * update comments to explain why we send 0 when dashboardId is null * only send dashboard_id as a number when it is a number, as expected by snowplow * remove un-needed async/await from saveAsPDF function * rename frontend/src/metabase/redux/downloading-analytics.ts -> frontend/src/metabase/redux/downloads-analytics.ts * fix cy.log message --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
John Swanson authored
This reverts commit c7a5aee1.
-
Noah Moss authored
-
Chris Truter authored
-
Nicolò Pretto authored
* update embed frame pdf button colors to use --mb-color- vars * change download pdf button color to brand color * testing adding the images that actually differ
-
Jeff Bruemmer authored
-
Roman Abdulmanov authored
-
Ngoc Khuat authored
-
Chris Truter authored
-
Alexander Solovyov authored
Previously we unpacked everything and picked up first entry as the directory containing the data. This works well when archives are passed as is. However, if a user unpacks and then packs an archive, there is a good chance that some hidden directories will appear - and they are first in order. So we skip those right now, and additionally check known markers of the serialization data directory.
-
Nemanja Glumac authored
-
- Aug 01, 2024
-
-
Emmad Usmani authored
* fix lost settings * add e2e test * trigger ci
-
Emmad Usmani authored
* fix pie border missing in batik static viz * refactor args * fix typo
-
Ryan Laurie authored
* fix db connection form icons * fix db connection form icons * appease typescript
-
Oreon Lothamer authored
-
lbrdnk authored
* Avoid adding temporal-unit to lhs cols * Use :default temporal-unit * Simplify logic, update comments * Update substitute-field-filter-test * Update align-temporal-unit-with-param-type-test * Update field-filter-date-test * Use end-excludding gte lt filter for DateTime fields * Update substitute-field-filter-test * Update align-temporal-unit-with-param-type-test * Update field-filter-date-test * Update bigquery test + comment * Update date-str->qp-aware-offset-dt * Add guard for unexpected date string format This is just for the completeness, I haven't encountered it. * Address review remarks * Update comment
-
Nick Fitzpatrick authored
* dismiss permissions modal regardless of network request * Spelling is hard
-
Ryan Laurie authored
* add auto-release patch job * better error handling * update schedule * address review feedback
-
Chris Truter authored
* Squash * Clean up query modifier for validating card references (#46283) * Fixup bad git merge on test expectation * Tweak docstrings and de-densify logic
-
github-automation-metabase authored
* Add v0.49.22 to the list of releases * Update releases.md --------- Co-authored-by:
Metabase bot <metabase-bot@metabase.com> Co-authored-by:
Alex Yarosh <alexandra@metabase.com>
-
lbrdnk authored
* Add :relative-time-interval mbql function * Add relativeDateFilterPartsRelativeTimeInterval * Update display-name-method :relative-time-interval * Update desugar-relative-time-interval * Define relative-time-filter op * Add or update tests * Update tests * Update display-name-method * Update test * Fix positive relative-time-interval shift
-
Ngoc Khuat authored
-
- Jul 31, 2024
-
-
Emmad Usmani authored
* fix pie chart total graphic not being removed * add e2e test
-
John Swanson authored
* Allow filtering on collection * Add `effective_ancestors` to collection data Note: I removed the `qv=` comparator. I think it'.s better to be more explicit about what exactly we're asserting. In particular, I hadn't updated the `:count` when we were filtering on collection type, so the count was still the total for *every* collection even though the results were being restricted by the collection. However the `qv=-data` function was still reporting that everything was OK, because it was accounting for other data from the App DB by just asserting that the count we'd specified was lower than the actual count. I'd argue it's better for tests to fail locally because I have garbage in my app DB (which I can clean up) than succeed when they really shouldn't. * Consolidate effective ancestors For the Search API, we're currently returning slightly different ancestors: - it never has the Root Collection, and - the ancestors don't have a `personal_owner_id` We could change the API (and maybe will soon - it seems pretty unexpected to have `effective_ancestors` sometimes act one way and sometimes act another) but for now we can just reshape things to look the same as they did before, while using the same code under the hood.
-
Gustavo Saiani authored
-
Noah Moss authored
Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com>
-
Emmad Usmani authored
* echarts pie * setup rendering pipeline for static pie chart (#43547) * setup rendering pipeline for static pie chart * remove more donut code from BE * compute viz settings for static pie chart (#43548) * compute viz settings for static pie chart * create chartModel for pie chart (#43549) * create chartModel for pie chart * render static pie chart (#43550) * render static pie chart * render static pie chart legend (#43551) * disable animation * alter static-viz pie chart be tests to account for echarts-impl The old implementation had a different implementation for legends, separate from the 'categorical/donut' js render. Echarts nicely combines the legend into the pie render, so we don't need to worry about that stuff anymore. Instead, I've written a simple set of assertions on the echarts pie implementation now. * Get rid of this test that was attempting to use old code path * echarts pie * One last spot where we don't need old pie stuff anymore. * add loki specs * save snapshots * fix small slices disappearing * update snapshots * add repro story for exteremely small slice * add snapshot * fix rounded total * fix percent formatting in legend * fix date dimension formatting * fix binned and relative date dimension labels on legend * add specs and snapshots for null and unaggregated dimensions * hide overlaping labels on chart * fix null dimension color * show error when metric column has a negative value * move legend to botom * make dot margin smaller * add columns to legend * sort legend vertically * dont use grid if only one row for legend * never hide legend in static viz * fix empty column culling * show single legend item * add long dimension name story * fix long dimension name in legend * right justify percentages in legend * remove negative error and re-add stories * handle negative values * create chart definition for dynamic pie chart * render chart with responsiveness * add comment for borderWidth calculation * center legend * fix legend centering * add story for missing currency formatting * fix missing currency formatting * fix graalvm crashing * fix column settings computation * add another currency formatting repro * fix wrong order of col settings computations * convert colors to hex * fix colors missing from viz settings * temp todo comment * fix colors in dynamic viz * update snapshots * fix crashing due to invalid dimension/metric setting * fix chart crashing for boolean dimension with labels on chart * add repro * fix regression in label formatting * fix labels on small slices * update specs * emphasis state for slice hover * recreate old label hiding logic * include height measurement in getIsLabelVisible * move d3 slices to chart model * fix labels on static viz * wip basic hover state and tooltip * fix emphasis style getting stuck by memoizing everything * update total display value * fix stuck emphasis by setting notMerge to false for pie only * handle other slice in tooltip * fix bugs in total graphic * use OTHER_SLICE_KEY const in static viz legend * implement legend and connect to hover state * implement click actions * fix slice not clickable * handle all zero slices * add repro * update specs * update pie_chart.cy.spec.js * update chart_drill.cy.spec.js * add repro for single column legend * use minimum 2 legend columns * fix legend text overlap * use more margin for single row legend * update specs * add repro for 28568 * add repro for 38424 * fix percent label not showing on large slices * hide total text when chart is small * replace comment about animations * show warning for mixed positive and negative values * delete old chart files * fix type errors * update d3 import * update specs * remove branch from uberjar.yml * dont put single slice into other * fix lint errors and pie render test * update more d3 imports * remove unused settings * revert preview-card-width change * remove unused import * remove majorWidth option from formatting * use debounceLeading refresh mode in ChartWithLegend * remove TOTAL_GRAPHIC_OPTION constant * delete unit test for pie chart * fix failing test by doing set comparison instead * fix typo in comment * remove SUNBURST_SERIES_OPTION constant * fix lint by removing unused eslint-disable * move default color computation to getValue * fix static pie test to show that we will always render the legend * update pie border color for night mode and embedding * fix styles for embedding case and add stories * skip embedding stories --------- Co-authored-by:
Adam James <adam.vermeer2@gmail.com>
-
adam-james authored
Since I set auto-merge to #45691, I missed some bits of review feedback. Luckily, nothing was blocking, so these are small readability/docs changes
-
Raphael Krut-Landau authored
-
Uladzimir Havenchyk authored
* cleanup webpack config * drop eslint-loader
-
Jeff Bruemmer authored
-
Alex Yarosh authored
-
Uladzimir Havenchyk authored
-