Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 02, 2024
  2. Aug 01, 2024
  3. Jul 31, 2024
    • Emmad Usmani's avatar
      fix pie chart total graphic not being removed (#46349) · bfc6838a
      Emmad Usmani authored
      * fix pie chart total graphic not being removed
      
      * add e2e test
      bfc6838a
    • John Swanson's avatar
      Some improvements to the REST API for query field validation (#46024) · c4196d99
      John Swanson authored
      * Allow filtering on collection
      
      * Add `effective_ancestors` to collection data
      
      Note: I removed the `qv=` comparator. I think it'.s better to be more explicit
      about what exactly we're asserting. In particular, I hadn't updated the
      `:count` when we were filtering on collection type, so the count was
      still the total for *every* collection even though the results were being
      restricted by the collection. However the `qv=-data` function was still
      reporting that everything was OK, because it was accounting for other
      data from the App DB by just asserting that the count we'd specified was
      lower than the actual count. I'd argue it's better for tests to fail
      locally because I have garbage in my app DB (which I can clean up) than
      succeed when they really shouldn't.
      
      * Consolidate effective ancestors
      
      For the Search API, we're currently returning slightly different
      ancestors:
      
      - it never has the Root Collection, and
      
      - the ancestors don't have a `personal_owner_id`
      
      We could change the API (and maybe will soon - it seems pretty
      unexpected to have `effective_ancestors` sometimes act one way and
      sometimes act another) but for now we can just reshape things to look
      the same as they did before, while using the same code under the hood.
      c4196d99
    • Gustavo Saiani's avatar
    • Noah Moss's avatar
      d55b6a31
    • Emmad Usmani's avatar
      migrate pie chart to echarts (#43555) · 4ec1fd88
      Emmad Usmani authored
      
      * echarts pie
      
      * setup rendering pipeline for static pie chart (#43547)
      
      * setup rendering pipeline for static pie chart
      
      * remove more donut code from BE
      
      * compute viz settings for static pie chart (#43548)
      
      * compute viz settings for static pie chart
      
      * create chartModel for pie chart (#43549)
      
      * create chartModel for pie chart
      
      * render static pie chart (#43550)
      
      * render static pie chart
      
      * render static pie chart legend (#43551)
      
      * disable animation
      
      * alter static-viz pie chart be tests to account for echarts-impl
      
      The old implementation had a different implementation for legends, separate from the 'categorical/donut' js
      render. Echarts nicely combines the legend into the pie render, so we don't need to worry about that stuff anymore.
      
      Instead, I've written a simple set of assertions on the echarts pie implementation now.
      
      * Get rid of this test that was attempting to use old code path
      
      * echarts pie
      
      * One last spot where we don't need old pie stuff anymore.
      
      * add loki specs
      
      * save snapshots
      
      * fix small slices disappearing
      
      * update snapshots
      
      * add repro story for exteremely small slice
      
      * add snapshot
      
      * fix rounded total
      
      * fix percent formatting in legend
      
      * fix date dimension formatting
      
      * fix binned and relative date dimension labels on legend
      
      * add specs and snapshots for null and unaggregated dimensions
      
      * hide overlaping labels on chart
      
      * fix null dimension color
      
      * show error when metric column has a negative value
      
      * move legend to botom
      
      * make dot margin smaller
      
      * add columns to legend
      
      * sort legend vertically
      
      * dont use grid if only one row for legend
      
      * never hide legend in static viz
      
      * fix empty column culling
      
      * show single legend item
      
      * add long dimension name story
      
      * fix long dimension name in legend
      
      * right justify percentages in legend
      
      * remove negative error and re-add stories
      
      * handle negative values
      
      * create chart definition for dynamic pie chart
      
      * render chart with responsiveness
      
      * add comment for borderWidth calculation
      
      * center legend
      
      * fix legend centering
      
      * add story for missing currency formatting
      
      * fix missing currency formatting
      
      * fix graalvm crashing
      
      * fix column settings computation
      
      * add another currency formatting repro
      
      * fix wrong order of col settings computations
      
      * convert colors to hex
      
      * fix colors missing from viz settings
      
      * temp todo comment
      
      * fix colors in dynamic viz
      
      * update snapshots
      
      * fix crashing due to invalid dimension/metric setting
      
      * fix chart crashing for boolean dimension with labels on chart
      
      * add repro
      
      * fix regression in label formatting
      
      * fix labels on small slices
      
      * update specs
      
      * emphasis state for slice hover
      
      * recreate old label hiding logic
      
      * include height measurement in getIsLabelVisible
      
      * move d3 slices to chart model
      
      * fix labels on static viz
      
      * wip basic hover state and tooltip
      
      * fix emphasis style getting stuck by memoizing everything
      
      * update total display value
      
      * fix stuck emphasis by setting notMerge to false for pie only
      
      * handle other slice in tooltip
      
      * fix bugs in total graphic
      
      * use OTHER_SLICE_KEY const in static viz legend
      
      * implement legend and connect to hover state
      
      * implement click actions
      
      * fix slice not clickable
      
      * handle all zero slices
      
      * add repro
      
      * update specs
      
      * update pie_chart.cy.spec.js
      
      * update chart_drill.cy.spec.js
      
      * add repro for single column legend
      
      * use minimum 2 legend columns
      
      * fix legend text overlap
      
      * use more margin for single row legend
      
      * update specs
      
      * add repro for 28568
      
      * add repro for 38424
      
      * fix percent label not showing on large slices
      
      * hide total text when chart is small
      
      * replace comment about animations
      
      * show warning for mixed positive and negative values
      
      * delete old chart files
      
      * fix type errors
      
      * update d3 import
      
      * update specs
      
      * remove branch from uberjar.yml
      
      * dont put single slice into other
      
      * fix lint errors and pie render test
      
      * update more d3 imports
      
      * remove unused settings
      
      * revert preview-card-width change
      
      * remove unused import
      
      * remove majorWidth option from formatting
      
      * use debounceLeading refresh mode in ChartWithLegend
      
      * remove TOTAL_GRAPHIC_OPTION constant
      
      * delete unit test for pie chart
      
      * fix failing test by doing set comparison instead
      
      * fix typo in comment
      
      * remove SUNBURST_SERIES_OPTION constant
      
      * fix lint by removing unused eslint-disable
      
      * move default color computation to getValue
      
      * fix static pie test to show that we will always render the legend
      
      * update pie border color for night mode and embedding
      
      * fix styles for embedding case and add stories
      
      * skip embedding stories
      
      ---------
      
      Co-authored-by: default avatarAdam James <adam.vermeer2@gmail.com>
      4ec1fd88
    • adam-james's avatar
      Quick Followup to Pull #45691 (#46286) · e8d5dac2
      adam-james authored
      Since I set auto-merge to #45691, I missed some bits of review feedback.
      Luckily, nothing was blocking, so these are small readability/docs changes
      e8d5dac2
    • Raphael Krut-Landau's avatar
    • Uladzimir Havenchyk's avatar
      dx: drop eslint-loader (#46279) · 9f6d99b5
      Uladzimir Havenchyk authored
      * cleanup webpack config
      
      * drop eslint-loader
      9f6d99b5
    • Jeff Bruemmer's avatar
      update firefox link (#46330) · d9eb14e8
      Jeff Bruemmer authored
      d9eb14e8
    • Alex Yarosh's avatar
      docs: import clarification (#46328) · e33c21ff
      Alex Yarosh authored
      e33c21ff
    • Uladzimir Havenchyk's avatar
Loading