This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Aug 12, 2024
-
-
Oisin Coveney authored
-
Duncan Mak authored
* Add testcase from https://github.com/metabase/metabase/issues/43915 * Try a custom formatter if the default formatter for OffsetDateTime doesn't work * Add testcase * Make auxillary formatter private * Catch a more specific exception * Throw IllegalArgumentException on invalid dates * Use strict resolver and fix test * Empty commit to assign credit where it's due --------- Co-authored-by:
Chris Truter <chris@metabase.com>
-
adam-james authored
* Dowload Row Limit Env Var Adds `MB_DOWNLOAD_ROW_LIMIT` to enable changing the row limit on downloads and alert/subscription attachments (not the rendered tables, but the .csv, etc.). Based on: #44982 (Thanks, @r-kot) Partially implements: #28144 The difference in this PR compared to #44982 is that the download limit applies to all downloads, the only exception being when the limit is above `qp.i/absolute-max-results` (1048575, based on Excel's limitation); in such a case, the user supplied limit is only used if the download is csv or json, and `qp.i/absolute-max-results` is used for xlsx. This PR also fixes alert/subscription attachment limits; prior to this, they were set to the in-app limit of 2000 rows, but now they will follow the user supplied download-row-limit. This PR also adds a test to the downloads-and-exports test namespace, confirming that they follow the supplied limit, or the max limit if none is supplied. * add test confirming the default limit works * fix test to use the download-row-limit * address review feedback * Update src/metabase/public_settings.clj Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com> * add test covering case where download-row-limit is unset --------- Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com>
-
Uladzimir Havenchyk authored
-
Kamil Mielnik authored
* Refactor filter utils to TS * Remove type casts * Improve dimension instantiation * Fix typing
-
Chris Truter authored
-
Denis Berezin authored
-
Uladzimir Havenchyk authored
-
Alexander Solovyov authored
-
Nick Fitzpatrick authored
* Revert "Remove unused humanizeCoercionStrategy and its test suite (#36136)" This reverts commit 5375347e. * humanize coercion strategies, add e2e test * unit test adjustment * pr feedback
-
Uladzimir Havenchyk authored
* dx: raise an error if lodash is used * fix lint errors * use ts-deepmerge * don't throw an error * use correct type * use merge form icepick
-
Chris Truter authored
-
Alexander Solovyov authored
-
Oisin Coveney authored
-
Oisin Coveney authored
-
Ngoc Khuat authored
-
- Aug 10, 2024
-
-
Oleksandr Yakushev authored
-
Aleksandr Lesnenko authored
* conditional dismissal step * check for download status in the container * try fixing flakes again * try again * chartPathWithFillColor already verifies chart has been rendered
-
- Aug 09, 2024
-
-
Nemanja Glumac authored
* Introduce subpath-safe URL utils * Open data source links from a notebook safely on a subpath * Open browse model links safely on a subpath * Uniform naming * Use the existing URL helper * Trim url * Add unit tests * Add one more test case * Fix test name
* Make URLs non-optional strings -
adam-james authored
* Export Formatting Correctness WIP Several bugs exist around the correctness of export formatting, this aims to fix them. Fixes #27374 When a model has viz settings/metadata changed after save, the download won't incorporate said changes. At least it's clear that scale doesn't work. * number formatter merges settings from columns too * column formatting on aggregated cols works in xlsx now too * fixes 43040 by grabbing global-type-settings in csv formatter
-
github-automation-metabase authored
-
Raphael Krut-Landau authored
fix(admin/performance): Ensure that the tab's title (e.g. Database caching) and 'Performance' are visible in document title (#46602)
-
Oleksandr Yakushev authored
-
Oisin Coveney authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Refactor * Fix wrong colors when passing empty SDK `colors` * Clean up CSS custom properties * Add missing color mapping to the SDK * Add missing colors to the main app * Only override additional dynamic colors when values are passed * Fix unit tests * Address review Co-authored-by:
Phoomparin Mano <poom@metabase.com> --------- Co-authored-by:
Phoomparin Mano <poom@metabase.com>
-
Uladzimir Havenchyk authored
* dx: get rid of csp errors in TableInteractive * get rid of csp errors in mantine
-
Romeo Van Snick authored
Move the compare to the past aggregation to the bottom of the dropdown and hide it when no temporal breakouts are available (#46500) * Move the compare to the past aggregation to the bottom of the dropdown * Fix missing icon property * Hide 'Compare to the past' when there are no temporal columns * Update copy in tests * Add test for questions with no temporal columns * Fix unit test for AggregationPicker * Allow adding a compare aggregation when the first breakout is not temporal too * Rename to 'Compare to the past' in custom column action * Rename to 'Compare to the past' in column drill * Update copy in tests for actions and drills * Move canAddTemporalAggregation to CompareAggregation utils * Use aggregations from the query always * Remove unnecessary displayName check
-
- Aug 08, 2024
-
-
adam-james authored
* Last Used Param Value doesn't fill in with default value if cleared Fixes #46368 The Last used parameter value is cleared when the frontend sends `nil` as the parameter's value. This works except in cases where a user clears a parameter with a default value. In this case, we want to indicate that the parameter is cleared, so we store `nil` in the appdb in such a case. * Update src/metabase/query_processor/dashboard.clj Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * add assertion showing that 'nil' with default is still stored --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
Ryan Laurie authored
* log full version history * remove test code
-
Case Nelson authored
Fixes: #46558 In #45575 we introduced casting uuid fields for drilldowns. However we failed to include a check that the rhs was itself another field of uuid type and so no casting should occur. This broke joins on models when the database_type of the field may not be known.
-
Aleksandr Lesnenko authored
* fix downloads e2e flakes * fix flake
-
Nemanja Glumac authored
* MS2 follow up: add more unit tests for joins * Address review comments re: variable naming
-
Nemanja Glumac authored
* Add tooltip to the data step cell * Conditionally display tooltip * Add unit tests for the data step * Add unit tests for the join step * Move the abstraction to the NotebookDataPicker * Cover the tooltip behavior with E2E test * Update test
-
Emmad Usmani authored
* automatically use compact formatting for pie chart total * add story and snapshots
-
Mahatthana (Kelvin) Nomsawadi authored
-
Nick Fitzpatrick authored
* useLogRecentItem * updating tests * unit tests * e2e test * PR Feedback * log questions / models * Accept :dataset instead of :model * Adding e2e test for recent activity datasets, reverting 'await' changes * Add e2e for collection moving error --------- Co-authored-by:
dan sutton <dan@dpsutton.com>
-
Oisin Coveney authored
-
Uladzimir Havenchyk authored
-
Oisin Coveney authored
-
Kamil Mielnik authored
* Add test boilerplate * Rename test and add assertions * Add broken test for models * Add unit of time tests * Deduplicate code * Add date parameter tests * Add test for multiple stages * Fix model test setup and refactor getColumnsInfos * Remove redundant assertions * Format codee * Extract createQuestion and createModel * Add unit of time model tests * Add test for model * Extract constants * Add a warning * Build dataset queries with mbql * Introduce queryOrders * Revert redundant change * Improve Question creation
-