This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Oct 14, 2023
-
-
Tim Macdonald authored
-
- Oct 13, 2023
-
-
Jerry Huang authored
-
Denis Berezin authored
* Add Sort drill * Fix unit tests * Add more unit/integration tests * Add more unit/integration tests * Add more unit/integration tests
-
Anton Kulyk authored
* Collapse temporal units list * Extract `MoreButton` component * Simplify conditions * Make `isInitiallyExpanded` a bit more clear * Use `INITIALLY_VISIBLE_ITEMS_COUNT` in tests * Fix typos * Remove comment * Update popover size and spacing * Remove outdated test * Update E2E tests * Add hover state to the "More" button * Disable hover transition
-
Anton Kulyk authored
-
Cam Saul authored
-
John Swanson authored
This namespace is deprecated and replaced with `java-time.api`. https://github.com/metabase/metabase/issues/34506
-
Ngoc Khuat authored
-
Cal Herries authored
-
Anton Kulyk authored
-
Alexander Solovyov authored
fixes #31153 Co-authored-by:
Mayank Agarwal <mayankagarwal44442@gmail.com>
-
Cal Herries authored
FE: Do not show linked filter options if the parameter has values_source_type of "static-list" or "card" (#34438)
-
Oisin Coveney authored
-
- Oct 12, 2023
-
-
Luis Paolini authored
-
Aleksandr Lesnenko authored
-
Case Nelson authored
-
Noah Moss authored
-
Luis Paolini authored
* Add check for driver version * Update docs/troubleshooting-guide/db-connection.md Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com> --------- Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
Tim Macdonald authored
[Fixes #34592]
-
Aleksandr Lesnenko authored
* use gh cli in the backport script
-
Ryan Laurie authored
-
Noah Moss authored
-
Nick Fitzpatrick authored
* Adding dropped series to split suggestions * adding unit test * adding e2e test
-
Maz Ameli authored
-
Luis Paolini authored
-
lbrdnk authored
Make test parallel, now for real! And `checkins` -> nil has no effect from functional point of view, but leaving checkins in could just confuse the reader.
-
Ryan Laurie authored
-
John Swanson authored
Thanks to @dpsutton for the help here! I investigated an alternative approach of reusing the machinery that we use in tests to determine whether the database already exists, but that turned out to rely on a private atom that stored a list of databases created by the tests. I didn't want to muck around with those internals, and it turned out to be simpler than expected to make `can-connect?` work (although I did need to catch the exception thrown when we couldn't connect, which seems a little odd - I would have expected `can-connect?` to catch that and return `false`). Fixes https://github.com/metabase/metabase/issues/9962
-
Tim Macdonald authored
[Fixes #33714]
-
Anton Kulyk authored
* MLv2 Joins 1 — Basic features (#32903) * Fix `FilterClause` return type * Export `Joinable` type * Add `Join` type to `replaceClause` * Add `CardDisplayInfo` type * Add `FilterOperatorDisplayInfo` type * Add `JoinExternalOp` type * Export `QueryColumnPickerProps` * Implement basic MLv2 `JoinStep` * Remove `null` condition hack * Sync join strategy on external query update * Clean `JoinStep.styled.tsx` * Add `JoinConditionClause` type * Fix join external op type-casting * Use HTML button in `JoinTablePicker` * Simplify `JoinStep` logic * Add `Join` type to `removeClause` * Extract `useJoin` hook * Extract `useJoinCondition` hook * Group `JoinStep` components into directories * Fix new condition rendering hack * Use `cursor: pointer` for join column picker * Fix condition duplication * Fix missing LHS/RHS column method arguments * Simplify join condition assertions * Fetch metadata for selected table * Fix `joinConditionLHSColumns` usage * Highlight selected condition columns * Preselect right table database, filter databases * Fix table filter * Open LHS column picker when table is selected * Use `joinLHSDisplayName` * Patch test * Fix text * Open RHS column picker once the LHS one is selected * Preselect models picker for model based questions * Fix test * Remove TODOs * Fix popover ref * Disallow removing condition columns * Use "Previous results" if table name is unavailable * Fix previous results shown too early * Update `joinLHSDisplayName` usage * MLv2 Joins 2 — Suggested condition (#32904) * Use suggested join condition if available * Remove `it.todo` * MLv2 Joins 3 — Fields (#32905) * Update `FieldsPicker` API * Export `JoinFields` type * Implement join fields selection * Fix empty column list when need to fetch metadata * Add missing tests * Remove `it.todo` * Extend tests * Fix tests * Fix race-condition when loading table metadata * Make field picker's `isColumnSelected` required * MLv2 Joins 4 — Multiple conditions (#32906) * Implement multiple conditions * Fix tests * Remove irrelevant test * Extract `JoinConditionRightPart` * Fix temporal units sync for join columns * MLv2 Joins 5 — Update condition UI (#32907) * Add `removeCondition` to `useJoin` * Sync `useJoinCondition` state * Update join condition UI * Improve a11y * Tweak UI * Fix color literal usage * Update UI * Fix read only mode (#32908) * MLv2 Joins 7 — Fix notebook editor lifecycle issue (#32911) * Allow keeping a step open on calling `updateQuery` * Don't auto-close join notebook steps * Make join steps open by default * Remove join on table change * Move open steps calc to `getInitialOpenSteps` * Remove no longer relevant check * Add a link to proper fix description * Use MLv2 in `notebook/lib/steps` * Update join's `isValid` check * Remove redundant tests * Remove more redundant tests * Revert "Use MLv2 in `notebook/lib/steps`" This reverts commit 24df2d722282ff1eef60fa45cef4b0e742826d12. * Revert "Revert "Use MLv2 in `notebook/lib/steps`"" This reverts commit 7b511fd053f59fef2624883c5136a643818e7dee. * Fix join revert * Fix type imports linter errors * MLv2 Joins 8 — Update tests (#32912) * Use new test IDs * Update test Join suggested condition is smarter now and we don't need to manually construct a condition here * Fix test * Remove irrelevant test The behavior used in the repro is removed * Fix test Section names used to be inconsistent — mixing singular and plural forms * Fix test * Fix fails because of FK name in column names Normally it's expected to show FK reference names here It seems like MLv1 just couldn't resolve it through metadata before * Fix column name * Fix `JoinStep` tests * Fix missing FK reference name * Fix columns highlighting for new condition * Fix missing FK reference name * Update E2E tests MLv2 now figures out suggested conditions in a better way, and we can skip the manual selection steps now * MLv2 Joins 9 — Remove `externalOp` usage (#33526) * Replace `JoinConditionExternalOp` type * Add `joinConditionParts` helper * Revert `externalOp` method type definitions * Don't use `externalOp` for joins * Fix deselecting all join fields * Fix test * Fix tests * Remove most of MLv1 joins code (#33334) * Remove join's `clean` method * Remove join's `hasGaps` method * Remove join's strategy methods * Remove join fields method * Remove join's `addEmptyDimensionsPair` method * Remove join's `joinDimensionOptions` method * Remove join's `setJoinSourceTableId` method * Remove join's alias methods * Remove join's `setOperator` method * Remove join's `removeCondition` method * Remove join's `setDefaultCondition` method * Remove join's `parentDimensions` method * Remove join's dimension setter methods * Remove join's `parentDimensionOptions` method * Remove join's `isMultipleConditionsJoin` method * Remove join's `joinDimensions` method * Clean up the `Join` class * Remove query's `clearJoins` method * Add `getQueryStageIndex` method * Remove query's `hasJoins` method * Remove query's `addJoin` method * Mark query's `joinedDimensions` as deprecated * Mark query's `joins` as deprecated * Mark query's `join` as deprecated * Remove join update methods * Remove join removal methods * Make `cleanJoins` private * Remove `Join.unit.spec` * Return `clearFields` join method * Fix wrong references * Revert "Remove join removal methods" This reverts commit 9ae1e8c503d9b097d073836e7c6530282c6a64fa. * Revert "Remove join update methods" This reverts commit de232238bd266ed72a498d0afea3675e609cfae3. * Mark join methods as deprecated * Remove tests * Fix bad reference * Fix linter error * Revert #32911 (#34407) * MLv2 Joins — Disable RHS table changes (#34501) * Disable RHS table change * Don't highlight inactive join step cells * Use `disabled` prop instead of custom styles * Fix test * Fix RHS column table names * Fix column name label * Don't suggest joining something by its implicitly joinable columns (#34538) Fixes #34526. --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
Ngoc Khuat authored
-
Kamil Mielnik authored
* Sort scripts in package.json * Sort scripts in release/package.json * Fix a flaking test
-
lbrdnk authored
* Update way source metadata are transformed to fields `add-implicit-fields` now transforms expressions containing only field, coming from source-query, to field with string id (aka name). With use of numerical id, implicit field could have been added twice, and because of that later discarded. * Add test checking implicit expr field from source query
-
Nemanja Glumac authored
This commit reverts b19add25.
-
- Oct 11, 2023
-
-
metamben authored
-
Nick Fitzpatrick authored
* re-initialize qb when navigating back * a gentler approach * Moving describe block
-
lbrdnk authored
-
Alexander Solovyov authored
allowed-params should be keywords, because they are compared with keys in a body map, which are keywords
-
Luis Paolini authored
* Update Apache POI Let's see if this fixes https://github.com/metabase/metabase/issues/29839 without busting everything else * Rework XLSX auto-sizing test to be more resilient --------- Co-authored-by:
Noah Moss <noahbmoss@gmail.com>
-
Luis Paolini authored
-