This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jul 19, 2022
-
-
Aleksandr Lesnenko authored
* adjust font size on scalar cards * fix specs
-
Nemanja Glumac authored
-
GitStart authored
Co-authored-by:
gitstart <gitstart@users.noreply.github.com> Co-authored-by:
GitStart-Chalktalk <nitesh.singh@gitstart.dev> Co-authored-by:
Gh0sT <coolmagnas@gmail.com> Co-authored-by:
Rubens Rafael <70234898+RubensRafael@users.noreply.github.com> Co-authored-by:
Benjamin Mayanja <vibenjamin6@gmail.com> Co-authored-by:
Júlio Piubello da Silva Cabral <julio.piubello@gitstart.dev>
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Ryan Laurie authored
* allow field values widget to fill width * banish horizontal fieldvaluespicker scroll
-
Nemanja Glumac authored
* Define all Java flags separately for readability * Separate database and snowplow configs * Explicitly say that we are generating a temporary DB file * Extract `userDefaults` and warn about it * Rename `databaseConfig` to `metabaseConfig` * Rename temporary database path generator
-
Aleksandr Lesnenko authored
-
- Jul 18, 2022
-
-
Nemanja Glumac authored
* Remove unused and non-existent ENV * Export only resources actually used elsewhere * Remove the default callback implementation * Remove unused Cypress app db fixture * Remove `DEFAULT_DB_KEY` We're never ever going to use `test_db_fixture.db` to spin a Cypress instance up. That was the only reason why `DEFAULT_DB_KEY` existed in the first place. In order to fall back to using that fixture app db `dbKey` would have to be `undefined` or `null`. * Simplify `get` method Get the `dbKey` inline, rather than having to pass another callback with the separate logic. * Remove obsolete filter flag (see #19378) * Remove unused Java flag * Bring back `MB_USER_DEFAULTS` This reverts 70ea7bedddb5cc1e221cff934c7c939e96bb43c8 * Link the PR that explains the origin of `MB_USER_DEFAULTS`
-
Ryan Laurie authored
* disable erroring json filters * better summarize action handling
-
GitStart authored
Co-authored-by:
gitstart <gitstart@users.noreply.github.com> Co-authored-by:
gitstart <gitstart@gitstart.com> Co-authored-by:
Benjamin Mayanja <vibenjamin6@gmail.com> Co-authored-by:
GitStart-Chalktalk <nitesh.singh@gitstart.dev> Co-authored-by:
Júlio Piubello da Silva Cabral <julio.piubello@gitstart.dev>
-
Nick Fitzpatrick authored
* Closing all Dashboard sidebars when entering/exiting edit mode * fixing unit test
-
Gustavo Saiani authored
-
Nemanja Glumac authored
-
Ryan Laurie authored
* allow operator changes on category fields
-
Nick Fitzpatrick authored
-
Mahatthana (Kelvin) Nomsawadi authored
-
Alexander Polyankin authored
-
Ryan Laurie authored
-
Ngoc Khuat authored
* add snowplow tracking for new records on TaskHistory * more tests and have a better way to figure out db_id, db_engine
-
Alexander Polyankin authored
-
Nemanja Glumac authored
-
- Jul 15, 2022
-
-
GitStart authored
* Visualization: Bar chart not showing 0 values unlike line and area chart Co-authored-by:
gitstart <gitstart@gitstart.com> Co-authored-by:
gitstart <gitstart@users.noreply.github.com> Co-authored-by:
Nitesh Singh <nitesh.singh@gitstart.dev> Co-authored-by:
Gh0sT <coolmagnas@gmail.com> Co-authored-by:
Rubens Rafael <70234898+RubensRafael@users.noreply.github.com> Co-authored-by:
GitStart <1501599+gitstart@users.noreply.github.com> Co-authored-by:
Benjamin Mayanja <vibenjamin6@gmail.com> Co-authored-by:
Júlio Piubello da Silva Cabral <julio.piubello@gitstart.dev> * Visualization: Bar chart not showing 0 values unlike line and area chart Co-authored-by:
gitstart <gitstart@gitstart.com> Co-authored-by:
gitstart <gitstart@users.noreply.github.com> Co-authored-by:
GitStart-Chalktalk <nitesh.singh@gitstart.dev> Co-authored-by:
Gh0sT <coolmagnas@gmail.com> Co-authored-by:
Rubens Rafael <70234898+RubensRafael@users.noreply.github.com> Co-authored-by:
GitStart <1501599+gitstart@users.noreply.github.com> Co-authored-by:
Benjamin Mayanja <vibenjamin6@gmail.com> Co-authored-by:
Júlio Piubello da Silva Cabral <julio.piubello@gitstart.dev> * remove 0 filter for bar chart Co-authored-by:
gitstart <gitstart@gitstart.com> Co-authored-by:
gitstart <gitstart@users.noreply.github.com> Co-authored-by:
GitStart-Chalktalk <nitesh.singh@gitstart.dev> Co-authored-by:
Gh0sT <coolmagnas@gmail.com> Co-authored-by:
Rubens Rafael <70234898+RubensRafael@users.noreply.github.com> Co-authored-by:
GitStart <1501599+gitstart@users.noreply.github.com> Co-authored-by:
Benjamin Mayanja <vibenjamin6@gmail.com> Co-authored-by:
Júlio Piubello da Silva Cabral <julio.piubello@gitstart.dev> Co-authored-by:
gitstart <gitstart@users.noreply.github.com> Co-authored-by:
gitstart <gitstart@gitstart.com> Co-authored-by:
Nitesh Singh <nitesh.singh@gitstart.dev> Co-authored-by:
Gh0sT <coolmagnas@gmail.com> Co-authored-by:
Rubens Rafael <70234898+RubensRafael@users.noreply.github.com> Co-authored-by:
Benjamin Mayanja <vibenjamin6@gmail.com> Co-authored-by:
Júlio Piubello da Silva Cabral <julio.piubello@gitstart.dev>
-
Ryan Laurie authored
-
Nick Fitzpatrick authored
* Fixing viewheader unit test * Fixing SavedQuestionHeaderButton unit test
-
dpsutton authored
* Lets use the main thread * Strip out channel stuff and rename * 202 -> 200 response When returning a channel we return a 202. A map is just a 200. Since we no longer need to have the main stuff async (as opposed to the metadata stuff) we can just return the map with a 200 instead of this long running channel stuff and a 202. * Last test * renames, logging, ensure query is the same before saving metadata * Sandbox test 202 -> 200 * Another 202 -> 200 * Put timeout on async metadata saving timeout of 15 minutes before we give up on the async metadata saving. It is possible this cuts things off but hard to tell if work is still being done at that point. * outdated comment * Return json error message, not text/plain this is a subtle one that I'm not happy about. Our error handling will return text/plain if you throw an `(ex-info "something" {:status-code 400})`. ```shell ❯ http post localhost:3000/api/timeline-event/ name=some-name description=Bob timestamp=2022 timezone=America/Central time_matters:=false timeline_id:=1629 Cookie:$COOKIE HTTP/1.1 404 Not Found Content-Type: text/plain Timeline with id 1,629 not found ``` But if you add extra information to the map to the ex-info, you get json! ```clojure (defmethod api-exception-response Throwable [^Throwable e] (let [{:keys [status-code], :as info} (ex-data e) other-info (dissoc info :status-code :schema :type) body (cond (and status-code (empty? other-info)) ;; If status code was specified but other data wasn't, it's something like a ;; 404. Return message as the (plain-text) body. (.getMessage e) ;; if the response includes `:errors`, (e.g., it's something like a generic ;; parameter validation exception), just return the `other-info` from the ;; ex-data. (and status-code (:errors other-info)) other-info ;; Otherwise return the full `Throwable->map` representation with Stacktrace ;; and ex-data :else (merge (Throwable->map e) {:message (.getMessage e)} other-info))] {:status (or status-code 500) :headers (mw.security/security-headers) :body body})) ``` So this fix is a _very_ subtle way to get to what we want, although it does add a bunch of extra junk to our response. ```javascript { ... "message": "Invalid Field Filter: Field 26 \"PRODUCTS\".\"CATEGORY\" belongs to Database 1 \"Sample Database\", but the query is against Database 990 \"copy of sample dataset\"", "data": { "status-code": 400, "query-database": 990, "field-filter-database": 1} ... } ``` Reminder of what we want: the frontend is saving a card. We added a field filter on a database and then changed the source database of the query. So the backend needs to reject the field filter as being on the wrong db. The FE expects a json response with a message and will then show that message in the save/edit modal. Why did this come up now: these endpoints for saving and editing a card used to always return 202 streaming responses. This means they would have to tuck any errors inside of an already open 202 response. Which is why you get a message as a json response. But now that they are sync, the api can just return a proper 400 with a reason. But we still want that to be a json response for the FE. * error layout fix * Several Cleanups - make sure numbers have units at the end (-ms) - use (u/minutes->ms 15) rather than a more opaque (* 15 60 1000) - move the scheduled metadata saving into its own function This last bit is actually a bit more than that. I was previously throwing everything in a thread submitted to the pooled executor. I'm now using a `future` but with a caveat: All of the waiting for the timeout, checking if we got metadata is done in a simple `a/go` block now, and the thread does just the last bit of IO. We have to select the card as it is now to ensure the query is the same and then save. Refresher on why we have to check if the query is the same. We have up to 15 minutes to wait for the query metadata to come back. Completely possible for them to have edited the query and then our metadata is useless. Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com>
-
Nemanja Glumac authored
* Fix broken collection tests * Merge related tests together - #16555 is not relevant anymore - add repro for #20716
-
Nick Fitzpatrick authored
-
Nemanja Glumac authored
* Run mochawesome from within a custom Cypress runner * Remove Mochawesome report from GitHub E2E workflows
-
Anton Kulyk authored
* Wrap string in `t` * Don't translate email string
-
Mahatthana (Kelvin) Nomsawadi authored
* Make collection and dashboard header buttons consistent * Make question buttons consistent * Standardize header button margin for collection and dashboard * Use Maz's spacing * Fix conflicts with Maz's spacing on dashboards * Change spacing between collection header buttons to use gap * Match dashboard and question divider spacing * Refactor question header spacing to use gap
-
Maz Ameli authored
* text-dark and a new hover state * change min width
-
Nick Fitzpatrick authored
-
Nemanja Glumac authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Refactor code to make it more concise * Make dashboard buttons hover effect more consistent * Make EntityMenu style more consistent * Fix collection event button tab selection * Add missing tooltip to dashboard info button * styled cleanup * Fix failed E2E tests * Address Anton's feedback * Fix question buttons style clashing with #23827 * Address Alexander's feedback * maz spacing and sizing tweaks Co-authored-by:
Maz Ameli <mazameli@gmail.com>
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
- Jul 14, 2022
-
-
Cal Herries authored
Fix for #20716: "Our analytics" can be confusing when user does not have access to that collection (#23887) * Change collection endpoints to not return root collection if user doesn't have Root permission * hide our analytics collection in saved question picker when users do not have access * Fix tests Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com>
-
Cal Herries authored
* Update the reply-to setting component to never allow it's value to be [""] * Fix e2e test * Validate email-reply-to setting to be a list of email addresses * Fix validation copy * Fix copy on reply-to setting description * Update src/metabase/email.clj Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-