This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- May 15, 2024
-
-
Jeff Bruemmer authored
-
Jeff Bruemmer authored
-
Nick Fitzpatrick authored
* replace search bar with command palette toggle * e2e test part one * onboarding suite * green e2e * unit tests * delete shame
-
Alex Yarosh authored
* update collections * feedback * links * Update docs/questions/native-editor/sql-parameters.md Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com> --------- Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
John Swanson authored
3 TODOs were removed here: - "a way to SET Database-local values." More like TODONE :haaa: - "we should probably also bind this [that is, *database-local-values*] in sync contexts e.g. functions in [[metabase.sync]]" I think we don't need to do this. The full set of maybe-database-local settings right now is `aggregated-query-row-limit`, `unaggregated-query-row-limit`, `database-enable-actions`, and `persist-models-enabled`. None of these need to be set when `sync`ing. If at some point we do add a db-local setting that should affect the way syncing works, we will need to do this - but I don't think this TODO will help figure that out. - "settings sent via an env var aren't returned for security purposes. It is an open question whether we should obfuscate them and still show the last two characters like we do for sensitive values that are set via the UI." I think if it's been this way for 5 years, it no longer qualifies as an "open question." We can reopen if down the road if this is something we want.
-
adam-james authored
* PoC Pivot table exporting. Works so far! This just hacks a couple things in. I added the :query via format_rows, which should instead have its own proper middleware Pivot export should probably not just be in the middleware namespace but in qp.pivot. Should not break the streaming results writer for non-pivots... obviously this breaks ordinary results, so that needs to be handled properly. Better documentation about how the logic actually works. Pivot tables are hard to remember/easy to forget, so some very clear diagrams/examples would probably be good. * adjust csv export to export a pivot table when pivot options exist * post processing of pivot table rows for card/dashcard downloads * WIP on getting pivot exports to work with unsaved questions * WIP getting pivot exports working on unsaved questions The dataset POST /pivot endpoint is used to get the pivot data to the frontend, but also to get the pivot query. The query that is returned by the POST comes from the json_query, which is populated by the userland-query stuff with the last run query. The pivot qp runs mulitple queries and each query runs through the regular userland query qp, so we'll 1. see lots of executions recorded and 2. end up with the wrong query in the POST return. It'll look mostly correct, but due to how the pivot qp works won't necessarily have all of the fields. That incorrect pivot query is passed to the /:export-format endpoint and we don't end up seeing correct results. Since that json_query gets fed back to the backend when doing an export, we do need it to be correct, like the query that was sent to /pivot in the first place. Since this is a WIP, I've just passed the query as a string to :original-query in :info, and if that exists, use that to fill the :json_query key. Then, also add a :was-pivot flag so that the dataset download endpoint can look at it and use the pivot qp instead of the regular qp. Even if we have the correct 'top level' query, we need to run it through the pivot qp to get the full, correct pivoted results. * Pivot Export Test Here I've added a pivot export test that has various assertions trying to capture the correct output from the pivot csv export. I've done my best to explain the tests with comments, but have also left a (comment ) form with a function `explore-pivot` to help *show* rather than tell what the expected pivot output should be. I've created this new namespace to first capture this pivot export test with the intent to add tests that can improve our confidence that ALL exports/downloads in ALL places behave as we expect in the future. It just seemed nice to start fresh here with the pivot export test first. * Don't need to make this public. * Add lots of comments to hopefully make this a bit easier to follow * Added an explore-raw-pivot fn in comment form * Update test/metabase/api/downloads_exports_test.clj Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com> * begin addressing feedback - finish an unfinished docstring - merge info instead of assoc - use a native query to build the pivot data instead of using a custom dataset, to keep test speed ok * Create a new ns for the pivot post processing utils Separate the post processing fns into their own namespace. This means I can easily add a test namespace for the post processing specifically as well. * Add pivot postprocessing test ns, not complete, but decent start * fix mistake in endpoint. Only add original query to first pivot q * Figured out how to keep the original query without storing as a string * Perhaps this'll fix things properly? --------- Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com>
-
Romeo Van Snick authored
* Move the extract examples inline * Use ui Button for ClickAction and render examples inline
-
Phoomparin Mano authored
* support theming in table * theme injection with hoc * reasonable default theme options * customizable text color * theming table header * table theming * change theme configuration order * apply sorted cell color directly * gutter background * remove header theming for now * fix: id column styling * id column borders * border color * add cell hover color * conditional hover color * use brand color to accent * add default theme values to unit test * cell background should default to white * update unit test * remove unused properties * remove duplicated color declaration as inner cell data styles it * remove duplicate fallback * remove unused use-embedding-theme hook * use theme color from Mantine for css variables * update defaults * inject default component theme * add notes on cell data theme * update unit tests * update unit tests * remove no-op text-brand hover color * remove no-op is sorted cell color
-
Raphael Krut-Landau authored
-
Raphael Krut-Landau authored
-
Raphael Krut-Landau authored
-
Nemanja Glumac authored
* Explicitly decide whether to upload or not * Upload in the main e2e workflow, but skip uploading in stress-test workflow * Do not record runs in the stress-test workflow * Add Replay API key Even though we're not using it in this workflow.
* Omit env var from the stress-test workflow -
Alexander Solovyov authored
this lowers memory usage 100x for 50kb strings (our limit before this change) and speeds up parsing by an order of magnitude. For example, results for parsing 42kb string (already in memory): Before: Time per call: 6.32 ms Alloc per call: 8,732,850b After: Time per call: 55.16 us Alloc per call: 83,254b
-
Romeo Van Snick authored
* Render item icon inline with column icon * Use inline info icon in field picker * Use new QueryColumnInfoIcon on filter columns picker * Use new QueryColumnInfoIcon on suggestions dropdown * Use new QueryColumnInfoIcon aggregations dropdown * Use new QueryColumnInfoIcon filter modal * Use new QueryColumnInfoIcon in BreakoutColumnListItem * Use new QueryColumnInfoIcon in FieldList * Use new QueryColumnInfoIcon in DataSelectorFieldPicker * Update TableInfoIcon to render fallback too * Use new TableInfoIcon in DataSelector * Use new TableInfoIcon in ViewHeader * Fix types in breakout column * Move aria-label to wrapper * Move binning back to the right * Always give info icon full opacity * Remove asDot props everywhere
-
Uladzimir Havenchyk authored
-
Ngoc Khuat authored
An one time job to init send-pulse trigger and migration down to clean up send-pulse triggers (#42316) * Add a job to init send pulse trigger only once * Send pulse triggers should respect report timezone (#42502)
-
- May 14, 2024
-
-
Aleksandr Lesnenko authored
* fix static combo chart crashes when viz settings are invalid * spec
-
Emmad Usmani authored
-
Jeff Bruemmer authored
-
Braden Shepherdson authored
Follow up to #42424. This enforces that all drills do not appear on native stages. Also fixes one more drill on top of the two in #42424 that were wrongly showing up for native queries.
-
Uladzimir Havenchyk authored
* Optimize isVisualizationClickable check in TableInteractive * Destructure question * Mode is nullable
-
Alexander Polyankin authored
-
Braden Shepherdson authored
- `:metadata/key-constraints` for those databases which formally track PK and FK key constraints. Some databases (eg. Presto/Athena/Starburst family) don't support constraints like that, but do support querying based on foreign keys (which is the `:foreign-keys` feature). - `:connection/multiple-databases` for databases where a single connection can connect to many databases. This is the case for Athena, since it connects to an S3 bucket and exposes all files in the bucket as databases through that single connection. - Also removed a troublesome "all DBs except a huge list" case in the SSH tunnel tests with a shorter list of supported drivers.
-
Anton Kulyk authored
* Add icons * Use icons
-
Nemanja Glumac authored
* Fix broken metric revision API call Fixes #42633 * Add E2E repro for #42633 * Fix metrics revision history in the data reference * Add repro for #42633 for the reference page * Consolidate tests * Do not use hard coded id * Fix lint errors
-
Ryan Laurie authored
* Disable Error Diagnostic Modal In Embedding * add e2e test for diagnostic modal
-
bryan authored
* handle recent view for non-existant entity * test that recent views works with missing entities - just doesn't return them. * dont count on there being entities in the app-db
-
Ryan Laurie authored
* add recents tab type updates fix unit test change where we filter recents WIP Recents Tab wip recents design updates update recents design to match search use new recents format initial recents implementation fix types * fix e2e tests * update more e2e tests * allow recents filters * update test mocks * add unit tests for recents tab * update e2e tests * add e2e tests for recents picker tab * fix lost access test
-
Nemanja Glumac authored
* Remove `@visx/event` * Remove `@visx/legend` * Remove `@visx/responsive` * Remove `@visx/mock-data` * Remove `@visx/tooltip`
-
Ngoc Khuat authored
-
Ngoc Khuat authored
-
Raphael Krut-Landau authored
-
Chris Truter authored
-
Nemanja Glumac authored
* Remove unused `SettingsBatchForm` component * Remove `react-collapse` and its types
-
Nemanja Glumac authored
* Expand the single or multi-selectable string filter choices * Mark operators as `multi` * Wrap an existing test in a separate `describe` block * Test multiple values settings * Expand repro to include multiple dashboard filter values * Ease the load by limiting the card results * Switch to the more flexible data structure for the dashboard filters * Expand the assertions * Fix typo Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Romeo Van Snick authored
-
Uladzimir Havenchyk authored
-
Nemanja Glumac authored
-
- May 13, 2024
-
-
Aleksandr Lesnenko authored
-
Emmad Usmani authored
-