This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 08, 2024
-
-
-
Kamil Mielnik authored
* Remove @flaky tag * Unskip test and remove @flaky tag * Remove @flaky tag * Remove @flaky tag * Revert "Remove @flaky tag" This reverts commit 08c57add.
-
Kamil Mielnik authored
-
Phoomparin Mano authored
-
Kamil Mielnik authored
* Try to fix flake * See if timeout is necessary * Revert "See if timeout is necessary" This reverts commit 181f3c5e. * Revert change for coordinates filter
-
Kamil Mielnik authored
* Remove @flaky tag * Make workaround test pass * Disable workaround test * Uncomment and unquarantine the workaround test * Disable normal test for now * Revert "Disable normal test for now" This reverts commit 68fa2175. * Bring back quarantine * Update comment
-
Phoomparin Mano authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Correct embedding hash options type semantically * Pass `X-Metabase-Locale` to embed downloads * wip locale header middleware * Allow smart scalar text to be translated * Stop using global variable * Add more details to embedding types * Extend the E2E util type and correct some properties types * Add e2e test * Fix dashboard name * Add a test for static embed question * Make a type name follows a convention Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Fix failed E2E tests due to missing default values * Fix public embed not working with `?locale` anymore * Revert "wip locale header middleware" This reverts commit 83d8d135. * Preserve locale when in the `as-admin` macro is used Motivating issue: ```shell ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124' x-metabase-locale:fr -pb | jq '.data|.cols|map(.display_name)' [ "State", "Count" ] ``` I'm running a query that has aggregated columns and it is returning the untranslated. Note that these are computed and dynamically given a display name. ```clojure (case tag :count (i18n/tru "Count") :cum-count (i18n/tru "Cumulative count")) ``` The problem is that we run embedding things as admin. And that gets the current user, which in embed and public spaces is nil, and so binds a nil to user-locale, which defaults to english when translating. After: ``` ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124' x-metabase-locale:fr -pb | jq '.data|.cols|map(.display_name)' [ "State", "Nombre de lignes" ] ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124' x-metabase-locale:zh -pb | jq '.data|.cols|map(.display_name)' [ "State", "行数" ] ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124 ' x-metabase-locale:es -pb | jq '.data|.cols|map(.display_name)' [ "State", "Contar" ] ``` This is fetching a dashboard's card which is a query of orders grouped by created at month, sum of total. --------- Co-authored-by:
Nicolò Pretto <info@npretto.com> Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> Co-authored-by:
dan sutton <dan@dpsutton.com>
-
- Nov 07, 2024
-
-
Romeo Van Snick authored
* Handle touch start capture as well as mouse down for popover * Also stop event propagation for touch events on menu item
-
Ngoc Khuat authored
-
Raphael Krut-Landau authored
Closes #49534
-
Alexander Solovyov authored
-
Jeff Bruemmer authored
* notes on database browser * typo
-
Raphael Krut-Landau authored
-
Raphael Krut-Landau authored
-
Jeff Bruemmer authored
-
Nicolò Pretto authored
-
Luis Paolini authored
* note about apsaradb * Update docs/installation-and-operation/configuring-application-database.md Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com> --------- Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
Alex Yarosh authored
* docs: remove nested queries setting * docs: remove mention of nested query setting
-
Alex Yarosh authored
* docs: cloud environment variables * Apply suggestions from code review Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com> --------- Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
Nemanja Glumac authored
* Move the upload CSV button to the main nav bar * Remove the old `SidebarOnboardingSection` * Remove obsolete unit tests * Rework E2E tests * Add some spacing around the button * Fix E2E test * Break `MainNavbar` unit test down * Expand unit tests * Update E2E tests * Fix E2E test failure * Move JSDoc where it belongs * Provide context for translators * Simplify the condition
-
Oisin Coveney authored
-
Oisin Coveney authored
-
github-automation-metabase authored
-
Kamil Mielnik authored
Fix - Values from the returned rows not present in the visualization are interpolable in the URL but don't have values (#49530) * Fix #46318 * Add repro for #46318 * Move setup to beforeEach
-
- Nov 06, 2024
-
-
adam-james authored
* Pivot Measures Order Used in Pivot Exports Fixes #48442 A pivot table can have any number of measures, and the user can order these by dragging in the UI. Before this PR, that order was ignored and measures would alway be in index order, which is confusing for any user who needs the measures to be displayed in a particular order, especially if they've re-ordered them in the pivot viz settings UI. A test has been added to check that measure order is used. A few minor changes to the pivot qp and post-processor - measure indices are looked up in the pivot qp and added in viz-settings order - the pivot measures are only added if the qp has not already added them. - pivot-opts Malli spec has been made in the namespace, adjusted to allow `nil` as a valid pivot-opts output, and used in relevant functions * address review points. * add a rows order test * Filter out Empty Rows from Pivot Exports Fixes #49353 The linked issue is not actually related to pivot export size but is instead related to the 'Min of Created At: Month' aggregation; the default aggregation function was `+`, so it broke when the date string was encountered. That was fixed. As I was trynig to keep the export small if possible, I noticed that in some cases empty rows are appended, so I added the filter so that if a pivot row's values are completely empty, it doesn't add it. Finally, this PR also adds the 'sub section totals' which I noticed were missing from the exports. This comes up when you have 3+ pivot-rows configured, so you can see the subtotals for the first pivot row and the subtotals nested within those sections for the second pivot row, and so on. * add test for non-numeric values * Make sure the new name refs match on aggregations not just breakouts * cljfmt
-
Noah Moss authored
-
Ryan Laurie authored
-
Ryan Laurie authored
* push metabot to stats * use metabot tag instead
-
Phoomparin Mano authored
* move the database prompt to the very beginning * ability to use sample database for cli * print username and password in console * no tenancy isolation as a default option * highlight sample credentials file * update credential log messages Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * continue without tenancy isolation --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
Alexander Solovyov authored
previously import would return 200 w/o regard if it was successful or not fixes #49602
-
Alexander Polyankin authored
* Fix :pivot-measures with column names * Fix the test * Update src/metabase/query_processor/pivot.clj Co-authored-by:
Braden Shepherdson <braden@metabase.com> * Add a test * Add a test --------- Co-authored-by:
Braden Shepherdson <braden@metabase.com>
-
Kamil Mielnik authored
* Remove @flaky tag * Fix flake * Refactor * Use getDashboardCard * Shorten text * Fix flake * Revert previous changes * Revert "Revert previous changes" This reverts commit 16b56f26. * Fix flake
-
Kamil Mielnik authored
* Remove @flaky tag * Fix flake * Try typing delay instead * Improve comment * Bring back original solution
-
Luis Paolini authored
* Update static embedding iframe resizer * Update docs/embedding/static-embedding.md Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com> --------- Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
Jeff Bruemmer authored
-
Nicolò Pretto authored
Co-Authored-by:
Poom <poom@poom.dev>
-
Braden Shepherdson authored
Adds filters to generative testing for queries. There's a lot of new code here, but don't panic, it's quite straightforward: generating filter values, in the right shapes for various filter expressions.
-
Uladzimir Havenchyk authored
-