Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Sep 05, 2023
    • Ryan Laurie's avatar
      Parameterize collection and dashboard ids in e2e tests (#33570) · 9d3ea413
      Ryan Laurie authored
      * parameterize collection and dashboard ids in e2e tests
      
      * fix copyPasta errors
      
      * appease the linter
      
      * obey the linter
      Unverified
      9d3ea413
    • Cam Saul's avatar
      Implement timeseries zoom drill thru (#33574) · 00e2565e
      Cam Saul authored
      * First crack at drill-thru, adding quick-filter-drill
      
      * Adding object detail drill
      
      Needs tests for the multi-PK case
      
      * Add distribution-drill and foreign-key-drill
      
      * Add sort drill
      
      * summarize-column and part of automatic-insights
      
      * Add `display-info` for drill-thrus and the special pivot functions
      
      Clean up and should be ready for FE first crack
      
      * Add `drill-thru` implementations for all current drills
      
      * small fixes
      
      * overhaul of available-drill-thru
      
      Fixes several issues with targeting, merges in Mode logic, fixes
      pivot-drills
      
      Still TODO: other drills' mode conditions; lots of checking and testing
      the various cases of what should be shown; writing tests for that.
      
      * Add `display-info` for drill-thrus and the special pivot functions
      
      Clean up and should be ready for FE first crack
      
      * Add `display-info` for drill-thrus and the special pivot functions
      
      Clean up and should be ready for FE first crack
      
      * Integrating the basic drill-thru ops, with some debugging hacks
      
      * Fix bad spelling of parameters
      
      * bunch of a progress, :null sentinel, refactor to context
      
      * tests for lots more cases; two missing drills
      
      * adding underlying records drills, not yet working
      
      * fixing up to work with upstream changes
      
      * fixes from Denis' PR
      
      * more progress debugging FE drills and adding tests
      
      * drill tests coming along
      
      * cleanup, test fixes
      
      * display-info-js for recursion
      
      * Add TS typing for displayInfo of drill thrus
      
      * partial changes for underlying records
      
      * hack hack
      
      * splitting out progression logic to a separate file
      
      * First crack at drill-thru, adding quick-filter-drill
      
      * Adding object detail drill
      
      Needs tests for the multi-PK case
      
      * Add distribution-drill and foreign-key-drill
      
      * Add sort drill
      
      * summarize-column and part of automatic-insights
      
      * Add `display-info` for drill-thrus and the special pivot functions
      
      Clean up and should be ready for FE first crack
      
      * Add `drill-thru` implementations for all current drills
      
      * small fixes
      
      * overhaul of available-drill-thru
      
      Fixes several issues with targeting, merges in Mode logic, fixes
      pivot-drills
      
      Still TODO: other drills' mode conditions; lots of checking and testing
      the various cases of what should be shown; writing tests for that.
      
      * Add `display-info` for drill-thrus and the special pivot functions
      
      Clean up and should be ready for FE first crack
      
      * Add `display-info` for drill-thrus and the special pivot functions
      
      Clean up and should be ready for FE first crack
      
      * Integrating the basic drill-thru ops, with some debugging hacks
      
      * Fix bad spelling of parameters
      
      * bunch of a progress, :null sentinel, refactor to context
      
      * tests for lots more cases; two missing drills
      
      * adding underlying records drills, not yet working
      
      * fixing up to work with upstream changes
      
      * fixes from Denis' PR
      
      * more progress debugging FE drills and adding tests
      
      * drill tests coming along
      
      * cleanup, test fixes
      
      * display-info-js for recursion
      
      * Add TS typing for displayInfo of drill thrus
      
      * partial changes for underlying records
      
      * hack hack
      
      * splitting out progression logic to a separate file
      
      * Lint and test cleanup
      
      * MLv2 pivot reorganization part 1
      
      * MLv2 pivots reorganization
      
      * Revert some unneeded changes
      
      * Don't enable the histogram test
      
      * Fix lint errors and add a drill-thru-method implementation for sort
      
      * `drill-thru` should support > 3 args
      
      * Implement timeseries zoom drill thru
      
      * Fix circular refs
      
      * Fix `mu/defmethod` for Cljs
      
      * Fix reader error in commented-out code :unamused:
      
      
      
      * appease Eastwood
      
      * PR feedback
      
      ---------
      
      Co-authored-by: default avatarBraden Shepherdson <braden@metabase.com>
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      Unverified
      00e2565e
    • Nemanja Glumac's avatar
    • Nemanja Glumac's avatar
      Download previously saved uberjar for E2E workflow (#33190) · f518801c
      Nemanja Glumac authored
      * PoC: Download previously saved uberjar for E2E workflow
      
      * Separate `e2e_specs` and `e2e_all` file path triggers
      
      * Fix file path result oputput
      
      * Refine E2E tests conditional trigger
      
      * Further refine E2E tests conditional trigger
      
      * Download the uberjar directly where it's needed
      
      * Work around inability to dynamically define job ouputs
      
      * First obtain the artifact, then run anything else
      
      * Map job outputs
      
      https://docs.github.com/en/actions/using-jobs/defining-outputs-for-jobs
      
      * Apply changes to visual regression tests
      
      * Final logic cleanup
      
      * Work around the API rate limit
      Unverified
      f518801c
    • Oisin Coveney's avatar
    • Noah Moss's avatar
      Don't decode SSO redirect URLs before extracting host (#33703) · ed9b4a7e
      Noah Moss authored
      * Don't decode SSO redirect URLs before extracting host
      
      * clean ns
      
      * re-add kondo ignore
      
      * address feedback
      Unverified
      ed9b4a7e
    • Anton Kulyk's avatar
      Remove external op on the FE (#33433) · bff2ceb5
      Anton Kulyk authored
      * Remove external op on the FE
      
      * Clean commit
      Unverified
      bff2ceb5
    • Kamil Mielnik's avatar
      Refactor - Break ObjectDetail down (#33694) · dcee76ba
      Kamil Mielnik authored
      * Extract ObjectDetailBody to a separate file
      
      * Extract ObjectDetailHeader to a separate file
      
      * Extract ObjectDetailView to a separate file
      - extract ObjectDetailWrapper.styled.tsx
      
      * Extract ObjectDetailHeader unit tests
      
      * Extract ObjectDetailBody unit tests
      
      * Rename ObjectDetail.unit.spec.tsx to ObjectDetailView.unit.spec.tsx
      Unverified
      dcee76ba
  2. Sep 04, 2023
    • adam-james's avatar
      Modify GET /api/user endpoint to only work for admins/group managers (#33217) · f0479dab
      adam-james authored
      
      * Modify GET /api/user endpoint to only work for admins/group managers
      
      * Restrict group managers to only see users of groups they manage
      
      * Adjust segmented user tests and dedupe when user in multiple groups
      
      * Revert a small change that broke other tests. Change wasn't strictly needed anyway.
      
      * Properly enable premium feature :advanced-permissions in group-manager test
      
      * Fix sandbox user list tests. Count query needs distinct now bc of how group manager user list is returned
      
      * Add back the filter I forgot to include in the count query
      
      * Unused require due to a change in one of the tests
      
      * Fix group-manager permissions logic on the user endpoint
      
      * Update src/metabase/api/user.clj
      
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      
      * Changed endpoint's logic and impl slightly
      
       - cleaner group-ids-for-manager query
       - use existing validation/check-manager-of-group
       - simplify group-id-clause since at that point we know that the user is admin or group manager
      
      Added a test case to ensure group-manager still only gets their groups users when group_id is not supplied
      
      These scenarious should be accounted for in this setup now
      
      ;; ADMIN GM group_id  GM of group_id OUTCOME
      ;; t     t    t            t         can see users from that group
      ;; t     t    t            f         can see users from that group (bc admin can see)
      ;; t     f    t            f         can see users from that group (bc admin can see)
      ;; t     t    f            f         can see all (admin can see all)
      ;; f     t    f            f         can see users from all groups they manage
      ;; f     t    t            t         can see users from that group
      ;; f     t    t            f         cannot see (bc non admin, GM of different group)
      
      * Alter tests to correctly check 403 in OSS setting
      
      * Modify test to use generic verified by text since User endpoint is now more restricted.
      
      * Strange pulse e2e test. Intercept the user api call to circumvent for now
      
      * request recipients through /api/user/recipients instead of /api/user
      
      * I don't even know anymore. Why did this change now?
      
      Seems that there's a collection ID where before there was a null,
      which caused redirect to collection/root
      
      ---------
      
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      Co-authored-by: default avatarJesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
      Unverified
      f0479dab
    • Oisin Coveney's avatar
      Add Right Arrow Icon (#33674) · f8613161
      Oisin Coveney authored
      Unverified
      f8613161
  3. Sep 02, 2023
    • Cam Saul's avatar
      Migrate QP/drivers code to use MLv2 metadata directly; make another 100+ tests... · 7bacd2fa
      Cam Saul authored
      Migrate QP/drivers code to use MLv2 metadata directly; make another 100+ tests parallel and shave 12 seconds off test suite (#33429)
      
      * QP MLv2 Metadata Provider follow-ons
      
      * Update lots of stuff to use MLv2 metadata instead of legacy metadata
      
      * Fix lint warnings
      
      * B I G  cleanup
      
      * Everything is neat
      
      * Mention new test pattern in driver dev changelog
      
      * Appease Cljs by renaming a bunch of namespaces
      
      * Move more stuff over
      
      * Fix kondo errors
      
      * Fix even more things
      
      * Test fixes
      
      * Fix JS export
      
      * Test fixes :wrench:
      
      * Fix final MongoDB test
      Unverified
      7bacd2fa
    • metamben's avatar
      48 cycle simple bumps (#33630) · 2bd21bf8
      metamben authored
      * Bump simple changes
      * Account for changed exception message
      * Add buddy-sign license
      * Use maven coordinates to select tools.build version
      Unverified
      2bd21bf8
  4. Sep 01, 2023
    • Jeff Bruemmer's avatar
      docs - deprecate beanstalk (#33067) · d2fabad9
      Jeff Bruemmer authored
      * alternatives
      
      * remove links
      
      * remove mentions of eb
      
      * remove eb from rds page
      Unverified
      d2fabad9
    • Luis Paolini's avatar
      Adding Snowflake to the list of DB's (#33677) · 5695df91
      Luis Paolini authored
      ... you can reference when using native questions
      Unverified
      5695df91
    • metamben's avatar
      Use field ID as name if the field cannot be resolved (#33648) · 4792f8ac
      metamben authored
      Fixes #33490.
      Unverified
      4792f8ac
    • Cam Saul's avatar
      Move drill thrus to their own namespaces & numerous bug fixes (#33572) · 1d2e85dd
      Cam Saul authored
      * First crack at drill-thru, adding quick-filter-drill
      
      * Adding object detail drill
      
      Needs tests for the multi-PK case
      
      * Add distribution-drill and foreign-key-drill
      
      * Add sort drill
      
      * summarize-column and part of automatic-insights
      
      * Add `display-info` for drill-thrus and the special pivot functions
      
      Clean up and should be ready for FE first crack
      
      * Add `drill-thru` implementations for all current drills
      
      * small fixes
      
      * overhaul of available-drill-thru
      
      Fixes several issues with targeting, merges in Mode logic, fixes
      pivot-drills
      
      Still TODO: other drills' mode conditions; lots of checking and testing
      the various cases of what should be shown; writing tests for that.
      
      * Add `display-info` for drill-thrus and the special pivot functions
      
      Clean up and should be ready for FE first crack
      
      * Add `display-info` for drill-thrus and the special pivot functions
      
      Clean up and should be ready for FE first crack
      
      * Integrating the basic drill-thru ops, with some debugging hacks
      
      * Fix bad spelling of parameters
      
      * bunch of a progress, :null sentinel, refactor to context
      
      * tests for lots more cases; two missing drills
      
      * adding underlying records drills, not yet working
      
      * fixing up to work with upstream changes
      
      * fixes from Denis' PR
      
      * more progress debugging FE drills and adding tests
      
      * drill tests coming along
      
      * cleanup, test fixes
      
      * display-info-js for recursion
      
      * Add TS typing for displayInfo of drill thrus
      
      * partial changes for underlying records
      
      * hack hack
      
      * splitting out progression logic to a separate file
      
      * First crack at drill-thru, adding quick-filter-drill
      
      * Adding object detail drill
      
      Needs tests for the multi-PK case
      
      * Add distribution-drill and foreign-key-drill
      
      * Add sort drill
      
      * summarize-column and part of automatic-insights
      
      * Add `display-info` for drill-thrus and the special pivot functions
      
      Clean up and should be ready for FE first crack
      
      * Add `drill-thru` implementations for all current drills
      
      * small fixes
      
      * overhaul of available-drill-thru
      
      Fixes several issues with targeting, merges in Mode logic, fixes
      pivot-drills
      
      Still TODO: other drills' mode conditions; lots of checking and testing
      the various cases of what should be shown; writing tests for that.
      
      * Add `display-info` for drill-thrus and the special pivot functions
      
      Clean up and should be ready for FE first crack
      
      * Add `display-info` for drill-thrus and the special pivot functions
      
      Clean up and should be ready for FE first crack
      
      * Integrating the basic drill-thru ops, with some debugging hacks
      
      * Fix bad spelling of parameters
      
      * bunch of a progress, :null sentinel, refactor to context
      
      * tests for lots more cases; two missing drills
      
      * adding underlying records drills, not yet working
      
      * fixing up to work with upstream changes
      
      * fixes from Denis' PR
      
      * more progress debugging FE drills and adding tests
      
      * drill tests coming along
      
      * cleanup, test fixes
      
      * display-info-js for recursion
      
      * Add TS typing for displayInfo of drill thrus
      
      * partial changes for underlying records
      
      * hack hack
      
      * splitting out progression logic to a separate file
      
      * Lint and test cleanup
      
      * MLv2 pivot reorganization part 1
      
      * MLv2 pivots reorganization
      
      * Revert some unneeded changes
      
      * Don't enable the histogram test
      
      * Fix lint errors and add a drill-thru-method implementation for sort
      
      * `drill-thru` should support > 3 args
      
      * Fix `mu/defmethod` for Cljs
      
      * Fix reader error in commented-out code :unamused:
      
      
      
      * appease Eastwood
      
      ---------
      
      Co-authored-by: default avatarBraden Shepherdson <braden@metabase.com>
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      Unverified
      1d2e85dd
    • Cal Herries's avatar
  5. Aug 31, 2023
  6. Aug 30, 2023
  7. Aug 29, 2023
  8. Aug 28, 2023
Loading