This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Sep 05, 2023
-
-
Ryan Laurie authored
* parameterize collection and dashboard ids in e2e tests * fix copyPasta errors * appease the linter * obey the linter
-
Cam Saul authored
* First crack at drill-thru, adding quick-filter-drill * Adding object detail drill Needs tests for the multi-PK case * Add distribution-drill and foreign-key-drill * Add sort drill * summarize-column and part of automatic-insights * Add `display-info` for drill-thrus and the special pivot functions Clean up and should be ready for FE first crack * Add `drill-thru` implementations for all current drills * small fixes * overhaul of available-drill-thru Fixes several issues with targeting, merges in Mode logic, fixes pivot-drills Still TODO: other drills' mode conditions; lots of checking and testing the various cases of what should be shown; writing tests for that. * Add `display-info` for drill-thrus and the special pivot functions Clean up and should be ready for FE first crack * Add `display-info` for drill-thrus and the special pivot functions Clean up and should be ready for FE first crack * Integrating the basic drill-thru ops, with some debugging hacks * Fix bad spelling of parameters * bunch of a progress, :null sentinel, refactor to context * tests for lots more cases; two missing drills * adding underlying records drills, not yet working * fixing up to work with upstream changes * fixes from Denis' PR * more progress debugging FE drills and adding tests * drill tests coming along * cleanup, test fixes * display-info-js for recursion * Add TS typing for displayInfo of drill thrus * partial changes for underlying records * hack hack * splitting out progression logic to a separate file * First crack at drill-thru, adding quick-filter-drill * Adding object detail drill Needs tests for the multi-PK case * Add distribution-drill and foreign-key-drill * Add sort drill * summarize-column and part of automatic-insights * Add `display-info` for drill-thrus and the special pivot functions Clean up and should be ready for FE first crack * Add `drill-thru` implementations for all current drills * small fixes * overhaul of available-drill-thru Fixes several issues with targeting, merges in Mode logic, fixes pivot-drills Still TODO: other drills' mode conditions; lots of checking and testing the various cases of what should be shown; writing tests for that. * Add `display-info` for drill-thrus and the special pivot functions Clean up and should be ready for FE first crack * Add `display-info` for drill-thrus and the special pivot functions Clean up and should be ready for FE first crack * Integrating the basic drill-thru ops, with some debugging hacks * Fix bad spelling of parameters * bunch of a progress, :null sentinel, refactor to context * tests for lots more cases; two missing drills * adding underlying records drills, not yet working * fixing up to work with upstream changes * fixes from Denis' PR * more progress debugging FE drills and adding tests * drill tests coming along * cleanup, test fixes * display-info-js for recursion * Add TS typing for displayInfo of drill thrus * partial changes for underlying records * hack hack * splitting out progression logic to a separate file * Lint and test cleanup * MLv2 pivot reorganization part 1 * MLv2 pivots reorganization * Revert some unneeded changes * Don't enable the histogram test * Fix lint errors and add a drill-thru-method implementation for sort * `drill-thru` should support > 3 args * Implement timeseries zoom drill thru * Fix circular refs * Fix `mu/defmethod` for Cljs * Fix reader error in commented-out code
* appease Eastwood * PR feedback --------- Co-authored-by:Braden Shepherdson <braden@metabase.com> Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-
Nemanja Glumac authored
[ci skip]
-
Nemanja Glumac authored
* PoC: Download previously saved uberjar for E2E workflow * Separate `e2e_specs` and `e2e_all` file path triggers * Fix file path result oputput * Refine E2E tests conditional trigger * Further refine E2E tests conditional trigger * Download the uberjar directly where it's needed * Work around inability to dynamically define job ouputs * First obtain the artifact, then run anything else * Map job outputs https://docs.github.com/en/actions/using-jobs/defining-outputs-for-jobs * Apply changes to visual regression tests * Final logic cleanup * Work around the API rate limit
-
Oisin Coveney authored
-
Noah Moss authored
* Don't decode SSO redirect URLs before extracting host * clean ns * re-add kondo ignore * address feedback
-
Anton Kulyk authored
* Remove external op on the FE * Clean commit
-
Kamil Mielnik authored
* Extract ObjectDetailBody to a separate file * Extract ObjectDetailHeader to a separate file * Extract ObjectDetailView to a separate file - extract ObjectDetailWrapper.styled.tsx * Extract ObjectDetailHeader unit tests * Extract ObjectDetailBody unit tests * Rename ObjectDetail.unit.spec.tsx to ObjectDetailView.unit.spec.tsx
-
- Sep 04, 2023
-
-
adam-james authored
* Modify GET /api/user endpoint to only work for admins/group managers * Restrict group managers to only see users of groups they manage * Adjust segmented user tests and dedupe when user in multiple groups * Revert a small change that broke other tests. Change wasn't strictly needed anyway. * Properly enable premium feature :advanced-permissions in group-manager test * Fix sandbox user list tests. Count query needs distinct now bc of how group manager user list is returned * Add back the filter I forgot to include in the count query * Unused require due to a change in one of the tests * Fix group-manager permissions logic on the user endpoint * Update src/metabase/api/user.clj Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> * Changed endpoint's logic and impl slightly - cleaner group-ids-for-manager query - use existing validation/check-manager-of-group - simplify group-id-clause since at that point we know that the user is admin or group manager Added a test case to ensure group-manager still only gets their groups users when group_id is not supplied These scenarious should be accounted for in this setup now ;; ADMIN GM group_id GM of group_id OUTCOME ;; t t t t can see users from that group ;; t t t f can see users from that group (bc admin can see) ;; t f t f can see users from that group (bc admin can see) ;; t t f f can see all (admin can see all) ;; f t f f can see users from all groups they manage ;; f t t t can see users from that group ;; f t t f cannot see (bc non admin, GM of different group) * Alter tests to correctly check 403 in OSS setting * Modify test to use generic verified by text since User endpoint is now more restricted. * Strange pulse e2e test. Intercept the user api call to circumvent for now * request recipients through /api/user/recipients instead of /api/user * I don't even know anymore. Why did this change now? Seems that there's a collection ID where before there was a null, which caused redirect to collection/root --------- Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by:
Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
-
Oisin Coveney authored
-
- Sep 02, 2023
-
-
Cam Saul authored
Migrate QP/drivers code to use MLv2 metadata directly; make another 100+ tests parallel and shave 12 seconds off test suite (#33429) * QP MLv2 Metadata Provider follow-ons * Update lots of stuff to use MLv2 metadata instead of legacy metadata * Fix lint warnings * B I G cleanup * Everything is neat * Mention new test pattern in driver dev changelog * Appease Cljs by renaming a bunch of namespaces * Move more stuff over * Fix kondo errors * Fix even more things * Test fixes * Fix JS export * Test fixes
* Fix final MongoDB test -
metamben authored
* Bump simple changes * Account for changed exception message * Add buddy-sign license * Use maven coordinates to select tools.build version
-
- Sep 01, 2023
-
-
Jeff Bruemmer authored
* alternatives * remove links * remove mentions of eb * remove eb from rds page
-
Luis Paolini authored
... you can reference when using native questions
-
metamben authored
Fixes #33490.
-
Cam Saul authored
* First crack at drill-thru, adding quick-filter-drill * Adding object detail drill Needs tests for the multi-PK case * Add distribution-drill and foreign-key-drill * Add sort drill * summarize-column and part of automatic-insights * Add `display-info` for drill-thrus and the special pivot functions Clean up and should be ready for FE first crack * Add `drill-thru` implementations for all current drills * small fixes * overhaul of available-drill-thru Fixes several issues with targeting, merges in Mode logic, fixes pivot-drills Still TODO: other drills' mode conditions; lots of checking and testing the various cases of what should be shown; writing tests for that. * Add `display-info` for drill-thrus and the special pivot functions Clean up and should be ready for FE first crack * Add `display-info` for drill-thrus and the special pivot functions Clean up and should be ready for FE first crack * Integrating the basic drill-thru ops, with some debugging hacks * Fix bad spelling of parameters * bunch of a progress, :null sentinel, refactor to context * tests for lots more cases; two missing drills * adding underlying records drills, not yet working * fixing up to work with upstream changes * fixes from Denis' PR * more progress debugging FE drills and adding tests * drill tests coming along * cleanup, test fixes * display-info-js for recursion * Add TS typing for displayInfo of drill thrus * partial changes for underlying records * hack hack * splitting out progression logic to a separate file * First crack at drill-thru, adding quick-filter-drill * Adding object detail drill Needs tests for the multi-PK case * Add distribution-drill and foreign-key-drill * Add sort drill * summarize-column and part of automatic-insights * Add `display-info` for drill-thrus and the special pivot functions Clean up and should be ready for FE first crack * Add `drill-thru` implementations for all current drills * small fixes * overhaul of available-drill-thru Fixes several issues with targeting, merges in Mode logic, fixes pivot-drills Still TODO: other drills' mode conditions; lots of checking and testing the various cases of what should be shown; writing tests for that. * Add `display-info` for drill-thrus and the special pivot functions Clean up and should be ready for FE first crack * Add `display-info` for drill-thrus and the special pivot functions Clean up and should be ready for FE first crack * Integrating the basic drill-thru ops, with some debugging hacks * Fix bad spelling of parameters * bunch of a progress, :null sentinel, refactor to context * tests for lots more cases; two missing drills * adding underlying records drills, not yet working * fixing up to work with upstream changes * fixes from Denis' PR * more progress debugging FE drills and adding tests * drill tests coming along * cleanup, test fixes * display-info-js for recursion * Add TS typing for displayInfo of drill thrus * partial changes for underlying records * hack hack * splitting out progression logic to a separate file * Lint and test cleanup * MLv2 pivot reorganization part 1 * MLv2 pivots reorganization * Revert some unneeded changes * Don't enable the histogram test * Fix lint errors and add a drill-thru-method implementation for sort * `drill-thru` should support > 3 args * Fix `mu/defmethod` for Cljs * Fix reader error in commented-out code
* appease Eastwood --------- Co-authored-by:Braden Shepherdson <braden@metabase.com> Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-
Cal Herries authored
-
- Aug 31, 2023
-
-
Noah Moss authored
* quote impersonation roles for postgres conn impersonation * also quote snowflake roles
-
metamben authored
Fixes #21502. * Fix flaky test * Fix all occurrences of the typo replaced-indecies
-
Noah Moss authored
-
Jesse Devaney authored
* refactor use-list-select hook - toggleAll(items) felt unintuitive as some items could be selected while simultaneously unselecting others - switched to selectOnlyTheseItems(items) to be more explicit on what the function is doing - updated consumers of useListSelect to use the new API * convert to typescript * improve types * add desired behavior verification for useListSelect
-
Cam Saul authored
-
Noah Moss authored
* throw exception if impersonated db doesn't have default role * change text in snowflake plugin file * fix bugs and add tests * FE changes * inline enabled? call * add new driver feature connection-impersonation-requires-role * use variant=brand * break out impersonation-enabled-for-db? into a defenterprise helper function
-
Cam Saul authored
* MLv2: add `findColumnForLegacyRef` and `findFilterableColumnForLegacyRef` * Fix JS tests * Fix typo * Remove stray comment
-
- Aug 30, 2023
-
-
Ryan Laurie authored
* obey hidden widget settings in ColumnSettings widgets * always show unambiguous sample dates
-
Noah Moss authored
* lower-case column names in internal queries so that things dont break for h2 * fix tests * Update enterprise/backend/test/metabase_enterprise/audit_app/pages_test.clj Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> --------- Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
metamben authored
It's not only nil that can cause trouble, in some situations maps (i.e., incomplete columns) can reach this point too.
-
Emmad Usmani authored
-
Braden Shepherdson authored
There are still some pieces missing, but this has gone far enough to prove the concept. Follow-up PRs can carry this forward. ## Missing parts - Three drills (`automatic-insights`, `format`, `zoom-in`) are unimplemented. - A handful of drills will be returned by `available-drill-thrus` but do not have `drill-thru-method` implementations so they can't be applied. - Two or three drills have extra FE-only changes that need to be captured somewhere else. (Eg. changing the `card.display`) ## Interface - `available-drill-thrus` returns opaque maps describing the set of applicable drills - `display-info` on the drills to get an FE-friendly object - `drill-thru` to apply a drill to a query when clicked.
-
Ngoc Khuat authored
-
Cam Saul authored
* MLv2: generate 'consistent' display names (#24703) * Handle blank 'source' description correctly * Fix failing test
-
Mahatthana (Kelvin) Nomsawadi authored
-
- Aug 29, 2023
-
-
Alexander Polyankin authored
-
Cam Saul authored
* Fix `required-native-extras` for Cljs and add TypeScript wrappers * Oops add missing TS function impls
-
Nick Fitzpatrick authored
-
Vamsi Peri authored
* Run Cloverage job only on merge to `master` * Use shorter `github.ref_name` * [Reopened] Run Cloverage job only on merge to master --------- Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
-
metamben authored
Fixes #33527.
-
Alexander Polyankin authored
-
- Aug 28, 2023
-
-
Cam Saul authored
* MLv2 schema should enforce distinct breakouts and fields #32489 * Enforce distinct breakouts and fields (#32489)
-
Vamsi Peri authored
* Run chromatic CI job when there is a label called chromatic * Fix: Run chromatic job when one of the labels is chromatic * Run frontend checks when a new label is added - this will cover adding chromatic label too * added unlabeled event to frontend workflow * undo formatting changes
-