Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jan 19, 2023
  2. Jan 18, 2023
  3. Jan 17, 2023
  4. Jan 16, 2023
  5. Jan 13, 2023
    • Case Nelson's avatar
      FieldValues skipping but not updating last used at (#27655) · 33d54e53
      Case Nelson authored
      * FieldValues skipping but not updating last used at
      
      Related to #26863
      
      When fieldvalues synching was being skipped, the
      `get-or-create-full-field-values!` call was erroneously forgetting to
      update the `last_used_at` time; the time was only being updated if new
      field values came in since the last sync.
      
      * Add test for inactive field values
      
      * Only update last_used_at when there's an existing fieldvalues
      Unverified
      33d54e53
    • metamben's avatar
      Support nested queries for MongoDB (#27615) · 76db79d9
      metamben authored
      Unverified
      76db79d9
    • Braden Shepherdson's avatar
      [metabase-lib] Number and currency formatting polish (#27616) · e7e422cf
      Braden Shepherdson authored
      - Use currency-specific decimals count (eg. 0 for JPY, 8 for BTC)
      - Use plural currency names in Java, matching JS
          - previously: singular proper name "7.23 US Dollar"
          - now: plural prose "7.23 US dollars"
      - "Small numbers" hack to treat min/max fraction digits as significant
        digits now applies to percentages under 1%, as well as the original
        |n| < 1
      Unverified
      e7e422cf
    • Mark Bastian's avatar
      Fixed regex for latitude name type matching (#27614) · f395e2f2
      Mark Bastian authored
      * Fixed regex for latitude name type matching
      
      * Grouping regexes by lon/lat
      Unverified
      f395e2f2
    • Braden Shepherdson's avatar
      [metabase-lib] Port date and time parsing and formatting to CLJC (#27551) · 335d161f
      Braden Shepherdson authored
      This adds a cross-platform date/time formatting library in CLJC, with
      (nearly) identical output in both JVM and JS environments.
      
      The only known difference is week numbers.
      
      CLJS (through Moment.js) has ordinal numbers, and renders the week
      number as "34th". Neither the JVM nor Clojure has a handy library for
      this (I'm sure it's out there somewhere, but it seems like a silly
      dep to add) so it renders week numbers as simply "34".
      
      Both platforms have date formatters that use pattern strings (eg.
      `"YYYY-MM-dd"`) to turn date/time objects into strings. There's a strong
      resemblance in how these work and what letters stand for what parts of
      the date and time, but they are far from identical.
      
      Rather than try to hackily convert one set of strings to another with
      regexes or other manipulations, this PR defines a set of names for
      fragments of dates (eg. `:year`, `:day-of-week-full`, `:hour-24-dd`)
      and includes functions to transform a list of these keys into a
      platform-specific format function.
      
      This is portable and transparent, and can be written in Clojure or
      JS code:
      
      ```clj
      [:year "-" :month-dd "-" :day-of-month-dd]   ; 2022-04-08
      [:month-full " " :day-of-month-d ", " :year] ; April 8, 2022
      [:hour-12-dd ":" :minute-dd " " :am-pm]      ; 7:52 AM
      ```
      
      ```js
      [":year", "-", ":month-dd", "-", ":day-of-month-dd"]   ; 2022-04-08
      [":month-full", " ", ":day-of-month-d", ", ", ":year"] ; April 8, 2022
      [":hour-12-dd", ":", ":minute-dd", " ", ":am-pm"]      ; 7:52 AM
      ```
      
      Note that the original code allowed an unrecognized `:date-style` string
      to be used directly as the formatting string. With the move to
      formatting data structures that no longer works. Instead there is a
      fixed map of format strings to the above data structures, that contains
      all the currently used `:date-style` inputs.
      
      If some caller needs a new format someday, we can either: (a) add the
      style to the map; or (b) pass the data structure form directly to the
      `:date-format` option, which if provided is used as the format.
      
      It's tempting to go to all the call sites and replace these `:date-style`
      strings with the new format structures. However, the strings are still
      embedded in the `:visualization_settings` in user appDBs, so we still
      need to recognize them.
      
      Most of the existing functions in the TS library have the same API.
      
      The set of allowed `:date-style` and `:time-style` values is turned into
      a type using `keyof`, so that we get precise type-checking of these
      values rather than simply `string`.
      
      One function has been dropped from the API: `getDateFormatFromStyle`.
      There was no practical way to implement it using the new format data
      structures. The only caller was the date format column settings, and it
      has been rewritten to use the formatted string for its sample date as
      its key instead.
      Unverified
      335d161f
    • Nemanja Glumac's avatar
      [CI] Fix Trivy scans timing out (#27670) · e908df7c
      Nemanja Glumac authored
      Unverified
      e908df7c
  6. Jan 12, 2023
    • Aleksandr Lesnenko's avatar
      pie chart stacked tooltip (#27638) · c612f7d1
      Aleksandr Lesnenko authored
      Unverified
      c612f7d1
    • Bryan Maass's avatar
      malli describe fixes (#27602) · 69f49f05
      Bryan Maass authored
      * updates + updates tests
      
      - use titles for everything
      - repeat "sounds" right
      - biding time to remerge upstream
      
      * Update src/metabase/util/malli/describe.clj
      
      * pluralize times ouhgt to be private
      
      * keep error messages in tests in sync :neutral_face:
      
      * linter newline
      Unverified
      69f49f05
    • Aleksandr Lesnenko's avatar
      revert new tooltips for non-stacked series (#27620) · c218a9e2
      Aleksandr Lesnenko authored
      * revert new tooltips for non-stacked series
      
      * types
      Unverified
      c218a9e2
    • dpsutton's avatar
      restore aliases before annotating (#27637) · 3ddce607
      dpsutton authored
      * restore aliases before annotating
      
      * cleanup
      
      * fix tests
      
      * Don't add escaped->original if aliases have not changed
      
      No need to walk and replace the aliases if they are identical. And in
      that case, no need to keep a mapping of identical to identical. Not
      super important but saves some time and complexity, and keeps other
      tests passing since the presence of [:info :alias/escaped->original] in
      the query caused them to trivially fail.
      
      * oracle has a smaller limit and _expected_ mangled
      
      previous testing behavior was "what happened" and not what should
      happen. we fixed the bug but the "expect garbage" behavior was still
      present
      
      * Relax :alias/escaped->original schema
      
      oracle tests use keywords for the alias
      
      ```clojure
      {:alias/escaped->original
       {:test-data-venues--via-a763718f "test_data_venues__via__venue_id",
        :test-data-users--via--user-id "test_data_users__via__user_id"}}}
      ```
      
      No idea why that is keyworded
      
      * relax `:alias/escaped->original` schema
      
      see previous commit
      Unverified
      3ddce607
Loading