Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Dec 13, 2022
    • Anton Kulyk's avatar
      Cherry pick new data picker component to master (#27174) · a0d9e138
      Anton Kulyk authored
      
      * Add basic raw data picker for app scaffolding (#25997)
      
      * Show data app page ID params in editing mode (#25943)
      
      * Data apps layout updates (#25930)
      
      * play with grid sizes to make apps feel appier [ci skip]
      
      * move app nav to bar inside app
      
      * only hide other header buttons outside of edit mode
      
      * tweak overflow issue
      
      * fix header width on data apps
      
      * add control to see app contents
      
      * set data apps layout constants contextually [ci skip]
      
      * remove hardcoded value [ci skip]
      
      * extract conextual header styles [ci skip]
      
      * set max-width on paramaters for data apps [ci skip]
      
      * move data apps nav deeper, only show if not editing [ci skip]
      
      * add spacing to contents trigger, rm old code [ci skip]
      
      * rm table thing for now [ci skip]
      
      * Fixes for data app layout updates (#25962)
      
      * Reorder import
      
      * Fix type
      
      * Fix missing translation, move out URL
      
      * Remove not used import
      
      * Rework `getSelectedItems` utility for data apps
      
      * Fix selected data app page highlighting
      
      * Don't reload app navbar on page change
      
      * Change nav item links look
      
      * Remove `DataAppPageSidebarLink`
      
      * Turn nav into HTML list
      
      * Use styled components
      
      * Fix edit button covered by visualizations
      
      * Fix opening homepage
      
      * Remove redundant prop
      
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      
      * First take at parameterized data app page titles (#25938)
      
      * Bring `DataAppContext` back
      
      * Pass `onFocus` and `onBlur` to `EditableText`
      
      * Export `EditableTextProps`
      
      * Add basic `DataAppPageTitle` component
      
      * Use `DataAppPageTitle`
      
      * Fix component name
      
      * Add primitive autocompletion to page title input
      
      * Add `title_template` to `DataAppNavItem` type
      
      * Tweak value management in `DataAppPageTitle`
      
      * Handle `null` values in titles more gracefully
      
      * Don't show suggestions without detail cards
      
      * Don't add whitespace when pasting a token
      
      * Don't update app's collection all the time
      
      * Add data app related selectors to dashboard selectors
      
      * Add redux state to keep title template changes
      
      * Update page title template on page save
      
      * Wire up `DataAppPageTitle` with dashboard code
      
      * Fix unit tests
      
      * Reset state on exiting editing mode
      
      * Add back button to template data picker
      
      * Add `PanePicker` UI component
      
      * Add basic `RawDataPanePicker` component
      
      * displays databases, schemas, tables
      * allows picking a database and a schema (no tables yet)
      
      * Allow picking tables
      
      Supports single-selection and multi-selection modes
      
      * Auto-select single database schema
      
      * Use `.ts` instead of `.tsx` for hook file
      
      * Style `PanePicker`
      
      * Add `onTablesChange` callback prop to data picker
      
      * Use new data picker in new app modal
      
      * Use new data picker in add data modal
      
      * Remove `DataAppDataPicker`
      
      Co-authored-by: default avatarKyle Doherty <5248953+kdoh@users.noreply.github.com>
      
      * Make `DataPicker` controlled (#26018)
      
      * Add data type picker to scaffolding data picker (#26019)
      
      * Move `useSelectedTables` one level up
      
      * Extract `DataPickerSelectedItem` type
      
      * Add `type` to `DataPickerValue` type
      
      * Handle `type` in `useDataPickerValue` hook
      
      * Add data type picker step
      
      * Add back button to raw data picker
      
      * Add `CardPicker`
      
      * Tweak spacing
      
      * Move `VirtualTable` to shared picker types
      
      * Temporary disable saved questions data type
      
      * Simplify schema loading for models and questions
      
      * Remove redundant `useMemo`
      
      * Rename `RawDataPanePicker` to `RawDataPicker` (#26020)
      
      * Add safety checks to scaffolding data picker (#26023)
      
      * Pass available data types as a prop to the picker
      
      * Use nested queries settings for data types list
      
      * Offer models only if instance has at least one
      
      * Check data access
      
      * Break `DataPicker` into container and view
      
      * Make `DataPicker` cover the whole container
      
      * Add items filters API to data app scaffolding data picker (#26024)
      
      * Uncomment saved questions data type
      
      * Add data picker filters API types
      
      * Apply data type filters
      
      * Auto pick a data type when only one is available
      
      * Export data picker types
      
      * Add `DataAppScaffoldingDataPicker` component
      
      * Use `DataAppScaffoldingDataPicker`
      
      * Improve collection selection for scaffolding data picker (#26033)
      
      * Add collection ID to data picker value type
      
      * Handle collection ID in `onChange`
      
      * Handle collection ID in `CardPicker`
      
      * Automatically open root collection
      
      * Add basic search to scaffolding data picker (#26039)
      
      * Add data picker context
      
      * Add global search to data picker
      
      * Add basic search UI to new app modal
      
      * Don't use database ID in search
      
      * Scope search depending on selected data type
      
      * Expose more data picker types
      
      * Style search input
      
      * Keep filtered out data types in mind for search
      
      * Move `MIN_SEARCH_LENGTH` to constants file
      
      * Fix can't select nested collection in card picker (#26122)
      
      * Fix conflicts
      
      Co-authored-by: default avatarKyle Doherty <5248953+kdoh@users.noreply.github.com>
      Unverified
      a0d9e138
  2. Oct 26, 2022
  3. Oct 13, 2022
  4. Sep 21, 2022
  5. Nov 15, 2021
    • Anton Kulyk's avatar
      Cleanup QuestionDataSource and fix breadcrumb links issues (#18962) · 88cc45c4
      Anton Kulyk authored
      * Remove not used `noLink` prop
      
      * Namespace URL generators
      
      * Fix HeaderBreadcrumbs font-size in "head" mode
      
      * Add unit-tests for QuestionDataSource
      
      * Allow using react nodes in breadcrumbs
      
      * Use func declaration for QuestionDataSource
      
      * Add prop-types
      
      * Simplify query assignment expr
      
      * Don't swallow errors in QuestionDataSource tests
      
      * Add repro for #17961 (unit)
      
      * Allow passing custom divider for HeaderBreadcrumbs
      
      * Fix join tables breadcrumb links
      
      * Add extra saved question utils
      
      * Add tests for nested questions
      
      * Fix source question link
      
      * Don't show source question's schema
      
      * Fix breadcrumb colors
      
      * Fix tests
      
      * Fix breadcrumb colors
      
      * Use saved-questions lib utils for DataSelector
      Unverified
      88cc45c4
  6. Nov 03, 2021
    • Anton Kulyk's avatar
      Update query builder data selector for datasets (#18764) · 868f8782
      Anton Kulyk authored
      * Add unit tests for schema utils
      
      * Add data bucket step to DataSelector
      
      * Go to next steps from the data bucket step
      
      * Add different type of AccordionList icons layout
      
      * Add back navigation from 'Raw Data' tab
      
      * Fix selecting a database in 'Raw Data'
      
      * Enable search on data bucket step
      
      * Only render data bucket step if there are datasets
      
      * Prevent opening the data bucket step without datasets
      
      * Update picker search placeholder text
      
      * Update searchable models
      
      * Fix displaying datasets in search results
      
      * Hide "Saved Questions" in "Raw Data" tab
      
      * Encode data in schema str
      
      * Add ability to request dataset virtual tables
      
      * Support datasets in SavedQuestionPicker
      
      * Use saved question picker for datasets too
      
      * Add E2E tests
      
      * Show dataset icon in search results
      
      * Fix E2E selectors
      
      * Fix AccordionList icon rendering
      
      * Fix dataset can't be selected in search
      
      * Fix data selector step hydration
      
      * Fix JoinStep unit tests
      
      * Fix dataset icon size in picker view
      
      * Fix schema picker without datasets
      
      * Fix DataSelector tests
      
      * Fix error about null data selector step
      
      * Move schema utils to `metabase/lib`
      
      * Fix questions don't appear in pickers after created
      
      * Fix JoinStep unit tests
      
      * Test can create a question based on a dataset
      
      * Simplify schema ID parsing
      
      * Fix typo
      
      * Fix search models
      
      * Fix ellipsis character
      
      * Fix "Raw Data" button click area
      
      * Remove temp comment
      
      * Fix URL in personal collection contents request
      Unverified
      868f8782
  7. Oct 07, 2021
    • Anton Kulyk's avatar
      Fix new questions don't appear in the Saved Questions picker (#18095) · 8c43bd62
      Anton Kulyk authored
      * Enable repro
      
      * Move saved questions virtual DB id to own file
      
      * Add saved question helpers
      
      * Add test-id to Metabase logo component
      
      * Extend repro test to cover archived items handling
      
      * Handle saved question actions in schema entity
      
      * Handle saved question actions in table entity
      
      * Fix moved file import
      
      * Fix Cypress can't find logo in EE (whitelabeling)
      
      * Fix saved questions order
      
      * Fix saved questions included in database tables
      Unverified
      8c43bd62
Loading