Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Apr 23, 2024
  2. Apr 22, 2024
    • Noah Moss's avatar
      New default permissions for groups (#41323) · 39627a3a
      Noah Moss authored
      39627a3a
    • adam-james's avatar
      Dates Binned by Week Export Formatting Matches App (#41619) · 97861b15
      adam-james authored
      * Dates Binned by Week Export Formatting Matches App
      
      Fixes: #41492
      
      Before, the dates binned by week would be formatted as follows in CSV and JSON exports:
      
      `Week 1 - 2024`
      
      But that doesn't match the App's format of a Date Range:
      
      `January 1, 2024 - January 7, 2024`
      
      So, now the exports will apply formatting in this same way.
      
      Note that a second bug (#41616) exists on the Frontend preventing the column formatting being applied in the app. This is
      frontend only, and the csv and json exports will match the column formatting settings (eg. abbreviated dates and
      alternative separators will be used in the export).
      
      * add test and change default week style
      
      * Week format test change
      
      * also fix incorrect :hour formatting
      97861b15
    • A. Marius Rabenarivo's avatar
      [tech debt] Stop using ms/BooleanString and only use ms/BooleanValue (#41390) · faab06e3
      A. Marius Rabenarivo authored
      * [tech debt] Stop using ms/BooleanString and only use ms/BooleanValue
      
      ms/BooleanString will coerce to a string, and we should probably get rid of it and only ever use ms/BooleanValue which will always coerce to a boolean
      We want the coercion layer to give us values that are helpful, and true is more helpful than "true".
      So we should remove ms/BooleanString and calls to parseBoolean
      
      * Remove ms/BooleanString usage in api/native_query_snippet.clj
      
      * Remove test case related to ms/BooleanString
      
      * Remove the BooleanString schema def as no longer used
      faab06e3
  3. Apr 19, 2024
  4. Apr 18, 2024
  5. Apr 17, 2024
  6. Apr 16, 2024
  7. Apr 15, 2024
  8. Apr 12, 2024
    • adam-james's avatar
      Bugfix 37914 wrong filters UI in embedding (#41342) · f826a28f
      adam-james authored
      * Keep Filter Values for enabled Parameters in Embedding
      
      Fixes: #37914
      
      Previously, we removed locked parameters entirely. This is to prevent leaking potentially sensitive values.
      
      However, for the situation where the same field backs 1 locked or disabled paramter and 1 enabled parameter, we do
      still want to send the paramater values, because the enabled parameter implies that the values are permissible to see
      in the embed.
      
      So, this change will still remove parameters based on their 'disabled/locked/enabled' status, but will NOT remove the
      linked field ids if they're also being used by 'enabled' parameters.
      
      This results in the backend correctly sending necessary parameter values to the embed, where the frontend can then
      render the appropriate UI instead of falling back to just text filters.
      
      * test the case where a locked and enabled param share same field
      
      * Address feedback. Added comment to explain classify fn
      f826a28f
    • lbrdnk's avatar
      Exclude implicitly joinable columns from visible-columns in fk-columns-to (#41274) · 5d8cc872
      lbrdnk authored
      * Exclude implicitly joinable columns from visible-columns in fk-columns-to
      
      * Add test
      
      * Update description
      5d8cc872
    • Cam Saul's avatar
      [P1 BUG FIX] Cumulative aggregations with multiple breakouts should reset... · b93e99dc
      Cam Saul authored
      [P1 BUG FIX] Cumulative aggregations with multiple breakouts should reset counts when values of breakouts other than change (#41340)
      
      * Fix add-alias-info matching for nominal field literal refs
      
      * Minor cleanup
      
      * Minimize diff
      
      * A bit more cleanup
      
      * Cumulative aggregations w/ multiple breakouts should reset counts (#2862)
      
      * Update dox
      
      * Do the nesting FIRST before adding alias info.
      
      * Remove unused
      b93e99dc
    • Cal Herries's avatar
      Sample content (#40753) · bdb34a33
      Cal Herries authored
      bdb34a33
    • Cal Herries's avatar
    • Cam Saul's avatar
      Fix `add-alias-info` matching for nominal field literal refs (#41326) · dd40ac5f
      Cam Saul authored
      * Fix add-alias-info matching for nominal field literal refs
      
      * Minor cleanup
      
      * Minimize diff
      
      * A bit more cleanup
      dd40ac5f
  9. Apr 11, 2024
Loading