Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Sep 06, 2024
  2. Sep 05, 2024
  3. Sep 04, 2024
    • Aleksandr Lesnenko's avatar
      fix hidden pivot table scroll bar in QB (#47629) · 798c81a7
      Aleksandr Lesnenko authored
      
      * fix hidden pivot table scroll bar in QB
      
      * Update Loki Snapshots
      
      * Update Loki Snapshots
      
      ---------
      
      Co-authored-by: default avatarMetabase Automation <github-automation@metabase.com>
      Unverified
      798c81a7
    • appleby's avatar
      Store ::nil markers in CachedMetadataProvider for failed lookups (#47589) · 03aff864
      appleby authored
      * Fix typo in MetadataProvider docstring
      
      * Fix typo in caching-test: s/Second/Third/
      
      * Store ::nil markers in CachedMetadataProvider for failed lookups
      
      Store ::nil markers in CachedMetadataProvider for any ids for which the wrapped/uncached upstream provider fails to return
      metadatas. This prevents repeatedly querying the uncached-provider for ids that don't exist.
      
      The downside is that if the uncached-provider suddenly starts returning metadata for an id that previously did not
      exist, we won't pick up on it, but the assumption here is that this is no different / worse than cache invalidation
      for existing ids that happen to change after we cache them.
      
      * PR suggestion: remove unnecessary test assertion
      Unverified
      03aff864
Loading