Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 29, 2024
    • Nick Fitzpatrick's avatar
      Query validator FE (#47098) · b7349ec5
      Nick Fitzpatrick authored
      * Query Validator FE
      
      * collection path, unit tests
      
      * wrapping feature with token flag
      
      * updating util function, adding row type
      
      * updating session_test.clj
      
      * type adjustment
      
      * fixing other table sorting
      
      * Empty state, clean up utils
      
      * unit test adjustment
      
      * e2e adjustment
      Unverified
      b7349ec5
    • Dennis Schridde's avatar
      Hide attached DWH database details (#47247) · 592360c9
      Dennis Schridde authored
      == Goal ==
      
      Hide attached DWH database details from anyone incl. admins:
      * Do not show them in the UI
      * Do not permit to change them
      * Do not serialize them
      
      The aim is that customers cannot gain access to (parts of) credentials,
      and they cannot break a feature they are paying for by changing
      connection details.
      
      == Implementation ==
      
      The Metabase backend already contains provisions in the implementation
      of `metabase.models.interface/to-json` for `:model/Database` to hide the
      `details` of the database in HTTP responses, if the user lacks write
      permission on the database.  We utilize this by adding an
      `is_attached_dwh` column to the `database` table and rejecting
      `metabase.models.interface/can-write?` when this flag is enabled.  In
      the "admin" UI, we show a replacement text instead of the edit form when
      the flag is set.  (It might be correct to show this whenever `details`
      is absent.  See below for possible follow-up work.)
      
      However, several sections of the frontend code expected the `details`
      field to always be present.  In order to make `details` optional, as the
      backend seems to handle it, we fix the respective code to treat this
      case in the way that appears appropriate in the context.
      
      Database details are already generally excluded from H2 dump snapshots
      (see `metabase.cmd.copy/*copy-h2-database-details*`), thus nothing
      changes there.
      
      == How to test ==
      
      === New behaviour ===
      
      Setting the `is_attached_dwh` field hides the database details:
      
      1. Configure a database as described in https://www.metabase.com/docs/latest/configuring-metabase/config-file#databases.
         - In addition to the fields you would normally set, also set
           `is_attached_dwh: true`.
         - This also works when adding this flag to a database that previously
           did not have this flag set.
      2. Start your Metabase instance.
      3. Verify the database shows up in the "admin" section
         (`/admin/databases`).
      4. Verify that clicking the database to see its details only reveals
         "This database cannot be modified."
      5. Verify that responses from the backend do not include a `details`
         field for this database.
      
      === Original behaviour ===
      
      Behaviour without setting the `is_attached_dwh` field is unchanged:
      
      1. Configure a database as described in https://www.metabase.com/docs/latest/configuring-metabase/config-file#databases.
         - Only set the fields you would normally set.  Do not set
           `is_attached_dwh` (or set it to `false`).
      2. Start your Metabase instance.
      3. Verify the database shows up in the "admin" section
         (`/admin/databases`).
      4. Verify that clicking the database to see its details only reveal the
         regular edit form, showing connection fields like `host`, `user`,
         etc. with the values you configured.
      
      == How this will be rolled out ==
      
      1. Upgrade existing Metabase Cloud instances with data warehouse to a
         Metabase version that supports `is_attached_dwh`.
      2. Set `is_attached_dwh` in the database section of the config file for
         Metabase Cloud instances with a data warehouse.
      
      == Possible follow-up work ==
      
      In https://github.com/metabase/metabase/issues/25715, absent
      `database.details` was identified as a bug.  Since then, `details` was
      made `NOT NULL` in the application database, so this bug can no longer
      occur.  However, today backend responses can be missing the `details`
      field, if the current user lacks write permission to the database
      setting (see above).  Fully re-evaluating the fix to #25715 in this
      context is outside the scope of this PR.
      
      Closes: https://github.com/metabase/harbormaster/issues/5051
      Unverified
      592360c9
  2. Aug 28, 2024
    • Phoomparin Mano's avatar
      feat(sdk): generate sample Express.js api and user switcher components via cli (#47060) · 41b7f329
      Phoomparin Mano authored
      
      * ask for tenancy isolation columns
      
      * deny all permissions for all users group
      
      * create new collections
      
      * add jwt group mappings
      
      * add the permissions step
      
      * add multi-tenancy message in helper text format
      
      * add permission graph
      
      * wire together permissions
      
      * use schema permissions
      
      * use fields from table metadata from query_metadata
      
      * add tenancy field reference
      
      * remove log messages
      
      * deny access to unsandboxed tables
      
      * make permission graph more explicit
      
      * deny access to sample database for customer groups
      
      * add unit test for permission graph
      
      * split permission groups and sandboxes
      
      * jwt settings and hard-coded user attributes
      
      * handle errors when updating sso mappings
      
      * add express api and user switcher
      
      * only fallback to api keys when license is invalid
      
      * add util to sample tenancy column values
      
      * conditional BASE_SSO_API imports
      
      * improve embedding error message
      
      * setup jwt configuration after license step
      
      * setup permissions at the last step
      
      * add missing import
      
      * update steps that requires license
      
      * fix incorrect imports
      
      * add missing useContext
      
      * handle permission update error
      
      * remove tenancyIsolationEnabled field
      
      * add tenancy column sampling
      
      * differentiate tenancy column query error
      
      * rename tenancyColumnValues to tenantIds
      
      * assign sampled tenant ids to user attributes
      
      * add tenant ids
      
      * define collection permissions
      
      * reference sandboxing group by name
      
      * update snippet to be same as the README
      
      * extract ask for tenancy columns to a separate step
      
      * use the customer_id attribute
      
      * query the table query metadata at origin
      
      * append tables correctly
      
      * improve error handling in table scanning
      
      * add retry logic to metadata fetching
      
      * only query metadata for selected fields
      
      * fix race condition with retry
      
      * update loading state and retries
      
      * update comments on jwt license
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      
      * filter the target table by id
      
      * highlight last selected tenant column
      
      * use breakout to get list of ids
      
      * temporary workaround to reload the whole page
      
      * update row value types
      
      * update row value types
      
      * block non-selected tables
      
      * remove the source-field from sandboxing
      
      * use the fk_target_field_id as instead of target.id
      
      * update unit test
      
      * remove source-field as we only reference our own column
      
      * make native permission types more strict
      
      ---------
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      Co-authored-by: default avatarOisin Coveney <oisin@metabase.com>
      Unverified
      41b7f329
    • Phoomparin Mano's avatar
      feat(sdk): setup permissions and sandboxing for embedding cli (#46857) · c574c09d
      Phoomparin Mano authored
      
      * ask for tenancy isolation columns
      
      * deny all permissions for all users group
      
      * create new collections
      
      * add jwt group mappings
      
      * add the permissions step
      
      * add multi-tenancy message in helper text format
      
      * add permission graph
      
      * wire together permissions
      
      * use schema permissions
      
      * use fields from table metadata from query_metadata
      
      * add tenancy field reference
      
      * remove log messages
      
      * deny access to unsandboxed tables
      
      * make permission graph more explicit
      
      * deny access to sample database for customer groups
      
      * add unit test for permission graph
      
      * split permission groups and sandboxes
      
      * jwt settings and hard-coded user attributes
      
      * handle errors when updating sso mappings
      
      * add util to sample tenancy column values
      
      * improve embedding error message
      
      * setup jwt configuration after license step
      
      * setup permissions at the last step
      
      * handle permission update error
      
      * add tenancy column sampling
      
      * differentiate tenancy column query error
      
      * rename tenancyColumnValues to tenantIds
      
      * define collection permissions
      
      * reference sandboxing group by name
      
      * extract ask for tenancy columns to a separate step
      
      * query the table query metadata at origin
      
      * append tables correctly
      
      * improve error handling in table scanning
      
      * add retry logic to metadata fetching
      
      * only query metadata for selected fields
      
      * fix race condition with retry
      
      * update loading state and retries
      
      * filter the target table by id
      
      * highlight last selected tenant column
      
      * use breakout to get list of ids
      
      * update row value types
      
      * block non-selected tables
      
      * remove the source-field from sandboxing
      
      * use the fk_target_field_id as instead of target.id
      
      * update unit test
      
      * remove source-field as we only reference our own column
      
      * make native permission types more strict
      
      ---------
      
      Co-authored-by: default avatarOisin Coveney <oisin@metabase.com>
      Unverified
      c574c09d
  3. Aug 27, 2024
  4. Aug 26, 2024
  5. Aug 23, 2024
  6. Aug 22, 2024
  7. Aug 21, 2024
  8. Aug 20, 2024
  9. Aug 19, 2024
    • bryan's avatar
      Add no-access table-level and schema-level permission (#46542) · 2bbcf745
      bryan authored
      
      * allow `:blocked` to be saved for table level perms
      
      * Adds 2 tests for table level blocked permission settings
      
      - N.B. these are NOT ENFORCED YET
      
      * update test that asserted we cannot set block on tables (we can)
      
      * WIP: Pairing on making perms checking less wild
      
      * cleanup, update docs, and add a test for view-data perm only
      
      - Added a test where we have data permissions, but not create query, and
        I think it is failing when we have create query and blocked data
        permissions.
      - renamed some functions from check-x -> has-x? since they return a
        value instead of throwing now
      
      * Revert "WIP: Pairing on making perms checking less wild"
      
      Keep the same behavior, but stick with the saner flow control
      
      This reverts commit 63bcb5b4.
      
      * update docs
      
      * update test to be passing
      
      - TODO: make sure it's correct w.r.t. perm settings
      
      * Allow schema level blocked setting in permgraph
      
      * remove invalid test cases
      
      - continue to have a forcing function to test newly added perms
      
      * conform function output
      
      * ensure a single blocked table blocks native queries to its DB
      
      * update error message
      
      - we now catch this error in `metabase.models.query.permissions/has-perm-for-query?`
      
      * we now check for data permissions to process query for card
      
      * add more explanation to what we are testing
      
      - to help see why it fails on CI and passes locally
      
      * remove excess `def`
      
      * Add test for table-level data X collection perms
      
      - update test found to be in-error
      
      * update param values qp permission check style
      
      * set view-data and create-query explicitly
      
      * set viewdata and createquery explicitly in qp test
      
      * Respond to review comments (which fixes a case)
      
      * setting a table to blocked: leave other tables the same
      
      * [Permissions] Add "No access" schema/table permission (#46509)
      
      * first pass
      
      * refactors downgrading native permission logic and updates calculation so that "No access" downgrades native permissions to "No"
      
      * stub for permissions help info on table block
      
      * modal changes wip, updates downgrading create queries permissions to all happen at a single call site
      
      * clean up, sandboxing modal copy changes, removes rekoke/limit access modal changes to make the diff smaller and move code to a seperate PR
      
      * updates permissions help section to contain the final copy
      
      * sandboxing copy fix and remove modal that was dropped from requirements
      
      * adds blocked at the schema level, updates no access copy to blocked, updates permissions help section to contain new blocked and schema level changes
      
      * fixes failed unit and e2e tests after sandboxing copy changes
      
      * improve the block e2e test to include table blocking
      
      * fixes failing blocked test, fixes other schemas create queries permissions getting correct with one schema was droped to blocked view data access, fixes a bug that prevents the save bar from going away when all permissions for group are set to the default values
      
      * clean up
      
      * remove color changes
      
      * prevents parent being set to blocked preventing edits for children entities
      
      * add new hasPermissionValueInSubgraph fn, adds modal to warn users we have to upgrade the view data permissions when they upgrade create queries permissions when a child entity is set to blocked
      
      * adds test coverage for new modal
      
      * removes unused function, adds new updateEntityPermission fn to help consolidate some logic elsewhere
      
      * unit test fix and type fix
      
      * most pr feedback
      
      * updates the confirmation modal copy when changing a parent entity that contains a child with blocked permissions and/or sandboxed children, adds test coverage for that, adds test coverage for permission view data column not appearing in oss
      
      * type fix
      
      * [Permissions] Add e2e test coverage for blocked permissions enforcements (#46663)
      
      * adds test coverage for enforcement of blocked permissions
      
      * moves tests around based on pr feedback
      
      * copy changes
      
      * adds fix to make sure that blocked permissions are not removed from sibling tables that have the create queries permissions upgraded (#46854)
      
      * Fix table name lookup for dbs w/ 1 schema per db
      
      * add test for blank schema identifiers
      
      * Refine sandboxed user perms for query builder access (#46939)
      
      * Refine sandboxed user perms for query builder access
      
      - Limit create-queries permissions to unblocked tables only
      - Check user permissions for each table before granting query builder access
      - Prevent querying of blocked joined tables from query builder for sandboxed users
      
      * Adjust permissions for sandboxed users
      
      - Grant view-data permissions only for unblocked tables
      - Revert create-queries permissions to all tables in sandbox
      - Remove unnecessary intermediate variable
      
      * when sandboxing we no longer grant unrestricted view perms for blocked tables
      
      * Update enterprise/backend/src/metabase_enterprise/sandbox/query_processor/middleware/row_level_restrictions.clj
      
      remove blank line
      
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      
      * - make coalesce-test exhaustive (except for sandbox)
      
      * Update enterprise/backend/src/metabase_enterprise/sandbox/query_processor/middleware/row_level_restrictions.clj
      
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      
      * t2/select ... -> database/table-id->database-id
      
      * update comment
      
      * [Permissions] Prevent "Granular" option in DB View Data options from changing permissions to unrestricted (#46976)
      
      * fix
      
      * adds back most of the code and limits it to only happen with impersonations, updates test to handle differing logic between the two flows
      
      * removes test that is not longer needed
      
      * more sandbox join table perms tests
      
      ---------
      
      Co-authored-by: default avatarJohn Swanson <john.swanson@metabase.com>
      Co-authored-by: default avatarSloan Sparger <sloansparger@users.noreply.github.com>
      Co-authored-by: default avatarSloan Sparger <sloansparger@gmail.com>
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      Unverified
      2bbcf745
    • Nemanja Glumac's avatar
      tech: Remove the last GoogleAnalytics tracking bits and references (#46980) · 2899046d
      Nemanja Glumac authored
      * Remove simple references to `trackStructEvent`
      
      * Remove `withAnalytics` entities helper
      
      * Remove `trackLoginSSO`
      
      * Remove auth trackers
      
      * Remove permissions trackers
      
      * Remove performance trackers
      
      * Remove settings trackers
      
      * Remove pulse trackers
      
      * Remove undo trackers
      
      * Remove click actions trackers
      
      * Remove `trackStructEvent`
      
      * Remove GoogleAnalytics from the server security middleware
      
      * Remove GoogleAnalytics from Kondo config
      
      * Fix type failures
      
      * Revert "Remove GoogleAnalytics from Kondo config"
      
      This reverts commit 363557c4.
      Unverified
      2899046d
    • Ryan Laurie's avatar
      Remove unnecessary calls to `/api/collection` (#46752) · c78b46d6
      Ryan Laurie authored
      * use ee api to find custom reports collection
      
      * remove deprecated hook
      
      * fix race condition
      
      * add unit tests
      
      * fix circular dependency
      
      * fix unit tests
      
      * another plugin strategy
      Unverified
      c78b46d6
  10. Aug 16, 2024
  11. Aug 15, 2024
Loading