Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Mar 31, 2023
    • Nemanja Glumac's avatar
      Revert "Toggle JSON unfolding by field (#28742)" (#29720) · b92aaea1
      Nemanja Glumac authored
      This reverts commit 25a1b259.
      Unverified
      b92aaea1
    • Cal Herries's avatar
      Toggle JSON unfolding by field (#28742) · 25a1b259
      Cal Herries authored
      
      * Use type/JSON instead of type/SerializedJSON
      
      * Tidy migration
      
      * Update migration
      
      * Fix rollback migration for h2
      
      * whitespace
      
      * Add test for migration
      
      * Fix test
      
      * Add rollback
      
      * whitespace
      
      * Test JSONB type as well as JSON
      
      * Don't fingerprint JSON columns
      
      * Remove comment, that might be wrong in the future
      
      * Update test
      
      * Add tests for fingerprinting
      
      * Use base-type JSON for fingerprinting base query
      
      * Add test for visibility-type=details-only
      
      * undo .
      
      * Change migration id
      
      * Fix migration test
      
      * Merge master
      
      * Exclude mariadb from tests
      
      * Make is-mariadb? public
      
      * Migration for adding nfc_enabled
      
      * Add nfc_enabled to field settings
      
      * Update describe-nested-field-columns to only unfold fields that have not been disabled
      
      * Remove spy
      
      * Tidy
      
      * Fix
      
      * Clear nested fields immediately if folding is disabled
      
      * Clear nested fields on nfc_enabled change
      
      * Trim trailing whitespace
      
      * Tidy
      
      * Fix
      
      * Add enable-json-unfolding-test
      
      * Move to field api test
      
      * nfc_enabled -> json_unfolding
      
      * Tidy test
      
      * Make json-unfolding in database details just the default for new settings
      
      * Restore original visibility-type logic
      
      * Fix
      
      * Sync field json_unfolding according to db json_folding
      
      * Rename to json-unfolding-default
      
      * Add test for the case when the json-unfolding is false for the database
      
      * Implement default json unfolding for first sync
      
      * Update comment
      
      * Update comment
      
      * Restore PUT field
      
      * Migration for populating json_unfolding for mysql and postgres
      
      * Remove migration and use default on the frontend instead
      
      * Update json-unfolding database setting copy
      
      * Move Unfold JSON setting under semantic type setting
      
      * Separate sentences with spaces
      
      * Capitalize
      
      * Restore handleChangeSemanticType
      
      * Use base_type TYPE.JSON instead
      
      * Change order of migrations
      
      * Add h2 migration
      
      * Add test for migration
      
      * Update test description
      
      * Remove validCheckSum
      
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
      
      * Use ?? instead of ||
      
      * Fix tests
      
      * Remove outdated serdes stuff
      
      * Remove unnecessary and
      
      * Fix mysql migration
      
      * Remove unused require
      
      * Fix test
      
      * Add false default value for json_unfolding
      
      * Fix json-unfolding nil case
      
      * Other suggestions
      
      * whitespace
      
      * Tidy describe-nested-field-columns
      
      * Update comment
      
      * Remove unused clear-nested-fields!
      
      * Remove unused return value
      
      * Fix H2 migration to use base_type not database_type
      
      * Always set json-unfolding during sync
      
      * Fix test
      
      * Fix test
      
      * Fix test
      
      * Add comment explaining nested-field-column support for MySQL
      
      * Fix tests
      
      * Fix tests
      
      * Fix test
      
      * Fix test
      
      * Default json_unfolding to false for new fields
      
      * Fix merge
      
      * Add json_unfolding to mock tables
      
      * Don't capitalize prepositions
      
      * Update setting description
      
      * whitespace
      
      * whitespace
      
      * Fix fetch_metadata
      
      * Fix fetch_metadata
      
      * Fix tests
      
      * Fix test
      
      * Fix clj-kondo
      
      * Remove postgres database-supports test
      
      * Fix postgres test
      
      * Fix postgres test
      
      * Fix mysql migration
      
      * Fix clj-kondo
      
      * Don't test mariadb
      
      * Fix mysql test
      
      * Fix mysql json-unfolding nil case
      
      * Add comments to test
      
      * Add upterm step to mariadb test
      
      * Move upterm step before tests
      
      * Fix postgresql migration
      
      * move upterm step to test-driver action
      
      * Remove upterm step from drivers.yml
      
      * Comment out everything else in test-driver
      
      * Fix mariadb migration
      
      * Remove upterm action
      
      * Whitespace
      
      * Only handle JSONObjects with JSON_VALUE, not JSONArray
      
      * Fix fields.sync_metadata/update-field-metadata-if-needed!
      
      * Add comment explaining `json-unfolding-default`
      
      * Add comment for JSON_VALUE test
      
      * Update json-unfolding-default-true-test to use fresh db
      
      * Fix test descriptions
      
      * Don't capitalize setting display name
      
      * Fix update json_unfolding
      
      * Fix unfolding json for only one JSON column, not all
      
      * Add e2e test for JSON unfolding setting
      
      * Fix test
      
      * whitespace
      
      * Fix test
      
      * Fix json-unfolding for nested field columns
      
      * Fix mysql and postgres tests for nested field columns
      
      * Coerce nil json-unfolding to false for sync_metadata
      
      * Add test for nil json-unfolding for sync_metadata
      
      * Fix test
      
      * Don't update json_unfolding from intial sync
      
      * Add json_unfolding to update-field-test
      
      * Fix tests
      
      ---------
      
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
      Unverified
      25a1b259
  2. Mar 30, 2023
  3. Mar 27, 2023
  4. Mar 24, 2023
  5. Mar 23, 2023
  6. Mar 21, 2023
  7. Mar 20, 2023
    • Ngoc Khuat's avatar
      db/select-* to toucan 2 (#29319) · 952af410
      Ngoc Khuat authored
      * db/select-one-field -> t2/select-one-fn
      
      * `db/select-field` -> `t2/select-fn-set`
      
      * db/select-ids -> t2/select-pk-set
      
      * db/select-field->field -> t2/select-fn->fn
      
      * db/select-field->id -> t2/select-fn->pk
      
      * `db/select-id->field` -> `t2/select-pk->field`
      
      * add discourage var
      Unverified
      952af410
  8. Mar 17, 2023
  9. Mar 14, 2023
  10. Mar 09, 2023
  11. Mar 06, 2023
  12. Mar 04, 2023
  13. Feb 24, 2023
  14. Feb 23, 2023
    • Cam Saul's avatar
      Snowflake Honey SQL 2 (#28478) · e3d817a4
      Cam Saul authored
      * Snowflake Honey SQL 2
      
      * Test fix :wrench:
      
      * Use Honey SQL 2 for GTAP compilation in sandboxing tests
      
      * Test fix :wrench:
      Unverified
      e3d817a4
    • Case Nelson's avatar
      Sqlite honey sql 2 (#28389) · 80ba6b1a
      Case Nelson authored
      * Convert sqlite driver to honey-sql-2
      
      * Fix bad case statement
      
      * We can't run native queries with AS for oracle
      
      * Dont call ->honeysql on a honeysql-expr
      
      * Fix bad call to h2x
      
      * Identifier needs to be wrapped
      
      * Update kondo config
      
      * Fix test
      
      * Remove hformat fn handler
      
      * Rotate the Snowflake DB prefix AGAIN
      
      * `sql.qp/format-honeysql` needs to wrap stuff in parens when generating SQL snippets
      
      * Update tests to match new expected SQL format
      
      * Sort namespaces
      
      * Fix the flaky paging test
      
      * Fix flaky `metabase.query-processor-test.timezones-test/filter-datetime-by-date-in-timezone-test`
      
      * MySQL test fix :wrench:
      
      
      
      * Try running Redshift with a beefier runner
      
      ---------
      
      Co-authored-by: default avatarCam Saul <github@camsaul.com>
      Co-authored-by: default avatarCam Saul <1455846+camsaul@users.noreply.github.com>
      Unverified
      80ba6b1a
  15. Feb 22, 2023
  16. Feb 20, 2023
    • metamben's avatar
      Mongo joins (#28293) · 32854d3c
      metamben authored
      * Make joins work
      
      * Run fuzzy-field-info-test only against H2
      
      * Set driver/*driver* when performing actions
      
      * Restrict expressions+joins-test to DBs supporting date arithmetics
      
      * Fix ordering of (top level) fields in mongo tables
      
      * Explicitly exclude mongo from tests requiring foreign key support
      
      * Optimize away $sort stage for implicit order-by.
      Unverified
      32854d3c
  17. Feb 17, 2023
  18. Feb 16, 2023
  19. Feb 10, 2023
  20. Feb 09, 2023
  21. Feb 08, 2023
    • Case Nelson's avatar
      Adding support for timezone awareness to mongo (#27937) · 919d02ae
      Case Nelson authored
      * Adding support for timezone awareness to mongo
      
      * Remove unused ddl multimethod
      
      * Remove mongo from the sql driver type test
      
      * Fix tests and linters
      
      * Add test for filtering datetimes by date in timezone
      
      * Use test-data-with-timezones dataset as it should load in more dbs
      
      * Exclude broken drivers, vertica especially returns no rows
      
      * Address pr review, add timezone to isodate, include a full year of dates in the general timezone test
      
      * Assert against each row
      
      * Presto-jdbc year was not applying timezone
      Unverified
      919d02ae
    • Cam Saul's avatar
      Switch to Toucan 2 (#27688) · 06f52bd4
      Cam Saul authored
      Unverified
      06f52bd4
Loading