This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 15, 2024
-
-
Noah Moss authored
Make sure the query to fetch result_metadata for native sandboxes doesn't use the streaming results handler (#50049)
-
- Nov 08, 2024
-
-
Kamil Mielnik authored
* Remove @flaky tag * Make workaround test pass * Disable workaround test * Uncomment and unquarantine the workaround test * Disable normal test for now * Revert "Disable normal test for now" This reverts commit 68fa2175. * Bring back quarantine * Update comment
-
- Oct 15, 2024
-
-
Romeo Van Snick authored
* Rename Common Metrics to Metrics * Rename Basic Metrics to Summaries * Update chill mode button copy to 'Add a summary or metric' * Rename 'Pick the metric you want to see' button to include summary * Fix type in test * Rename Summaries to Basic functions * Fix test * Undo cross-version test changes
-
- Sep 23, 2024
-
-
Sloan Sparger authored
* removes the default-ee snapshot in favor for a blockUserGroupPermissions util * commit default-ee removal i forgot, replace default strings with undefined * fix oopsie * fixes failures for not removing enough permissions for tests in sandboxes.cy.spec.js * rename var
-
- Sep 20, 2024
-
-
Sloan Sparger authored
* fixes some tests where data permissions were overwriting sandboxing permissions, makes assertions in tests where sandboxing user is used but the test also passes if you were to sign in as the normal user, fixes one test that sandboxes the wrong table for the test * do not push - wip changes * add assertions to that network requests are provided sandboxed data, fix faulty test in dashboard-filters-source.cy.spec.js * use helpers to clean up parts of pagination assertions * rename assertDatasetIsSandboxed to assertDatasetReqIsSandboxed * adds assertions on api response data * clean up * fix typo * refactor helper to be easier to follow * golfing * pr feedback * fix * fix
-
- Aug 21, 2024
-
-
Ryan Laurie authored
* QuestionAlertWidget to FC + TS * update e2e tests * use regular alert for unsubscribes * Create Question and Dashboard Sharing Menu * Handle some edge cases * top notch unit tests * more testing and tweaking * fix imports * more tests * add alerts to question sharing menu * add tests for alerts * update e2e tests * use Oisin's toolbarbutton * fix rebase * prompt to save before sharing questions * show prompt to set up notification channels * fix import * update tests and hide on notebook screen * fixes * clean up pulse types * update e2e tests * fix a bunch more tests * more e2e test fixes * maybe green now?
* last one * design updates * make channel setup modal nicer * simpler component props * lint fix * lint fixes
-
- Aug 20, 2024
-
-
Uladzimir Havenchyk authored
* refactor: sort import members inside destructuring * Show an error message when the temporal unit is not applicable to a dashboard card (#46983) * Fix tests * Add tests * Add tests * Fix types * Fix types --------- Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
- Aug 02, 2024
-
-
Ryan Laurie authored
* YOLO * fix a lot of tests * fix more tests * fix unit tests * remove comment * update tests and formatting * add debug code * remove debug code
-
- Jun 05, 2024
-
-
Ryan Laurie authored
* tag flakiest tests as such * let well behaved tests out of flake jail * more bad actors off the streets * add another flake * sandboxes re-offended already
-
- May 17, 2024
-
-
Kamil Mielnik authored
* Fix nil schema in /api/table/:id/query_metadata * Fix nil schema in /api/table/:id/query_metadata * Fix nil schema in /api/table/:id/query_metadata * Fix nil schema in /api/table/:id/query_metadata * Fix nil schema in /api/table/:id/query_metadata * Revert "Fix nil schema in /api/table/:id/query_metadata" This reverts commit 38ac0923350db54966d831a456fceb339315e6d8. * Revert "Fix nil schema in /api/table/:id/query_metadata" This reverts commit 2b8fe78ed4039c82c665834904c13fd4a5263c90. * Revert "Fix nil schema in /api/table/:id/query_metadata" This reverts commit 219506f0e014b046844a726302eb2f2ea8457708. * Revert "Fix nil schema in /api/table/:id/query_metadata" This reverts commit 9430478bdf7d075594ef1a13c81714779afec871. * Revert "Fix nil schema in /api/table/:id/query_metadata" This reverts commit 8c6cdd9068db81c0de24998faf5f9bce80fd820c. * Table Picker (#40509) * Generic types * Generic types * Generic types + make generateKey a prop * Generic types * Extract AutoScrollBox.styled.tsx * Move AutoScrollBox to a separate directory * Generic types * Generic types * Generic types * Unhookify searchFilter * Generic types * Generic types * Generic types * Generic types * Generic types * Generic types * Generic types * Generic types * Finish dealing with a cast * Destructure import * Inline type * Generic types * Remove cast * Remove commented code * Remove redundant fallback * Move CollectionPicker out of EntityPicker * Avoid as unknown * Remove TODOs * Rename TisFolder to IsFolder * Fix any * Fix anys * Remove NestedItemPicker's storybook * Remove a cast * Remove a cast * Remove a cast * Revert "Remove a cast" This reverts commit b762d0f07692fa010ef752dd114ba8f1e350f0cb. * Use extends SearchModelType instead of extends string everywhere * Revert "Use extends SearchModelType instead of extends string everywhere" This reverts commit 708190d63ed61e0a4d36e560b9c6ef630982cb5d. * Fix SearchResult["available_models"] type * Handle options.allowCreateNew * Add missing description attribute to Database type * Move allowCreateNew to CollectionPickerOptions * Add missing description attribute in Database mock * Add types * Add TableList component * Add SchemaList component * Fix naming * Add DatabaseList component * Add NotebookDataItemPickerResolver * Fix typing * Add TablePicker and NotebookDataPickerModal * Update types * Fix types * Add folder type * Fix initial state * Update title * Make query model-dependent * Render tables * Fix schema icon * Adjust key generation * Rename utilts to utils * Use ItemList error prop * Use value prop * Rename NotebookDataPickerModal to DataPickerModal * Automatically open datapicker if there is no value * Highlight current item * Rename value to initial value * Fix item highlighting * Rework TablePicker state * Leave TODOs for names * Fix selecting items * Fix highlighting selected item * Hide confirmation button * Add fetchMetadata to tableApi * Fix Table['schema'] type * Fetch table metadata upon selection * Remove options from DataPickerModal * Fix collectionId typing in Question * Add collectionId prop * Remove title prop * Add todo * Fix confirmation button * Remove old DataSourceSelector * Bring back useSchemaListQuery * Fix crash * Fix picker not opening * Hide dbs list and schemas list if there's only 1 * Remove unused ref * Remove unused DataPickerListResolver * Remove unused types * Change conditional rendering to allow for loading state * Revert collection-related changes * Use RTK * Avoid using stale data * Fix highlighted db * Remove todo * Remove unused type * Remove useSchemaListQuery * Rename Value to TablePickerValue * Move isValueEqual to utils and rename it to isTablePickerValueEqual * Improve TODO * Remove unused options prop * Introduce tablePickerValueFromTable * Avoid having 2 table metadata requests * Update comment * Update comment * Remove unused function * Allow null in tablePickerValueFromTable * Extract helpers * Rename schemaId to schemaName * Remove description * Improve naming * Simplify types * Add explanatory comments * Fall back to empty state when there are no items * Account for null schemas * Account for null schema in tests * Revert "Account for null schema in tests" This reverts commit 0c96d1cb8807205913ea5b7c09cfba428e01bdd2. * Revert "Account for null schemas" This reverts commit 4f5c4e99ee9af74499c238f480b9a36d985de94f. * Improve typing around schema name * Refactor auto-select logic * Refactor * Avoid comment * Make useAutoSelectOnlyItem generic * Do not enforce presence of at least 1 tab with TypeScript * Fix types * Remove obsolete comment * Post-merge fix * Integrate QuestionPicker in DataPicker (#42268) * Add question and model pickers to Data Picker * Add model attribute to data picker value * Introduce DataPickerValue * Start with the right tab when opening data picker modal * Do not use stale sourceCard value * Fix switching tabs when a table is selected * Use undefined instead of null for consistency * Do not show models/questions tabs when there are no models/questions * Fix selecting models/questions in search results * Remove dead code * Remove dead code * Ignore selecting collections * Refactor useHasModels and useHasQuestions into useAvailableData * Use models param to speed up the query * Do not require `onConfirm` prop in `EntityPickerModal` (#42317) * Make onConfirm prop optional * Add a test for onConfirm prop assertion * Table does not appear selected in single-schema dbs (#42336) * Convert useAutoSelectOnlyItem arguments to param object * Disable auto-selection when there already is a selection * Use `DataPicker` in `JoinTablePicker` (#42330) * Refactor DataStep: - rename handleTableSelect to handleTableChange - extract value and memoize it * Remove redundant fragment * Add new DataPicker props * Use DataPickerModal in JoinTablePicker * Remove initialTab prop since the default tab is always the models tab anyway * Limit table selection to particular database * Limit search results to a given database * Support databaseId in useAvailableData * Filter collection items by databaseId * Use databaseId prop only for CollectionItemList component * Fix types * Fix filtering * Use useLatest for onChange * Fix typing * Introduce shouldShowItem and use it instead of databaseId prop * Improve PickerInfo type * Use MLv2 to generate DataPickerModal value in JoinTablePicker * Fix title * Add isModel to TableDisplayInfo * Add a hack to populate query metadata with info that table is a model * Remove NewQuestionView & QuestionDataSelector (#42562) * Temporarily disable recents tab in the data picker * Update Data Picker tests (#42565) * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Fix metadata loading * Update test * Update test * Update tests * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update tests * Update test * Update test * Update test and make it pass * Update test * Update tests * Update test * Use entityPickerModal() instead of modal() * Use entityPickerModal() instead of modal() * Update test * Update test * Update test * Revert change that broke tests * Update test * Update test * Update test * Update test * Update test * Update test * Remove test * Update test * Update test * Update test * Update test * Update test * Update test * Update tests * Update test * Update test * Rename createDatabaseIdItemFilter to createShouldShowItem * Update test * Update and skip a test * Remove test * Update tests * Update tests * Update tests * Remove test * Update tests * Update test * Update test * Update test * Extract utils * Use helpers * Extract helpers * Update test * Update test * Update test * Update test * Update test * Filter out collections that do not have card or dataset * Improve filtering * Always show root and personal collections, see https://github.com/metabase/metabase/issues/42687 * Remove failing assertion * Update tests * Use entityPickerModalTab * Accept strings in pickEntity * Use entityPickerModalLevel * Use entityPickerModalTab * Use entityPickerModalTab * Update tests * Update test * Update tests * Update test * Fix assertion * Update test * Update tests * Update test * Update tests * Update tests * Update test * Update test * Update tests - ensure database list gets loaded like in a real app * Update test * Update test * Integrate Recents tab in Data Picker (#42821) * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Fix metadata loading * Update test * Update test * Update tests * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update test * Update tests * Update test * Update test * Update test and make it pass * Update test * Update tests * Update test * Use entityPickerModal() instead of modal() * Use entityPickerModal() instead of modal() * Update test * Update test * Update test * Revert change that broke tests * Update test * Update test * Update test * Update test * Update test * Update test * Remove test * Update test * Update test * Update test * Update test * Update test * Update test * Update tests * Update test * Update test * Rename createDatabaseIdItemFilter to createShouldShowItem * Update test * Update and skip a test * Remove test * Update tests * Update tests * Update tests * Remove test * Update tests * Update test * Update test * Update test * Extract utils * Use helpers * Extract helpers * Update test * Update test * Update test * Update test * Update test * Filter out collections that do not have card or dataset * Improve filtering * Always show root and personal collections, see https://github.com/metabase/metabase/issues/42687 * Remove failing assertion * Update tests * Use entityPickerModalTab * Accept strings in pickEntity * Use entityPickerModalLevel * Use entityPickerModalTab * Use entityPickerModalTab * Update tests * Update test * Update tests * Update test * Fix assertion * Update test * Update tests * Update test * Update tests * Update tests * Update test * Update test * Update tests - ensure database list gets loaded like in a real app * Update test * Enable recents tab and update tests * Update test * Update tests * Add Recents-related assertions * Update test * Clean up mocks --------- Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
- Apr 26, 2024
-
-
Aleksandr Lesnenko authored
Co-authored-by:
Emmad Usmani <emmadusmani@berkeley.edu> Co-authored-by:
Adam James <adam.vermeer2@gmail.com> Co-authored-by:
Mark Bastian <markbastian@gmail.com> Co-authored-by:
Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com> Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
- Apr 19, 2024
-
-
Noah Moss authored
Co-authored-by:
Noah Moss <noahbmoss@gmail.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by:
Nick Fitzpatrick <nick@metabase.com> Co-authored-by:
John Swanson <john.swanson@metabase.com> Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com> Co-authored-by:
Sloan Sparger <sloansparger@gmail.com>
-
- Apr 18, 2024
-
-
Ryan Laurie authored
* WIP questionpicker * use to replace dashcard content * much better stuff * question picker * values source card modal * create action form * awesome hacky fix for crashing model detail page * use entity picker in sandboxing modal * deprecate ye olde question picker * keep old question picker in add-card dashboard sidebar * better last level check * update types * make stuff better * fix rebase conflicts * better initial value handling * update e2e tests * sweet sweet unit tests * fix sandbox tests * fix tests * type fix * fixes * search style improvements * remove unused prop * safer path detection * delayed loading spinner * change confirm default * set default collection for placeholder card * address review comments * update unit tests * update e2e tests * fix re-rebase * add some happy little comments
-
- Apr 17, 2024
-
-
Noah Moss authored
Co-authored-by:
Noah Moss <noahbmoss@gmail.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by:
Nick Fitzpatrick <nick@metabase.com> Co-authored-by:
John Swanson <john.swanson@metabase.com> Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com> Co-authored-by:
Sloan Sparger <sloansparger@gmail.com>
- Apr 15, 2024
-
-
Denis Berezin authored
-
- Apr 09, 2024
-
-
Mahatthana (Kelvin) Nomsawadi authored
* Remove unused CSS custom properties * Migrate .ModalContainer * Migrate .Modal * Migrate .ModalBackdrop * Migrate Modal transition classes * Migrate modal sizes * Fix tests * Add missing classes from migration * Address review: use `data-testid` * Remove unused classes * Revert the util that selects Mantine modal
-
- Apr 05, 2024
-
-
Mahatthana (Kelvin) Nomsawadi authored
* Moved a CSS rule, so we could only migrate 1 CSS file * Migrate .ListSectionHeader * Migrate .ListItem * Migrate .ListItemArrow * Migrate .ListSectionHeaderCursor * Migrate .ListSectionToggleAble * Migrate .ListSectionTitle * Migrate .ListSectionExpanded * Migrate .ListSectionIcon * Migrate .ListItemCursor * Migrate .ListItemDisabled * Migrate .ListItemSelected * Migrate .ListItemTitle * Migrate .ListItemDescription * Migrate a CSS class used in tests * Fix tests from migrating global CSS classes
-
- Mar 21, 2024
-
-
Alexander Polyankin authored
-
- Mar 20, 2024
-
-
Denis Berezin authored
* Global styles refactor * Add missing test change * Fix e2e * Migrate buttons * Migrate buttons * Migrate query builder * Migrate dashcards * Review fixes * Review fixes * Review fixes
-
- Mar 07, 2024
-
-
Noah Moss authored
Co-authored-by:
bryan <bryan.maass@gmail.com> Co-authored-by:
Bryan Maass <bryan.maass@gmail.com> Co-authored-by:
Jerry Huang <jhuang37050@gmail.com> Co-authored-by:
Noah Moss <noahbmoss@gmail.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by:
John Swanson <john.swanson@metabase.com>
-
- Mar 06, 2024
-
-
Kamil Mielnik authored
* Convert commands/api/question to TS * Add missing embedding_params and collection_position attributes to Card * Type question function * Move types to the top of file * Inline throwIfNotPresent * Add types for logAction * Define StructuredQuestionDetails & NativeQuestionDetails * Add typing to commands * Return for consistency * Remove queryType argument from question * Define typing for archiveQuestion command * Format code * Define typing for createQuestion and createNativeQuestion commands * Make options optional * Remove TODO * Use arrow functions, update JSDoc * Use type for consistency * Add missing attributes in mocks * Make embedding_params non-optional * Add boilerplate for 11994 repro * Add temporary code * Improve typing * Implement test for combo chart * Simplify code * Convert updatePermissions to TS and add typing for updatePermissionsGraph * Add typing for updatePermissionsSchemas * Add typing for API responses, make updatePermissionsSchemas parameters optional * Add JSDocs * Explicitly specify types in commands * Use CardId * Fix the test - add missing visuzalization_settings to the pivot question - use "readonly" user and drop permissions manipulations * Remove TODO * Add an explanatory comment * Inline visitDashboardByAlias * Make visitQuestion accept an alias * Use new visitQuestion interface where possible * Remove somewhat duplicated comment
-
- Feb 20, 2024
-
-
Kamil Mielnik authored
* Upgrade eslint-plugin-import * Configure import/order rule for consistent, predictable imports * Change "eslint-disable-next-line no-restricted-imports" into "eslint-disable-line" * Ensure imports are in a single block * Move or remove informative comments between import statements * Remove imports-grouping comments * Configure groups - the difference between the default setting is the presence of "internal" group * Manually fix imports order and disable "import/order" rule in files with possible circular dependencies * Move comment to the same line as import * Run "yarn eslint-fix" 5 times - Remaining: 16 problems (16 errors, 0 warnings) * Manually fix imports order in remaining files * Run "yarn prettier" * Fix import * Fix circular dependency * Fix circular dependency * Remove unused action creator (it was inlined in 702988ec3f8bd4c6bf6bbbdf169dca25a0ca5a13 due to circular dependency) * Re-add accidentally removed code * Fix typing * ESLint
-
- Feb 16, 2024
-
-
Ryan Laurie authored
-
- Jan 18, 2024
-
-
Noah Moss authored
Exclude :card from the parameter types which require defaults to be considered fully parameterized (#37764)
-
- Jan 13, 2024
-
-
Braden Shepherdson authored
The QP sometimes provides a `:source-alias` and no `:join-alias` for a joined column. Then its MLv2 ref would be missing a `:join-alias` and it would not match its own column under `lib.equality/find-matching-column`. Fixes #36861.
-
- Jan 05, 2024
-
-
Kamil Mielnik authored
* Rename query to legacyQuery * Use step.query * Port ExpressionStep to MLv2 * Use named export for ExpressionStep * Move setup to the top of the file * Add expressions parameter to createQueryWithClauses * Update ExpressionStep unit tests * Add a test for adding expressions * Format code * Add typing for openSteps and remove default parameter to prevent accidental omission * Rename arguments * Remove NotebookStep['update'] and update NotebookStepUiComponentProps['updateQuery'] * Remove NotebookStep['update'] from test util * Add metadata argument to NotebookStepFn * Remove unused NotebookStep['clean'] * Change previewQuery type to Query * Update NotebookStep['revert'] to work with MLv2 only * Use revert: null properly * Clear breakouts before aggregations * Update NotebookStepDef['active'] to work with MLv2 only * Update NotebookStepDef['valid'], remove NotebookStepFn * Remove TODO * Update STEP.valid calls * Port #36507 to master * Migrate STEP.valid * Format code * Rename topLevelQuery to query and stagedQuery to legacyQuery * Use INotebookStep["id"], simplify handleQueryChange * Use database from metadata instead of question * Format code * Apply expressions before aggregations * Improve typing in tests * Fix expression name uniqueness * Fix Lib.fields typing * Use dropStageIfEmpty when removing expressions * Fix unique name computation * Port hasData * Add stageIndex argument to NotebookStepDef['valid'] * Port query.isSourceQuery() * Add junit.xml to .gitignore - see https://github.com/metabase/metabase/pull/35929 * Make unit tests run * Improve revert typing * Update unit tests * Update unit tests * Update unit tests * Rename filterStep1 to filterStep and filterStep2 to postAggregationFilterStep * Update unit tests * Update unit tests * Update unit tests * Update unit tests * Convert unit tests to TS * Simplify getQuestionStepsForMBQLQuery * Refactor tests * Remove test for new queries - a Lib.Query object cannot exist without the "data step" * Lift database to reuse it * Port getQuestionSteps * Skip e2e test for metabase#19745 due to metabase#36574 - See https://github.com/metabase/metabase/issues/36574 - See https://metaboat.slack.com/archives/C04CYTEL9N2/p1702063378269379 - See https://metaboat.slack.com/archives/C0643FZ5E83/p1702365832126429?thread_ts=1702362649.548849&cid=C0643FZ5E83 * Update comment * Revert type change * Revert "Use dropStageIfEmpty when removing expressions" This reverts commit d529503e793c93ecdc006f0ecf20c874f8cd091b. * Format code * Skip 19745 tests * Format code * Use dropStageIfEmpty instead of cleanNesting * Try to drop only the updated stage * Use stageIndex instead of -1 in preview3 * Format code * Ignore question.isStructured() check * Finish migrating getQuestionSteps * Migrate query.clean in Notebook to MLv2 * Use reduceRight instead of reverse + reduce * Fix typo * Move hasBreakouts computation until after the redundant stage is removed * Update e2e sandboxing test to assert showing permissions error instead of magically dropping an unsupported join - @see https://metaboat.slack.com/archives/C01LQQ2UW03/p1704294434403599 --------- Co-authored-by:
Tamás Benkő <tamas@metabase.com> Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
- Dec 13, 2023
-
-
Ryan Laurie authored
-
- Dec 12, 2023
-
-
Ngoc Khuat authored
-
Alexander Polyankin authored
-
- Dec 04, 2023
-
-
Alexander Polyankin authored
-
- Nov 15, 2023
-
-
Ryan Laurie authored
* add special flaky group * tag tests with flakes over 10% * mark more flaky jobs
-
- Nov 02, 2023
-
-
Nick Fitzpatrick authored
* temp * Mostly functional. Still needs cleanup * cleanup * hide from table header * resolving type disputes. adding icon prop to column item * e2e tests passing * temp * branch cleanup * Fe linter and unit tests * e2e adjustments * PR Feedback * fix unit test * Hide Viz Settings Buttons in Column Headers in Raw Table Mode (#35114) * e2e adjustments * don't show viz settings actions on raw table view * better prop handling * Adding e2e test * updating selector * more e2e adjustments --------- Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com> * e2e updates * removing comment --------- Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com>
-
- Sep 07, 2023
-
-
Ryan Laurie authored
-
- Sep 05, 2023
-
-
Ryan Laurie authored
* parameterize collection and dashboard ids in e2e tests * fix copyPasta errors * appease the linter * obey the linter
-
- Aug 21, 2023
-
-
Jesse Devaney authored
* fix specific aria-label for generic sidebar * hide dashboard subscription button - when user is non-admin and email & slack are not configured * forward non-admin user to configured subscription form * fix: show pulse list after creation for non-admins - when pulse count is 0 and a new pulse is added by non-admins, it used to auto-redirect to the creation form again b/c the new pulse was not loaded before the forwarding would occur again * refactor magic strings * fix error when pulses has no length attribute * validate forwarding in subscriptions for non-admins * add remaining specs * updated tests for new subscriptions forwarding for non-admins * update tests for subscriptions forwarding for non-admins * update tests for subscriptions forwarding for non-admins * fix unit tests * update dashboard subscriptions button to exclude heading cards * [WIP] convert E2E tests to unit tests * convert subscriptions button test to unit test * restore some E2E tests * fix unit tests - new fetch request occurring in child component DashboardHeader was causing these tests to fail on the fetch request because there was no fallback
-
- Jul 20, 2023
-
-
Nick Fitzpatrick authored
* ordering users by first name in API responses * adjusting e2e tests * Adding Normal Personal Collection ID to cypress data
-
- Jul 11, 2023
-
-
Nemanja Glumac authored
* Start all tests without a token * Update tests * Fix tests in `admin` group * Fix tests in `dashboard-filters` group * Fix tests `visualizations` group * Batch fixes * Fix database banner snowplow test * Fix full-app mobile view banner test * Simplify and remove `isPremiumActive` check * Fix the helper * Fix helper to fail fast * Fix tests * Ensure token scope is set * Ensure CYPRESS_ env tokens are present * Set token only if running Metabase ee * Improve JSDoc * Slightly tweak log message * Update E2E dev guide * Update cross-version tests * Remove premium token from Cypress backend setup * Improve a comment * Fix test * Update embedding copy --------- Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
- May 26, 2023
-
-
Denis Berezin authored
* Update underlying records drill - bring to top, label changes (#29984) * Zoom in Drill (#30208) * Add updated zoom drill title * Fix e2e tests * Add title unit tests * Fix for Records drill UI when it is the only one displayed * Review fixes * Add pivot drill common popover (#30275) * Add grouping for Pivot drill options * Reuse filterField type * Fix date formatting after rebase * Move Automatic insight action to a common popover (#30370) * Refactor ChartClickActionsView, reuse it component in drills (#30706) * 26836 separate views for quick cell click filters (#30532) * Added separate views for QuickFilterDrill * Add tests, fix styles issues * 26836 contains/does not contain quick filter for tables (#30778) * Add contains/does not contain quick filter for tables * Self review fixes * Fix for column header filter search options cropped * Fix for icon margin difference for contains / does not contain filters * Fix contains filter actions icon styles * Add quick filters support for aggregated queries * Not show contains filter for joined fields * Fix typecheck * Adjust string field quick filter section title to have column name (#30888) * 26836 Add View details action for quick filters (#30967) * Add View details action to quick filters * Self review fixes * Fix e2e tests * Fix review issues
-
- May 11, 2023
-
-
Ryan Laurie authored
* don't allow unscoped text selectors in e2e tests * properly scope some recent tests * disable eslint for legacy violations * scope selectors in dashboard drill test
-