Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Mar 23, 2023
  2. Mar 22, 2023
  3. Mar 21, 2023
    • Emmad Usmani's avatar
      fix dashboard opening in editing state when it shouldn't (#29368) · 9ae66ab7
      Emmad Usmani authored
      * fix dashboard opening in editing state when it shouldn't
      
      * unskip reproduction test
      Unverified
      9ae66ab7
    • Cam Saul's avatar
      Port query description logic to MLv2 (#29200) · 8f554528
      Cam Saul authored
      * Query  D E S C R I P T I O N S
      
      * WIP
      
      * MLv2 Query description
      
      * Test fixes
      
      * More robust error handling
      
      * MLv2 more shuffling things around
      
      * Remove unneeded impl
      
      * Cumulative FE changes
      
      * WIP
      
      * lib.expressions -> lib.expression
      
      * Address PR feedback
      
      * Fix everything
      
      * Oops fix missing metadata
      
      * Test fixes :wrench:
      
      * Fixes post-merge
      
      * Fix merge conflict
      
      * JS metadata overhaul
      
      * Test fix :wrench:
      
      * Test fix
      
      * Hack to workaround busted JOINs
      
      * Use Braden's better fix
      
      * Cumulative fixes
      
      * Test fixes :wrench:
      
      * Remove unused
      
      * Include temporal unit in query description
      
      * Don't change indentation
      
      * Revert e2e browser changes
      
      * Revert bin change
      
      * Meaningless change to kick CI
      Unverified
      8f554528
  4. Mar 20, 2023
  5. Mar 19, 2023
  6. Mar 17, 2023
  7. Mar 16, 2023
  8. Mar 15, 2023
  9. Mar 14, 2023
  10. Mar 13, 2023
  11. Mar 10, 2023
    • Aleksandr Lesnenko's avatar
    • dpsutton's avatar
      List actions endpoint (#29055) · d2e893dd
      dpsutton authored
      
      * List all actions
      
      previously `api/action` required `?model-id=<model-id>`. This caused the
      FE to DOS the backend looping over each action. On stats I found 350 or
      so sequential requests, with app-db saturation leading to requests
      taking from 400ms near the beginning to 7seconds near the end.
      
      This makes `model-id` option and now returns actions on all models the
      user can see.
      
      ```
      ❯ http GET "localhost:3000/api/action" Cookie:$SESSION -pb
      [
          {
              "archived": false,
              "creator": {...},
              "creator_id": 1,
              "database_id": 3,
              "dataset_query": {...},
              "id": 1,
              "model_id": 1,
              "name": "source = foo",
              "parameter_mappings": null,
              "parameters": [...],
              ...
          }
          ...
      ]
      ```
      
      * update frontend for action picker to support single action list endpoint
      
      * list actions tests
      
      * update actions e2e tests
      
      * Return empty vector if no results
      
      Running tests locally might return some extra actions not asserted on in
      the tests. And there you might expect a 200. But CI runs with an empty
      database and returns no response so you get a 204. Quite annoying and
      there's no good way to expect a "2xx" status code at the moment. So just
      return the empty vector so it's always a 200 code.
      
      * update actions endpoint unit test mocks
      
      * Simplify logic a little
      
      * docstring tweak
      
      * schema with better error message
      
      * update mocks to accept optional modelId
      
      * simplify sorting and grouping
      
      * make sort case-insensitive
      
      * simplify action api test mocks
      
      ---------
      
      Co-authored-by: default avatarRyan Laurie <iethree@gmail.com>
      Unverified
      d2e893dd
Loading