This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Mar 23, 2023
-
-
Emmad Usmani authored
* fix pie chart legend not fading on hover * use `aria-current` in test instead of directly checking style * fix failing test
-
Nick Fitzpatrick authored
-
Tim Macdonald authored
* Add action.dataset_query to search results * Add action.database_id to search results * Unskip repro * better FE error handling for action query display * update repro --------- Co-authored-by:
Ryan Laurie <iethree@gmail.com>
-
Nemanja Glumac authored
* Remove usages of `cy.addFilterToDashboard` custom command * Fully remove `cy.addFilterToDashboard` custom command
-
- Mar 22, 2023
-
-
Alexander Polyankin authored
-
Noah Moss authored
* show all subscriptions in notification management page regardless of collection perms * strip cards and recipients if necessary * indentation tweak * add backend tests * add cypress repro * fix permissions check * slightly different approach * fix cypress test * fix test * address comment
-
Alexander Polyankin authored
-
- Mar 21, 2023
-
-
Emmad Usmani authored
* fix dashboard opening in editing state when it shouldn't * unskip reproduction test
-
Cam Saul authored
* Query D E S C R I P T I O N S * WIP * MLv2 Query description * Test fixes * More robust error handling * MLv2 more shuffling things around * Remove unneeded impl * Cumulative FE changes * WIP * lib.expressions -> lib.expression * Address PR feedback * Fix everything * Oops fix missing metadata * Test fixes
* Fixes post-merge * Fix merge conflict * JS metadata overhaul * Test fix * Test fix * Hack to workaround busted JOINs * Use Braden's better fix * Cumulative fixes * Test fixes * Remove unused * Include temporal unit in query description * Don't change indentation * Revert e2e browser changes * Revert bin change * Meaningless change to kick CI
-
- Mar 20, 2023
-
-
Ryan Laurie authored
* make object detail work for non-logged-in users * update types to account for optional params * test public object detail viz
-
Aleksandr Lesnenko authored
* fix missing group by columns from joined tables * fix spec
-
Ryan Laurie authored
* extract model creation helper * update model actions test to actually mutate data * fix merge conflicts and clean up
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix custom field type aggregation not showing When the origin table don't have that field type. * Add tests * Remove puzzle driven development comments * Make `getAggregationOperators` API more apparent
-
Uladzimir Havenchyk authored
-
- Mar 19, 2023
-
-
Emmad Usmani authored
* fix agressive y-axis splitting in charts * e2e tests * check if col settings are different * use `settings.column` instead of redefining default settings * refactor for feedback
-
- Mar 17, 2023
-
-
Aleksandr Lesnenko authored
-
Ngoc Khuat authored
-
Mark Bastian authored
Exposes models as a GenericTable and adds in UI menu option to show the x-ray. There's still work to be done to add filters and more interesting auto-generated charts, but this is the first step.
-
Nemanja Glumac authored
* Extract `parseArguments` into utils * Allow custom browser for Cypress snapshots generation
-
Nick Fitzpatrick authored
-
Nemanja Glumac authored
-
- Mar 16, 2023
-
-
Nick Fitzpatrick authored
* Updating graph.metrics when column is removed * updating logic and adding unit tests
-
Jeff Bruemmer authored
-
Alexander Polyankin authored
-
Denis Berezin authored
* Refactored ExpressionWidget, ClauseStep components to TS (#28687) * Implement new UI design, add unit tests (#28776) * Add design changes to ExpressionWidget * Add new design for ExpressionEditorHelpText (#28920) * Add expression function arguments interactivity (#28966) * New design for expression editor info link (#29113)
-
Anton Kulyk authored
* Fix empty database picker state * Remove redundant `requireWriteback` occurrences * Update test * Update test * Use clearer names * Don't show query language message for actions * Use database `hasActionsEnabled` method * Remove `requireWriteback` prop * Respect `readOnly` prop in `DataSourceSelectors` * Extend e2e test coverage * Use `setActionsEnabledForDB` in Cypress * Fix data picker behavior
-
- Mar 15, 2023
-
-
Alexander Polyankin authored
-
Ryan Laurie authored
-
Ngoc Khuat authored
-
- Mar 14, 2023
-
-
Nick Fitzpatrick authored
* adding hasMultipleDimensions check to hasLegend clause * Adding queryBuilderMain helper * PR Feedback * remove only
-
Aleksandr Lesnenko authored
-
Aleksandr Lesnenko authored
* fix exclude date filter serialization * review
-
Aleksandr Lesnenko authored
-
- Mar 13, 2023
-
-
Aleksandr Lesnenko authored
* lint e2e specs on CI * update eslint to run on e2e specs
-
Ryan Laurie authored
* only save changed dashboards * test early return from save action * remove problematic api wait for dashboard save * deeply compare cards and add better tests * update failing e2e test
-
Nick Fitzpatrick authored
* Adding Show Total toggle, adding unit tests * adjusting unit test, fixing logic * Adding Static Viz test. PR Feedback
-
Ryan Laurie authored
* composite key object detail test * add tests for no primary keys * fix rebase * allow db sync to wait on the presence of a specific table
-
Nick Fitzpatrick authored
-
- Mar 10, 2023
-
-
Aleksandr Lesnenko authored
-
dpsutton authored
* List all actions previously `api/action` required `?model-id=<model-id>`. This caused the FE to DOS the backend looping over each action. On stats I found 350 or so sequential requests, with app-db saturation leading to requests taking from 400ms near the beginning to 7seconds near the end. This makes `model-id` option and now returns actions on all models the user can see. ``` ❯ http GET "localhost:3000/api/action" Cookie:$SESSION -pb [ { "archived": false, "creator": {...}, "creator_id": 1, "database_id": 3, "dataset_query": {...}, "id": 1, "model_id": 1, "name": "source = foo", "parameter_mappings": null, "parameters": [...], ... } ... ] ``` * update frontend for action picker to support single action list endpoint * list actions tests * update actions e2e tests * Return empty vector if no results Running tests locally might return some extra actions not asserted on in the tests. And there you might expect a 200. But CI runs with an empty database and returns no response so you get a 204. Quite annoying and there's no good way to expect a "2xx" status code at the moment. So just return the empty vector so it's always a 200 code. * update actions endpoint unit test mocks * Simplify logic a little * docstring tweak * schema with better error message * update mocks to accept optional modelId * simplify sorting and grouping * make sort case-insensitive * simplify action api test mocks --------- Co-authored-by:
Ryan Laurie <iethree@gmail.com>
-