Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jul 05, 2024
    • Uladzimir Havenchyk's avatar
      lint: add stylelint support for emotion components (#45132) · c168b34e
      Uladzimir Havenchyk authored
      
      * lint: add stylelint support for emotion components
      
      * drop comment
      
      * fix pattern order
      
      * Use one version of typescript
      
      * use :focus not :outline
      
      * Use the logical CSS property "inset-inline-start:" (not "inline-start:" which doesn't exist) as replacement for the physical css property "left:"
      
      * Use mb-color-focus for focus color
      
      * Drop dead code
      
      ---------
      
      Co-authored-by: default avatarRaphael Krut-Landau <raphael.kl@gmail.com>
      c168b34e
    • Case Nelson's avatar
      fix: limit xrays on agg models to source fields (#44863) · e3378d4e
      Case Nelson authored
      * fix: limit xrays on agg models to source fields
      
      Fixes #43793
      
      1. `table-like?` was checking aggregations but not breakouts. This meant
         that legacy metric definitions would try to apply to the second stage
         which is generally illegal and would cause things like implicit joins
         to come in where they make no sense.
      2. Trying to bin a `count` metric-like model would give a bin span of
         0.0 which would blow up those questions.
      3. Trying to self reference breakout fields, in the precense of a
         question's  aggregation meant that most fields would not be exposed to
         the next stage and should be ignored. (similar to 1.)
      
      * Fix tests
      e3378d4e
    • Cal Herries's avatar
    • Cal Herries's avatar
    • Anton Kulyk's avatar
      Show alert sending time in alert form (#45062) · 77e1a472
      Anton Kulyk authored
      * Show alert sending time in alert form
      
      * F
      77e1a472
    • Alexander Polyankin's avatar
      41250c62
    • Alexander Solovyov's avatar
    • Romeo Van Snick's avatar
      Allow setting labels for filters (#44352) · 0d5bc020
      Romeo Van Snick authored
      
      * Add csv-stringify package
      
      * Split values at comma
      
      WIP: Parse values using json
      
      * Add label to ParameterValue and add ParameterValue to value config
      
      * Use custom label in FieldValuesWidget
      
      * Allow passing displayValue from outside of RemappedValue
      
      * Allow passing displayValue in ParameterFieldWidgetValue
      
      * Get custom value label in FormatterParameterValue
      
      * Allow rendering custom displayValue in FieldValuesWidget
      
      * Add custom ParameterValue types
      
      * Fix ParameterValuePicker type
      
      * Fix jest import for csv-stringify
      
      * Add missing RTKQ exports for paramters
      
      * Use direct implementation of useGetParameterValues
      
      * Fix ValueSourceModal tests
      
      * Add tests for value parsing and stringifying
      
      * Use custom label in list too
      
      * Render the custom label in a parameter value
      
      * Setup parameter mocks in embed test
      
      * Add info about splitting values with comma
      
      * Add model hint when user is using labels
      
      * Add test for cusom labels on dashboards
      
      * Handle label-value pairs in test
      
      * Test custom labels in parameter search input
      
      * Use the label to parse the value for text inputs
      
      * Fix comma's to commas
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      
      * Use strong instead of styling link
      
      * Use getInput instead of ignoring eslint rule
      
      * Use arrow function
      
      * Add newlines between tests
      
      * Use uppercase for test value
      
      * Name value
      
      * Use getLabel and getValue helpers to avoid indexing confusion
      
      * Pull out confusing condition
      
      * Move out getLabel helper
      
      * Be more explicit about non-existent config values
      
      Co-authored-by: default avatarUladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
      
      * Move setupParameterValuesEndpoints to setup
      
      * Add loading state
      
      * Do not use alert to implement info box
      
      * Fix formatting
      
      * Remove undefined from getValue signature
      
      * Use getLearnUrl
      
      * Remove dependency on column
      
      * Make custom field labels work in the absence of fields
      
      * Support custom values for non-field parameters
      
      * Add test for native question parameters
      
      * Add newline in test
      
      * Add test case for when show-metabase-links is false
      
      * Just fall back to rendering value when fetching label, or in case it failed
      
      * Add test for loading state of FormattedParameterValue
      
      * Do not fetch custom label for FormattedParameterValue
      
      * Add table with ip addresses
      
      * Add test for IPAddress filter with custom labels
      
      * Add test for custom labels on type/Quantity fields
      
      * Remove getInput helper in test
      
      * Remove unused hasCustomLabel value
      
      * Split up into common and premium tests
      
      * Make fieldValues a map for performance
      
      ---------
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      Co-authored-by: default avatarUladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
      0d5bc020
  2. Jul 04, 2024
  3. Jul 03, 2024
  4. Jul 02, 2024
Loading