Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jul 05, 2024
    • Uladzimir Havenchyk's avatar
      lint: add stylelint support for emotion components (#45132) · c168b34e
      Uladzimir Havenchyk authored
      
      * lint: add stylelint support for emotion components
      
      * drop comment
      
      * fix pattern order
      
      * Use one version of typescript
      
      * use :focus not :outline
      
      * Use the logical CSS property "inset-inline-start:" (not "inline-start:" which doesn't exist) as replacement for the physical css property "left:"
      
      * Use mb-color-focus for focus color
      
      * Drop dead code
      
      ---------
      
      Co-authored-by: default avatarRaphael Krut-Landau <raphael.kl@gmail.com>
      Unverified
      c168b34e
    • Romeo Van Snick's avatar
      Allow setting labels for filters (#44352) · 0d5bc020
      Romeo Van Snick authored
      
      * Add csv-stringify package
      
      * Split values at comma
      
      WIP: Parse values using json
      
      * Add label to ParameterValue and add ParameterValue to value config
      
      * Use custom label in FieldValuesWidget
      
      * Allow passing displayValue from outside of RemappedValue
      
      * Allow passing displayValue in ParameterFieldWidgetValue
      
      * Get custom value label in FormatterParameterValue
      
      * Allow rendering custom displayValue in FieldValuesWidget
      
      * Add custom ParameterValue types
      
      * Fix ParameterValuePicker type
      
      * Fix jest import for csv-stringify
      
      * Add missing RTKQ exports for paramters
      
      * Use direct implementation of useGetParameterValues
      
      * Fix ValueSourceModal tests
      
      * Add tests for value parsing and stringifying
      
      * Use custom label in list too
      
      * Render the custom label in a parameter value
      
      * Setup parameter mocks in embed test
      
      * Add info about splitting values with comma
      
      * Add model hint when user is using labels
      
      * Add test for cusom labels on dashboards
      
      * Handle label-value pairs in test
      
      * Test custom labels in parameter search input
      
      * Use the label to parse the value for text inputs
      
      * Fix comma's to commas
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      
      * Use strong instead of styling link
      
      * Use getInput instead of ignoring eslint rule
      
      * Use arrow function
      
      * Add newlines between tests
      
      * Use uppercase for test value
      
      * Name value
      
      * Use getLabel and getValue helpers to avoid indexing confusion
      
      * Pull out confusing condition
      
      * Move out getLabel helper
      
      * Be more explicit about non-existent config values
      
      Co-authored-by: default avatarUladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
      
      * Move setupParameterValuesEndpoints to setup
      
      * Add loading state
      
      * Do not use alert to implement info box
      
      * Fix formatting
      
      * Remove undefined from getValue signature
      
      * Use getLearnUrl
      
      * Remove dependency on column
      
      * Make custom field labels work in the absence of fields
      
      * Support custom values for non-field parameters
      
      * Add test for native question parameters
      
      * Add newline in test
      
      * Add test case for when show-metabase-links is false
      
      * Just fall back to rendering value when fetching label, or in case it failed
      
      * Add test for loading state of FormattedParameterValue
      
      * Do not fetch custom label for FormattedParameterValue
      
      * Add table with ip addresses
      
      * Add test for IPAddress filter with custom labels
      
      * Add test for custom labels on type/Quantity fields
      
      * Remove getInput helper in test
      
      * Remove unused hasCustomLabel value
      
      * Split up into common and premium tests
      
      * Make fieldValues a map for performance
      
      ---------
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      Co-authored-by: default avatarUladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
      Unverified
      0d5bc020
  2. Jul 01, 2024
  3. Jun 28, 2024
  4. Jun 26, 2024
  5. Jun 25, 2024
  6. Jun 20, 2024
  7. Jun 19, 2024
    • Kamil Mielnik's avatar
      Upgrade RTK to v2 (#44339) · 6daecbc6
      Kamil Mielnik authored
      * Upgrade @reduxjs/toolkit from ^1.9.3 to ^2.2.5
      
      * Fix typing
      
      * Upgrade redux-actions and @types/redux-actions
      
      * Fix type errors
      
      * Fix type errors
      
      * Upgrade react-redux from ^8.0.5 to ^9.1.2
      - remove @types/react-redux as it's no-longer-needed
      
      * Upgrade redux-promise from ^0.5.0 to ^0.6.0
      - upgrade @types/redux-promise
      
      * Remove unused @types/redux-logger
      
      * Revert "Upgrade redux-actions and @types/redux-actions"
      
      This reverts commit 65005a00.
      
      * Remove createWeakSelector as weakMapMemoize is the default memoization strategy now
      
      * Do not call unsubscribe if it does not exist
      
      * Do not subscribe
      
      * Remove console.log
      
      * Make DelayedLoadingSpinner always render something with data-testid="spinner" so that tests can be aware of when things are loading
      
      * Fix JoinStep unit tests
      
      * Fix AddToDashSelectDashModal unit tests
      
      * Fix SegmentApp unit tests
      
      * Bring back original subscription logic
      
      * Fix DataUsageStep unit tests
      
      * Fix ManageApiKeys unit tests
      
      * Simplify comment
      
      * Fix MainNavbar unit tests
      
      * Fix HomeRecentSection unit tests
      
      * Use afterEach instead of afterAll to reset mocks
      
      * Remove explanatory variable
  8. Jun 14, 2024
  9. Jun 07, 2024
  10. Jun 06, 2024
  11. Jun 04, 2024
  12. May 31, 2024
    • Mahatthana (Kelvin) Nomsawadi's avatar
      ci(sdk): Autogenerate changelog on build (#43364) · 78db8c49
      Mahatthana (Kelvin) Nomsawadi authored
      * Auto tag embedding team for PR review + dry run npm publish
      
      * Install changelog generation package
      
      * Add the initial changelog
      
      * feat(sdk): This is an empty commit. For testing purposes.
      
      * Update SDk build script to include changelog
      
      * Check if a tag exists
      
      * Ensure changelog is in the released package
      
      * Fix workflow
      
      * Remove unnecessary step
      
      * Ensure we can have access to release utils script when checking out master
      
      * Fix the step to create a PR updating readme and changelog
      
      * Fix changelog generation
      
      * Fix couldn't download changelog
      
      * Clean up steps
      Unverified
      78db8c49
    • Nick Fitzpatrick's avatar
      React 18 (#41975) · ead905b1
      Nick Fitzpatrick authored
      
      * initial commit with most types sorted
      
      * admin, binning, collections, custom-column and dashboard-cards suites
      
      * Filters, Joins, Metrics, Models, Native and Native filters suites
      
      * rest of e2e specs
      
      * filters, actions, onboarding and custom column will hopfully be green?
      
      * fixing static viz, brush filtering, login redirecting, and a few other tests
      
      * types green
      
      * linter green
      
      * hopefully fixes filter tests
      
      * I don't often cry, but when I do it's because of filter-types
      
      * hopfully sorted the last test that's failing CI
      
      * PR Feedback
      
      * yarn prettier
      
      * React 18 Upgrade - Unit Tests (#41577)
      
      * fixes for most unit tests to work with react 18 + upgraded rtl to v15
      
      * fixes all unit tests locally
      
      * fixes from rebasing
      
      * linter shames me
      
      * fix flake in maps.cy.spec.js
      
      ---------
      
      Co-authored-by: default avatarSloan Sparger <sloansparger@users.noreply.github.com>
      Co-authored-by: default avatarSloan Sparger <sloansparger@gmail.com>
      Unverified
      ead905b1
  13. May 28, 2024
    • Romeo Van Snick's avatar
      Allow creating new items by inserting comma in MultiAutocomplete (#42824) · b6bb9d18
      Romeo Van Snick authored
      
      * Pass current values to shouldCreate
      
      * Allow comma to create new item
      
      * Simplify getAvailableSelectItems
      
      * Add unit test for MultiAutocomplete input
      
      * Use text instead of Text in paste
      
      * Handle spaces in MultiAutocomplete
      
      * Remove cast
      
      * Reuse last var
      
      * Use haveLastBeenCalledWith over haveBeenCalledWith
      
      * Handle pasting when there is text in the input already
      
      * Accept quote-delimited values
      
      * Add info icon
      
      * Handle tab as a separator
      
      * Fix test cases for unsanitized parseValues
      
      * Add csv-parse
      
      * Use csv-parse to parse values
      
      * Apply the correct color to the info icon
      
      * Rename util to utils
      
      * Break up tooltip text
      
      * Only return unique values
      
      * Be more accepting around quotes in the middle of unescaped values
      
      * provide Buffer for csv-parse package in storybook
      
      * Use browser-friendly version of csv-parse
      
      * Remove unused eslint rule
      
      * Add specital case for csv-parse to jest config
      
      * Put uniqueness check in each state update
      
      * Only add partial value if it is valid
      
      * Only add partial value if it is valid
      
      * Fix test case for FilterValuePicker
      
      * Just use Set
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      
      * Allow parsing more than one value
      
      * Use isValid everywhere it makes sense
      
      * Add test for RTL languages
      
      ---------
      
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@gmail.com>
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      Unverified
      b6bb9d18
  14. May 17, 2024
  15. May 16, 2024
    • Aleksandr Lesnenko's avatar
      drop percy (#42303) · 361f568e
      Aleksandr Lesnenko authored
      Unverified
      361f568e
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Automate releasing embedding SDK (#42516) · 3dbeb3bf
      Mahatthana (Kelvin) Nomsawadi authored
      * WIP some workflows
      
      * Add reminder todo comment
      
      * Complete the workflow
      
      * Fix YAML syntax error
      
      * Trigger the workflow
      
      * Fix resuable workflow
      
      * Fix uberjar workflow
      
      * Add missing steps before testing
      
      * Pass recrets to resuable workflow, so it could run
      
      * Fix sdk artifact location
      
      * Remove unneeded output
      
      * fetch tags, so it doesn't fail on push
      
      * Only running EE uberjar in SDK workflow
      
      Because OSS is never needed
      
      * Fix incorrect syntax
      
      * Shuffle workflow so it failed fast
      
      * Fix syntax error
      
      * Attempt to bulid only EE jar
      
      * Fix the error handling step
      
      * Fix failing to upload to s3
      
      * Fix create a PR step
      
      * Fix the last temporary command, so the build looks green
      
      * Remove hack to trigger the workflow
      
      * Remove completed todo comment
      
      * Clean up S3 step
      
      * Add todo comment
      
      * Upload correct docker image name
      
      * Bump the package version before building SDK
      
      * Fix uploading the correct Metabase dev container name
      
      * Fix one too many double quote
      
      * Push the correct docker image
      
      * Fix PR creation step
      
      * Dry run publishing SDK
      
      * Use a separate uberjar workflow for SDK
      
      * Remove a bunch of unused steps
      
      * Update variable names, step names
      
      * Improve tag error message
      
      * Correct m2-cache-key to be unique
      
      * Fix the push tag failure step to only run when failed to push tag
      
      * Fix changed artifact name
      
      * Improve env name for clarity
      
      * Fix extra trailing empty line
      
      * Remove conditions from running certian steps
      
      * Removing npm publish dry-run
      Unverified
      3dbeb3bf
  16. May 14, 2024
  17. May 13, 2024
  18. May 09, 2024
  19. Apr 29, 2024
  20. Apr 26, 2024
  21. Apr 15, 2024
  22. Apr 11, 2024
    • Nicolò Pretto's avatar
      add env var to enable css modules classnames linting (#41173) · 99d15b04
      Nicolò Pretto authored
      
      * .eslintrc -> .eslintrc.js
      
      * This might work?
      
      * add env for linting css modules class names
      
      * avoid extending postcss-modules/recommended, specify just the used rule instead
      
      * add missing . on comment
      
      * Remove unused .detailName references
      
      * Fix ManageApiKeys and GuiQueryEditor
      
      * Fix SettingText and DashboardControls
      
      * fix missing textUnspaced class
      
      * remove usave of S.headerButton, that's actually never used because we never pass headerLink to ReferenceHeader
      
      * Remove flexNoShrink
      
      ---------
      
      Co-authored-by: default avatarOisin Coveney <oisin@metabase.com>
      Unverified
      99d15b04
  23. Apr 10, 2024
  24. Apr 08, 2024
  25. Apr 04, 2024
  26. Apr 03, 2024
  27. Apr 02, 2024
Loading