Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Oct 24, 2024
    • bryan's avatar
      AG housekeeping (#49047) · cca66d44
      bryan authored
      
      * upgrades is-airgapped? defn to defsetting airgap-enabled
      
      - uses the airgap-enabled settings value to remove Cloud section in
        SettingsEditor
      - "Metabase Enterprise Airgap" -> "Enterprise Airgap"
      
      * hide still need help section in airgap mode
      
      * move flag checking into selectors
      
      * fe lint
      
      * ts type check
      
      * use optional chaining and nullish coalescing
      
      * hide StillNeedHelp in ag mode
      
      * adding airgap-enabled to createMockSettings
      
      ---------
      
      Co-authored-by: default avatarNick Fitzpatrick <nickfitz.582@gmail.com>
      Unverified
      cca66d44
  2. Aug 23, 2024
  3. Aug 20, 2024
  4. Aug 02, 2024
  5. Jun 10, 2024
    • Denis Berezin's avatar
      feat(sdk): SDK theming part 6 - text-brand, text-dark, text-light,... · e8fedf01
      Denis Berezin authored
      feat(sdk): SDK theming part 6 - text-brand, text-dark, text-light, text-medium, admin-navbar, `accentX` (#43687)
      
      * Migrate text-brand
      
      * Migrate text-dark
      
      * Migrate text-light
      
      * Migrate text-medium
      
      * Migrate admin-navbar
      
      * make compact formatting consistent across all series (#43472)
      
      * make compact formatting consistent across all series
      
      * fix rebase
      
      * [Browse] Show Browse models link in nav only when there are models (#43286)
      
      * Upgrade to TypeScript v5.4 (#43736)
      
      * use correct github api for CI (#43750)
      
      * update list of releases (#43754)
      
      * Multi Series Dashcards Render with Filters Applied To All Series (#43428)
      
      * Multi Series Dashcards Render with Filters Applied To All Series
      
      Fixes: #39083
      
      Multi-series dashcards now properly render when a subscription is set up with filters that impact the values of each
      card in the multi-series card.
      
      * Small refactor for executing dashcards in a pulse context.
      
      - move execute-dashboard-subscription to pulse.util
      - this fn now will also execute all card series cards
        and put those results into a list on the key :series-results in the dashcard
        which is then used in the render multimethod to send the correct data to the javascript context
      
      A small todo was taken care of as well, we can now use :dashboard-subscription in the :context key
      
      * Fix up render fn
      
      The shape of hte data going into the javascript was a bit unclear before. This keeps things a little more
      understandable.
      
      Next step is probably to create some Malli schemas inside the js_svg namespace to document and enforce the needed data shapes
      
      * pull :data up a level from :result in the series cards
      
      * Update src/metabase/pulse/render/body.clj
      
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
      
      * Remove unneeded let
      
      * set/rename-keys won't work here because we raise the :data key
      
      I've realised a suggested change to just use set/rename-keys won't do what we need. We need instead to raise :data
      from within the result key up to the same level (and dissoc result).
      
      I've renamed the helper function to make its purpose a bit clearer
      
      ---------
      
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
      
      * Hydrate can_run_adhoc_query and address review comments (#43747)
      
      This is a followup on #43625.
      
      * Consolidate dashboard-card specs (#43716)
      
      * Consolidate joins specs (#43717)
      
      * Update translations for v50 and add Danish Language Support (#43314)
      
      * update translations for v50
      
      * add Danish
      
      * update translations for v50 release
      
      * alphabetical order is nice
      
      * Move database role to url parameters from connection properties on Snowflake (#43602)
      
      * Move role to url parameters from connection properties
      
      * Fix test
      
      * Fix width of save button in cache sidebar (#43755)
      
      * Remove dead code (#43603)
      
      * Combine search e2e specs (#43718)
      
      * Highlight the table cell data in dashboards when the cell is an ID column (#43728)
      
      * highlight id cell column
      
      * add simpletable stories
      
      * add simple table test data
      
      * add loki reference image
      
      * Update frontend/src/metabase/visualizations/components/TableSimple/TableCell.styled.tsx
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      ---------
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * Remove old repro for 39150 (#43749)
      
      * Fix remaining `tinyint` booleans in MySQL (#43296)
      
      * Correct type for `report_card.dataset`
      
      This was missed in the original migration of boolean types to
      ${boolean.type} in MySQL/MariaDB, and then missed again by me when I
      migrated `collection_preview` over a week ago.
      
      * Change all boolean types to `bit(1)` in MySQL
      
      Liquibase changed their boolean type in MySQL from `bit(1)` to
      `tinyint(4)` in version 4.25.1. Our JDBC driver does not recognize these
      as booleans, so we needed to migrate them to `bit(1)`s.
      
      As discussed [here](#36964), we
      changed all existing `boolean` types that were in the
      `001_update_migrations.yml` but not the SQL initialization file.
      
      For new installations, this works: things in the SQL initialization file
      get created with the `bit(1)` type.
      
      However, for existing installations, there's a potential issue. Say I'm
      on v42 and am upgrading to v49. In v43, a new `boolean` was added.
      
      In this case, I'll get the `boolean` from the liquibase migration rather
      than from the SQL initialization file, and it need to be changed to a
      `bit(1)`.
      
      I installed Metabase v41 with MySQL, migrated the database, and then
      installed Metabase v49 and migrated again. I made a list of all the
      columns that had the type `tinyint`:
      
      ```
      mysql> SELECT TABLE_SCHEMA, TABLE_NAME, COLUMN_NAME, COLUMN_TYPE,        COLUMN_DEFAULT, IS_NULLABLE FROM INFORMATION_SCHEMA.COLUMNS WHERE COLUMN_TYPE = 'tinyint' AND TABLE_SCHEMA='metabase_test';
      +---------------+------------------------------+-------------------+-------------+----------------+-------------+
      | TABLE_SCHEMA  | TABLE_NAME                   | COLUMN_NAME       | COLUMN_TYPE | COLUMN_DEFAULT | IS_NULLABLE |
      +---------------+------------------------------+-------------------+-------------+----------------+-------------+
      | metabase_test | core_user                    | is_datasetnewb    | tinyint     | 1              | NO          |
      | metabase_test | metabase_field               | database_required | tinyint     | 0              | NO          |
      | metabase_test | metabase_fieldvalues         | has_more_values   | tinyint     | 0              | YES         |
      | metabase_test | permissions_group_membership | is_group_manager  | tinyint     | 0              | NO          |
      | metabase_test | persisted_info               | active            | tinyint     | 0              | NO          |
      | metabase_test | report_card                  | dataset           | tinyint     | 0              | NO          |
      | metabase_test | timeline                     | archived          | tinyint     | 0              | NO          |
      | metabase_test | timeline                     | default           | tinyint     | 0              | NO          |
      | metabase_test | timeline_event               | archived          | tinyint     | 0              | NO          |
      | metabase_test | timeline_event               | time_matters      | tinyint     | NULL           | NO          |
      +---------------+------------------------------+-------------------+-------------+----------------+-------------+
      10 rows in set (0.01 sec)
      ```
      
      Then wrote migrations. For each column, we:
      
      - turn it into a `bit(1)`,
      
      - re-set the previously existing default value, and
      
      - re-add the NOT NULL constraint, if applicable.
      
      * Change author and add missing `dbms`
      
      ---------
      
      Co-authored-by: default avatarJohn Swanson <john.swanson@metabase.com>
      
      * Add ts-pattern library (#43752)
      
      * Add events to measure search performance (#43135)
      
      * new_search_query event
      
      * Filters in object, search click event
      
      * updating event schema
      
      * type and event schema adjustments
      
      * delete comments BE code
      
      * adjusting tests
      
      * PR feedback
      
      * typos and spacing
      
      * Fixup missing colors
      
      ---------
      
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@users.noreply.github.com>
      Co-authored-by: default avatarRaphael Krut-Landau <raphael.kl@gmail.com>
      Co-authored-by: default avatarSloan Sparger <sloansparger@users.noreply.github.com>
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      Co-authored-by: default avatarAlex Yarosh <alexandra@metabase.com>
      Co-authored-by: default avataradam-james <21064735+adam-james-v@users.noreply.github.com>
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      Co-authored-by: default avatarlbrdnk <lbrdnk@users.noreply.github.com>
      Co-authored-by: default avatarPhoomparin Mano <poom@metabase.com>
      Co-authored-by: default avatarNemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
      Co-authored-by: default avatarSakuragiYoshimasa <ysrhsp@outlook.com>
      Co-authored-by: default avatarJohn Swanson <john.swanson@metabase.com>
      Co-authored-by: default avatarNick Fitzpatrick <nick@metabase.com>
      Unverified
      e8fedf01
    • Denis Berezin's avatar
      feat(sdk): SDK theming part 5 - success, summarize, warning, white, text-white, bg-white (#43676) · 7046fef3
      Denis Berezin authored
      * Migrate success
      
      * Migrate summarize
      
      * Migrate warning
      
      * Migrate white
      
      * Add colors to storybook
      
      * Fix CI
      
      * Fix CI
      
      * Codereview fixes
      
      * Convert warning color
      Unverified
      7046fef3
  6. Jun 05, 2024
  7. Jun 03, 2024
  8. Mar 28, 2024
  9. Mar 19, 2024
  10. Feb 20, 2024
    • Kamil Mielnik's avatar
      RFC 70 - Automate sorting imports (#33883) · 2aa3cec6
      Kamil Mielnik authored
      * Upgrade eslint-plugin-import
      
      * Configure import/order rule for consistent, predictable imports
      
      * Change "eslint-disable-next-line no-restricted-imports" into "eslint-disable-line"
      
      * Ensure imports are in a single block
      
      * Move or remove informative comments between import statements
      
      * Remove imports-grouping comments
      
      * Configure groups
      - the difference between the default setting is the presence of "internal" group
      
      * Manually fix imports order and disable "import/order" rule in files with possible circular dependencies
      
      * Move comment to the same line as import
      
      * Run "yarn eslint-fix" 5 times
      - Remaining: 16 problems (16 errors, 0 warnings)
      
      * Manually fix imports order in remaining files
      
      * Run "yarn prettier"
      
      * Fix import
      
      * Fix circular dependency
      
      * Fix circular dependency
      
      * Remove unused action creator (it was inlined in 702988ec3f8bd4c6bf6bbbdf169dca25a0ca5a13 due to circular dependency)
      
      * Re-add accidentally removed code
      
      * Fix typing
      
      * ESLint
      Unverified
      2aa3cec6
  11. Feb 13, 2024
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Add ESLint rule for Metabase strings (#38553) · 279b3721
      Mahatthana (Kelvin) Nomsawadi authored
      * Fix case where Metabase links are render inside template strings
      
      * Add `no-literal-metabase-strings` ESLint rule
      
      * Fix all Metabase string errors
      
      * Address review: Fix the rule
      
      The rule was checking if we have imported the selector
      `getApplicationName` then ignore all Metabase strings. This is different
      than `no-unconditional-metabase-links-render` because in that rule, when
      fixed the Documentation URLs are still in the file, but in this rule,
      when fixed, there should be no Metabase strings left in the file.
      
      * Fix errors from the new lint rule
      Unverified
      279b3721
  12. Feb 12, 2024
  13. Jan 09, 2024
  14. Nov 02, 2023
    • Nick Fitzpatrick's avatar
      Add remove columns panel (#34087) · c593fecd
      Nick Fitzpatrick authored
      
      * temp
      
      * Mostly functional. Still needs cleanup
      
      * cleanup
      
      * hide from table header
      
      * resolving type disputes. adding icon prop to column item
      
      * e2e tests passing
      
      * temp
      
      * branch cleanup
      
      * Fe linter and unit tests
      
      * e2e adjustments
      
      * PR Feedback
      
      * fix unit test
      
      * Hide Viz Settings Buttons in Column Headers in Raw Table Mode (#35114)
      
      * e2e adjustments
      
      * don't show viz settings actions on raw table view
      
      * better prop handling
      
      * Adding e2e test
      
      * updating selector
      
      * more e2e adjustments
      
      ---------
      
      Co-authored-by: default avatarNick Fitzpatrick <nickfitz.582@gmail.com>
      
      * e2e updates
      
      * removing comment
      
      ---------
      
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      Unverified
      c593fecd
  15. Oct 24, 2023
  16. Aug 22, 2023
  17. Aug 09, 2023
  18. May 31, 2023
  19. May 13, 2023
  20. Mar 02, 2023
  21. Feb 23, 2023
  22. Jan 06, 2023
    • Anton Kulyk's avatar
      Fix minor unit test issues (#27545) · f1d355d4
      Anton Kulyk authored
      * Extract `setup` helper
      
      * Use more readable test string
      
      * Use `not.toBeInTheDocument` vs `toBeNull`
      
      * Fix missing assertions
      
      * Fix error about `widget` not being an element
      
      * Fix missing `key` prop
      
      * Improve new dashboard modal tests
      
      * Remove not used import
      
      * Fix typo
      
      * Add missing `key` props
      
      * Use `waitFor` instead of `act`
      Unverified
      f1d355d4
  23. Jan 05, 2023
    • Anton Kulyk's avatar
      Improve `renderWithProviders` test utility (#27398) · c7483334
      Anton Kulyk authored
      * Fix error about redux store fixture
      
      * Always add settings and embedding reducers
      
      * Add `value` to `SettingDefinition` type
      
      * Add `settings` type to admin state branch type
      
      * Add `users` to entities state
      
      * Convert `__support__/ui` to TypeScript
      
      * Fix error when rendering with router mock
      
      * Remove `form` from redux state
      
      * Address feedback
      
      * Fix tests setup
      
      * Add return type
      Unverified
      c7483334
  24. Dec 20, 2022
  25. Nov 30, 2022
    • Anton Kulyk's avatar
      Clean up setting selectors usage (#26637) · f1daa097
      Anton Kulyk authored
      * Clean up setting selector wrappers
      
      * Sort `LicenseAndBillingSettings` imports
      
      * Use `getSettings` in `LicenseAndBillingSettings`
      
      * Fix selectors usage in metabase enterprise
      
      * Fix selectors usage in Slack forms
      
      * Fix selectors usage in `GoogleAuthForm`
      
      * Fix selectors usage in `AppBanner`
      
      * Fix selectors usage in `CloudMigrationHelp`
      
      * Unsubscribe query builder from app settings
      
      They don't seem to be used at all
      
      * Fix selectors usage in auth selectors
      
      * Fix selectors usage across the app
      
      * Fix something happened to an import
      Unverified
      f1daa097
  26. Sep 30, 2022
  27. Aug 02, 2022
  28. Jul 06, 2022
  29. Apr 08, 2022
  30. Jan 31, 2022
  31. Jan 26, 2022
  32. Jan 24, 2022
  33. Jan 04, 2022
    • Alexander Lesnenko's avatar
      Replace enterprise with license page (#19343) · b0309e2c
      Alexander Lesnenko authored
      * remove old store page
      
      * add license pages
      
      * add remove webpack cache command
      
      * lint
      
      * fix specs
      
      * remove license widget from the oss version
      
      * add missing translation
      
      * show loader only for unput when updating token
      
      * fix specs
      
      * amend the license page
      
      * unactivated state fix
      
      * add premium embedding page, refactor, fix specs
      
      * amend the license page
      
      * amend the license page
      
      * change license page padding
      Unverified
      b0309e2c
Loading