This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Sep 12, 2022
-
-
Ryan Laurie authored
* derive parameter types from form settings on save * update template tag types with parameter types * improve tests
-
Cam Saul authored
* Support starting Metabase without initializing the Quartz scheduler * Fix
-
Mahatthana (Kelvin) Nomsawadi authored
* Render text in Slack subscription when there is no result * Change is correct, just fixing nitpicks Co-authored-by:
Adam James <adam.vermeer2@gmail.com>
-
Alexander Polyankin authored
-
Cal Herries authored
* Show a basic banner if token status is "unpaid" or "past_due" * Add warning emoji to banner message * Swap unpaid and past-due meanings * Make links consistent between messages * Replace useLicense with token-status setting * Add token-status to SettingName * Extract AppBanner logic to selector and reuse Banner component * Create TokenStatus type and createMockTokenStatus * Remove hard-coded status * Make token-status have internal visibility * Revert "Make token-status have internal visibility" This reverts commit 8983617a0f7f1e1a9e36206d93d871df5c290965. * Write test for token-status setting * Bring back AppBanner to render message correctly * Test banner isn't present for normal users * Address Alex's comments
-
Cal Herries authored
Don't show an error page when loading cardtagEditor if the user doesn't have permission to view the referenced card (#25334)
-
Alexander Polyankin authored
-
Anton Kulyk authored
* Move `ClickBehavior` types to its own file * Add click_behavior to `ActionButtonDashboardCard` * Fix `createMockDashboardActionButton` helper * Rename `isActionButtonWithMappedAction` * Add unit tests for `isMappedExplicitActionButton`
-
Mahatthana (Kelvin) Nomsawadi authored
* Make data point circle more visible * Test combo-chart with data point values shown
-
- Sep 09, 2022
-
-
Natalie authored
-
Noah Moss authored
* use .p12 file extension for pkcs-12 keys * test * fix messed up indentation * default to empty string ssl password * address feedback * fix tests
-
Cal Herries authored
* Add an autocomplete completer that gets all the columns for referenced questions * Tidy up * Add docstring for WIP * Add TODOs * Add endpoint for referenced-cards * Undo changing comment * Revert back to returning null * Update src/metabase/api/card.clj Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> * Add template tag that isn't a card reference to the test * Make ids follow conventions and tidy * Remove unused require * Create e2e test * Add wait to be sure autocompleter finishes * Remove referenced-cards endpoint and fetch questions as the user types * Remove unrelated change * Filter columns for substring matches only * Prioritise question columns in autocomplete results * Fix issue with autocomplete if user doesn't have access to referenced question * Add useCachedForbiddenError option for withCachedData * Actually add useCachedForbiddenError Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
Anton Kulyk authored
* Allow rendering `DataSelector` outside of popover * Add scaffold endpoint * Add scaffold action * Implement scaffolded "New App" flow
-
Natalie authored
-
adam-james authored
* Respect custom series names in static viz * Remove change that isn't actually necessary * Revert "Remove change that isn't actually necessary" This reverts commit 617ff4a9719bd5386bf69651cad696948a1fea7b. * Remove uneeded change * Add helper fn * Add back a change I actually did need... brain fart, oops * Add a test to make sure the correct :name key is used for series * Remove unused function
-
Gustavo Saiani authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Render ordinal x-axis label 90deg instead of 45deg * Fix chart grid and x-axis size not equal when having left padding * Fix X-axis line covered by grid lines * Update static chart text size to match new designs * Handle 90deg rotated x-axis tick labels * Fix timeseries overlapping x-axis tick labels * Fix typo * Show data point circle to make reading line charts less confusing * Render data point circle only on visible data point values + fix types * Address review
-
- Sep 08, 2022
-
-
Bryan Maass authored
* users may only send non-ddl native sql to h2 * tests for diasllowing h2 ddl * improve error message on throw * fix linter + cleanup the-exploit example. * refix linter * handle garbage input by failing to classify it. If it h2 can't parse it, then that input cannot trigger a vulnerability. Our parser simply chews through erroneous sql, and classifies statements that it is able to parse. * When h2 is running in client-side mode, do not parse sql - SessionRemote indicates that we are currently client side * refactor so that building parser is easier * remove unused import SessionRemote * Revert "refactor so that building parser is easier" This reverts commit a41800131696de00d98e4eb7124d4d4b1b1cb33c. * check client-side conns => import SessionRemote * replace truncate function via inlining * fix drop arg order
-
adam-james authored
* Add goal line settings to the viz-settings map passed to combo chart * Add a test to check that goal lines are added to line/area/bar/combo
-
Jeff Bruemmer authored
-
Gustavo Saiani authored
-
Case Nelson authored
* [Apps] Prototype backend app scaffolding WIP Given a set of table-ids, we try to build out an app. Ideally the produced scaffold is done on the frontend and passed in to 1. avoid code duplication 2. allow the front end to maintain ownership of visualization_settings 3. avoid regressions on frontend code changes However, this currently builds the scaffold on the backend due to FE dev bandwidth. In theory, it is done in such a way that it both matches the FE as closely as possible as well as becomes easy to change this code to accept a scaffold rather than generating one itself. It uses `scaffold-target` to map cards and dashboards in the scaffold with the inserted ids. Things that are still being worked out elsewhere: 1. The shape of nav-items 2. The shape of implicit action buttons * Sort namespace * Update and fix scaffold based on demo * Address review comments Deduplicate table-ids and make sure they are valid. i18n page suffixes. Check that tables have exactly one primary key column. Check that card scaffold has a `scaffold-target` Remove redudant check in scaffold-target replacement that the map lookup took care of.
-
Jeff Bruemmer authored
-
Case Nelson authored
-
Nick Fitzpatrick authored
-
Anton Kulyk authored
-
Case Nelson authored
* [Apps] Allow extra parameters to be passed to action execution For actions, unlike queries, the user will be asked to fill in unmapped parameters. This change allows the dashboard action execution to accept incoming parameters without an "id" but with a "target". If that target exists on the action, it will be accepted. * Update doc string and validation message * Review changes Remove action-id from the execute endpoint, this will be looked up through the dashcard. Revert map-parameters and split parameters into an extra_parameters value. extra_parameters are combined with the mapped parameters and passed to execution. * Fixing tests
-
Jeff Bruemmer authored
-
Natalie authored
-
Alexander Polyankin authored
-
Anton Kulyk authored
-
Alexander Polyankin authored
-
- Sep 07, 2022
-
-
metamben authored
Hydrate app_id for dashboard activities Part of #25254. Only the /recent_views and /popular_items endpoints have been extended. The / endpoint currently doesn't deliver additional information like the other endpoints do. (The other endpoints deliver at most 5 items, but the / endpoint doesn't limit the number of results.)
-
Jeff Bruemmer authored
-
Bryan Maass authored
* adds schema based api error messages for maps - e.g. in defendpoint. see: the error for `metabase.api.action/HTTPActionTemplate`: value must be a map with schema: ( body (optional) : value may be nil, or if non-nil, value must be a string. headers (optional) : value may be nil, or if non-nil, value must be a string. parameter_mappings (optional) : value may be nil, or if non-nil, value must be a map. parameters (optional) : value may be nil, or if non-nil, value must be an array. Each value must be a map. method : value must be one of: `DELETE`, `GET`, `PATCH`, `POST`, `PUT`. url : value must be a string. ) * use deferred-tru for error message - fix spacing in api-error-message - spruce up test * sort ns * swap another test to using str/join "\n"
-
Bryan Maass authored
* adds ddiff2 as a dev dependency - used in process-query-debug * Update dev/src/dev/debug_qp.clj use 0 arg version of println Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
Nick Fitzpatrick authored
* Adding text-overflow to ChartSettingsFieldPicker
-
Aleksandr Lesnenko authored
* fix timelines visual specs flakes * review
-
Alexander Polyankin authored
-
Anton Kulyk authored
* Only allow action execution for button dash cards * Add action properties to `DashboardOrderedCard` * Add `isActionButtonWithMappedAction` helper * Extract `ActionOptionItem` * Split `ActionOptions` inner and outer components * Extract `BaseDashboardOrderedCard` type * Add `ActionButtonDashboardCard` type * Export `ClickBehaviorParameterMapping` * Add data app and writeback test mock factories * Add new endpoint for action execution * Use new execution endpoint in `executeRowAction` * Extend writeback utils * Pass `action_id` when updating dashboard cards * Add `updateButtonActionMapping` redux action * Make `getDataFromClicked` more TypeScript friendly Setting default argument values makes these args optional in TypeScript * Add tools to convert parameter mappings * Show button name in click behavior sidebar * Update button action and parameters mapping logic * Pass dashcard to dashboard click object `extraData` * Add drill executing writeback actions * Fix `action_id` not passed on adding a button card * Add vertical space in button config sidebar * Fix "Unknown" click behavior state * Fix type * Add a comment about parameter mapping formats * Extract `ActionClickMappings` component * Clean parameter mappings when changing action * Fix navigation button don't work * Bring "Perform action" option back * Fix action option icon
-