This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Mar 07, 2024
-
-
Oleg Gromov authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Romeo Van Snick authored
* Add info icon to the column picker dropdown in the notebook editor (#38725) * Make SemanticTypeLabel not depend on Field but just on the semantic type * Add MLv2 version of FieldInfo * Add MLv2 props to FieldInfoPopover * Convert TableInteractive to use MLv2 version of FieldInfoPopover * Support Fingerprints in FieldInfo for MLv2 types * Move DateTimeFingerprint to its own file * Move NumberFingerprint to its own file * Allow Category finderprint info to work with MLv2 types * Remove null values in fingerprint info * Move move ColumnDescription into separate component * Split up fingerprint info component * Add hover card metadata to summarize sidebar (#38817) - Add column info hovercard to the summarize sidebar - Implement redesign of the bucker picker to accommodate the icon * Add hovercard on notebook filters (#38854) Add ColumnInfoIcon to the notebook filter picker * Add info popover to custom expression popover (#38870) * Pass query to ExpressionEditorSuggestions * Add info popover to custom expression suggestions * Add test for custom expression hovercard * Pass column directly instead of spreading it * Add unit test for suggestion list item * Add column info on filter modal (#38916) Add column info icon on the filter modal fields * Implement design feedback and fix tests (#39064) * Be more explicit with the icon position * Align the info icon more to the left * Directly export HoverParent * Ignore outside clicks on popover element * Fix binning tests * Select the correct popover * Fix import order * Fix broken export * Force click out of item * Fix missing bucket picker (#39244) * Data reference info hovercards (#39144) * Add info icons to fields in the data reference * Add test for info icon on field list * Render field items in a delay group * Fix import order to avoid circular dep * Force click item in test to avoid overlapping element * Add info icon to parameter field mapping (#39099) * Add info icon to dataselector * Add unit test for info icon * Fix import order to avoid circular dep * Ignore overlay when clicking element * Fix a circular dependency coming up in DataSelectorFieldPicker.unit.spec.tsx * Explicitlty import React * Fix text selector * Force click items to avoid overlapping elements from breaking the test * Avoid circular dependencies in entities/questions --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Join column hovercard (#38967) * Render Info icon on join column picker * Allow customising label on AccordionList * Add unit test for info icon on join column picker * Add info icon to summarize picker too * Fix margin on item name * Fix tests that rely on binning label * Set icon color without !important * Fix position of popover * Allow list item content to shrink where necessary * Make list item title ellipsified * Never shrink icon * Ignore overlay when clicking element * Fix import order to avoid circular dep * Reduce overlapping hovercards * Fix cut-off of text in summary column * Table info hovercard (#39308) * Use named export for TableInfoPopover * Remove duplicate propTypes * Export TableInfo's props * Use Mantine HoverCard for table info popover * Move info Popover to separate component * Move InfoIcon to shared component file * Add TableInfoIcon component * Add info icon to table picker * Pass through TableInfo props * Add test for TableInfoIcon * Use the info icon for the table header in chill mode * Pick the hovercard inside of the popover * Fix rendering children * Fix question test for table header * Avoid rendering huge icon in subtitle * Avoid unneccessary ternary Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Do not use within with single query Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Avoid cutting of loading spinner * Avoid closing popover when clicking it's content * Add test for click inside hovercard * Fix typo in commment Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Use direct import of ReactNode * Be more specific with popover selector * Scope selector to sidebar * Use correct selector for hovercard * Avoid scrollbars in info card * Adjust the width of the target component * Add more padding to description in table info card * Increase close delay to allow for clicks to go through * Simplify to findByText --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Add DelayGroup to unpinned dimensions * Remove unused variable * Use getByText * Fix time popover closing when more... is clicked --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Kamil Mielnik authored
-
- Mar 06, 2024
-
-
Raphael Krut-Landau authored
-
Jeff Bruemmer authored
-
Noah Moss authored
-
Chris Truter authored
-
Jesse Devaney authored
* fix dashcard text gets cut off * fix magic number
-
Jesse Devaney authored
-
bryan authored
-
Vamsi Peri authored
-
Nick Fitzpatrick authored
* Metadata Table columns use Sortable List * cleanup * e2e test adjustments
-
Uladzimir Havenchyk authored
* Add stylelint * Apply stylelint
-
Nemanja Glumac authored
[ci skip]
-
Nick Fitzpatrick authored
* ChartSettingOrderedItems using SortableList * e2e test adjustments * unit tests
-
Kamil Mielnik authored
* Convert commands/api/question to TS * Add missing embedding_params and collection_position attributes to Card * Type question function * Move types to the top of file * Inline throwIfNotPresent * Add types for logAction * Define StructuredQuestionDetails & NativeQuestionDetails * Add typing to commands * Return for consistency * Remove queryType argument from question * Define typing for archiveQuestion command * Format code * Define typing for createQuestion and createNativeQuestion commands * Make options optional * Remove TODO * Use arrow functions, update JSDoc * Use type for consistency * Add missing attributes in mocks * Make embedding_params non-optional * Add boilerplate for 11994 repro * Add temporary code * Improve typing * Implement test for combo chart * Simplify code * Convert updatePermissions to TS and add typing for updatePermissionsGraph * Add typing for updatePermissionsSchemas * Add typing for API responses, make updatePermissionsSchemas parameters optional * Add JSDocs * Explicitly specify types in commands * Use CardId * Fix the test - add missing visuzalization_settings to the pivot question - use "readonly" user and drop permissions manipulations * Remove TODO * Add an explanatory comment * Inline visitDashboardByAlias * Make visitQuestion accept an alias * Use new visitQuestion interface where possible * Remove somewhat duplicated comment
-
Uladzimir Havenchyk authored
* Tweak webpack config * Fix memory leak
-
Chris Truter authored
-
Chris Truter authored
-
Kamil Mielnik authored
Repro #11994 - Clicking RawData-toggle on pivoted table makes the question dirty and shows Save-button (#39629) * Convert commands/api/question to TS * Add missing embedding_params and collection_position attributes to Card * Type question function * Move types to the top of file * Inline throwIfNotPresent * Add types for logAction * Define StructuredQuestionDetails & NativeQuestionDetails * Add typing to commands * Return for consistency * Remove queryType argument from question * Define typing for archiveQuestion command * Format code * Define typing for createQuestion and createNativeQuestion commands * Make options optional * Remove TODO * Use arrow functions, update JSDoc * Use type for consistency * Add missing attributes in mocks * Make embedding_params non-optional * Add boilerplate for 11994 repro * Add temporary code * Improve typing * Implement test for combo chart * Simplify code * Convert updatePermissions to TS and add typing for updatePermissionsGraph * Add typing for updatePermissionsSchemas * Add typing for API responses, make updatePermissionsSchemas parameters optional * Add JSDocs * Explicitly specify types in commands * Use CardId * Fix the test - add missing visuzalization_settings to the pivot question - use "readonly" user and drop permissions manipulations * Remove TODO * Add an explanatory comment
-
Cal Herries authored
-
Anton Kulyk authored
* Scroll dashboard tabs to the end when adding a tab * Fix useEffect deps * Handle typescript error
-
Uladzimir Havenchyk authored
-
Kamil Mielnik authored
Refactor `cy.updatePermissionsGraph`, `cy.updatePermissionsSchemas` & `cy.updateCollectionGraph` to TypeScript (#39675) * Convert updatePermissions to TS and add typing for updatePermissionsGraph * Add typing for updatePermissionsSchemas * Add typing for API responses, make updatePermissionsSchemas parameters optional * Add JSDocs * Explicitly specify types in commands
-
Alexander Polyankin authored
-
Cal Herries authored
-
Cal Herries authored
-
Cal Herries authored
-
- Mar 05, 2024
-
-
adam-james authored
* Use timestamp in attachment filenames Fixes: #39120 This modifies the subscriptin attachment filenames to match the same format used when doing a direct download from a dashboard or question. That is: - card names are slugified (spaces and dashes turned to underscores, etc.) - a timestamp is appended to the slugified card name * Fix tests * Change docstring to use example local to the namespace
-
Jesse Devaney authored
Fix click behavior not working for pivot table header cells and tables pivoted (pivoted column cells) (#39569) * update pivot table header cells clicked format to match the expected format * fix clicked table pivoted click behavior for the chosen pivot column * fix failing tests * add tests
-
Ryan Laurie authored
-
Uladzimir Havenchyk authored
* Dedup some packages * Fix typecheck * formatting
-
Chris Truter authored
-
Braden Shepherdson authored
`metabase.lib.field/remove-field` is intended for manipulating the `:fields` list. That list controls which fields from the source, previous stage, explicit join, or implicit join should be included in the results. All aggregations, breakouts, and custom expressions are always included in the return columns for that stage, so they cannot be removed with the `:fields` clause. The UI does not attempt to do this, but this check is a guardrail for future changes. Trying to hide an aggregation from the `:fields` clause can silently create a broken query.
-
Noah Moss authored
-
Anton Kulyk authored
* Add repro test Reproduces #38055 Reproduces #38278 * Add `cancelEditingDashboard` action * Clean `selectedTabId` when canceling editing
-
Ryan Laurie authored
-
Romeo Van Snick authored
-