Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Dec 29, 2020
  2. Dec 28, 2020
    • Ariya Hidayat's avatar
      Better safe than sorry: really check only the hostname (#14208) · 089e9b17
      Ariya Hidayat authored
      * Better safe than sorry: really check only the hostname
      
      Thus, avoid matching for "openstreetmap.org" in any other parts of the URL.
      https://codeql.github.com/codeql-query-help/javascript/js-incomplete-url-substring-sanitization/
      
      * Guard against a potentially invalid map tile URL
      Unverified
      089e9b17
    • Ariya Hidayat's avatar
      Use ExternalLink component instead of <a href> (#14207) · caecc7bb
      Ariya Hidayat authored
      This automatically adds "noreferrer noopener", which is important for
      security: https://web.dev/external-anchors-use-rel-noopener/.
      Unverified
      caecc7bb
    • Maz Ameli's avatar
      Update translations for 0.38 (#14191) · e48dcc1b
      Maz Ameli authored
      
      * basic multi-level pivoting [ci skip]
      
      * better code to get rows
      
      * multiple value columns, other fixes
      
      * fix pivot table unit tests now that values are formatted
      
      * Pivot table column settings (#13760)
      
      * Pivot table virtualization (#13879)
      
      * add pivot table icon
      
      * Dashboard subscriptions work, squashed
      
      This test namespace differs in EE and OSS
      
      Without other changes from EE, this won't work
      
      so, for now, I've restored the pure OSS version of this test
      
      redo wording on existing subscription cards
      
      hacks? to address some timing issues where the render loop executes
      before properties are available (loaded from the server)
      
      links to configure pulse types
      
      Display a link to configure email or slack when they aren't already
      
      Fix the am/pm picker
      
      set up a new schedule tooltip
      
      The sidebar can appear and disappear from the Sharing popover
      
      run prettier on everything
      
      email recipients now does the "name [and n other]" thing
      
      Dashboard subscriptions work, squashed
      
      redo wording on existing subscription cards
      
      hacks? to address some timing issues where the render loop executes
      before properties are available (loaded from the server)
      
      styling for email not configured state
      
      add styling for slack unconfigured state
      
      disable cursor-pointer if email or slack isn't configured
      
      Implement cancel button for the sidebar (#13741)
      
      Dashboard subscription UX enhancements:
      
      * Implement cancel button for the sidebar
      
      * Don't return duplicate dashboard subscriptions
      
      * Move sidebar cancellation into Redux
      
      * Add close icon
      
      * Fix popover behavior
      
      Dashboard Subscriptions: Fix build (#13859)
      
      * Frontend lint fixes
      
      * Fix failing email tests
      
      * Revert some of the snapshot changes
      
      * regenerate snapshots
      
      * done fixing FE tests?
      
      * Make `dashboard_card_id` optional in CardRef schema
      
      * Fix test setup in pulse model test
      
      * Fix collection API test
      
      * Order pulses by name
      
      * Cypress fixes/skips
      
      Co-authored-by: default avatarPaul Rosenzweig <paul.a.rosenzweig@gmail.com>
      
      Subscribe to dashboards send test email (#13886)
      
      * Frontend lint fixes
      
      * Fix failing email tests
      
      * Revert some of the snapshot changes
      
      * regenerate snapshots
      
      * done fixing FE tests?
      
      * Make `dashboard_card_id` optional in CardRef schema
      
      * Fix test setup in pulse model test
      
      * Fix collection API test
      
      * Order pulses by name
      
      * Cypress fixes/skips
      
      * uggh cypress
      
      * Add button to send test email for dashboard subscriptions
      
      * Disable test email with no recipients
      
      * Refactor SendTestEmail
      
      Co-authored-by: default avatarPaul Rosenzweig <paul.a.rosenzweig@gmail.com>
      
      Fix failing collection tests (#13891)
      
      * Move dashboard embedding button (#13928)
      
      * PoC of a basic waterfall renderer (#13661) (#13812)
      
      * PoC of a basic waterfall renderer (#13661)
      
      * Ensure that waterfall bars are not razor-thin
      
      * Assume the data is already in the form of increases & decreases
      
      * Waterfall chart: show the correct series values (positives and negatives) (#13661) (#13824)
      
      * Waterfall chart: show the correct series values (positives and negatives)
      
      Also, position the value labels properly (horizontally centered).
      
      * Waterfall: fix the vertical posiition of series values
      
      * Refactor the detection of bar or waterfall display
      
      * Waterfall: add the total bar (#13862)
      
      * Waterfall: add the total bar
      
      This is carried out by adding a new row in the chart series.
      
      * Fix string for translation
      
      * Fix reducer when calculating the total sum
      
      * Fix the position of the value label for the total bar
      
      * Use _.each and array spread operator
      
      * Prepare the total bar for waterfall without mutating the series data
      
      * Waterfall: Refactor stacked bar computation to fix for negative values (#13893)
      
      * Waterfall: Refactor stacked bar computation to fix for negative values
      
      This also simplifies the renderer, as most of the usual logic for
      stacked bar can be reused for waterfall.
      
      * Simplify computing waterfall values using Array#reduce
      
      * Add some unit tests for the waterfall renderer (#13909)
      
      * Waterfall: Ensure the correct tooltip and value label for the total (#13907)
      
      * Waterfall setting show/hide the total bar (#13919)
      
      * add waterfall icon
      
      * Waterfall settings: color settings for increases, decreases, total (#13931)
      
      * Waterfall settings: color widgets for increases, decreases, total
      
      * Compactify the color settings for waterfall
      
      * Waterfall colors: apply the increase & decrease colors
      
      * Move waterfall coloring to setChartColor()
      
      * Separate waterfall's total into its own (in the virtual stacked bars)
      
      This makes it easy to color the total bar, which has a value only for
      the last one in the series anyway
      
      * Waterfall total color should be conditional on the total toggle
      
      * Hide the regular series color widgets for waterfall charts. (#13951)
      
      Since the waterfall rendering only uses the increase, decrease, and
      total colors, there is no need to let the user pick the regular series
      colors.
      
      * add some strings that aren't in the UI yet (#13963)
      
      * update translations
      
      * remove all the extra newlines blerg
      
      * check out unmodified dashboard.clj model
      
      * reset two unrelated files
      
      Co-authored-by: default avatarPaul Rosenzweig <paul.a.rosenzweig@gmail.com>
      Co-authored-by: default avatarPaul Rosenzweig <paulrosenzweig@users.noreply.github.com>
      Co-authored-by: default avatarRobert Roland <rob@metabase.com>
      Co-authored-by: default avatarAriya Hidayat <ariya@metabase.com>
      Co-authored-by: default avatarAriya Hidayat <ariya.hidayat@gmail.com>
      Co-authored-by: default avatarReza Lotun <reza@lotun.ca>
      Unverified
      e48dcc1b
    • Kyle Doherty's avatar
      Remove `react-retina-image` package (#14205) · 2c1deee0
      Kyle Doherty authored
      * switch to srcset on GTAPModal
      
      * switch to srcset on SettingsSlackForm
      
      * switch to srcset on AlertModals
      
      * switch to srcset on Table
      
      * switch to srcset on WhatsAPulse
      
      * switch to srcset on SharingPane
      
      * switch to srcset on Overworld
      
      * switch to srcSet on Icon
      
      * switch to srcSet on EmbeddingLevel
      
      * remove react-retina-image package
      Unverified
      2c1deee0
    • Kyle Doherty's avatar
      remove single use of system components (#14204) · e4e9fffd
      Kyle Doherty authored
      
      * remove single use of system components
      
      * update snapshots
      
      Co-authored-by: default avatarPaul Rosenzweig <paul.a.rosenzweig@gmail.com>
      Unverified
      e4e9fffd
    • Ariya Hidayat's avatar
  3. Dec 25, 2020
  4. Dec 23, 2020
  5. Dec 22, 2020
  6. Dec 21, 2020
  7. Dec 19, 2020
  8. Dec 18, 2020
  9. Dec 17, 2020
  10. Dec 16, 2020
Loading