Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Apr 17, 2024
  2. Apr 16, 2024
  3. Apr 15, 2024
  4. Apr 12, 2024
    • Raphael Krut-Landau's avatar
      Add Schedule strategy to Admin > Performance (#41230) · 8006c2c6
      Raphael Krut-Landau authored
      Adds a Schedule strategy to the Admin / Performance page
      
      ![image](https://github.com/metabase/metabase/assets/130925/d78ff74d-df1c-477a-b157-a0c3f21a861b)
      
      [Loom](https://www.loom.com/share/5623cd5d772e417ba2e58c29ae1b8c14?sid=9844f0db-5bb1-4d35-af9b-206d263f5516)
      
      As discussed with @luizarakaki, rather than modify the legacy `SchedulePicker` to work with this use case, I made a new version of it - a `Schedule` component - that uses Mantine and a better (though imperfect) approach to localization. For now, the dropdowns are not vertically aligned in this Schedule picker - something I can try to remedy later if that is important.
      
      Tests for the Schedule component will be added in a follow-up PR.
      Unverified
      8006c2c6
    • adam-james's avatar
      Bugfix 37914 wrong filters UI in embedding (#41342) · f826a28f
      adam-james authored
      * Keep Filter Values for enabled Parameters in Embedding
      
      Fixes: #37914
      
      Previously, we removed locked parameters entirely. This is to prevent leaking potentially sensitive values.
      
      However, for the situation where the same field backs 1 locked or disabled paramter and 1 enabled parameter, we do
      still want to send the paramater values, because the enabled parameter implies that the values are permissible to see
      in the embed.
      
      So, this change will still remove parameters based on their 'disabled/locked/enabled' status, but will NOT remove the
      linked field ids if they're also being used by 'enabled' parameters.
      
      This results in the backend correctly sending necessary parameter values to the embed, where the frontend can then
      render the appropriate UI instead of falling back to just text filters.
      
      * test the case where a locked and enabled param share same field
      
      * Address feedback. Added comment to explain classify fn
      Unverified
      f826a28f
Loading