This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Aug 04, 2024
-
-
Radosław Kotkiewicz authored
-
- Aug 02, 2024
-
-
Emmad Usmani authored
* add pie.decimal_places setting * add unit spec * add stories * Update Loki Snapshots * add placeholder text --------- Co-authored-by:
Metabase Automation <github-automation@metabase.com>
-
Aleksandr Lesnenko authored
* fix pivot table missing horizontal scroll * spec * Update Loki Snapshots --------- Co-authored-by:
Metabase Automation <github-automation@metabase.com>
-
Ryan Laurie authored
* YOLO * fix a lot of tests * fix more tests * fix unit tests * remove comment * update tests and formatting * add debug code * remove debug code
-
Sloan Sparger authored
-
Raphael Krut-Landau authored
-
Raphael Krut-Landau authored
-
Alexander Polyankin authored
-
Sloan Sparger authored
* wip * moves code to enterprise folder, adds enterprise guards, updates conditionals as to when to show the feature * impls filter date logic, improves styling, mocks out real endpoint with collection items endpoint, updates table with isLink boolean rath er than using custom item renderer, removes dead code * use the actual url for stale * so many things... updated design, custom table component, polish, misc. refactors, more correct api typing * updates to pagination component and reverts some now unused changes to the base items table * impls pr feedback * fixes * fixes failing unit test * completes pr feedback from raffi * implements second round of feedback from raffi * adds tests and couple of small fixes / feedback * migrate clean up action to enterprise plugin and fix related e2e test, also skip the collection items count query when we do not need the value * finish main base case e2e test * clean up helper code for manual testing and add OSS test to make sure feature is not available in OSS * better handling of min-height on smaller screens * adds internal undo notification for bulk archiving in the clean up modal * reset pagination when items are archived/unarchived to keep users from getting stuck on a page beyond the current view * pr feedback * further cleanup * unit test fix * fixes issue where archiving all items in the modal and then undoing does not result in the stale items list getting refetched --------- Co-authored-by:
John Swanson <john.swanson@metabase.com>
-
Emmad Usmani authored
-
Ryan Laurie authored
* hide notebook button for brand new questions * test notebook button visibility for new questions * move brand new check inside shouldRender * test embedding SDK notebook button * update unit tests * add spy to shouldRender
-
John Swanson authored
* Fix coll permissions for audit collection We've had a function in `models.collection` for a while that has taken a permissions set and returned a set of collection IDs that the user has permissions on. I refactored this recently, but didn't notice that it was actually doing the permissions checks slightly incorrectly. Specifically, because it only looks at the user's permissions and the collection IDs and doesn't use `mi/can-read?` or `mi/can-write?`, it's completely indifferent to whether a collection is an audit collection or not. This is arguably not a *permissions* issue: the two errors that could come about here are: - someone sees the audit collection even though the audit feature is disabled, or - someone is presented with the audit collection in a context where only writable collections should be present - when they try to actually write to it, it fails (since then we're doing the real permissions check). The primary motivation for this fix was to prevent audit dashboards and cards from appearing in the list of stale items. * Fix hardcoded collection ID We were creating a timeline in a fixed collection ID, that in tests happened to be the ID of the Metabase Analytics collection.
-
lbrdnk authored
* Update values-from-card-query * Add test * Update values-from-card-query * Add missing issue no
-
Ryan Laurie authored
* properly handle SMTP environment variables * disable clear button when set by env var * allow the SMTP form to validate with any combination of environment variables * add unit tests for SMTP connection form * BONUS: fix console error for jt keys * fix types
-
github-automation-metabase authored
-
Jeff Bruemmer authored
-
Jeff Bruemmer authored
* link fixes * more links
-
Uladzimir Havenchyk authored
* do not update size if width or height is 0 * add a comment
-
Alexander Solovyov authored
-
Nicolò Pretto authored
* update the UI of the downloads toggle to make it look like the others in the page * make unit tests pass * make e2e pass
-
Sloan Sparger authored
* updates the ordering of create queries permissions options so that granular permissions is the last option * fix unit test * move granular option above no
-
Nicolò Pretto authored
* update static_embed_code_copied to use downloads (#45944) * copy schema file for better diff * adds downloads field to appearance in embed_flow schema * update event to send `downloads` parameter, update e2e tests * fix test for dwonloads: false * fix: use correct schema version for embed flow analytics (#46053) * update `dashboard_pdf_exported` and use it in embedding context (#46076) * copy schema for better diff * adds `dashboard_accessed_via` to the `dashboard_pdf_exported` event * download_results_clicked event (#46132) * adds download_results_clicked event + e2e tests * make strings nullable * adds maxLength * switch back to if/then as it seems more readable * refactor: use the resourceType to determine the download params instead of re-doing the logic * fix ''question' is possibly 'undefined'.' * split resource_type into resource_type and accessed_via to also consider interactive-embedding and sdk * edit comment * adds test for ad-hoc-question * Update frontend/src/metabase/query_builder/actions/downloading.ts Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * makes describe message more consistent * "else if" => if * fix describe block name * convert downloads event to use enum for download_type and export_type * resource_type should be an enum too * fix line added in the wrong place during merges --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * Update frontend/src/metabase/public/components/EmbedFrame/EmbedFrame.tsx Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * adds enum schema to dashboard_accessed_via * fix accessed_via for sdk embeds * update comments to explain why we send 0 when dashboardId is null * only send dashboard_id as a number when it is a number, as expected by snowplow * remove un-needed async/await from saveAsPDF function * rename frontend/src/metabase/redux/downloading-analytics.ts -> frontend/src/metabase/redux/downloads-analytics.ts * fix cy.log message --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
John Swanson authored
This reverts commit c7a5aee1.
-
Noah Moss authored
-
Chris Truter authored
-
Nicolò Pretto authored
* update embed frame pdf button colors to use --mb-color- vars * change download pdf button color to brand color * testing adding the images that actually differ
-
Jeff Bruemmer authored
-
Roman Abdulmanov authored
-
Ngoc Khuat authored
-
Chris Truter authored
-
Alexander Solovyov authored
Previously we unpacked everything and picked up first entry as the directory containing the data. This works well when archives are passed as is. However, if a user unpacks and then packs an archive, there is a good chance that some hidden directories will appear - and they are first in order. So we skip those right now, and additionally check known markers of the serialization data directory.
-
Nemanja Glumac authored
-
- Aug 01, 2024
-
-
Emmad Usmani authored
* fix lost settings * add e2e test * trigger ci
-
Emmad Usmani authored
* fix pie border missing in batik static viz * refactor args * fix typo
-
Ryan Laurie authored
* fix db connection form icons * fix db connection form icons * appease typescript
-
Oreon Lothamer authored
-
lbrdnk authored
* Avoid adding temporal-unit to lhs cols * Use :default temporal-unit * Simplify logic, update comments * Update substitute-field-filter-test * Update align-temporal-unit-with-param-type-test * Update field-filter-date-test * Use end-excludding gte lt filter for DateTime fields * Update substitute-field-filter-test * Update align-temporal-unit-with-param-type-test * Update field-filter-date-test * Update bigquery test + comment * Update date-str->qp-aware-offset-dt * Add guard for unexpected date string format This is just for the completeness, I haven't encountered it. * Address review remarks * Update comment
-
Nick Fitzpatrick authored
* dismiss permissions modal regardless of network request * Spelling is hard
-
Ryan Laurie authored
* add auto-release patch job * better error handling * update schedule * address review feedback
-
Chris Truter authored
* Squash * Clean up query modifier for validating card references (#46283) * Fixup bad git merge on test expectation * Tweak docstrings and de-densify logic
-