Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Mar 24, 2022
    • Cam Saul's avatar
    • Cam Saul's avatar
      Support quarters in Dashboard filters (#21205) · 2eb61395
      Cam Saul authored
      * Support quarters in Dashboard filters
      
      * Mark test as ^:parallel
      
      * :wrench:
      Unverified
      2eb61395
    • adam-james's avatar
      Default Icon for Timelines / Events and Root Collection Hydration (#21201) · fca980fb
      adam-james authored
      * Timeline has default icon, Timeline Event default icon from Timeline
      
      * Move the icon schema to Timeline model.
      
      The 'default icon' of a Timeline is concretely 'star', whereas the default icon for an event is taken from the
      Timeline it's part of, which could be any of the icons.
      
      Since the default should be one of the icons listed in the Schema, it makes sense for readability that the icon schema
      is in the same namespace.
      
      * When timeline's collection_id is nil, build the root collection
      
      Timeline's always have :collection_id, and when the ID is a proper ID, :collection hydration works properrly. When the
      ID is nil, we don't pass the necessary data to the frontend. So, match the behaviour for the `GET
      /api/collection/root` endpoint and use that data on the :collection key
      
      * Add root collection hydration to GET /api/timeline
      
      * Add tests for collection hydration and timeline default icons
      Unverified
      fca980fb
  2. Mar 23, 2022
  3. Mar 21, 2022
  4. Mar 17, 2022
    • Jeff Bruemmer's avatar
      docs - driver guide (#20567) · 37f3ab43
      Jeff Bruemmer authored
      Unverified
      37f3ab43
    • Noah Moss's avatar
    • Noah Moss's avatar
      Delete MetaBot permissions group (#20925) · f917849c
      Noah Moss authored
      Unverified
      f917849c
    • Bryan Maass's avatar
      Sharing dashboard subscriptions slack performance (#20570) · 73917b31
      Bryan Maass authored
      * Get slack users and conversations simulatenously
      
      - instead of waiting for the channels, and then getting the users
      
      * Add cache+timeout capability to conversations-list
      
      * extend async approach to users-list
      
      - return timeout+cache warning
      - adds tests
      
      * updating docstrings + adding more tests
      
      * Add cache clear and seed slack token settings on-change
      
      - add dox for :on-change for defsettings
      - fixing tests
      
      * Fixing tests
      
      - cannot pass a declared (not def'd) value
      - some cleanup
      
      * remove unused function
      
      * remove need for slack-configured from timeout fns
      
      - update some docstrings
      
      * pre-populate slack caches
      
      - on app init
      
      * introduce blocking (and cache resetting) endpoint
      
      - this one does not timeout, meant to be called when a user hits a
        button like: "Refetch my slack channels"
      
      * removes -timeout versions of users/channels fn
      
      - the endpoint now returns the cached slack data
      - removes tests
      
      * fixes routing layer
      
      * remove trailing whitespace
      
      * add missing docstring
      
      * move the cached slack data into a setting
      
      * add missing docstring
      
      * fix typo
      
      * update form-input-test
      
      * refresh cache in test
      
      * remove un-needed anonymous fn wrapping
      
      * refresh slack cache when user sets new valid token
      
      * refresh the cache when reading from it
      
      - the more its used the more up to date it will be
      
      * code review responses + removes 2-arity refresh-cache!
      
      - clear out cache when slack connection is broken or unset
      - add to docstring for slack settings route
      - wrap init refresh-cache! with a future
      - re-spell parallel
      
      * do not block when returning cached slack data
      
      * rename cache defsetting
      
      * Addressing code review issues
      
      - Adds scheduled updates to the slack users and channels cache
        every 4 hours
      - Removes `form_input_refresh` route
      - Automatically refreshes cache when `form_input` route is hit,
        if 10 minutes have passed since the last cache fix
      - Removes cache refresh on app startup
      - Stores only user names, and channel names in the cache, not maps with
        irrelevant data
      - Clears out some noisy linter warnings via `#_:clj-kondo/ignore`
      
      * Adds slack task RefreshCache jobs
      
      - Sets up startup-triggered and cron-triggered (every 4 hours at a
        random minute) slack channel/username cache refreshing
      
      * Implements 2 jobs to update slack users/channels
      
      - one on startup, one every 4 hours
      - improve docstrings
      
      * ns linter fixes
      
      * more ns linter fixes
      
      * refactor files-channel to look in the cache
      
      - instead of making a tricky api call
      - fixing tests
      
      * update files-channel-test to test the cache
      
      * fixup integrations.slack ns decl
      
      * fixup test integrations.slack ns decl
      
      * fix outdated mock of slack/files-channel
      
      * fix a few more tests
      
      * fix api slack-test
      
      * adds locking to refresh-channels-and-usernames!
      
      * re-order requires
      Unverified
      73917b31
  5. Mar 16, 2022
    • Cam Saul's avatar
      Fix noisy backend tests (#20910) · f9f1bf41
      Cam Saul authored
      
      * Change u/profile from println to log/info
      
      * Change most test printlns to log/info
      
      * Make u/profile message a fn rather than a delay
      
      * Apparently clj-http errors aren't wrapped in :object anymore
      
      * Add running commentary
      
      * Log the amount of time it took to find and run tests
      
      * Sort namespaces
      
      * Update test
      
      Co-authored-by: default avatarDiogo Mendes <diogo@metabase.com>
      Unverified
      f9f1bf41
  6. Mar 15, 2022
  7. Mar 14, 2022
    • Cam Saul's avatar
      Upgrade Liquibase to latest version; remove final Java source file and need... · aaf1b601
      Cam Saul authored
      Upgrade Liquibase to latest version; remove final Java source file and need for `clojure -X:deps prep` (#20611)
      
      * Upgrade Liquibase to latest version
      
      * Try adjusting log
      
      * Fix checksums for the TWO migrations with ID = 32
      
      * FINALLY get Liquibase to use Log4j2
      
      * Set Liquibase ConsoleUIService OutputStream to null OutputStream
      
      * Manually define a package for our H2 proxy class so Java 8 works
      
      * Fix package-name determination code
      
      * Update migrations file spec
      
      * `databasechangelog` shouldn't be upper-case
      
      * Lower-case quartz table names
      
      * More MySQL fixes :wrench:
      
      * Properties for all the Quartz tables :cry:
      
      * Formatting tweaks [ci skip]
      
      * Revert a few more busted changes
      
      * Fix more busted changes
      
      * Bump Liquibase version to 4.8.0 to fix MySQL defaultValueBoolean bug
      
      * OMG I think I finally fixed MySQL
      
      * Remove Java source file and prep-deps code
      
      * Remove two more references to bin/prep.sh
      
      * Minor cleanup
      
      * Revert unneeded changes
      
      * Fix busted indentation
      
      * Don't search inside java/ anymore since it's G-O-N-E
      
      * Appease the namespace linter
      
      * Update src/metabase/db/liquibase/h2.clj
      Unverified
      aaf1b601
    • Noah Moss's avatar
    • adam-james's avatar
      Adjust GET /api/timeline to allow include=events parameter (#20972) · 65c01bdd
      adam-james authored
      This lets the Frontend get a list of timelines with the events included, useful in case of having an unsaved question
      where timelines should still be showable.
      
      > left comments but seems workable
      
      I'm going to merge this to let FE continue events implementation. 
      
      I will discuss the above concerns in Slack, and we can make adjustments as needed.
      Unverified
      65c01bdd
  8. Mar 12, 2022
  9. Mar 11, 2022
    • dpsutton's avatar
      Cleanup and schema for bookmarks (#20942) · cdcfc9ec
      dpsutton authored
      - sorting in query so don't have to sort in memory afterwards, and
      leaves open spot on the api to sort with user preferences if
      present (future work)
      - adds schema so we know what these bookmarks look like, and return an
      explicit structure instead of threading through dissoc and assoc
      - combined the remove-nil-values into the normalize function since it
      set up preconditions necessary for the normalize.
      - use Models in query so we don't have to hardcode the underlying table
      Unverified
      cdcfc9ec
  10. Mar 10, 2022
  11. Mar 09, 2022
  12. Mar 08, 2022
  13. Mar 01, 2022
    • dpsutton's avatar
      Cleanup some lint errors (#20770) · 9a8ef14d
      dpsutton authored
      mostly unused bindings. Had a few redundant lets. One common pattern was
      a let binding for a read check but the resulting value was never used,
      just checked that we could read or write it. Removed that from a binding
      since it throws otherwise
      Unverified
      9a8ef14d
  14. Feb 25, 2022
    • adam-james's avatar
      Events Backend Cleanup and Adding Start/End Range test (#20633) · 88a4e178
      adam-james authored
      * Adding tests in collections and card. Fixing some minor test things
      
      * Added Test for timeline event range selection via card API
      
      * Cleaned up a few TODO comments
      
      * Made the timestamp required when POST-ing a timeline-event
      
      * Remove unnecessary nesting of with-temp* forms
      
      * Moved Icons schema into timeline-event model
      
      This schema seems to be validating more than just the API, so we've moved it.
      
      * Added start/end to GET /api/timeline/:id
      
      Also cleaned up some unnecessary nesting in a card API test
      Added timeline range test in timeline API test ns too.
      
      * Parse timestamp when it exists in a timeline-event PUT
      
      We saw the db error presented in the FE when updating timeline events. This should fix that problem.
      
      * Add a test to ensure we can change timestamps via timeline-event PUT
      Unverified
      88a4e178
  15. Feb 24, 2022
  16. Feb 23, 2022
Loading