That is: collection, dimension, metric, native_query_snippet, pulse,
report_card, report_dashboard, report_dashcard, segment, timeline

Notably that doesn't include database, table, or field, since those all
have external unique IDs that are used instead.

* `defsetting` setter functions should end in `!`

* Fix typo

* Update .clj-kondo/hooks/metabase/models/setting.clj

* Fix clj-kondo for Toucan defmodel not emitting a docstring

* Remove `^:private` metadata on a couple of Settings since it makes Eastwood fussy

* Revert "Revert new precondition"

This reverts commit 1f97a4d6ccfdaa92ff82fd0256f08f3512c3c5e7.

* Revert "plug in and alter tests to use with-actions-test-data"

This reverts commit 2f33cb47b700b1da106adf54d41928c5956978d0.

* Revert "Add Database-local Setting for enabling Actions for a specific Database"

This reverts commit a52f8d0a478a31bb1f1b4a6693abf8f8e658d9cf.

* Revert "Make sure api.actions is loaded"

This reverts commit 7d7b913a7a0d64cbe2b6907f389d994a1130c0f5.

* Revert "Add `experimental-enable-actions` feature flag (#22559)"

This reverts commit 9b313752.

* Revert "SQL JDBC Delete Row Action (#22608)"

This reverts commit d6864f38.

* Remove actions api docs

* Revert "Destructible version of `test-data` dataset for testing writeback actions (#22692)"

This reverts commit 15c57d9a.

* keep around a few misc improvements

* removes precondition

- {:pre [(nil? (namespace symb))]}

* various fixes that needn't be reverted

* Update persist model api permissions for EE

On OSS, only Admins can enable model cache in `Settings/Cache`,
enable database model cache in `Settings/Databases` and cache individual models.

On EE/Pro, users with `Settings access` application permissions can enable model
cache in `Settings/Cache` and users with `Manage database` can enable model
cache for a database.

* Add tests for application permissions

* Add `experimental-enable-actions` feature flag

* Simplify Ring middleware

* Sort namespaces

* Make sure api.actions is loaded

Background:

We had two lint configs: lint-config.edn which was enfored by Github Actions, and
.clj-kondo/config.edn, the default location used by editors.


Problem:

Patchy enforcement of the (larger) config in .clj-kondo/config.edn since not
everyone uses an editor.

Some new lint, like canonical namespace aliases (#21738, #19930) is not enforced
automatically and has begun to bit-rot.

Solution:

Combine both configs, fix any outstanding lint, and update our tooling to use
the unified config.

Caveats:

Anyone who has their local editor configured to use lint-config.edn will have
their linting broken by this change.

* scaffolding, docstring & arg parsing

* tweaks

* registry and basic oss->ee dispatch

* stubbed defenterprise-ee

* full defenterprise-ee impl

* fix build and tweak docstring

* remove debug code

* basic tests

* use defonce

* support for :any feature

* schema support

* fix schema test

* switch to using format

* support for schema on return val

* tweak macro

* move schema validation to submacros

* do ee fn resolution at runtime

* do conditionals at macro-expansion time

* adjust semantics & refactor

* fix test

* add memoization for ee resolution

* fix tests

* emit register-mapping! call to avoid eval

* call starts-with on symbol

* remove schema support

* use spec for arg parsing, generate fns, and remove :error fallback option

* clean ns

* change schema alias to schema

* add :arglists meta and small refactor

* refactor

* move EE logic to fn

* validate that the correct args are passed in EE/OSS namespaces, and make :feature required

* remove logic for handling nil :feature

* fix lint errors

* fix ee macros

* defenterprise-schema macro & tests

* clean ns

* propogate metadata

* don't memoize ee resolution in dev to make debugging easier

* dont do ee fn resolution during macroexpansion

* migrate LDAP functions to defenterprise

* lint

* require ee ns separately so that EE settings are available

* revert change to function mocked in tests

* add back code lost in merge

* clean ns

* clean ns again

* minor refactor and cleanup

* major refactor

* fix defenterprise-schema syntax

* fix import

* major refactor

* update docstrings

* more docstring tweaks

* try to fix lint error on ldap PR

* add lint-as mappings for defenterprise and defenterprise-schema to clj-kondo config

* clj-kondo/ignore use of spec alias

* use destructuring in arg lists since it's now supported

* add docstring to def emitted by macro, and some formatting tweaks

```
❯ clj-kondo --lint src:shared/src
src/metabase/api/common/validation.clj:2:33: warning: Inconsistent alias. Expected str instead of string.
src/metabase/api/database.clj:664:5: warning: Redundant let expression.
src/metabase/api/table.clj:18:45: warning: Inconsistent alias. Expected field-values instead of sync.field-values.
src/metabase/cmd.clj:123:5: warning: unused binding docs
src/metabase/db/data_migrations.clj:15:52: warning: Inconsistent alias. Expected perms-group instead of group.
src/metabase/db/data_migrations.clj:55:15: warning: #'metabase.db.data-migrations/data-migrations is deprecated
src/metabase/db/data_migrations.clj:62:24: warning: #'metabase.db.data-migrations/data-migrations is deprecated
src/metabase/db/data_migrations.clj:63:7: warning: #'metabase.db.data-migrations/run-migration-if-needed! is deprecated
src/metabase/db/data_migrations.clj:154:1: warning: #'metabase.db.data-migrations/defmigration is deprecated
src/metabase/db/data_migrations.clj:201:1: warning: #'metabase.db.data-migrations/defmigration is deprecated
src/metabase/db/setup.clj:59:5: warning: Missing catch or finally in try
src/metabase/driver/postgres.clj:18:63: warning: Inconsistent alias. Expected sql-jdbc.describe-table instead of sql-jdbc.sync.describe-table.
src/metabase/driver/postgres.clj:304:9: warning: unused binding nfc-path
src/metabase/driver/postgres.clj:323:60: warning: unused binding fields-fields
src/metabase/driver/sql_jdbc/sync/describe_table.clj:253:39: error: Expected: set or nil, received: seq.
src/metabase/driver/sql_jdbc/sync/describe_table.clj:254:39: error: Expected: set or nil, received: seq.
src/metabase/driver/sql_jdbc/sync/describe_table.clj:333:11: warning: unused binding map-inner
src/metabase/models/secret.clj:248:23: warning: use :else as the catch-all test expression in cond
src/metabase/pulse/render/body.clj:216:64: warning: unused binding cols
src/metabase/task/refresh_slack_channel_user_cache.clj:52:25: error: clojurewerkz.quartzite.schedule.simple/with-interval-in-seconds is called with 1 arg but expects 2
linting took 5988ms, errors: 3, warnings: 17
```

```
❯ clj-kondo --lint src:shared/src
src/metabase/task/refresh_slack_channel_user_cache.clj:52:25: error: clojurewerkz.quartzite.schedule.simple/with-interval-in-seconds is called with 1 arg but expects 2
linting took 5270ms, errors: 1, warnings: 0
```

Want to call out a few things:

The following all related to the new paths into json feature. Wanted
howon to verify that nothing got dropped with these unused bindings.

```
src/metabase/driver/postgres.clj:304:9: warning: unused binding nfc-path
src/metabase/driver/postgres.clj:323:60: warning: unused binding fields-fields
src/metabase/driver/sql_jdbc/sync/describe_table.clj:253:39: error: Expected: set or nil, received: seq.
src/metabase/driver/sql_jdbc/sync/describe_table.clj:254:39: error: Expected: set or nil, received: seq.
src/metabase/driver/sql_jdbc/sync/describe_table.clj:333:11: warning: unused binding map-inner
```

* Make namespace aliasing consistent everywhere; enforce with clj-kondo

See the table of aliases in .clj-kondo/config.edn

Notable patterns:
- `[metabase.api.foo :as api.foo]`
- `[metabase.models.foo :as foo]`
- `[metabase.query-processor.foo :as qp.foo]`
- `[metabase.server.middleware.foo :as mw.foo]`
- `[metabase.util.foo :as u.foo]`
- `[clj-http.client :as http]` and `[metabase.http-client :as client]`

Fixes #19930.

* Make partial= test helper take exactly two arguments

Fixes #21454.

`(= 2) ;=> true` and `partial=` followed that pattern. It leads to
confusing test assertions that silently succeed.

It's possible to extend this to support >= 2 arguments instead, but I'm
keeping it simple for now.

Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com>

* Remove references to qp/query->preprocessed

* Fix Oracle

* Refer all

* allow refer all in tests

* Add toucan test macro config

* wip

* Improve hooks

* Fix formatting issue

* Improve

* presto

* oracle

* mongo

* druid

* zero errors

* undo whitespace change

* ns linter satisfaction

* honeysql var improvements

* Define routes

* Define routes

* define-routes improvement

* honeysql helpers

* honesql

* abs in clojure 1.11

* fix logic unresolved vars

* deprecated

* deprecated var warnings

* undo replace

* Turn defendpoint config macro into analyze-call hook for better linting

* Simplify hook

* Remove previous macro config

* Fix all errors concerning third party libs

* revert whitespace change:

* Linting improvements: 0 errors in src + shared/src

* satisfy other linter