This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Aug 14, 2023
-
-
Emmad Usmani authored
* fix `ChartSettingInputNumeric` decimals on safari * add unit test
-
Jeff Bruemmer authored
-
Jeff Bruemmer authored
-
Anton Kulyk authored
* Extend `ace-builds.d.ts` * Partially migrate to TypeScript Define component props and state types, add straightforward types * Add editor ref null checks * Add null checks for optional fn props * Fix missing types (simple) * Add straightforward ace editor null checks * Cast editor type on load * Fix `cardTagIdAtCursor` method * Fix `handleCursorChange` method * Fix missing arguments for ace's `setScrollMargin` * Use `Question` methods over properties * Use ace's completer types * Add editor null checks * Fix `setTableId` method * Fix `_updateSize` method * Fix `getCardTagCompletions` method * Fix `getSnippetCompletions` method * Fix autocompletion types * Fix scroll margin * Fix `fetchQuestion` type * Fix resizable box * Remove redundant editor null check * Fix incorrect type * Break down `OwnProps` * Fix `_lastAutoComplete` type * Minor fix * Minor fix * Avoid ace editor type casting * Add radix to `parseInt`
-
Noah Moss authored
* don't throw when host is nil * fix test ns name * Update enterprise/backend/test/metabase_enterprise/sso/integrations/sso_utils_test.clj Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com> --------- Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com>
-
Alexander Polyankin authored
-
Uladzimir Havenchyk authored
-
Anton Kulyk authored
* Extract `aceEditorStyle` * Extract drag handle * Port more `NativeQueryEditorRoot` class names * Port editor root and resizable box * Remove redundant class names * Remove `.NativeQueryEditor` class * Use CSS variable colors in `NativeQueryEditor.css` * Add a comment on `NativeQueryEditor.css`
-
Ryan Laurie authored
-
Kamil Mielnik authored
* Use named import for ErrorView * Export ErrorView and ErrorViewProps from Visualization * Define AddSeriesModalErrorView * Make ErrorView component configurable in Visualization by introducing errorView prop * Use AddSeriesModalErrorView thanks to new errorView prop * Fix export type syntax * Remove the dot for consistency with other error messages * Rename AddSeriesModalErrorView to ErrorView and extract it to a separate file * Allow translating the custom error message * Don't show custom ErrorView when there is only one series (or none) * Add a test case for a single incomplete chart * Inline: dashcardData * Add a reproduction e2e test for #32231 * Add explicit assertion for the error message * Add a test case for default error message when there is only 1 series * Remove redundant setup functions * Wait for series query endpoint * Rename ErrorView to VisualizationErrorView * Rename VisualizationErrorView to MultipleSeriesErrorView * Improve assertions * Use editDashboard helper * Use data-testid for AddSeriesModal * Refactor errorView prop into errorMessageOverride - Do not export ErrorViewProps and Error out of Visualization
-
Nemanja Glumac authored
-
Tim Macdonald authored
* Search by table description [Fixes #25792]
-
Kamil Mielnik authored
* Use MetabaseApi where possible in entities/tables.js * Mock syncing state * Disable table link if sync is not complete * Disable model link if sync is not complete * Gray out the disabled link by inheriting body color * Revert "Disable model link if sync is not complete" This reverts commit 5423834bc6638638f0e3c2d2b51d044e099bea62. * Revert "Mock syncing state" This reverts commit 4546f7655e95310a59bb21f3022a8ebad8479e23. * Export DatabaseTablesPaneProps * Use SearchResult type instead of any * Add a unit test boilerplate * Implement test cases for various initial_sync_status for tables * Update names * Add explanatory comments and functions
-
Kamil Mielnik authored
* Fix initial values not reloading in the action modal * Add a repro test for #33084 * Use cy.button helper
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Case Nelson authored
Part of #33140
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix dashboard actions linked with filters don't work * Add E2E test * Make assertion clearer
-
Maz Ameli authored
* add latvian and update translations for 47 * translate untagged strings found in review * okay but really this time is it I swear
-
- Aug 13, 2023
-
-
shaun authored
Creating a collection when saving a question/dashboard should return to the question/dashboard save modal with the new collection selected (#32778)
-
- Aug 12, 2023
-
-
shaun authored
-
- Aug 11, 2023
-
-
Jeff Bruemmer authored
-
Alexander Polyankin authored
-
Jeff Bruemmer authored
-
Nemanja Glumac authored
From the Cypress docs https://docs.cypress.io/guides/references/configuration#Global The number of tests for which snapshots and command data are kept in memory. Reduce this number if you are experiencing high memory consumption in your browser during a test run. The default value is 50. We're dialing it down to 1.
-
Nemanja Glumac authored
Fixes #33080
-
Oisin Coveney authored
-
- Aug 10, 2023
-
-
Cam Saul authored
* Test metadata helper function consolidation * More code consolidation
-
shaun authored
-
Luis Paolini authored
-
Noah Moss authored
* fix currency metadata * fix test * change renminbi back to yuan because that's what Intl.NumberFormat uses
-
Ryan Laurie authored
* reproduce #32985 * don't crash fieldValuesWidget when we get null options
-
Ryan Laurie authored
* expose field_id mlv2 function * Update frontend/src/metabase-lib/fields.ts Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com> --------- Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
Ryan Laurie authored
* convert DefaultPicker to typescript * unit test DefaultPicker * update types * use rowvalue
-
lbrdnk authored
* Unify semicolon and comment handling in nested native queries * Use different comment and semicolon removal approach * Apply suggestions from code review Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Update base and effective type verification for oracle * Avoid running test with snowflake and bigquery * Update `breakout-results` and test 1. In `breakout-results` case driver statement was redundant. Original code had field name and types hardcoded. During further examination, I've realized name and types are available thanks to the use of `qp.test/col`, so are just "unhardcoded" :) 2. `card-id-native-source-queries-test` is altered, so instead of hardcoding native sub-queries, roughly equivalent* mbql query is compiled and its native form is used. This way I can hopefully avoid problems with extraction of cloud databases' table names for testing purposes. * By roughly equivalent I mean instead of using * for selecting fields, mbql is compiled selecting fields explicitly. Also limit is added in some cases, but local testing showed no problems with that. --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
lbrdnk authored
Modify `:contains`, `:starts-with` and `:ends-with` so field or expression can be used as the second argument (#32446) * Update `LIKE` to handle fields and expressions Previously only string could be used with like clause, ie. as second argument of `:starts-with`, `:ends-with` or `:contains`. This commit modifies translation of those functions, so fields or expressions can be used in place of second argument. * Make only expression or field args use `concat` Using concat with values unnecessarily complects generated sql. * Update tests * Extend mongo string matching capabilities Make mongo filter compilation use `$regexMatch` for `:contains`, `:starts-with` and `:ends-with` so expressions and fields can be matched against. * Adjust mongo specific tests * Update druid Druid's filters work with `:contains`, `:starts-with` and `:ends-with`, but only if second argument is literal pattern. This commit updates existing code, so expection is thrown if `pattern` has different form than `[:value ...]`. * Address review comments - sql * Address review comments - mongo * Use mbql `:concat` instead of `hx/call :concat` Vertica, orcacle and sqlite handle concat differently than other drivers. To overcome this limitation, `pre`, `post` and `arg` are wrapped into mbql's concat expression which is then translated with regards to the specifics of particular driver. * Update according to the review feedback --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
lbrdnk authored
Change is compatible with prior implementation. Match clause like the following, `{$match: {"something": "Facebook"}}`, does exact match if `something` is a scalar, and in case `something` was an array, match would check whether it contains the `Facebook` value. Same behavior, as with `{$match: {"something": {$in: ["Facebook"]}}}`. Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
Anton Kulyk authored
* Group native editor files in a single directory * Fix mocking * Clean up imports
-
Kamil Mielnik authored
* Add reproduction test for #28756 * Reuse DASHBOARD_SLOW_TIMEOUT
-
- Aug 09, 2023
-
-
metamben authored
* Support segments Fixes #32409.
-