Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 22, 2024
  2. Aug 21, 2024
    • Ryan Laurie's avatar
      Create Question and Dashboard Sharing Menu (#46593) · 3964d71e
      Ryan Laurie authored
      * QuestionAlertWidget to FC + TS
      
      * update e2e tests
      
      * use regular alert for unsubscribes
      
      * Create Question and Dashboard Sharing Menu
      
      * Handle some edge cases
      
      * top notch unit tests
      
      * more testing and tweaking
      
      * fix imports
      
      * more tests
      
      * add alerts to question sharing menu
      
      * add tests for alerts
      
      * update e2e tests
      
      * use Oisin's toolbarbutton
      
      * fix rebase
      
      * prompt to save before sharing questions
      
      * show prompt to set up notification channels
      
      * fix import
      
      * update tests and hide on notebook screen
      
      * fixes
      
      * clean up pulse types
      
      * update e2e tests
      
      * fix a bunch more tests
      
      * more e2e test fixes
      
      * maybe green now? :fingers_crossed:
      
      * last one :pleading_face:
      
      * design updates
      
      * make channel setup modal nicer
      
      * simpler component props
      
      * lint fix
      
      * lint fixes
      Unverified
      3964d71e
    • Oisin Coveney's avatar
      feat(sdk): Edit Question (#46894) · 0a6d0a19
      Oisin Coveney authored
      Unverified
      0a6d0a19
    • Phoomparin Mano's avatar
      feat(sdk): embedding cli opens the metabase store to get trial token and... · 4453abb1
      Phoomparin Mano authored
      feat(sdk): embedding cli opens the metabase store to get trial token and applies the license (#46810)
      
      * open metabase store to get trial token
      
      * remove license env from instance setup as we provide the license key later
      
      * activate metabase license
      
      * fix password field missing
      
      * fix formatting for generated component files message
      
      * activate license key
      
      * add missing auth options for postgres
      
      * add function to print with padding
      
      * prevent infinite loop and update section representation
      
      * show the activate license error in red
      
      * rename variable
      Unverified
      4453abb1
  3. Aug 20, 2024
  4. Aug 19, 2024
    • bryan's avatar
      Add no-access table-level and schema-level permission (#46542) · 2bbcf745
      bryan authored
      
      * allow `:blocked` to be saved for table level perms
      
      * Adds 2 tests for table level blocked permission settings
      
      - N.B. these are NOT ENFORCED YET
      
      * update test that asserted we cannot set block on tables (we can)
      
      * WIP: Pairing on making perms checking less wild
      
      * cleanup, update docs, and add a test for view-data perm only
      
      - Added a test where we have data permissions, but not create query, and
        I think it is failing when we have create query and blocked data
        permissions.
      - renamed some functions from check-x -> has-x? since they return a
        value instead of throwing now
      
      * Revert "WIP: Pairing on making perms checking less wild"
      
      Keep the same behavior, but stick with the saner flow control
      
      This reverts commit 63bcb5b4.
      
      * update docs
      
      * update test to be passing
      
      - TODO: make sure it's correct w.r.t. perm settings
      
      * Allow schema level blocked setting in permgraph
      
      * remove invalid test cases
      
      - continue to have a forcing function to test newly added perms
      
      * conform function output
      
      * ensure a single blocked table blocks native queries to its DB
      
      * update error message
      
      - we now catch this error in `metabase.models.query.permissions/has-perm-for-query?`
      
      * we now check for data permissions to process query for card
      
      * add more explanation to what we are testing
      
      - to help see why it fails on CI and passes locally
      
      * remove excess `def`
      
      * Add test for table-level data X collection perms
      
      - update test found to be in-error
      
      * update param values qp permission check style
      
      * set view-data and create-query explicitly
      
      * set viewdata and createquery explicitly in qp test
      
      * Respond to review comments (which fixes a case)
      
      * setting a table to blocked: leave other tables the same
      
      * [Permissions] Add "No access" schema/table permission (#46509)
      
      * first pass
      
      * refactors downgrading native permission logic and updates calculation so that "No access" downgrades native permissions to "No"
      
      * stub for permissions help info on table block
      
      * modal changes wip, updates downgrading create queries permissions to all happen at a single call site
      
      * clean up, sandboxing modal copy changes, removes rekoke/limit access modal changes to make the diff smaller and move code to a seperate PR
      
      * updates permissions help section to contain the final copy
      
      * sandboxing copy fix and remove modal that was dropped from requirements
      
      * adds blocked at the schema level, updates no access copy to blocked, updates permissions help section to contain new blocked and schema level changes
      
      * fixes failed unit and e2e tests after sandboxing copy changes
      
      * improve the block e2e test to include table blocking
      
      * fixes failing blocked test, fixes other schemas create queries permissions getting correct with one schema was droped to blocked view data access, fixes a bug that prevents the save bar from going away when all permissions for group are set to the default values
      
      * clean up
      
      * remove color changes
      
      * prevents parent being set to blocked preventing edits for children entities
      
      * add new hasPermissionValueInSubgraph fn, adds modal to warn users we have to upgrade the view data permissions when they upgrade create queries permissions when a child entity is set to blocked
      
      * adds test coverage for new modal
      
      * removes unused function, adds new updateEntityPermission fn to help consolidate some logic elsewhere
      
      * unit test fix and type fix
      
      * most pr feedback
      
      * updates the confirmation modal copy when changing a parent entity that contains a child with blocked permissions and/or sandboxed children, adds test coverage for that, adds test coverage for permission view data column not appearing in oss
      
      * type fix
      
      * [Permissions] Add e2e test coverage for blocked permissions enforcements (#46663)
      
      * adds test coverage for enforcement of blocked permissions
      
      * moves tests around based on pr feedback
      
      * copy changes
      
      * adds fix to make sure that blocked permissions are not removed from sibling tables that have the create queries permissions upgraded (#46854)
      
      * Fix table name lookup for dbs w/ 1 schema per db
      
      * add test for blank schema identifiers
      
      * Refine sandboxed user perms for query builder access (#46939)
      
      * Refine sandboxed user perms for query builder access
      
      - Limit create-queries permissions to unblocked tables only
      - Check user permissions for each table before granting query builder access
      - Prevent querying of blocked joined tables from query builder for sandboxed users
      
      * Adjust permissions for sandboxed users
      
      - Grant view-data permissions only for unblocked tables
      - Revert create-queries permissions to all tables in sandbox
      - Remove unnecessary intermediate variable
      
      * when sandboxing we no longer grant unrestricted view perms for blocked tables
      
      * Update enterprise/backend/src/metabase_enterprise/sandbox/query_processor/middleware/row_level_restrictions.clj
      
      remove blank line
      
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      
      * - make coalesce-test exhaustive (except for sandbox)
      
      * Update enterprise/backend/src/metabase_enterprise/sandbox/query_processor/middleware/row_level_restrictions.clj
      
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      
      * t2/select ... -> database/table-id->database-id
      
      * update comment
      
      * [Permissions] Prevent "Granular" option in DB View Data options from changing permissions to unrestricted (#46976)
      
      * fix
      
      * adds back most of the code and limits it to only happen with impersonations, updates test to handle differing logic between the two flows
      
      * removes test that is not longer needed
      
      * more sandbox join table perms tests
      
      ---------
      
      Co-authored-by: default avatarJohn Swanson <john.swanson@metabase.com>
      Co-authored-by: default avatarSloan Sparger <sloansparger@users.noreply.github.com>
      Co-authored-by: default avatarSloan Sparger <sloansparger@gmail.com>
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      Unverified
      2bbcf745
    • Nemanja Glumac's avatar
      tech: Remove the last GoogleAnalytics tracking bits and references (#46980) · 2899046d
      Nemanja Glumac authored
      * Remove simple references to `trackStructEvent`
      
      * Remove `withAnalytics` entities helper
      
      * Remove `trackLoginSSO`
      
      * Remove auth trackers
      
      * Remove permissions trackers
      
      * Remove performance trackers
      
      * Remove settings trackers
      
      * Remove pulse trackers
      
      * Remove undo trackers
      
      * Remove click actions trackers
      
      * Remove `trackStructEvent`
      
      * Remove GoogleAnalytics from the server security middleware
      
      * Remove GoogleAnalytics from Kondo config
      
      * Fix type failures
      
      * Revert "Remove GoogleAnalytics from Kondo config"
      
      This reverts commit 363557c4.
      Unverified
      2899046d
    • Ryan Laurie's avatar
      Remove unnecessary calls to `/api/collection` (#46752) · c78b46d6
      Ryan Laurie authored
      * use ee api to find custom reports collection
      
      * remove deprecated hook
      
      * fix race condition
      
      * add unit tests
      
      * fix circular dependency
      
      * fix unit tests
      
      * another plugin strategy
      Unverified
      c78b46d6
  5. Aug 16, 2024
  6. Aug 15, 2024
  7. Aug 14, 2024
    • Nicolò Pretto's avatar
    • Phoomparin Mano's avatar
      fix(sdk): optimistic update query builder and update questions in notebook (#46652) · 3df927c9
      Phoomparin Mano authored
      
      * update question state
      
      * update question state
      
      * reload metadata for runQuestionOnNavigate
      
      * fix runnable queries
      
      * fix cannot run question
      
      * extract question predicate functions to question.ts
      
      * update types
      
      * create utils subfolder for query builder
      
      * fix query builder predicate imports
      
      * naming tweaks to be more self-explanatory
      
      * document the non-intuitive loadQuestion useEffect
      
      * change imports to support metric
      
      * remove unused import
      
      * revert originalQuestion check to try to fix e2e failures
      
      ---------
      
      Co-authored-by: default avatarOisin Coveney <oisin@metabase.com>
      Unverified
      3df927c9
    • Romeo Van Snick's avatar
      Automatically select offset breakout or move it to the front (#46573) · 9fa749d6
      Romeo Van Snick authored
      * Add defaultTemporalBucket helper
      
      * Add helper to pick default breakout
      
      * Move breakout to the front or add one if it does not exist
      
      * Add updateQuery to AggregationPicker props
      
      * Add tests for creation and reordering of temporal breakouts
      
      * Reuse defaultTemporalBucket in withDefaultTemporalBucket
      
      * Reorder query operations to make sure the correct names get generated
      
      * Remove dependency on referential equality of breakout
      
      * Rename updateQuery to onQueryChange
      
      * Remove onAddAggregations and onUpdateAggregation for onQueryChange
      
      * Extract query update in to separate function
      
      * Remove on{Add,Update,Remove}Aggregation in favor of onQueryChange
      
      * Remove aggregations from summarize details
      
      * Fix e2e tests
      
      * Remove conflicting test
      
      * Fix recent clause in unit tests
      
      * Fix superflouous check for columnAndBucket
      
      * Future proof breakout check
      
      * Remove reliance on details in the useSummarize hook
      
      * Remove details in unit tests
      
      * Removal of default summarization should not trigger a query change
      Unverified
      9fa749d6
  8. Aug 13, 2024
  9. Aug 12, 2024
  10. Aug 09, 2024
  11. Aug 08, 2024
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Follow-up milestone 2 for [Epic] Re-design transparent theme for static... · a4df4eb7
      Mahatthana (Kelvin) Nomsawadi authored
      Follow-up milestone 2 for [Epic] Re-design transparent theme for static embedding and public links (#46491)
      
      * Update new Metabase base colors
      
      * Make hover and selected state consistency
      
      * Fix wrong embed frame border color
      
      * Refactor: extract props
      
      * Fix border color
      
      * Fix pivot table cell hover color
      
      * Fix smart scalar text contrast
      
      * Add smart scalar tests + update text color design
      
      * Theme dashboard card menu
      
      * Remove dashcard action menu tests since they don't work in loki
      
      * Fix storybook background color for dark theme
      
      * Update loki snapshots
      
      * Disable untestable tests
      
      * Make sure all storybook inherit all necessary base styles
      
      * Skip untestable tests
      
      * Update loki snapshots
      Unverified
      a4df4eb7
    • github-automation-metabase's avatar
    • Phoomparin Mano's avatar
      feat(sdk): connect databases, generate models and x-rays from the CLI (#46502) · 178997d7
      Phoomparin Mano authored
      
      * add setup commands
      
      * fix settings definition
      
      * update environment variables for cli
      
      * handle instances not being ready
      
      * update error messages
      
      * add more specific loading messages
      
      * loading spinner state
      
      * improve error message
      
      * use a fixed demo setup token
      
      * remove extraneous spinner
      
      * update status checks
      
      * update container messages
      
      * update wait timing
      
      * create api keys
      
      * extract constants
      
      * remove manual steps
      
      * Add anonymous tracking + other things. will need to clean up
      
      * Modify SDK for better structure
      
      * remove line from print.ts
      
      * Update webpack.embedding-sdk-cli.config.js back to production
      
      * Add types and add quick note
      
      * Fix a typo
      
      * Add index file, simplify types, use an array
      
      * Add safer json parsing
      
      * use delay of 100ms between each setup call
      
      * Suggestions from review
      
      * ensure that cli works
      
      * Attempt to fix jest errors
      
      * Remove node-fetch from sdk code to hopefully get unit tests working again
      
      * add database connection
      
      * add connection details handling
      
      * refactor asking for database connection info
      
      * apply actual database id for syncing schema
      
      * fix failing database sync step
      
      * allow table selection
      
      * create model for each table
      
      * handle errors in model creation
      
      * fix incorrect model display name
      
      * create x-rays based on user data
      
      * consolidate instance setup message
      
      * workaround for inquirer eventemitter issue
      
      * fix yarn.lock file
      
      ---------
      
      Co-authored-by: default avatarOisin Coveney <oisin@metabase.com>
      Unverified
      178997d7
  12. Aug 07, 2024
    • github-automation-metabase's avatar
    • Phoomparin Mano's avatar
      feat(sdk): CLI to bootstrap an embedding-ready Metabase instance (#46080) · 4ce37a25
      Phoomparin Mano authored
      
      * add setup commands
      
      * fix settings definition
      
      * update environment variables for cli
      
      * handle instances not being ready
      
      * update error messages
      
      * add more specific loading messages
      
      * loading spinner state
      
      * improve error message
      
      * use a fixed demo setup token
      
      * remove extraneous spinner
      
      * update status checks
      
      * update container messages
      
      * update wait timing
      
      * create api keys
      
      * extract constants
      
      * remove manual steps
      
      * Add anonymous tracking + other things. will need to clean up
      
      * Modify SDK for better structure
      
      * remove line from print.ts
      
      * Update webpack.embedding-sdk-cli.config.js back to production
      
      * Add types and add quick note
      
      * Fix a typo
      
      * Add index file, simplify types, use an array
      
      * Add safer json parsing
      
      * use delay of 100ms between each setup call
      
      * Suggestions from review
      
      * ensure that cli works
      
      * Attempt to fix jest errors
      
      * Remove node-fetch from sdk code to hopefully get unit tests working again
      
      * fix yarn.lock file
      
      * revert capture groups change
      
      ---------
      
      Co-authored-by: default avatarOisin Coveney <oisin@metabase.com>
      Unverified
      4ce37a25
  13. Aug 06, 2024
  14. Aug 05, 2024
    • Mahatthana (Kelvin) Nomsawadi's avatar
      [Milestone 2] Re-design transparent theme for static embedding and public links (#46428) · 3d5233bc
      Mahatthana (Kelvin) Nomsawadi authored
      
      * Update popover dark theme on part of ParameterFieldWidget (#45813)
      
      * Add filter visual tests
      
      * Simplify embed CSS colors
      
      * [WIP] theme filter popover
      
      * Move theme to global node, so it affects portal too
      
      * Fix embed colors
      
      * Theme part of ParameterFieldWidget
      
      * Add story for parameter with dropdown
      
      * Update loki snapshots
      
      * Update more popover style
      
      * Update loki snapshots
      
      * Remove outdated snapshots
      
      * Update loki snapshots with production build
      
      * Fix loki not working with `userEvent`
      
      * Theme mantine popover
      
      * Improve dark theme text-brand visibility
      
      * Update loki snapshots from master change
      
      * Fix new colors not working in SDK
      
      * Fix flaky Loki tests
      
      * Filter popover dark theme part 2 (#46284)
      
      * Theme Date all options
      
      * wip add month and year filter
      
      * Fix wrong CSS custom property declaration
      
      * Test hover state
      
      * Update Loki snapshots
      
      * Theme date month and year
      
      * Add quarter and year tests
      
      * Theme date single and date range
      
      * Style relative date
      
      * Update frontend/src/metabase/admin/datamodel/components/filters/pickers/DatePicker/DatePickerHeader.styled.tsx
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      ---------
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * Complete theming filter popover night mode (#46365)
      
      * Style unit of time and number widget
      
      * Attempt to fix flaky Loki snapshots
      
      * Address white background checkbox on dark theme
      
      * Style search filter single value
      
      * Fix mis color
      
      * Update snapshots
      
      * Remove duplication on play functions since they're long
      
      * Milestone 2 polishing (#46382)
      
      * Matches the footer padding with header padding
      
      * Update snapshots
      
      * Add E2E to prevent further problem
      
      * Try to reduce flaky Loki tests
      
      * Remove unused color shades (#46421)
      
      * Update no results illustration to work better on dark theme
      
      * Update loki snapshots
      
      ---------
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      Unverified
      3d5233bc
  15. Aug 02, 2024
    • Ryan Laurie's avatar
      test(sdk) Update the Query Editor Button (#46097) · c924c38e
      Ryan Laurie authored
      * YOLO
      
      * fix a lot of tests
      
      * fix more tests
      
      * fix unit tests
      
      * remove comment
      
      * update tests and formatting
      
      * add debug code
      
      * remove debug code
      Unverified
      c924c38e
    • Sloan Sparger's avatar
    • Sloan Sparger's avatar
      [Auto Clean-up] Clean-up modal (#44512) · 1d277035
      Sloan Sparger authored
      
      * wip
      
      * moves code to enterprise folder, adds enterprise guards, updates conditionals as to when to show the feature
      
      * impls filter date logic, improves styling, mocks out real endpoint with collection items endpoint, updates table with isLink boolean rath
      er than using custom item renderer, removes dead code
      
      * use the actual url for stale
      
      * so many things... updated design, custom table component, polish, misc. refactors, more correct api typing
      
      * updates to pagination component and reverts some now unused changes to the base items table
      
      * impls pr feedback
      
      * fixes
      
      * fixes failing unit test
      
      * completes pr feedback from raffi
      
      * implements second round of feedback from raffi
      
      * adds tests and couple of small fixes / feedback
      
      * migrate clean up action to enterprise plugin and fix related e2e test, also skip the collection items count query when we do not need the value
      
      * finish main base case e2e test
      
      * clean up helper code for manual testing and add OSS test to make sure feature is not available in OSS
      
      * better handling of min-height on smaller screens
      
      * adds internal undo notification for bulk archiving in the clean up modal
      
      * reset pagination when items are archived/unarchived to keep users from getting stuck on a page beyond the current view
      
      * pr feedback
      
      * further cleanup
      
      * unit test fix
      
      * fixes issue where archiving all items in the modal and then undoing does not result in the stale items list getting refetched
      
      ---------
      
      Co-authored-by: default avatarJohn Swanson <john.swanson@metabase.com>
      Unverified
      1d277035
Loading