Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Sep 25, 2024
  2. Sep 24, 2024
    • Alexander Polyankin's avatar
    • Romeo Van Snick's avatar
      Verified metrics (#47886) · 7ffdd997
      Romeo Van Snick authored
      * Support skipToken in useFetchMetrics
      
      * WIP
      
      * Add user setting for verified metrics
      
      * Add verified metrics to the VERIFIED_CONTENT plugin
      
      * Use metric plugins for verified metrics
      
      * Move helpers down
      
      * Do not filter for verified metrics if there are none, regardless of user setting
      
      * Add label to filter button
      
      * Revalidate search when card gets (un-)verified
      
      * Add e2e test for verified metrics
      
      * Avoid checking for verified metrics on when content-verification is not enabled
      
      * Fix broken test
      
      * Simplify content verification plugin structure for metrics
      
      * Add content moderation types and API helpers
      
      * Update content moderation plugin to make use of the moderation api in metabase/api
      
      * Fix lint
      
      * Fix missing list tag
      
      * Store verified metric filter preference
      
      * Move all helpers to the bottom
      
      * Ensure the user setting gets updated when chaning the filter
      
      * Add comment about component similarity
      
      * Undo changes to embedding-sdk
      Unverified
      7ffdd997
    • Romeo Van Snick's avatar
      Reset filters in dashboard click action (#48075) · 9d36cc14
      Romeo Van Snick authored
      * Use default values for parameters in dashboard filters when used from click action
      
      * Add test for setting non-specified parameters to default in dashboard accessed via click action
      Unverified
      9d36cc14
    • Ryan Laurie's avatar
      Dashboard Settings Sidebar + Enhance Dashboard Info Sidebar (#47905) · 35d4611c
      Ryan Laurie authored
      * create dashboard settings sidebar
      
      * update e2e tests
      
      fix
      
      * only show settings to dashboard editors
      
      * update copy
      
      * update e2e test
      
      * fix types
      
      * update tests for new copy
      
      * fix import
      Unverified
      35d4611c
  3. Sep 23, 2024
  4. Sep 20, 2024
    • Sloan Sparger's avatar
      [E2E] Improve + Fix tests that use sandboxing (#46465) · e66aad34
      Sloan Sparger authored
      * fixes some tests where data permissions were overwriting sandboxing permissions, makes assertions in tests where sandboxing user is used but the test also passes if you were to sign in as the normal user, fixes one test that sandboxes the wrong table for the test
      
      * do not push - wip changes
      
      * add assertions to that network requests are provided sandboxed data, fix faulty test in dashboard-filters-source.cy.spec.js
      
      * use helpers to clean up parts of pagination assertions
      
      * rename assertDatasetIsSandboxed to assertDatasetReqIsSandboxed
      
      * adds assertions on api response data
      
      * clean up
      
      * fix typo
      
      * refactor helper to be easier to follow
      
      * golfing
      
      * pr feedback
      
      * fix
      
      * fix
      Unverified
      e66aad34
  5. Sep 17, 2024
  6. Sep 13, 2024
  7. Sep 12, 2024
  8. Sep 11, 2024
  9. Sep 10, 2024
  10. Sep 09, 2024
    • Aleksandr Lesnenko's avatar
      show additional columns in the tooltip (#47700) · 82b13c25
      Aleksandr Lesnenko authored
      * show additional columns in the tooltip
      
      * specs, tweaks
      
      * drop stack dependency
      
      * handle invalid columns
      
      * change copy
      Unverified
      82b13c25
    • Ryan Laurie's avatar
      Question Info + Settings Sidesheets (#47157) · b797ea4f
      Ryan Laurie authored
      * Question Settings Sidesheet (#47699)
      Unverified
      b797ea4f
    • Anton Kulyk's avatar
      Toggle series visibility from chart legend (pie charts) (#47581) · 41b4b687
      Anton Kulyk authored
      * Add series visibility props to `ChartWithLegend`
      
      * Mark pie slices as visible or hidden
      
      * Don't let to hide the last visible slice
      
      * Add space between legend dot and title
      
      * Fix legend dot outer circle is clipped by overflow
      
      * Use `ChartSettingSeriesOrder` for `pie.rows` setting
      
      * Actually hide slices and exclude from total calc
      
      * Don't show "0%" next to hidden slice legend items
      
      * Hide the "Other" slice
      
      * Make overflow slices popover interactive
      
      * Fix hover
      
      * Fix incorrect visibility state in legend popover
      
      * Add e2e test
      
      * Remove debug stuff
      
      * Fix hover and drill issues with slice index calc
      
      * Fix `pie.rows` ordering bug
      
      * Revert "Fix hover and drill issues with slice index calc"
      
      This reverts commit f104aaa5.
      
      * Fix hover and drill issues with slice index calc (2)
      
      `dataIndex` based approach
      
      * Use a special data key for the "Other" slice
      
      * Fixed viewport size in legend e2e test
      
      * Fix jumping legend width
      
      * Fix dot and label vertical alignment
      
      * Rework pie e2e test
      
      * Fix legend dot and label alignment
      Unverified
      41b4b687
    • Anton Kulyk's avatar
      Recalculate "graph.metrics" and "graph.dimensions" if empty (#47692) · 6cca5fb3
      Anton Kulyk authored
      * Add repro
      
      * Update `isValid` check for metrics and dimensions
      
      * Fix unit test
      Unverified
      6cca5fb3
    • Romeo Van Snick's avatar
      Browse metrics page (#47277) · d566fae9
      Romeo Van Snick authored
      
      * Add custom image for empty metrics
      
      * Add useFetchMetrics helper
      
      * Copy browse models page to metrics page
      
      * Add route for browse metrics page
      
      * Add useHasMetrics hook
      
      * Add link to browse metrics page to the sidebar
      
      * Simplify MetricsTable component
      
      * Render description markdown in table too
      
      * Add unit tests for browse metrics page
      
      * Remove custom padding
      
      * Fix line height of markdown cell
      
      * Add e2e tests for browse page
      
      * Fix metrics sorting
      
      * Fix types
      
      * Fix column widths and cell padding
      
      * Typo
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      
      * Remove name check
      
      * Simplify alphabet
      
      * Remove resetSnowplow
      
      * Use helper to get metric in table
      
      * Use MouseEvent from React directly
      
      * Use --mb-color-icon-primary
      
      * Test ellipsification of description
      
      * Simplify useHasMetrics
      
      * Move useHasMetrics MainNavBar
      
      * Merge sortMetrics and sortModels into sortCards
      
      * Fix metric default description
      
      * Extract SidebarSkeleton to a separate component
      
      * Test sorting via Collection too
      
      * Use ModelTableRow to fix cursor
      
      * Share more components between ModelsTable and MetricsTable
      
      * Use the same simplified structure in ModelsTable as for MetricsTable
      
      * Render block-level elements as inline so ellipsis detection works
      
      * Pick better testid for metric name
      
      * Remove delay
      
      * Avoid type specificty error in sortCards
      
      * Add test for not opening in new tab
      
      * Remove useFetchMetrics defaults
      
      * Fix unit test import
      
      * Test meta-click with cypress
      
      * Add comment on inline markdown elements
      
      * Use model-name test id
      
      * Use correct colors for icon
      
      * Remove delay from browse models page too
      
      * Make meta key in test platform-dependent
      
      * Fix hover color on metrics table
      
      * Add focus styling for celss in the models and metrics table
      
      * Use MarkdownPreview for table cells
      
      * Define --mb-color-icon-primary
      
      * Make the collection link take up the whole height of the cell
      
      * Remove tabIndex from table rows
      
      * Rename ModelsTable.module.css to BrowseTable.module.css
      
      * Rename CardsTable to BrowseTable
      
      * Remove single module.css class in favor of styled components
      
      * Allow customising allowed elements
      
      * Allow forcing all markdown on one line
      
      * Render bold and italics in markdown descriptions and move content onto one line
      
      * Fix legacy tooltip in test
      
      * Make sure getValueForSorting returns a string
      
      * Remove empty file
      
      * Remove icon for metrics in the table
      
      * Remove else statement.
      
      Co-authored-by: default avatarUladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
      
      * Remove async findBy where possible
      
      * Add github issue link for TODO item
      
      * Disambiguate between getMetricDescription type
      
      * Be explicit with sortModelOrMetric
      
      ---------
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      Co-authored-by: default avatarUladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
      Unverified
      d566fae9
Loading