This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Sep 25, 2024
-
-
Noah Moss authored
Co-authored-by:
Thomas Schmidt <thomas@metabase.com>
-
Nick Fitzpatrick authored
* test with disabled query analysis and feature disabled in token * types * useSetting
-
Nemanja Glumac authored
* Pre-fill cloud user info from search params * Autofocus password field for hosted instances * Add tests * Parse setup user info and store it immediatelly * Autofocus password input field for hosted instances * Add e2e reproduction * Fix the user info * Fix unit test
-
Anton Kulyk authored
-
Sloan Sparger authored
-
Sloan Sparger authored
display warning that native query access is restricted if a table or schema is set to blocked (#47630)
-
- Sep 24, 2024
-
-
Alexander Polyankin authored
-
Romeo Van Snick authored
* Support skipToken in useFetchMetrics * WIP * Add user setting for verified metrics * Add verified metrics to the VERIFIED_CONTENT plugin * Use metric plugins for verified metrics * Move helpers down * Do not filter for verified metrics if there are none, regardless of user setting * Add label to filter button * Revalidate search when card gets (un-)verified * Add e2e test for verified metrics * Avoid checking for verified metrics on when content-verification is not enabled * Fix broken test * Simplify content verification plugin structure for metrics * Add content moderation types and API helpers * Update content moderation plugin to make use of the moderation api in metabase/api * Fix lint * Fix missing list tag * Store verified metric filter preference * Move all helpers to the bottom * Ensure the user setting gets updated when chaning the filter * Add comment about component similarity * Undo changes to embedding-sdk
-
Romeo Van Snick authored
* Use default values for parameters in dashboard filters when used from click action * Add test for setting non-specified parameters to default in dashboard accessed via click action
-
Ryan Laurie authored
* create dashboard settings sidebar * update e2e tests fix * only show settings to dashboard editors * update copy * update e2e test * fix types * update tests for new copy * fix import
-
- Sep 23, 2024
-
-
Sloan Sparger authored
* removes the default-ee snapshot in favor for a blockUserGroupPermissions util * commit default-ee removal i forgot, replace default strings with undefined * fix oopsie * fixes failures for not removing enough permissions for tests in sandboxes.cy.spec.js * rename var
-
Nicolò Pretto authored
-
Nicolò Pretto authored
-
- Sep 20, 2024
-
-
Sloan Sparger authored
* fixes some tests where data permissions were overwriting sandboxing permissions, makes assertions in tests where sandboxing user is used but the test also passes if you were to sign in as the normal user, fixes one test that sandboxes the wrong table for the test * do not push - wip changes * add assertions to that network requests are provided sandboxed data, fix faulty test in dashboard-filters-source.cy.spec.js * use helpers to clean up parts of pagination assertions * rename assertDatasetIsSandboxed to assertDatasetReqIsSandboxed * adds assertions on api response data * clean up * fix typo * refactor helper to be easier to follow * golfing * pr feedback * fix * fix
-
- Sep 17, 2024
-
-
Uladzimir Havenchyk authored
* increase timeout to fix flakiness * add more timeout * timeout * WIP * bypass race condition
-
- Sep 13, 2024
-
-
appleby authored
* Rollback to legacy unique-name-generator in annotate-native-cols * Add native query long column alias test to nested queries tests * Add native query long column alias test to dataset api tests * Add native query long column alias test to models e2e tests * Move limit into inner native query * PR suggestion: simplify lambda argslist Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * PR suggestion: remove unnecessary mt/with-temp-copy-of-db * Tweak test name --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
Uladzimir Havenchyk authored
* add offset e2e tests * mark test not flaky * add basic tests * add more tests * WIP * working version * cleanup * oops * improve naming * fix test * improve formatting * update comment and ts * add a test for metric * space * update tests and create a new issue * add one more test * re-enable test * make imports consistent * rewrite tests to put data through UI
-
Ryan Laurie authored
* Dashboard Info Sidebar * e2e test updates * add unit tests * e2e test updates * fix e2e tests * fix more e2e tests * update back behavior
-
Nick Fitzpatrick authored
-
Aleksandr Lesnenko authored
* dedupe a bit * remove pie row settings for values not from dataset * remove unnecessary filtering * series -> rows * extend spec * feedback
-
Uladzimir Havenchyk authored
* fix broken test about resizing column by readonly user * Update e2e/test/scenarios/question/saved.cy.spec.js Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> --------- Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
- Sep 12, 2024
-
-
Ryan Laurie authored
* cleanup data reference tooltips * update test
-
Nicolò Pretto authored
-
Romeo Van Snick authored
* Render values for temporal metrics * Render data as rich * Add tests for temporal metric * Add TODO about isDate * Check for errors in dataset * Add unit test for timeseries dataset * Add check for rows earlier * Group tests better * Add e2e test for metrics with no value * Add test for metric with error
-
Alexander Polyankin authored
-
- Sep 11, 2024
-
-
Alexander Solovyov authored
-
Raphael Krut-Landau authored
This PR tests that the user can assign any of three cache invalidation strategies ("duration", "adaptive", and "don't cache") to dashboards and questions. The tests check that the following things are true: * These strategies can be applied directly (via the sidebar) * Dashboards and questions can inherit their caching strategy from the database that underlies them * Dashboards and questions can inherit their caching strategy from the instance-wide default policy * When a question inside a dashboard has been assigned a strategy, this is overridden by the strategy assigned to the dashboard. What these tests do not examine: * the schedule strategy * the minimum query duration * edge-case strategies, such as very long durations or very large values for the adaptive strategy multiplier These may be addressed in follow-up work. Closes #45355
-
Mahatthana (Kelvin) Nomsawadi authored
-
Romeo Van Snick authored
* Alway render models and metrics links * Remove useHasMetrics and useHasModels helpers' * Update metrics test for metrics in sidebar * Fix unit test * Fix e2e tests
-
- Sep 10, 2024
-
-
John Swanson authored
* Move stale endpoint to /ee/stale/${collection-id} It's an enterprise-only endpoint, so it makes sense to put the whole thing under enterprise. * refactors ui to use ee stale endpoint lint fixes, change endpoint location fix failure e2e test * Fix endpoint location --------- Co-authored-by:
Sloan Sparger <sloansparger@gmail.com>
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Romeo Van Snick authored
* Add metric actions * Fix dot menu width * Refetch card when it's being (un-)bookmarked * Add tests for metric dot menu * Make sure bookmarked metric appears in sidebar * Make sure restoring a metric works * Add more tests for readonly users * Use non-root collection for metric test * Render Scalar metric values * Add tooltip * Render Scalar metric value using formatValue * Move isMetricScalar and getMetricValue to utils * Add e2e tests for scalar metric values * Fix unit tests * Add card query endpoint to metabase/api * Use card query from api instead of question loader * Add test for non-numeric scalar metric * Move providesCardQueryTag to utils * Use skipToken for query * Clean up getDatasetScalarValueForMetric
-
Alexander Polyankin authored
-
Romeo Van Snick authored
* Add metric actions * Fix dot menu width * Refetch card when it's being (un-)bookmarked * Add tests for metric dot menu * Make sure bookmarked metric appears in sidebar * Make sure restoring a metric works * Add more tests for readonly users * Use non-root collection for metric test
-
- Sep 09, 2024
-
-
Aleksandr Lesnenko authored
* show additional columns in the tooltip * specs, tweaks * drop stack dependency * handle invalid columns * change copy
-
Ryan Laurie authored
* Question Settings Sidesheet (#47699)
-
Anton Kulyk authored
* Add series visibility props to `ChartWithLegend` * Mark pie slices as visible or hidden * Don't let to hide the last visible slice * Add space between legend dot and title * Fix legend dot outer circle is clipped by overflow * Use `ChartSettingSeriesOrder` for `pie.rows` setting * Actually hide slices and exclude from total calc * Don't show "0%" next to hidden slice legend items * Hide the "Other" slice * Make overflow slices popover interactive * Fix hover * Fix incorrect visibility state in legend popover * Add e2e test * Remove debug stuff * Fix hover and drill issues with slice index calc * Fix `pie.rows` ordering bug * Revert "Fix hover and drill issues with slice index calc" This reverts commit f104aaa5. * Fix hover and drill issues with slice index calc (2) `dataIndex` based approach * Use a special data key for the "Other" slice * Fixed viewport size in legend e2e test * Fix jumping legend width * Fix dot and label vertical alignment * Rework pie e2e test * Fix legend dot and label alignment
-
Anton Kulyk authored
* Add repro * Update `isValid` check for metrics and dimensions * Fix unit test
-
Romeo Van Snick authored
* Add custom image for empty metrics * Add useFetchMetrics helper * Copy browse models page to metrics page * Add route for browse metrics page * Add useHasMetrics hook * Add link to browse metrics page to the sidebar * Simplify MetricsTable component * Render description markdown in table too * Add unit tests for browse metrics page * Remove custom padding * Fix line height of markdown cell * Add e2e tests for browse page * Fix metrics sorting * Fix types * Fix column widths and cell padding * Typo Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Remove name check * Simplify alphabet * Remove resetSnowplow * Use helper to get metric in table * Use MouseEvent from React directly * Use --mb-color-icon-primary * Test ellipsification of description * Simplify useHasMetrics * Move useHasMetrics MainNavBar * Merge sortMetrics and sortModels into sortCards * Fix metric default description * Extract SidebarSkeleton to a separate component * Test sorting via Collection too * Use ModelTableRow to fix cursor * Share more components between ModelsTable and MetricsTable * Use the same simplified structure in ModelsTable as for MetricsTable * Render block-level elements as inline so ellipsis detection works * Pick better testid for metric name * Remove delay * Avoid type specificty error in sortCards * Add test for not opening in new tab * Remove useFetchMetrics defaults * Fix unit test import * Test meta-click with cypress * Add comment on inline markdown elements * Use model-name test id * Use correct colors for icon * Remove delay from browse models page too * Make meta key in test platform-dependent * Fix hover color on metrics table * Add focus styling for celss in the models and metrics table * Use MarkdownPreview for table cells * Define --mb-color-icon-primary * Make the collection link take up the whole height of the cell * Remove tabIndex from table rows * Rename ModelsTable.module.css to BrowseTable.module.css * Rename CardsTable to BrowseTable * Remove single module.css class in favor of styled components * Allow customising allowed elements * Allow forcing all markdown on one line * Render bold and italics in markdown descriptions and move content onto one line * Fix legacy tooltip in test * Make sure getValueForSorting returns a string * Remove empty file * Remove icon for metrics in the table * Remove else statement. Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com> * Remove async findBy where possible * Add github issue link for TODO item * Disambiguate between getMetricDescription type * Be explicit with sortModelOrMetric --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-