Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Oct 28, 2024
  2. Oct 25, 2024
  3. Oct 24, 2024
  4. Oct 23, 2024
    • Aleksandr Lesnenko's avatar
      Unverified
      b94da758
    • Nick Fitzpatrick's avatar
      Alert isValid check only looks at configured channels (#48485) · c9bfb047
      Nick Fitzpatrick authored
      * converting UpdateAlertModalContent and CreateAlertModalContent to functional
      
      * lint stuff
      
      * e2e adjustments:
      
      * type and e2e adjustments
      Unverified
      c9bfb047
    • Aleksandr Lesnenko's avatar
      Add allowed iframe host setting (#48805) · 7d61485b
      Aleksandr Lesnenko authored
      * add allowed iframe host setting wip
      
      * use allowed-iframe-hosts setting in the CSP header
      
      * add a test for the frame-src csp directive
      
      * Update allowed-iframe-hosts setting definition
      
      * Add error state for forbidden iframe url domains
      
      * Move out iframe e2e test suite
      
      * Add e2e test
      
      * Update error message in view mode
      
      * Fix unit tests
      
      * Update setting on the admin page
      
      * Update error state
      
      * Add links to error states
      
      * Update docs links
      
      * Update link anchors
      
      * Add default allowed hosts to public setting
      
      * Update allowed domain check logic
      
      * Fix default value display in admin page
      
      * Don't update setting without changes
      
      * Update error message spacing
      
      * correct the parsing of allowed-hosts string for CSP header entries
      
      * fix test
      
      * fix not handling wildcard ports
      
      * Fix failing e2e test
      
      * Fix subdomain test
      
      * address review
      
       - the parse-allowed-iframe-hosts fn is now memoized
       - a * entry is handled and doesn't produce a weird *:* entry
       - no more try/catch, errors in parsing will be logged but the list returns all valid entries
       - when www. is encountered, an entry including www. is added
       - trailing / is 'cleaned' and the entry is used as if there was no trailing /
      
      * Fixup test for expecting a few more frame sources
      
      * indentation fix for linter :smiling_face_with_tear:
      
      
      
      * Fix type error
      
      ---------
      
      Co-authored-by: default avatarAdam James <adam.vermeer2@gmail.com>
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      Co-authored-by: default avatardan sutton <dan@dpsutton.com>
      Unverified
      7d61485b
    • Nicolò Pretto's avatar
      embedding homepage v2 (#49027) · 5d81bdc4
      Nicolò Pretto authored
      * ui implementation of new emb homepage, tests will come later
      
      * change padding of the last card to be consistent with the top one
      
      * update beta badge spacing
      
      * update tests
      
      * fix stories type error
      
      * use quick-start for url
      
      * update HomeContent tests
      
      * update events + related e2e
      
      * Update frontend/src/metabase/home/components/EmbedHomepage/StaticEmbedContent.tsx
      Unverified
      5d81bdc4
    • Anton Kulyk's avatar
      Allow grouping bar chart series into "Other" category (#48265) · dbdef76e
      Anton Kulyk authored
      
      * Add `graph.max_categories` viz setting
      
      * Allow grouping series into "other" category
      
      * Add tooltip
      
      * Toggle "other" series visibility
      
      * WIP: new implementation for `graph.series_order`
      
      * Remove not used function
      
      * Make "other" series a regular `SeriesModel`
      
      * Fix stacked bar charts
      
      * Remove colors from "other" tooltip
      
      * Sort "other" tooltip values
      
      * Update `graph.max_categories` setting
      
      - negative number validation
      - 0 value turns off grouping
      
      * Fix Loki test
      
      * Add basic loki test
      
      * Add loki test for stacked chart
      
      * Add loki test for stacked normalized chart
      
      * slight refactor of series_order setting
      
      * Add screenshots
      
      * Handle different kinds of aggregations for "other"
      
      * Handle different aggregation kinds in tooltips
      
      * Add `graph.other_series_aggregation_fn` viz setting
      
      * Fix type errors
      
      * Fix unit tests
      
      * settings ui
      
      * remove sorting by value to match series order setting, other color
      
      * hide grouped series controls
      
      * Add e2e test
      
      * Update screenshots
      
      * Fix incorrect series grouping for stacked charts
      
      * group series into other settings
      
      * Update e2e test to work with new viz settings
      
      * Disable drills for the "Other" series
      
      * fix max_categories setting popover positioning
      
      * fix total row has misaligned columns on other series values
      
      * Remove redundant `click({ force: true })`
      
      * Rename aggregation fn viz setting
      
      * Move aggregation fn setting to the popover
      
      * WIP
      
      * Update popover
      
      * Fix `it.only`
      
      * Fix legend sync issue
      
      * Disable "Other" category by default (temporary)
      
      * Enable aggregation fn picker for MBQL queries (temporary)
      
      * Move "Other" category summary to a tooltip row
      
      * Add `graph.max_categories_enabled` to viz settings type
      
      * Reuse already computed "Other" value in tooltips
      
      * Add null check
      
      * Fix series length check
      
      ---------
      
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@gmail.com>
      Unverified
      dbdef76e
  5. Oct 22, 2024
  6. Oct 21, 2024
  7. Oct 18, 2024
  8. Oct 17, 2024
  9. Oct 16, 2024
  10. Oct 15, 2024
    • Raphael Krut-Landau's avatar
    • Aleksandr Lesnenko's avatar
    • Anton Kulyk's avatar
      Fix maps visualization crashing on x-rays (#48742) · 54b141c7
      Anton Kulyk authored
      * Add default value for `hiddenIndices`
      
      * Add e2e test
      Unverified
      54b141c7
    • adam-james's avatar
      Incremental Pivot Processing for Exports (#46995) · 8d52a03f
      adam-james authored
      
      * Incremental Pivot Processing for Exports
      
      WIP
      
      Fixes pivot exports for CSV and xlsx.
      
      The CSV export should use less memory by incrementally building up the data structure and aggregating necessary row
      data right away, so the memory overhead becomes only as large as the total pivot result.
      
      In cases where the pivot rows/cols do combine into many many columns and rows, this can still be a large set of data,
      but it should behave much better now in most cases.
      
      The Excel export is a little more straightforward: create the export rows in the same fashion, streaming one row at a
      time, and just post-process the sheet to add the pivot table in one shot at the end.
      
      * WIP adding row totals.
      
      * aggregate totals as rows are added
      
      Row, column, section, and grand totals are all aggregated as each row is added.
      This means the final step of building pivot output becomes just an exercise of lookups/arrangement, no further
      aggregation is needed.
      
      * CSV pivot works per-row, export respects formatting
      
      This is a big step forward; we don't need to hold the entire dataset in memory, we instead aggregate a row's data into
      the pivot datastructure, which only holds onto:
      
      - unique values for each pivot-row in a sorted set
      - unique values for each pivot-col in a sorted set
      - grand total for each measure N values, where N is number of measures, ususally 1 or 2
      - row totals for each combination of each pivot-row * N measures
      - col totals for each combination of each pivot-col * N measures
      - totals for each 'section', determined by unique values of first pivot-row * N measures
      - values for each measure in every 'cell'; Row Combos * Col Combos * N Measures
      
      So, there can still be a decent amount of data to store; but it will never hold onto all of the 'raw rows' from the
      dataset.
      
      We can never completely guarantee that Row Combos * Col Combos * N Measures remains small, but two things let us move
      forward anyway:
      
      - there's now visible feedback in the app that the download is running (or if it's failed)
      - Pivot table utility diminishes rapidly with huge output anyway; users still need to curate/set up their data
      - effectively to improve the table's utility, so we can assume that a slow-to-download pivot table is also slow to
      - use/less effective, and will likely be something the user doesn't want (as often).
      
      * some test fixes
      
      * now, if we export 'raw pivot rows', they don't show pivot-grouping
      
      and they also don't include the 'extra' rows for totals/subtotals/grand totals (any row with pivot-grouping > 0).
      
      This means that now the non-pivot version of a pivot table export will match what a user sees if they change the viz
      to a regular table.
      
      * remove old test
      
      * re-incorporate some changes from master
      
      * fix csv for non-pivots due to oversight in my changes
      
      This is just a temporary change, I think I should clean up this bit of the code a little, I can probably make it a
      little more readable and use some cleaner logic regarding if the rows are 'raw pivot rows' or not.
      
      * start moving format_rows to POST bod, add pivot_results too
      
      There's still wiring work to do, but this starts to add format_rows and pivot_results to POST body for the various API
      endpoints. Also modify tests to improve coverage/consistency across downloads and alerts/subscriptions.
      
      The tests will not pass on this commit, but fixes will be incoming
      
      * native pivot tables in xlsx
      
      * add precondition to pass migration linter
      
      * try to get migrations fixed
      
      * pasing pivot-results through api and attachments
      
      * fix tests for format_rows in BODY vs query param
      
      * tests!
      
      * might have the tests all fixed now
      
      * the pivoted export now respects col/row totals settings
      
      * add test coverage for public questions and dashboards
      
      * col and row totals work as expected
      
      * build-pivot refactor for clarity
      
      * docstring change + tiny refactor in helper fn
      
      * see if dashcard download works with format_rows
      
      * csv pivot handles nil values
      
      * pass format_rows and pivot_results in :params not :body
      
      * fix some other tests
      
      * pivot-grouping col filtered out of xlsx
      
      * pivot-grouping-col removed for all rows
      
      * configurable pivot exports and attachments (#47880)
      
      * exports fe
      
      * specs
      
      * ui
      
      * specs
      
      * format/unformatted now works for xlsx
      
      * format test changes for xlsx formatting
      
      * embedding endpoints accept pivot_results
      
      * cljfmt and eslint fix
      
      * empty
      
      * embedding test should have formatting defaulted to true
      
      * embed test fixes
      
      * Use `Chip` for export settings widget
      
      * downloads e2e test fix
      
      * fix public download limit test
      
      * public card download defaults
      
      * fix public download defaults in some tests
      
      * Fix visual test
      
      ---------
      
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@users.noreply.github.com>
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      Unverified
      8d52a03f
    • Romeo Van Snick's avatar
      Remove "Replace or save question" UI when saving and edited question from a metric (#48669) · b8997a1e
      Romeo Van Snick authored
      * Remove 'Save as new question' toggle when saving questions from editing a metrics' ad-hoc question
      
      * Allow visitQuestion to work for metrics
      
      * Use visitQuestion in metric test
      
      * Add test for #48555 (showing the 'Save as new?' ui for metrics)
      
      * Add issue info to repro
      
      * Use visitMetric, visitModel and visitQuestion helpers in createQuestion
      
      * Move check to make it more clear what the save ui does
      
      * Use cy.button for Done button
      
      * Remove unnecessary .within
      
      * Sign in as normal user
      
      * Add missing dataset alias
      Unverified
      b8997a1e
    • Uladzimir Havenchyk's avatar
    • Kamil Mielnik's avatar
      Refactor remaining e2e API commands to TS helper functions (#48672) · 46af3b4c
      Kamil Mielnik authored
      * Refactor createDashboardWithQuestions, createQuestionAndAddToDashboard and editDashboardCard to TS function helpers
      
      * Fix createNativeQuestionAndDashboard that got out of sync
      Unverified
      46af3b4c
    • Nicolò Pretto's avatar
      fix flaky test on embed share behaviour snowplow events (#48665) · dcb843bf
      Nicolò Pretto authored
      
      * increase time tolerance to make tests less flaky on ci when CPU is under heavy load
      
      * Update e2e/test/scenarios/sharing/public-sharing-embed-button-behavior.cy.spec.js
      
      Co-authored-by: default avatarUladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
      
      ---------
      
      Co-authored-by: default avatarUladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
      Unverified
      dcb843bf
    • Romeo Van Snick's avatar
      Change Metrics and Summaries copy (#48451) · 86ff88a1
      Romeo Van Snick authored
      * Rename Common Metrics to Metrics
      
      * Rename Basic Metrics to Summaries
      
      * Update chill mode button copy to 'Add a summary or metric'
      
      * Rename 'Pick the metric you want to see' button to include summary
      
      * Fix type in test
      
      * Rename Summaries to Basic functions
      
      * Fix test
      
      * Undo cross-version test changes
      Unverified
      86ff88a1
Loading